Srujan Gaddam
4f2e49038b
Migrate js_interop_1_test to async_minitest
...
Semantics needed to change to replace expectAsyncUntil.
Change-Id: I7dd55c9571b405e471c812e966e708e6ef76a134
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139822
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Srujan Gaddam <srujzs@google.com >
2020-03-17 19:19:25 +00:00
Erik Ernst
568255dbec
Change tests to expect new behavior of fromEnvironment
...
Constructors int.fromEnvironment and String.fromEnvironment will now
yield 0 or '' rather than null in the case where the requested
environment declaration does not exist, so various expectations needed
to be updated accordingly.
Change-Id: Ie6f3b9ee18a970e50520ac84c2741b4875ada3c9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139804
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Erik Ernst <eernst@google.com >
2020-03-17 13:43:17 +00:00
Robert Nystrom
a1f87c6962
Reland "Fail synchronously if null is passed as an error to async APIs."
...
This is a reland of bef363bfb7
Original change's description:
> Fail synchronously if null is passed as an error to async APIs.
>
> The first patchset is Lasse's original changes.
>
> Change-Id: Ic5f24bcfc0ef4e82edee68d61e015b095cb5916e
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138605
> Reviewed-by: Leaf Petersen <leafp@google.com >
Change-Id: I142831dca5dc4ca266ded08d93cb427ad3fbde74
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139683
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Leaf Petersen <leafp@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
2020-03-17 00:39:31 +00:00
Joshua Litt
f1d57374ae
[dart2js] Move a bunch of references from objectType to topType.
...
Change-Id: Ia57b3604f26c8a92c53180d58ea5b41265965252
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138613
Commit-Queue: Joshua Litt <joshualitt@google.com >
Reviewed-by: Mayank Patke <fishythefish@google.com >
2020-03-16 21:54:21 +00:00
Nicholas Shahan
fa77a43c76
[tests] Add analysis options file to migrated test directories
...
The intent of this change is to make editing the tests in these
directories more user friendly. When you open these directories in an
analyzer enabled editor it will produce results consistent with the
language features being used in the test.
Change-Id: I68e9cdc0e9fccfc360a2649261a5fdca042ec108
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139560
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2020-03-16 20:51:26 +00:00
Konstantin Shcheglov
0f8238efe9
Issue 41036. Add null-shorting for prefix/postfix expressions.
...
Bug: https://github.com/dart-lang/sdk/issues/41036
Change-Id: Iccff235bc81b6e65a3b40f972aaa75707ac2232c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139462
Reviewed-by: Janice Collins <jcollins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-16 20:23:16 +00:00
Robert Nystrom
54ae6c123e
Make minitest and async_minitest NNBD agnostic.
...
Fix a couple of errors when compiling those libraries as opted in to
NNBD.
Change-Id: I7dfb629d951d8531c8bed4e765950984e9291f44
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139686
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Srujan Gaddam <srujzs@google.com >
Reviewed-by: Srujan Gaddam <srujzs@google.com >
2020-03-16 19:58:10 +00:00
Srujan Gaddam
3cbf1f65f3
Migrate interactive_geolocation_test to async_minitest
...
Change-Id: I46ae16ccca91823b68421fd5c067ff68166a7cf3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139499
Commit-Queue: Srujan Gaddam <srujzs@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2020-03-16 17:48:48 +00:00
Srujan Gaddam
47e495a89a
Migrate indexeddb_* tests to async_minitest
...
Change-Id: Ie43d3f4610eb01cfc800556f30e93514a7ac1ac5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139498
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2020-03-16 17:48:48 +00:00
Srujan Gaddam
5f8df3af03
Migrate file_sample_test to async_minitest
...
Refactored to use Futures for asynchronous tests.
Change-Id: I95c7b3e0230f9c8d81b32b7323aa58ff339eadea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139493
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2020-03-16 17:48:48 +00:00
Srujan Gaddam
739e79e863
Migrate events_test to async_minitest
...
Change-Id: I994d376d3a6a86be989130104fabdc6d217fc0e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139492
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2020-03-16 17:48:48 +00:00
Markzipan
7397c03670
[tests] Cleaning up strong mode tests.
...
Change-Id: I78ee36b245fb91f23775de87ce616445fbcbdb7b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139039
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2020-03-16 16:54:56 +00:00
Dmitry Stefantsov
928f9fc932
[cfe] Remove flag --force-nnbd-checks
...
The checks are now always enabled for the "non-nullable" experiment
Closes #40980 .
Bug: https://github.com/dart-lang/sdk/issues/40980
Change-Id: I32a141a93f0ba86ebdab554e1f312c2147927993
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139440
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
2020-03-16 15:01:38 +00:00
Erik Ernst
330ec173a9
Add bool.hasEnvironment constructor and tests
...
Change-Id: I65ebfcb48bf46292d5ae611ecb7431e0666f753c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139286
Reviewed-by: Martin Kustermann <kustermann@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Erik Ernst <eernst@google.com >
2020-03-16 11:17:58 +00:00
Srujan Gaddam
87779c4225
Migrate element_test to async_minitest
...
Change-Id: If99d88551b245d28a7898769703758c4747d693a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139360
Commit-Queue: Srujan Gaddam <srujzs@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2020-03-13 23:09:07 +00:00
Srujan Gaddam
5c02523f4f
Migrate html element_animate tests to async_minitest
...
Change-Id: Icfbcbe7aa69e337d923aa678986d0f40ba8a76dc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139301
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2020-03-13 23:09:07 +00:00
Srujan Gaddam
d044aeca59
Migrate html custom_ tests to async_minitest
...
Change-Id: I8fa192967c5c7083e780433fce0e246cbc846c24
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139300
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2020-03-13 23:09:07 +00:00
Srujan Gaddam
e60e7378b9
Migrate custom/entered_left_view tests to async_minitest
...
Change-Id: Ida616678a146fa7a6a0c90bba7339758a84e3aa8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139261
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2020-03-13 23:09:07 +00:00
Srujan Gaddam
799cf665ea
Move html custom tests off unittest
...
Many of the setUps were meant to be one time setUps, so
they're only called once.
anyOf is added to async_minitest using the minitest impl.
Change-Id: Ibb2d4d0c3990d0df025fcaf6c02d49faa9733569
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139147
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2020-03-13 23:09:07 +00:00
Ryan Macnak
8ed772d37f
Reland "[vm] Fix some further mirror breaks with frontend NNBD checks enabled."
...
Without loadLibrary()! changes.
Change-Id: I78806547ac62fa806e99eb2d5e3f2041f20ce942
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139404
Reviewed-by: Régis Crelier <regis@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2020-03-13 17:11:52 +00:00
Johnni Winther
a5eb0b559c
[cfe] Handle callable extension getters
...
Closes #40596
Closes #40713
Closes #39889
Change-Id: I183560b912e2f6f2c02d51278c0d28c8a6d67f99
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139203
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-03-13 10:46:39 +00:00
Johnni Winther
6c6144bb74
[cfe] Implement consolidated in ClassHierarchyBuilder
...
Closes #40414 and #40156
Change-Id: I066aa8ceef4f998230215fd9e9b446b2281cc3bc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138294
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2020-03-13 08:16:49 +00:00
Ryan Macnak
42e6cf4967
Revert "[vm] Fix some further mirror breaks with frontend NNBD checks enabled."
...
This reverts commit daf91f56b9 .
Reason for revert: Analyzer and CFE disagree
Original change's description:
> [vm] Fix some further mirror breaks with frontend NNBD checks enabled.
>
> Change-Id: I3c52dac2244c1f7eae59d85bc637cce2cbb3faa9
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139302
> Reviewed-by: Régis Crelier <regis@google.com >
> Reviewed-by: Siva Annamalai <asiva@google.com >
> Commit-Queue: Ryan Macnak <rmacnak@google.com >
TBR=rmacnak@google.com ,asiva@google.com ,regis@google.com
Change-Id: I2f13dac7f2d7441f8db61543261ca28f500b8adc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139319
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2020-03-12 22:41:41 +00:00
Ryan Macnak
daf91f56b9
[vm] Fix some further mirror breaks with frontend NNBD checks enabled.
...
Change-Id: I3c52dac2244c1f7eae59d85bc637cce2cbb3faa9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139302
Reviewed-by: Régis Crelier <regis@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2020-03-12 20:58:56 +00:00
Nicholas Shahan
9301c2f593
[tests] Fix analysis errors in tests
...
Non-nullable and optional method arguments need default values. Embedded
the generic type argument into a List as an easy way to create a default
value.
Change-Id: Ib171c272c75b114447d356d423c45dc9aeff9bb4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139160
Commit-Queue: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
2020-03-12 18:16:36 +00:00
Lasse R.H. Nielsen
468f9eb2f9
Backport changes to RuneIterator to non-NNBD SDK.
...
Change-Id: I02087a794cd731348f00e34eee8b154f80fe4c9a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135316
Commit-Queue: Leaf Petersen <leafp@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2020-03-12 16:47:46 +00:00
Srujan Gaddam
871bb5a06e
Convert remaining canvasrendering tests to async_minitest
...
Refactored code to handle lack of setUp and tearDown and async
completion across tests.
Change-Id: I5411e7b7cf3a5687c892c8d0a33f4a6e6a440c32
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139028
Commit-Queue: Srujan Gaddam <srujzs@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2020-03-12 02:48:50 +00:00
Nicholas Shahan
33349076ee
[tests] Add tests for type object equality after FutrureOr normalization
...
Change-Id: I61d0b35fff087091eafa921f679a29760b00b84f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138103
Reviewed-by: Erik Ernst <eernst@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2020-03-12 01:20:50 +00:00
Leaf Petersen
5e9be81d5e
Make all CastErrors be TypeErrors.
...
This makes CastError implement TypeError, and changes all test
expectations to look for TypeError. A followup CL will deprecate
CastError.
Bug: https://github.com/dart-lang/language/issues/787
Bug: https://github.com/dart-lang/sdk/issues/34097
Change-Id: I7102c6260901317572d2df08c4be9c4c48197688
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138670
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2020-03-11 23:31:06 +00:00
Ryan Macnak
f82e5fcbb1
[vm] Update some return types of mirror natives to be explicitly nullable.
...
Bug: https://github.com/dart-lang/sdk/issues/40997
Change-Id: I18e4bc4637f68ba5080c11d0a2c3c7bb43eb54bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139061
Reviewed-by: Régis Crelier <regis@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2020-03-11 22:47:30 +00:00
Mark Zhou
684c53a6f1
[tests] Fixing some null-safe strong mode tests.
...
Change-Id: I131754d0183bed52e6443c2511197ed3b1e63b04
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138887
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Mark Zhou <markzipan@google.com >
2020-03-11 15:41:59 +00:00
Konstantin Shcheglov
a44f680932
Update assignment in language/nnbd/operator_type_test
...
Change-Id: I81b87af6bd8ae51d626afb79412730c4bc39204a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138980
Reviewed-by: Erik Ernst <eernst@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-11 15:09:24 +00:00
Konstantin Shcheglov
0e0cde55a0
Add default values for tests/language/nnbd/type_equality/function_type_equality_test
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I5f1f356e96f66b4b0098fba6ab61109ae5cc3ac5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139026
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-11 15:01:29 +00:00
Konstantin Shcheglov
21cddbd4cf
Fix language/nnbd/syntax/late_modifier_error_test
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: Icdefdfcae39a496fff6f8cf0b505b0a67a282ef2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139021
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-11 15:01:21 +00:00
Lasse Reichstein Holst Nielsen
9e10ef4458
Fix null-read in RegExpMatch.groupNames.
...
Fixes VM, DDC and Dart2js.
BUG= http://dartbug.com/39406
Change-Id: If181eaf50905c571614b656a232564e394e1b35d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136635
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Teagan Strickland <sstrickl@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2020-03-11 14:21:39 +00:00
David Morgan
a5bf30c401
Revert "Fail synchronously if null is passed as an error to async APIs."
...
This reverts commit bef363bfb7 .
Reason for revert: Breaks google3 tests, see b/151204525.
Original change's description:
> Fail synchronously if null is passed as an error to async APIs.
>
> The first patchset is Lasse's original changes.
>
> Change-Id: Ic5f24bcfc0ef4e82edee68d61e015b095cb5916e
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138605
> Reviewed-by: Leaf Petersen <leafp@google.com >
TBR=leafp@google.com ,rnystrom@google.com
Change-Id: Ie17c35e9d23c70a7aecd1ef292962154cf6f007d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138925
Reviewed-by: David Morgan <davidmorgan@google.com >
Commit-Queue: David Morgan <davidmorgan@google.com >
2020-03-11 10:07:49 +00:00
Robert Nystrom
63bff1a2fb
Improve asynchronous test failures and async_minitest.
...
There's a bundle of improvements here:
- Show the stack trace of the failure when a test using async_minitest
fails. The trade-off is that it now only reports the first failure.
Collecting all of them didn't play nice with the stack trace
deobfuscation the test runner does.
- Report the group and name of the test that failed when known.
- Fix as many double-reporting test result bugs as I could find. Also,
in case that still happens, don't spew out a pile of useless JSON.
- Correctly wait for a test to complete even if it schedules its own
asynchronous operations without returning futures.
- Generally simplify and clean some stuff up.
Change-Id: Ie020ae0b80a11764c455cf0ce24dfea09ca0adce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138903
Reviewed-by: Srujan Gaddam <srujzs@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Bob Nystrom <rnystrom@google.com >
2020-03-11 01:12:48 +00:00
Konstantin Shcheglov
d7f697f64a
Include additional analyzer errors in language/nnbd/syntax/class_member_declarations_error_test
...
Change-Id: Iee4344a65e85890c3361294a6bdaa0920a3a4f10
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139020
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-03-11 00:45:41 +00:00
Robert Nystrom
bef363bfb7
Fail synchronously if null is passed as an error to async APIs.
...
The first patchset is Lasse's original changes.
Change-Id: Ic5f24bcfc0ef4e82edee68d61e015b095cb5916e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138605
Reviewed-by: Leaf Petersen <leafp@google.com >
2020-03-10 23:42:43 +00:00
Srujan Gaddam
fcb00812ed
Migrate canvasrendering tests off of unittest
...
Migration to minitest where possible. async tests will
be migrated in a different CL.
Change-Id: I4662300bd841c56b7113adf2182ee2f8e3d7eae8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138889
Commit-Queue: Srujan Gaddam <srujzs@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2020-03-10 22:04:21 +00:00
Sigmund Cherem
2c68152847
[ddc] cleanup: use Never direclty in nnbd tests
...
Change-Id: I67aceaccb819ad6033bdb9c7d9870b05859c1064
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138900
Reviewed-by: Nicholas Shahan <nshahan@google.com >
2020-03-10 19:13:33 +00:00
Leaf Petersen
f34fa57d98
Update null aware subscript test
...
Change-Id: Ib3a37f575906c125b850fa82732595f1532c9d9e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138721
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2020-03-10 17:41:51 +00:00
Konstantin Shcheglov
bbb449dfa4
Issue 40931. Update inference constraint for T? to be non-nullable.
...
Bug: https://github.com/dart-lang/sdk/issues/40931
Change-Id: I483c3febad236b366f911f38339c712dd928cfcf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138790
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2020-03-10 02:19:50 +00:00
Srujan Gaddam
a61e012e93
Migrate html tests using async_minitest and minitest
...
Move them to async_minitest.
Change-Id: Ibe850b05a838dd64ae62b30c9a979de371b24db6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138741
Commit-Queue: Srujan Gaddam <srujzs@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2020-03-09 20:32:49 +00:00
Konstantin Shcheglov
24c8021f03
Replace initialize() with declare().
...
Fixes https://github.com/dart-lang/sdk/issues/38791
Change-Id: I954059160c75de91e1e32fe2f82ebfdc5569d947
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138666
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2020-03-09 18:24:51 +00:00
Brian Wilkerson
9a62df57fa
Fix a test to get the analyzer nnbd bot to pass
...
Change-Id: I5892c245d4aa984c896471bf18cd71362958d0c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138782
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-03-09 17:47:47 +00:00
Srujan Gaddam
3d0432eafc
Add returnsNormally to async_minitest
...
Included change in fileapi_supported_throws_test to sanity test the
change in async_minitest.
Change-Id: I6e6b6b4eb0740ae695a85d4b3c1e2b4f8f63615a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138614
Commit-Queue: Srujan Gaddam <srujzs@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2020-03-07 02:02:24 +00:00
Mayank Patke
81c3208c10
[dart2js] Special case null is T.
...
Change-Id: Iec5212db2d4493797257753f9eaa63799d047253
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138574
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Mayank Patke <fishythefish@google.com >
2020-03-06 21:33:53 +00:00
Mayank Patke
de0fcd71d4
[dart2js] Assign the correct type to super tearoffs.
...
Bug: https://github.com/dart-lang/sdk/issues/40902
Fixes: https://github.com/dart-lang/sdk/issues/40902
Change-Id: Ie2c58e5dab9902cbabd7c2ef9aae5b6c1773c7e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138663
Reviewed-by: Stephen Adams <sra@google.com >
2020-03-06 21:33:53 +00:00
Srujan Gaddam
29d4b611fb
Remove html_individual_config from indexeddb_1_test
...
Change-Id: I1fe053dd575b8bdaeff61d9424af614eef946b7c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138242
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Srujan Gaddam <srujzs@google.com >
2020-03-06 21:32:43 +00:00