9dfd0127da
Do not report super-constructor errors on external constructors
...
Bug: https://github.com/dart-lang/sdk/issues/27218
Change-Id: I1772cc850b21e97694eaa1852893993f6d4037b6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139824
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-03-17 18:34:04 +00:00
faae2ec2c5
Issue 41019. Fix for readType of IndexExpression.
...
Bug: https://github.com/dart-lang/sdk/issues/41019
Change-Id: I861b355c14c6bb30e570bb0c0101871db423ffb0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139821
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-17 17:16:56 +00:00
3e970c4215
fix lint code urls
...
Change-Id: I54c7fa05ea8d3c4dfee6d468ae5f99b3bb34c2c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139745
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2020-03-17 14:23:32 +00:00
db5dc11b9b
Issue 41050. Get default values for fromEnvironment() from element model.
...
Bug: https://github.com/dart-lang/sdk/issues/41050
Change-Id: I8fee34a6b5816a725df4e4886fc85061ac4ec9b5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139661
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-17 02:05:41 +00:00
fbd232dbe6
Issue 40958. Fix null shorting for MethodInvocation.
...
Bug: https://github.com/dart-lang/sdk/issues/40958
Change-Id: Ic96b54feeeced5adb3b4271180636b493f951976
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139749
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-17 00:29:51 +00:00
efdbd86647
Issue 40704. Fix AstTextPrinter for '?[' support.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/40704
Change-Id: Icc800f8d5244030170b414c4f8c4d95cefab09a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139743
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-16 22:15:51 +00:00
0f8238efe9
Issue 41036. Add null-shorting for prefix/postfix expressions.
...
Bug: https://github.com/dart-lang/sdk/issues/41036
Change-Id: Iccff235bc81b6e65a3b40f972aaa75707ac2232c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139462
Reviewed-by: Janice Collins <jcollins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-16 20:23:16 +00:00
3237380259
Fix for creating a field when the target is in a part without a library.
...
R=brianwilkerson@google.com
Change-Id: I90b8031a805ba0cb51e7ccb8c2477d4f0d0ac8ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139603
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-16 15:52:08 +00:00
7079c49b05
Check for importedLibrary is null in importLibraryElement().
...
I see it in crashes sometimes.
R=brianwilkerson@google.com , pquitslund@google.com
Change-Id: I734d78f0e71c5985c7833fcf6e439fd4c48a5899
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139601
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-15 21:22:37 +00:00
7c5059f528
Issue 40704. Report INVALID_NULL_AWARE_OPERATOR for unnecessary '?['.
...
Bug: https://github.com/dart-lang/sdk/issues/40704
Change-Id: I67b45a4b5c6afba38141b33b44e2fc28726dffd3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139483
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-13 20:42:56 +00:00
29fe8b85c2
Issue 2025. Report an error when evaluating Set/Map literal and ForElement.
...
Bug: https://github.com/dart-lang/linter/issues/2025
Change-Id: Ifa61299ed69e029a51f3f05fa11583e7abd5a2f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-13 16:50:32 +00:00
668c81ffbf
Don't report FINAL_NOT_INITIALIZED_CONSTRUCTOR for mixins.
...
We already report MIXIN_DECLARES_CONSTRUCTOR, and there was a crash
in quick fixes when we attempted to fix it for a mixin.
R=brianwilkerson@google.com
Change-Id: I453d1de0702e36978c3972fd586494d2cd92aa40
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139316
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-03-12 22:49:46 +00:00
aef2012b3a
Add more data to debug FunctionTypeAlias linking crash.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/41023
Change-Id: Ica2aa7ec72992b9fe1b5a374b6f3546e7e297c51
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139318
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-12 22:46:31 +00:00
cd3a13e3f6
Add an option to allow for prefecthing of directly referenced files when building unlined summaries.
...
Change-Id: I20869dd6aee3ab5f4fc0bf99eab05c08173cb782
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139320
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-03-12 22:28:46 +00:00
ef6c7efc9f
Issue 40941. Report FINAL_AND_COVARIANT_LATE_WITH_INITIALIZER.
...
Bug: https://github.com/dart-lang/sdk/issues/40941
Change-Id: Ica0bbbdeee447c410cbfd64aea1a643711d21655
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139322
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-03-12 21:04:06 +00:00
e9e1d5a7f1
Issue 40956. Legacy view on required named parameters is not required.
...
Bug: https://github.com/dart-lang/sdk/issues/40956
Change-Id: Ib4be27f084f7c88ccc4dab92aa557eab85eda166
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139323
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-12 20:39:46 +00:00
3da03a648a
Issue 40955. Late final variables without initializers have setters.
...
Bug: https://github.com/dart-lang/sdk/issues/40955
Change-Id: I7cdccbf7f16e3a070b79f05062e6b5692a9f0051
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139283
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-12 19:02:06 +00:00
ad4762343b
Issue 39876. Report DEFINITELY_UNASSIGNED_LATE_LOCAL_VARIABLE.
...
Bug: https://github.com/dart-lang/sdk/issues/39876
Change-Id: I855579c47ab8f932bb3977eb44d0c17d0ce5987a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139034
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-12 15:41:07 +00:00
cdac6f614c
Issue 40837. Fix for invalid function expression flow analysis.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/40837
Change-Id: Id7021aa6b54fede6af2d03f51fd1d53445d174c9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139149
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-12 15:33:02 +00:00
92b1057f3f
Fix hint deprecated_member_use in analyzer
...
Change-Id: I90031ca5044626b731ef57cc0f6ad57012850ae5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138982
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-03-11 15:20:59 +00:00
ace1d9b921
Do not repeatedly analyze a full library per part when dartfixing.
...
Migration performance improves 10x on web_ui with this CL.
Also fixes a heisenbug in the linter code where identical uniqueNames
for LintCodes could wind up in objects that compare differently.
Bug: https://github.com/dart-lang/sdk/issues/40915
Change-Id: Iddddfd7659f4bc724ddf21ebae41750a0ee51e74
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138940
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Janice Collins <jcollins@google.com >
2020-03-10 21:16:11 +00:00
7f649e9ebc
Remove a missed usage of .analysis_options.
...
Change-Id: I552fa197aa13b1987b6b348295a37d1e61ba7775
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138961
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
2020-03-10 20:30:01 +00:00
9a0c09ecb2
Track definitely unassigned variables.
...
Change-Id: Id610a133912605f9af63222f25408942420cbf1f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138881
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-10 18:35:40 +00:00
f5a6554635
Move 'thisType' to ResolverVisitor.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug: https://github.com/dart-lang/sdk/issues/40932
Change-Id: Ie0fd3554fcb1f8baa3944bd6805ac72f0b76da61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138841
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-10 15:50:20 +00:00
83378633e1
Add the attachment with the content of the file being analyzed.
...
Change-Id: I75b1c61e2d04cd5e03ef4375e97ef3c9f4add874
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138384
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-03-10 04:57:20 +00:00
bbb449dfa4
Issue 40931. Update inference constraint for T? to be non-nullable.
...
Bug: https://github.com/dart-lang/sdk/issues/40931
Change-Id: I483c3febad236b366f911f38339c712dd928cfcf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138790
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2020-03-10 02:19:50 +00:00
8329bd7ca8
Do not check for '.analysis_options' for default options file in builder.
...
Change-Id: I9decba4d0db318caedcfd3695f41c127b66f416f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138660
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
2020-03-09 19:31:24 +00:00
24c8021f03
Replace initialize() with declare().
...
Fixes https://github.com/dart-lang/sdk/issues/38791
Change-Id: I954059160c75de91e1e32fe2f82ebfdc5569d947
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138666
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2020-03-09 18:24:51 +00:00
a629dbf073
Add a fix to inline a typedef
...
I needed to fix AST nodes for parameters to know about the required
token when computing the beginning token and child entities.
Change-Id: Icb0fc27bc1e9f6650376f5870944fb8f592a5e8c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138744
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-03-09 14:17:07 +00:00
e79f50098e
Unify two error codes into one
...
Change-Id: I955298756a7e8aa7094cc36e7b2846aac3d785db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138323
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-03-06 17:25:10 +00:00
60a81b0f51
Add hints to find equal elements in literal sets and maps
...
Change-Id: Ib930b49b338d7cb088b17909991934b16c4f1538
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138602
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-03-06 14:22:44 +00:00
ce7fcff2ea
Resolve type parameters to bounds when checking for implementing Iterable / Map.
...
R=brianwilkerson@google.com
Change-Id: Ifdb8fe73cbe731bfe5e3ea130f846fabfc1ce07f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138565
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-06 02:36:21 +00:00
5e66618175
Issue 40316. Verify only language version override locations at line starts.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/40316
Change-Id: I932fd9aa5a516096c11b605b16c9f674098cdc21
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138562
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-05 19:18:29 +00:00
110a29c9b3
Issue 40704. Support for ?[ in resolution.
...
Bug: https://github.com/dart-lang/sdk/issues/40704
Change-Id: Iaa4680e65a44c83bdc6a3ae826cc510b685a7ccf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138563
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-05 18:59:34 +00:00
0649115b06
Rename VoidWithTypeParameters to VoidWithTypeArguments.
...
Change-Id: I5df6a49f0b27b6edfe2ce0f677d5f898900d8384
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138341
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-05 17:31:34 +00:00
72acbc18e6
Issue 40316. Report hint if @dart language version override is not before any declartion.
...
Bug: https://github.com/dart-lang/sdk/issues/40316
Change-Id: I787df83020835f930e21dd772faa848d375a8a78
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138388
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-03-04 23:32:13 +00:00
285cce47e1
When implicit casts are disabled, report it also for for-each.
...
Internal presubmit looks green.
https://test.corp.google.com/ui#id=OCL:298910526:BASE:298911322:1583359564045:f2c3047c
Change-Id: I548b1d439ecc9cbb7f0924087fa9cab158022bb8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138381
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-04 22:43:33 +00:00
d3fd44182d
Fix crash in declaredParameterElement().
...
R=brianwilkerson@google.com
Bug: b/150742402
Change-Id: Ia72179f934579f1eb6861bf8b6cc955168e10136
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-04 19:42:16 +00:00
f67cc65ecb
Update tests and error code for void with type arguments.
...
R=brianwilkerson@google.com
Change-Id: I82c8c61bce2d841e06724d1d41dc10cac6f0c304
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138329
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-04 18:53:37 +00:00
27c50aeb86
Implement factor() operation from flow analysis.
...
Change-Id: If2e23c3b850974d9190b90b287b811baf3121739
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138269
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-04 17:01:55 +00:00
81bc629582
Use packageDefaultFeatureSet when the language version is the same as the current version.
...
Change-Id: I14862603d4204b879cd2b0f950d75a98dd347419
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138262
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-04 17:01:35 +00:00
1f92f1d903
Issue 40865. Fix for parsing documentation comment of an annotatied EnumConstantDeclaration.
...
Bug: https://github.com/dart-lang/sdk/issues/40865
Change-Id: Ida37b7140d8f2366d0f8c6d7e073f0ef92d95369
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138246
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-03-04 16:18:15 +00:00
fb547fcb28
Log data to debug crash in declaredParameterElement().
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I7f0ed393177adc9711560d8ea9ecfd2f57bd1217
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138270
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-04 15:38:00 +00:00
f828f00b59
[parser] Error recovery of type parameters on void
...
Fixes #39958 .
Change-Id: I851bef762776f4b68f0fcb645d634019b8b32e81
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137925
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2020-03-04 14:02:35 +00:00
794f70a044
Add currentVersion to experiments.g.dart code generated output.
...
Change-Id: I0ea91aaeb34068d25c07b61b0a432d24af0dd59a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138104
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2020-03-03 19:25:44 +00:00
131502d752
Unify two error codes and improve the messages
...
Change-Id: Ic3be0dfeadce045c051304be5331a1828202d057
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138120
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
2020-03-03 17:53:11 +00:00
e687b62ffe
Improve recovery on yield not-in generator; Improves #32967
...
Fix is inspired by very similar recover for `await` in synchronous
function, like `looksLikeAwaitExpression` and `endInvalidAwaitExpression`.
Change-Id: I50bf0c1e73c31551b94de29d78fd3d449c30fd20
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136920
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
2020-03-02 17:29:22 +00:00
860dca93ea
Fix crash when reporting REDIRECT_TO_NON_CONST_CONSTRUCTOR for unnamed constructor.
...
Another crash from internal crash logs.
R=brianwilkerson@google.com
Change-Id: I91cce6c968ba9641b55a4e77f63f34ad70cdca4c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137881
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-03-01 21:42:02 +00:00
7f483c067c
Set TypeName type of unresolved class with prefixed identifier in instance creation.
...
It was crashing prefer_void_to_null lint.
R=brianwilkerson@google.com
Change-Id: Ie9301d53267f264907ecc9e84d0c9252532172e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137827
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-02-29 00:24:50 +00:00
34fcc56458
Fix for renaming named formal parameters from invocations, when synthetic.
...
R=brianwilkerson@google.com
Change-Id: I4dc57cfc2a941229f2ba8b8b262ed49ecdd6b170
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137825
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-02-28 23:11:00 +00:00
Sam Rawlins