dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
71,210 Commits 2 Branches 0 Tags
52fe5ec0cdd63083b94de3489c27aab49a0995c4
Commit Graph

3382 Commits

Author SHA1 Message Date
Brian Wilkerson 486467c02d Bulk sort of a subset of the files in analysis_server 
Change-Id: Id811d37ad565c6f3c0ed508ae2b42e22469cbd3d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139830
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-17 19:13:14 +00:00
Paul Berry d9ce4d57aa Migration: create data structures for the navigation tree view. 
Change-Id: I482b07d3ae2025cf3a9375a02ddaa509beabc2de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139780
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
 2020-03-17 17:19:41 +00:00
Paul Berry 2ce64e4a7e Migration: create data structures for file details. 
Change-Id: Ibb909795431b33f826e52c39cd7108cc3ec7f204
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139684
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-03-17 00:07:41 +00:00
Jaime Wren 4590cd86c1 Add some missing tests for the new class ArithmeticMeanComputer in pkg/analysis_server/tool/completion_metrics/completion_metrics.dart 
Change-Id: Icff02abe7912e7d9b36a63181aa0a2f84b78aab7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139742
Commit-Queue: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-16 22:11:41 +00:00
Janice Collins 34fee361b6 Add sanity checks for NNBD state in migration. 
Also adds some ability for the migration tool to abort itself on
a few known-fatal errors and armor-plates dartdev tests against
CWD problems.

Bug: https://github.com/dart-lang/sdk/issues/40329
Change-Id: I1cfa2c9dcc7815eed075ecb38c63a74c75889002
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139282
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
 2020-03-16 18:27:58 +00:00
Mike Fairhurst 1ec961a7f9 [nnbd_migration] Reload changed paths on rerun to remove hack. 
Fixes https://github.com/dart-lang/sdk/issues/41025

Change-Id: I40fc3aa3438bdcecd595768d8b34dbe864b2a5d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139407
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-03-16 18:14:48 +00:00
Konstantin Shcheglov 3237380259 Fix for creating a field when the target is in a part without a library. 
R=brianwilkerson@google.com

Change-Id: I90b8031a805ba0cb51e7ccb8c2477d4f0d0ac8ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139603
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-16 15:52:08 +00:00
Brian Wilkerson 8929bbfbe1 Add a fix for the prefer_interpolation_to_compose_strings lint 
Change-Id: I24cf735233dcf4c0e0c269ba14fbc59873a89751
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139600
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-03-16 14:31:58 +00:00
Brian Wilkerson 48ac44b0e9 Fix a typo in a comment 
Change-Id: I4bbe3a7703cbd954aafd4e53b43649a29617f571
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139561
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-14 00:28:28 +00:00
pq a6a879577d remove non_const_const fix 
Change-Id: Ib2c96b06416b4f392f726de9af22bbf6700dd9dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139487
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-13 22:08:16 +00:00
Brian Wilkerson cf4b7d312a Add a flutter-specific fix for ARGUMENT_TYPE_NOT_ASSIGNABLE. 
Change-Id: I1687f88a274c69dd2fb6af5bcca7425378b9fd61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139480
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-03-13 17:33:01 +00:00
Paul Berry c3a0bb086a Migration: Add "why not nullable" traces where "!"s are inserted. 
Change-Id: I0367f869d59da0397589df7df43170f1ecbcb69c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139401
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-03-13 16:31:11 +00:00
Brian Wilkerson 28309556e6 Add more coverage in the relevance tests 
Change-Id: Iadf8c0f0931ba58aaad9aa03087011ea3bc62bad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139481
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-13 16:27:51 +00:00
Mike Fairhurst 563aebd5c7 [nnbd_migration] Rerun migration after performing edits. 
The way the server is managed is not 100% ideal, filed here: #41018

Change-Id: Idca6dd56e8375b2e8ea7cbb2f2bf329f2643a442
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139308
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-03-13 16:16:21 +00:00
Paul Berry 8361357e6e Fix assertion failure in stack trace builder. 
Fixes #41020.

Change-Id: I6cf52c3a5aac545c352f653def53508356676d71
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139317
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-03-13 12:27:40 +00:00
Konstantin Shcheglov a42efec049 Don't suggest ADD_RETURN_TYPE for setters. 
R=brianwilkerson@google.com, pquitslund@google.com

Change-Id: Ia584be1de6d6e4237f316bdd8cef77ae841a15ae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139315
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-12 22:54:36 +00:00
Konstantin Shcheglov 68b0b83bfe Issue 40842. Fix for getter return type location. 
R=brianwilkerson@google.com, pquitslund@google.com

Bug: https://github.com/dart-lang/sdk/issues/40842
Change-Id: Ifc8343a6df62d64d05b3870255b4602ab898d4cc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139260
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-12 17:44:26 +00:00
Konstantin Shcheglov d5eb515a88 Extract AddReturnType producer. 
As a preparation to fix the bug.

R=brianwilkerson@google.com, pquitslund@google.com

Bug: https://github.com/dart-lang/sdk/issues/40842
Change-Id: I9b448ebb79520e1f0f79cb008feeecd657e5b596
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139148
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2020-03-12 16:20:58 +00:00
pq 1f9881b63f type member relevance test 
Change-Id: Ifbe90c9478add7f1c7b93c1491ca6f08f96e9b39
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139145
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-03-12 01:16:30 +00:00
Konstantin Shcheglov 51f5636daf Report FLUTTER_GET_WIDGET_DESCRIPTION_CONTENT_MODIFIED when a file is changed during the request. 
R=brianwilkerson@google.com

Change-Id: I9d77df28dd16fdaf30ba4dd04fe8cfff221c236d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139144
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-12 01:09:00 +00:00
Paul Berry 93448a47c6 Migration: change trace view to alternate between edges and nodes. 
Previously, we only included edges in the trace view, which resulted
in a lot of missing information.  Generally the reasoning process
looks like "type at A is nullable because of an expression at B, which
propagates nullability from a type at C, which is nullable because of
an expression at D, etc."  This change makes the trace reflect that
reasoning process better.

Change-Id: I27d1b7aac736529b6f1fa2f7be8dea0d3eca9a6c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139064
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-03-11 21:30:40 +00:00
Konstantin Shcheglov 4e55949fa6 Refactor RemoveUnusedLocalVariable and fix for locals outside of function bodies. 
R=brianwilkerson@google.com, pquitslund@google.com

Change-Id: Idfb85bbe97a48055fc96dc5441618b7889a7cc00
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139060
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-11 18:19:40 +00:00
Jaime Wren 60dd17d053 Add the void keyword into additional missing portions of the AST in the keyword_contributor.dart - type arguments and method invocation type arguments 
Related PR: https://dart-review.googlesource.com/c/sdk/+/138743

Change-Id: I085cb0718ae00867e245fc13ef219e738306f14e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138914
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-03-11 15:29:59 +00:00
Brian Wilkerson 2282761bb6 Remove a duplicated key in a literal map 
Change-Id: I5351a56d86ff9e61da69c3274fe1956673d86382
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139035
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-03-11 15:16:49 +00:00
Jaime Wren 699f4b7395 Add additional metrics into the completion metrics algorithm, MRR broken apart by type member completions, and non-type member completions 
Change-Id: I5fd0c6b0ac1f9f0450ba630964e335488046a698
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138912
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-03-10 19:48:21 +00:00
Brian Wilkerson d673c176ae Start implementing new relevance scores for members of a type 
Change-Id: I5594da6c9f1b71d239593131c02b5b10a57a4725
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138907
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-10 17:28:51 +00:00
Konstantin Shcheglov b311a0052e Fixes REMOVE_UNUSED_FIELD and optional field formal parameters. 
R=brianwilkerson@google.com

Change-Id: I15587001262ed70fb6e4b740fee12542acb6b1a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138905
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-10 15:50:00 +00:00
Konstantin Shcheglov 83378633e1 Add the attachment with the content of the file being analyzed. 
Change-Id: I75b1c61e2d04cd5e03ef4375e97ef3c9f4add874
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138384
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-10 04:57:20 +00:00
Paul Berry 043af430c1 Migraiton: Add function names to trace output. 
This makes them look a lot more like real stacktraces.

Change-Id: I0c060f72f8676ab6d5c0272532b90931b815fddf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138607
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2020-03-09 22:00:59 +00:00
Jaime Wren 005c5d7b52 Add an additional MMR "Max Rank 5" metric to the output of the completion_metrics.dart 
Change-Id: I00ff65853eaef85bd33d76e930d7ba1d39783a14
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138882
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-03-09 21:54:20 +00:00
Jaime Wren 54e96f6ccf Add the dynamic keyword into additional missing portions of the AST (in method and constructor parameters) in the keyword_contributor.dart 
Change-Id: Idd394dc19992fa6406783a53ad50ebf58cf8f60f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138785
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-03-09 19:36:34 +00:00
Keerti Parthasarathy 8329bd7ca8 Do not check for '.analysis_options' for default options file in builder. 
Change-Id: I9decba4d0db318caedcfd3695f41c127b66f416f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138660
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2020-03-09 19:31:24 +00:00
Jaime Wren 4f0fb8f9b0 Fix some syntax errors in the Dart code in the keyword_contributor_test.dart 
Change-Id: I9ee3e22fd0afc21854f21d4701665cc24f3799df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138786
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-03-09 19:28:29 +00:00
Sam Rawlins fa2df01895 Null Safety preview: Fix description for uninitialized field 
Fixes #40773

Change-Id: I7639364820785f5a877917afbbb62ab9c09eff00
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138781
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-03-09 18:34:17 +00:00
Brian Wilkerson a629dbf073 Add a fix to inline a typedef 
I needed to fix AST nodes for parameters to know about the required
token when computing the beginning token and child entities.

Change-Id: Icb0fc27bc1e9f6650376f5870944fb8f592a5e8c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138744
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-03-09 14:17:07 +00:00
Jaime Wren 7e815546ac Add the dynamic keyword into additional missing portions of the AST in the keyword_contributor.dart 
Change-Id: I64ff9721c151e3e51841ea638e8b2fd2b472ac27
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138743
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-03-09 05:34:00 +00:00
Jaime Wren de493465c8 Include 'dynamic' in the list of suggested keywords for type names, i.e. the 'dynamic' in "dynamic contents = ..." 
Change-Id: I8e388a2b8077140cb7e0047e1f16c36ea12aded5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138612
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-03-06 23:09:54 +00:00
Mike Fairhurst 972e045649 [analyzer] Fix windows paths again, and use ResourceProviderMixin. 
The paths in the SourceEdits I was constructing needed to be converted,
and since it wasn't a "new failure," the windows trybot for the previous
CL passed anyway (and didn't include output of what went wrong).

Change-Id: I5bb2a52bf8cf112d6a2dae0b5749d1ae4e900e2a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138575
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2020-03-06 18:29:13 +00:00
Mike Fairhurst 5b0e439503 Fix windows path test/bots 
Change-Id: Ia0f983fb14915bf1c6b331c5d5b68b30ffeaec04
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138482
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2020-03-05 19:19:39 +00:00
Paul Berry a74253987b Migration: add trace functionality to the preview tool. 
This establishes the base functionality.  A lot of follow-up work is
needed from here:

- Each trace should have an entry at the top of it pointing to the
  thing that was made nullable.

- The source code links in traces don't include lengths, so we can't
  highlight whole identifiers when the user clicks on a link.

- Description strings are currently generated by running toString() on
  the individual nullability nodes and edges, resulting in long-winded
  and useless descriptions.

Change-Id: Ibb370bae6bedc7a8c86092462785023002a48ac3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138481
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-03-05 17:21:54 +00:00
Mike Fairhurst d83efc38f9 [nnbd_migration] Apply the changes to disk on apply-migration request 
This integrates fairly well with the new dartdev ux. We may be able to
improve the wording, etc., but given the fact that it has to be rerun
with --apply-edits, there is no need to notify anyone that the edits
occurred (currently). I'll take another look at potential wording
improvements in a follow-up CL.

In the dartfix ux, the dartfix driver doesn't get notified of the
changes and will ask if you want to apply, and this is not as good :) If
you say yes, you will apply the edits twice. Given that there is already
a CL to delete that code, I didn't change this in dartfix and don't plan
to.

Change-Id: Ie822a5761d05b3dd08b5a793f812a331d4657598
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138203
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-03-04 18:42:56 +00:00
Mike Fairhurst 9eb655ee66 [nnbd_migration] Preserve "migration applied" state across reload. 
Change-Id: I30e0dd282b4d50ad416cd1ac9aa3d1c0bc58037f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138202
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-03-04 18:42:56 +00:00
Brian Wilkerson ed1091af3e Add two fixes for avoid_returning_null_for_future 
Change-Id: I6ece892025233fe3dd51ececb7b92368be9669ae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138321
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-04 17:26:45 +00:00
Brian Wilkerson 027f9588e1 Fix replace_null_with_closure when the parameter type has no parameter names (issue 40578) 
Change-Id: Ie85294e1925a1d3880416ef4ceed86052e1534e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138140
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-03 18:51:23 +00:00
Paul Berry 8fa6e9d20e Migration: separate EditLink and TargetLink models for preview tool. 
The preview tool's "edit details" box handles two kinds of links:
links allowing the user to request a change to the source file
(i.e. adding/removing hints), and links allowing the user to navigate
to a target.  Use separate data structures for these two kinds of
links, because they store different data.

Change-Id: I41bdf7fc9c94fc28e703da34d67d8c20f6f86108
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138012
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-03-03 16:42:51 +00:00
Paul Berry 179f2caf14 Migration: update region_renderer_test to use new EditDetails data structure. 
Change-Id: I4103eb63f752b91fb679d024b27ed63b5fca4551
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138048
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-03-03 16:42:51 +00:00
Mike Fairhurst ca3ad264a6 [nnbd_migration] Report info building exceptions to server adapter 
Change-Id: I4e3eef0d3e404bd090f36f8b2516abb97cc6c311
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137520
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2020-03-02 23:33:06 +00:00
Mike Fairhurst 1cb188e2a1 [nnbd_migration] Add assertions that we produced good explanations. 
Change-Id: Id09c64304eb1ffce51ccfde33403dec5f8498072
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137122
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-03-02 23:33:06 +00:00
Brian Wilkerson dda9290461 Add a fix for use_full_hex_values_for_flutter_colors 
I also extended the framework to allow arguments to be returned so that
the fix messages can be parameterized. I'm not super thrilled with the
extra return statements everywhere, so if you have suggestions for an
alternate approach I'm happy to hear them.

Change-Id: Ie7c7133d83df4aa54b198125477fcbbc0ab8f5ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137940
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-02 22:04:26 +00:00
Brian Wilkerson 1c34d8ce57 Add a new command-line flag for server to enable the new relevance computations 
Change-Id: If4c9e95a6e5e804fe480cf8a061ff95ec37651e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138002
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-02 18:55:32 +00:00