f617f92c15
Capture the syntactic metrics removed from relevance-metrics
...
Change-Id: I89f7112ad31f41b0b6bc406156f4371fa373d62c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139842
Reviewed-by: Jaime Wren <jwren@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-03-17 19:35:55 +00:00
23abbd30b8
Set a default relevance for cases where none of the features apply
...
Change-Id: I7fd837349965ce7710fd99daacd691b30bf25100
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139841
Reviewed-by: Jaime Wren <jwren@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-03-17 19:27:30 +00:00
169b88654d
Split out metrics computations for static members
...
Also did a little cleanup and sorted the file.
Change-Id: I7bb288345abf851dd88d6f7cf28e4d49ade75ec6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139829
Reviewed-by: Jaime Wren <jwren@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-03-17 19:23:27 +00:00
486467c02d
Bulk sort of a subset of the files in analysis_server
...
Change-Id: Id811d37ad565c6f3c0ed508ae2b42e22469cbd3d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139830
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-03-17 19:13:14 +00:00
8c07071afb
Use context type in the static member contributor
...
I couldn't think of any other features related to static members. Please
let me know if you can think of any.
I need to modify the metrics utility to be able to differentiate between
static and instance member references in order to measure the impact of
this approach. I'll look into doing that today. I suspect that we'll
eventually need it to split out results in many more ways as well.
Also updated some comments in an attempt to make it easier in the future
to determine which contributor to look at for bug fixes or enhancements.
Change-Id: Ieef62c6189bbfbd35283abdf35b8cbdd17746ee8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139820
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-03-17 17:27:46 +00:00
d9ce4d57aa
Migration: create data structures for the navigation tree view.
...
Change-Id: I482b07d3ae2025cf3a9375a02ddaa509beabc2de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139780
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Janice Collins <jcollins@google.com >
2020-03-17 17:19:41 +00:00
87cc6c76ca
Sort declarations in navigation_tree_renderer.dart
...
Change-Id: I3689bc8e6079252cead246bfd0a8402b8f60da1d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139744
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-03-17 17:19:41 +00:00
2ce64e4a7e
Migration: create data structures for file details.
...
Change-Id: Ibb909795431b33f826e52c39cd7108cc3ec7f204
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139684
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2020-03-17 00:07:41 +00:00
4590cd86c1
Add some missing tests for the new class ArithmeticMeanComputer in pkg/analysis_server/tool/completion_metrics/completion_metrics.dart
...
Change-Id: Icff02abe7912e7d9b36a63181aa0a2f84b78aab7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139742
Commit-Queue: Jaime Wren <jwren@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Auto-Submit: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-03-16 22:11:41 +00:00
810d85d4cf
Measure and report the average number of milliseconds it takes per code completions.
...
Tests to come for the new class.
Change-Id: I387ec41966e8db674c0be26124a9dcb8abeeb30a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139700
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-03-16 19:58:20 +00:00
0e0d4fb76b
linter 0.1.113
...
Change-Id: I75cc9478171de15df24bc5addfa0aca4dcf7e97a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139660
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-03-16 19:48:00 +00:00
90e32fe161
Disable other sorting when using the new relevance computation
...
This actually makes the scores slightly worse, but I think it's important
that we understand the quality of the scores without other sorting. The
scores are still better than with the old computation.
Change-Id: I514aa35029b600b9ab87bf531064f1e89b02774a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139682
Reviewed-by: Jaime Wren <jwren@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-03-16 18:36:03 +00:00
34fee361b6
Add sanity checks for NNBD state in migration.
...
Also adds some ability for the migration tool to abort itself on
a few known-fatal errors and armor-plates dartdev tests against
CWD problems.
Bug: https://github.com/dart-lang/sdk/issues/40329
Change-Id: I1cfa2c9dcc7815eed075ecb38c63a74c75889002
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139282
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Janice Collins <jcollins@google.com >
2020-03-16 18:27:58 +00:00
1ec961a7f9
[nnbd_migration] Reload changed paths on rerun to remove hack.
...
Fixes https://github.com/dart-lang/sdk/issues/41025
Change-Id: I40fc3aa3438bdcecd595768d8b34dbe864b2a5d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139407
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-03-16 18:14:48 +00:00
3237380259
Fix for creating a field when the target is in a part without a library.
...
R=brianwilkerson@google.com
Change-Id: I90b8031a805ba0cb51e7ccb8c2477d4f0d0ac8ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139603
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-16 15:52:08 +00:00
8929bbfbe1
Add a fix for the prefer_interpolation_to_compose_strings lint
...
Change-Id: I24cf735233dcf4c0e0c269ba14fbc59873a89751
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139600
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-03-16 14:31:58 +00:00
48ac44b0e9
Fix a typo in a comment
...
Change-Id: I4bbe3a7703cbd954aafd4e53b43649a29617f571
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139561
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-03-14 00:28:28 +00:00
a6a879577d
remove non_const_const fix
...
Change-Id: Ib2c96b06416b4f392f726de9af22bbf6700dd9dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139487
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-03-13 22:08:16 +00:00
1d959fad1b
Refactor the way context type is computed to improve performance
...
Change-Id: Icab69d66d30c616c4800d18ae7543059a21e5e7f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139484
Reviewed-by: Jaime Wren <jwren@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-03-13 20:34:06 +00:00
cf4b7d312a
Add a flutter-specific fix for ARGUMENT_TYPE_NOT_ASSIGNABLE.
...
Change-Id: I1687f88a274c69dd2fb6af5bcca7425378b9fd61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139480
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-03-13 17:33:01 +00:00
c3a0bb086a
Migration: Add "why not nullable" traces where "!"s are inserted.
...
Change-Id: I0367f869d59da0397589df7df43170f1ecbcb69c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139401
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2020-03-13 16:31:11 +00:00
28309556e6
Add more coverage in the relevance tests
...
Change-Id: Iadf8c0f0931ba58aaad9aa03087011ea3bc62bad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139481
Reviewed-by: Jaime Wren <jwren@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-03-13 16:27:51 +00:00
4cdd7ec7be
[nnbd_migration] Enable apply edit links by default.
...
Change-Id: I06731286a049a58c8ba968423b0629a0800825f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139310
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2020-03-13 16:16:21 +00:00
624b135cf0
[nnbd_migration] Add a rerunning pane to enforce consistency on hinting
...
Change-Id: Ie1f08f5a7bb73e9e73783326c4efcfc6b5f75dfa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139309
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2020-03-13 16:16:21 +00:00
f1452fc2d9
[nnbd_migration] Apply hint block until rerun; refresh preview after.
...
Change-Id: I49df050ec05099742510aa78584bfd15d9e9f840
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139321
Reviewed-by: Paul Berry <paulberry@google.com >
2020-03-13 16:16:21 +00:00
563aebd5c7
[nnbd_migration] Rerun migration after performing edits.
...
The way the server is managed is not 100% ideal, filed here: #41018
Change-Id: Idca6dd56e8375b2e8ea7cbb2f2bf329f2643a442
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139308
Reviewed-by: Paul Berry <paulberry@google.com >
2020-03-13 16:16:21 +00:00
2ee07c3193
[nnbd_migration] Fix issue creating two PreviewSite's for GET/POST
...
This caused an issue where the POST request to add a hint would trigger
a rerun and update the state of the POST handler, but the GET handler
still had the old state.
Make just one PreviewSite so that state can be updated and stay
consistent.
Change-Id: I9f984708fd95954b1d8d2c0b8fc2e3bce8350053
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139307
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2020-03-13 16:16:21 +00:00
546acb1e8e
[nnbd_migration] Split apart running tasks from sending dartfix response
...
This enables us to get code that we can execute to rerun dartfix in
later CLs.
One note is that this won't pick up on certain file changes, etc. I
think a better long-term solution is to rerun the entire DartFix code on
rerun, and that dartfix response can be returned directly to the js
front end. Its possible that the types of file changes this will miss
are extremely rare, such as changed .packages files only etc.
This would require a bit more untangling, things like managing the way that
dartfix will start a server each time, and ensuring that we get a
DartFix respnse *and* a migration state, so this CL seems worth landing
in the meantime. Filed as #41017
Change-Id: If629cac41149728b34f6eb9785a7cea543a23a6f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139306
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Janice Collins <jcollins@google.com >
2020-03-13 16:16:21 +00:00
8361357e6e
Fix assertion failure in stack trace builder.
...
Fixes #41020 .
Change-Id: I6cf52c3a5aac545c352f653def53508356676d71
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139317
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2020-03-13 12:27:40 +00:00
b31445c0f8
Improve the relevance scores for instance type members
...
The "super matches" feature should have been disabled (-1.0) when the
target wasn't `super`, but it wasn't. That artificially lowered the
score for methods. But it wasn't being used (even when it should have
been) for getters and setters, so their scores weren't being lowered.
That accounted for the poor mrr I was seeing. This fixes both problems
so that the feature is now used everywhere when it should be and not
when it shouldn't be.
Change-Id: I541a9b1ed524e8b2ed2c0c7f39e7bca786e12ea9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139380
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Jaime Wren <jwren@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-03-13 01:12:41 +00:00
a42efec049
Don't suggest ADD_RETURN_TYPE for setters.
...
R=brianwilkerson@google.com , pquitslund@google.com
Change-Id: Ia584be1de6d6e4237f316bdd8cef77ae841a15ae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139315
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-12 22:54:36 +00:00
68b0b83bfe
Issue 40842. Fix for getter return type location.
...
R=brianwilkerson@google.com , pquitslund@google.com
Bug: https://github.com/dart-lang/sdk/issues/40842
Change-Id: Ifc8343a6df62d64d05b3870255b4602ab898d4cc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139260
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-12 17:44:26 +00:00
d5eb515a88
Extract AddReturnType producer.
...
As a preparation to fix the bug.
R=brianwilkerson@google.com , pquitslund@google.com
Bug: https://github.com/dart-lang/sdk/issues/40842
Change-Id: I9b448ebb79520e1f0f79cb008feeecd657e5b596
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139148
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2020-03-12 16:20:58 +00:00
009d27b081
Extract AddFieldFormalParameters.
...
Here I also add forCode(ErrorCode) method with the same goal - keep
all the knowledge about one issue in one place. Producers already
have to know which error they handle, because the have expectations
about the target node.
R=brianwilkerson@google.com , pquitslund@google.com
Change-Id: I584521b3a6e79cc126b5ff152dab26a397535463
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139181
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-12 15:34:42 +00:00
1f9881b63f
type member relevance test
...
Change-Id: Ifbe90c9478add7f1c7b93c1491ca6f08f96e9b39
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139145
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2020-03-12 01:16:30 +00:00
51f5636daf
Report FLUTTER_GET_WIDGET_DESCRIPTION_CONTENT_MODIFIED when a file is changed during the request.
...
R=brianwilkerson@google.com
Change-Id: I9d77df28dd16fdaf30ba4dd04fe8cfff221c236d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139144
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-12 01:09:00 +00:00
93448a47c6
Migration: change trace view to alternate between edges and nodes.
...
Previously, we only included edges in the trace view, which resulted
in a lot of missing information. Generally the reasoning process
looks like "type at A is nullable because of an expression at B, which
propagates nullability from a type at C, which is nullable because of
an expression at D, etc." This change makes the trace reflect that
reasoning process better.
Change-Id: I27d1b7aac736529b6f1fa2f7be8dea0d3eca9a6c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139064
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2020-03-11 21:30:40 +00:00
a7b8401517
Add a Stopwatch to time the completion_metrics.dart
...
Change-Id: I05ba8ac79ffa6a63c1cf66a79410d289d3659a29
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139062
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-03-11 18:24:09 +00:00
4e55949fa6
Refactor RemoveUnusedLocalVariable and fix for locals outside of function bodies.
...
R=brianwilkerson@google.com , pquitslund@google.com
Change-Id: Idfb85bbe97a48055fc96dc5441618b7889a7cc00
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139060
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-11 18:19:40 +00:00
1d5601e7f9
Modify the completion_metrics.dart algorithm to compute the set of completion suggestions with useNewRelevance set to true and false, and printing out each set of results for comparison.
...
Change-Id: I2510d247b1ee7397cfb5a01e6e87a3015543bc31
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139036
Commit-Queue: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-03-11 17:33:59 +00:00
60dd17d053
Add the void keyword into additional missing portions of the AST in the keyword_contributor.dart - type arguments and method invocation type arguments
...
Related PR: https://dart-review.googlesource.com/c/sdk/+/138743
Change-Id: I085cb0718ae00867e245fc13ef219e738306f14e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138914
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-03-11 15:29:59 +00:00
2282761bb6
Remove a duplicated key in a literal map
...
Change-Id: I5351a56d86ff9e61da69c3274fe1956673d86382
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139035
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-03-11 15:16:49 +00:00
37530145ff
Extract RemoveUnusedLocalVariable producer.
...
R=brianwilkerson@google.com , pquitslund@google.com
Change-Id: I0d0d7cccd0adb064f87bb1b9e656cad49f03a2e0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139033
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-11 06:01:29 +00:00
ace1d9b921
Do not repeatedly analyze a full library per part when dartfixing.
...
Migration performance improves 10x on web_ui with this CL.
Also fixes a heisenbug in the linter code where identical uniqueNames
for LintCodes could wind up in objects that compare differently.
Bug: https://github.com/dart-lang/sdk/issues/40915
Change-Id: Iddddfd7659f4bc724ddf21ebae41750a0ee51e74
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138940
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Janice Collins <jcollins@google.com >
2020-03-10 21:16:11 +00:00
cc85d28e60
Migrator: Add preliminary styles to stack trace
...
Change-Id: Iac8fdccb18b5ba04b058236ac1ee9b60643f67cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138924
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-03-10 21:06:10 +00:00
699f4b7395
Add additional metrics into the completion metrics algorithm, MRR broken apart by type member completions, and non-type member completions
...
Change-Id: I5fd0c6b0ac1f9f0450ba630964e335488046a698
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138912
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-03-10 19:48:21 +00:00
d673c176ae
Start implementing new relevance scores for members of a type
...
Change-Id: I5594da6c9f1b71d239593131c02b5b10a57a4725
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138907
Reviewed-by: Jaime Wren <jwren@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-03-10 17:28:51 +00:00
b311a0052e
Fixes REMOVE_UNUSED_FIELD and optional field formal parameters.
...
R=brianwilkerson@google.com
Change-Id: I15587001262ed70fb6e4b740fee12542acb6b1a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138905
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-10 15:50:00 +00:00
83378633e1
Add the attachment with the content of the file being analyzed.
...
Change-Id: I75b1c61e2d04cd5e03ef4375e97ef3c9f4add874
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138384
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-03-10 04:57:20 +00:00
043af430c1
Migraiton: Add function names to trace output.
...
This makes them look a lot more like real stacktraces.
Change-Id: I0c060f72f8676ab6d5c0272532b90931b815fddf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138607
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
2020-03-09 22:00:59 +00:00
Brian Wilkerson