dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
71,210 Commits 2 Branches 0 Tags
52fe5ec0cdd63083b94de3489c27aab49a0995c4
Commit Graph

29919 Commits

Author SHA1 Message Date
Martin Kustermann a67aac8c6a Re-land "[vm/tfa] Convert named and optional parameters to required parameters where possible." 
When performing protobuf-aware treeshaking, we may generate a kernel
file which will later be used in conjunction with a non-transformed
platform kernel. In this case signature shaking is unsafe.

The original revision is in patchset 1.

This reverts commit b59dad38df.

Change-Id: I1a85e42f245fcdbd821fa1f07b2e9966b8c2d958
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139100
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2020-03-17 19:54:05 +00:00
Brian Wilkerson f617f92c15 Capture the syntactic metrics removed from relevance-metrics 
Change-Id: I89f7112ad31f41b0b6bc406156f4371fa373d62c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139842
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-17 19:35:55 +00:00
Brian Wilkerson 23abbd30b8 Set a default relevance for cases where none of the features apply 
Change-Id: I7fd837349965ce7710fd99daacd691b30bf25100
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139841
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-17 19:27:30 +00:00
Brian Wilkerson 169b88654d Split out metrics computations for static members 
Also did a little cleanup and sorted the file.

Change-Id: I7bb288345abf851dd88d6f7cf28e4d49ade75ec6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139829
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-17 19:23:27 +00:00
Brian Wilkerson 486467c02d Bulk sort of a subset of the files in analysis_server 
Change-Id: Id811d37ad565c6f3c0ed508ae2b42e22469cbd3d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139830
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-17 19:13:14 +00:00
Sam Rawlins 9dfd0127da Do not report super-constructor errors on external constructors 
Bug: https://github.com/dart-lang/sdk/issues/27218
Change-Id: I1772cc850b21e97694eaa1852893993f6d4037b6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139824
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-03-17 18:34:04 +00:00
Brian Wilkerson 8c07071afb Use context type in the static member contributor 
I couldn't think of any other features related to static members. Please
let me know if you can think of any.

I need to modify the metrics utility to be able to differentiate between
static and instance member references in order to measure the impact of
this approach. I'll look into doing that today. I suspect that we'll
eventually need it to split out results in many more ways as well.

Also updated some comments in an attempt to make it easier in the future
to determine which contributor to look at for bug fixes or enhancements.

Change-Id: Ieef62c6189bbfbd35283abdf35b8cbdd17746ee8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139820
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-17 17:27:46 +00:00
Johnni Winther 5df236229a [cfe] Perform full field type inference in delayed type computation 
Change-Id: I2de1626588866c4089152747e70ddd8ff84a672b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139809
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-03-17 17:25:01 +00:00
Paul Berry 4b9b46ef01 Migration: improve specificity of FixBuilderTest.isMakeNullable 
Change-Id: Ibef1db9d1426cc4e8a5e7286f26887504352a767
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139751
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-03-17 17:19:41 +00:00
Paul Berry d9ce4d57aa Migration: create data structures for the navigation tree view. 
Change-Id: I482b07d3ae2025cf3a9375a02ddaa509beabc2de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139780
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
 2020-03-17 17:19:41 +00:00
Paul Berry 87cc6c76ca Sort declarations in navigation_tree_renderer.dart 
Change-Id: I3689bc8e6079252cead246bfd0a8402b8f60da1d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139744
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-17 17:19:41 +00:00
Konstantin Shcheglov faae2ec2c5 Issue 41019. Fix for readType of IndexExpression. 
Bug: https://github.com/dart-lang/sdk/issues/41019
Change-Id: I861b355c14c6bb30e570bb0c0101871db423ffb0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139821
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-17 17:16:56 +00:00
Johnni Winther bd9cb563a4 [cfe] Handle forwarding constructors in hasConstConstructor computation 
Closes #41070

Change-Id: If2f7120a29de97b4690f867c60aa6e21b1b777d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139806
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-03-17 15:25:33 +00:00
Johnni Winther 5721a33077 [cfe] Compute signature as part of override dependencies 
Change-Id: I893a8a31d78185ee73a8d175e63f13194e1cb991
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139501
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-03-17 14:42:02 +00:00
pq 3e970c4215 fix lint code urls 
Change-Id: I54c7fa05ea8d3c4dfee6d468ae5f99b3bb34c2c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139745
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-03-17 14:23:32 +00:00
Johnni Winther 4aba58122c [cfe] Handle bool.hasEnvironment constructor in constant evaluation 
.fromEnvironment environment constructor handling is updated to read
the default value from the declaration instead of hardcoding it.

Closes #41051
Closes #40501

Change-Id: I8eb4018dc7d6bea466a645d7762702914d9887db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139642
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-03-17 10:10:42 +00:00
Konstantin Shcheglov db5dc11b9b Issue 41050. Get default values for fromEnvironment() from element model. 
Bug: https://github.com/dart-lang/sdk/issues/41050
Change-Id: I8fee34a6b5816a725df4e4886fc85061ac4ec9b5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139661
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-17 02:05:41 +00:00
Konstantin Shcheglov fbd232dbe6 Issue 40958. Fix null shorting for MethodInvocation. 
Bug: https://github.com/dart-lang/sdk/issues/40958
Change-Id: Ic96b54feeeced5adb3b4271180636b493f951976
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139749
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-17 00:29:51 +00:00
Paul Berry 2ce64e4a7e Migration: create data structures for file details. 
Change-Id: Ibb909795431b33f826e52c39cd7108cc3ec7f204
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139684
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-03-17 00:07:41 +00:00
Konstantin Shcheglov efdbd86647 Issue 40704. Fix AstTextPrinter for '?[' support. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/40704
Change-Id: Icc800f8d5244030170b414c4f8c4d95cefab09a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139743
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-16 22:15:51 +00:00
Jaime Wren 4590cd86c1 Add some missing tests for the new class ArithmeticMeanComputer in pkg/analysis_server/tool/completion_metrics/completion_metrics.dart 
Change-Id: Icff02abe7912e7d9b36a63181aa0a2f84b78aab7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139742
Commit-Queue: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-16 22:11:41 +00:00
Mayank Patke 794d2eba4a [dart2js] Normalize X extends Never in generic functions. 
Change-Id: I36ddb6514ab8bfc3af70568502ce83d1f7d84d6b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139497
Commit-Queue: Mayank Patke <fishythefish@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2020-03-16 22:03:06 +00:00
Nicholas Shahan edb2c51dc4 [dartdevc] Cleanup old DDC test suite descriptors 
Change-Id: Ic4f295f67bfdad9ac28b0513769e62fd93ca85c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139720
Reviewed-by: Mark Zhou <markzipan@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2020-03-16 21:55:01 +00:00
Joshua Litt f1d57374ae [dart2js] Move a bunch of references from objectType to topType. 
Change-Id: Ia57b3604f26c8a92c53180d58ea5b41265965252
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138613
Commit-Queue: Joshua Litt <joshualitt@google.com>
Reviewed-by: Mayank Patke <fishythefish@google.com>
 2020-03-16 21:54:21 +00:00
jonahwilliams af46f7b103 [frontend_server] output dill during initial compilation to JavaScript 
This will allow the tool to use initialize from dill to speedup subsequent runs. In local testing, adding this and initialize from dill sped up the initial compile of the flutter_gallery from 14 seconds to 7 seconds.

https://github.com/flutter/flutter/issues/50616

Change-Id: Ie6bf08ec547c903da75177d892fdbb36a8924d0b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139313
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Jonah Williams <jonahwilliams@google.com>
 2020-03-16 20:34:46 +00:00
Konstantin Shcheglov 0f8238efe9 Issue 41036. Add null-shorting for prefix/postfix expressions. 
Bug: https://github.com/dart-lang/sdk/issues/41036
Change-Id: Iccff235bc81b6e65a3b40f972aaa75707ac2232c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139462
Reviewed-by: Janice Collins <jcollins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-16 20:23:16 +00:00
Jaime Wren 810d85d4cf Measure and report the average number of milliseconds it takes per code completions. 
Tests to come for the new class.

Change-Id: I387ec41966e8db674c0be26124a9dcb8abeeb30a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139700
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-03-16 19:58:20 +00:00
Robert Nystrom 54ae6c123e Make minitest and async_minitest NNBD agnostic. 
Fix a couple of errors when compiling those libraries as opted in to
NNBD.

Change-Id: I7dfb629d951d8531c8bed4e765950984e9291f44
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139686
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Srujan Gaddam <srujzs@google.com>
 2020-03-16 19:58:10 +00:00
pq 0e0d4fb76b linter 0.1.113 
Change-Id: I75cc9478171de15df24bc5addfa0aca4dcf7e97a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139660
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-16 19:48:00 +00:00
Brian Wilkerson 90e32fe161 Disable other sorting when using the new relevance computation 
This actually makes the scores slightly worse, but I think it's important
that we understand the quality of the scores without other sorting. The
scores are still better than with the old computation.

Change-Id: I514aa35029b600b9ab87bf531064f1e89b02774a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139682
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-16 18:36:03 +00:00
Janice Collins 34fee361b6 Add sanity checks for NNBD state in migration. 
Also adds some ability for the migration tool to abort itself on
a few known-fatal errors and armor-plates dartdev tests against
CWD problems.

Bug: https://github.com/dart-lang/sdk/issues/40329
Change-Id: I1cfa2c9dcc7815eed075ecb38c63a74c75889002
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139282
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
 2020-03-16 18:27:58 +00:00
Mike Fairhurst 1ec961a7f9 [nnbd_migration] Reload changed paths on rerun to remove hack. 
Fixes https://github.com/dart-lang/sdk/issues/41025

Change-Id: I40fc3aa3438bdcecd595768d8b34dbe864b2a5d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139407
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-03-16 18:14:48 +00:00
Devon Carew c27af75504 Use the 'any' constraint for the recommended dep on package:test. 
Change-Id: I4052cf0653d827795e120b9b2beecc285935973a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139680
Reviewed-by: Gary Roumanis <grouma@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Michael Thomsen <mit@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2020-03-16 16:56:18 +00:00
Konstantin Shcheglov 3237380259 Fix for creating a field when the target is in a part without a library. 
R=brianwilkerson@google.com

Change-Id: I90b8031a805ba0cb51e7ccb8c2477d4f0d0ac8ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139603
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-16 15:52:08 +00:00
Dmitry Stefantsov 928f9fc932 [cfe] Remove flag --force-nnbd-checks 
The checks are now always enabled for the "non-nullable" experiment

Closes #40980.

Bug: https://github.com/dart-lang/sdk/issues/40980
Change-Id: I32a141a93f0ba86ebdab554e1f312c2147927993
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139440
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2020-03-16 15:01:38 +00:00
Brian Wilkerson 8929bbfbe1 Add a fix for the prefer_interpolation_to_compose_strings lint 
Change-Id: I24cf735233dcf4c0e0c269ba14fbc59873a89751
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139600
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-03-16 14:31:58 +00:00
Jens Johansen d7a7854a5e [CFE] Add test that combine different scenarios 
This CL adds a test that combine different scenarios for compilation,
and check that we

* don't crash
* verify
* can serialize

The current combinations allow for combining an "outer level"
(top level, class level, extension level) with an "inner level"
(methods, fields, either static or not) with an expression.

This yields a large number of tests that has already shown some errors
(that was corrected before uploading this CL though).

The test can certainly be update later to uncover more territory.

Change-Id: Ic4b46ff3e26255c88c8eb8d8ce45f0257ffbc993
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139621
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-03-16 13:30:18 +00:00
Erik Ernst 330ec173a9 Add bool.hasEnvironment constructor and tests 
Change-Id: I65ebfcb48bf46292d5ae611ecb7431e0666f753c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139286
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
 2020-03-16 11:17:58 +00:00
Johnni Winther d2950737b8 [cfe] Add test for covariant late final fields 
Closes #40805

Change-Id: I896bce935803a951cfb8c9c0d0f70a6227de2413
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139464
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-03-16 08:30:08 +00:00
Johnni Winther e470662897 [cfe] Report error on opt-in exporting opt-out 
Closes #41032

Change-Id: I45fbb4c5cc5e723d3638ceb650909764d5c8012d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139460
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-03-16 08:28:17 +00:00
Konstantin Shcheglov 7079c49b05 Check for importedLibrary is null in importLibraryElement(). 
I see it in crashes sometimes.

R=brianwilkerson@google.com, pquitslund@google.com

Change-Id: I734d78f0e71c5985c7833fcf6e439fd4c48a5899
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139601
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-15 21:22:37 +00:00
Sigmund Cherem eff5548a68 [dart2js] remove invalid assertion in dart2js batch runner. 
Turns out the invariant is not respected in practice. This is what caused hundreds of flaky failures in the old-rti bot when I added this assert.

The batchArguments include experiments whenever the first test in a shard has an experiment flag. If that happens and most other test in the same shard don't have the experiment, all those tests will appear to crash with this assertion.  Because the assertion is outside the test itself, we get almost no feedback on the test logs.

TBR=fishythefish@google.com

Change-Id: I1230d79ed3cccbe388dddf19b5e8aa18c50f7329
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139566
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2020-03-15 04:33:56 +00:00
Stephen Adams 5d4dc1d5c4 [dart2js] Default to printLegacyStars for debug printing 
Change-Id: I504b6ebc4cc323c229d0aa068a874fe1331ddfbe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139562
Reviewed-by: Mayank Patke <fishythefish@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2020-03-14 01:56:27 +00:00
Brian Wilkerson 48ac44b0e9 Fix a typo in a comment 
Change-Id: I4bbe3a7703cbd954aafd4e53b43649a29617f571
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139561
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-14 00:28:28 +00:00
Srujan Gaddam 799cf665ea Move html custom tests off unittest 
Many of the setUps were meant to be one time setUps, so
they're only called once.

anyOf is added to async_minitest using the minitest impl.

Change-Id: Ibb2d4d0c3990d0df025fcaf6c02d49faa9733569
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139147
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-03-13 23:09:07 +00:00
Joshua Litt f42628cccd [dart2js] Handle nullabilities correctly while converting closures. 
Change-Id: I8ee97abc0a3ed1b3b72ce7b9d4f6060d24bcd4e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139489
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Joshua Litt <joshualitt@google.com>
 2020-03-13 22:16:17 +00:00
Stephen Adams 9375704dd0 [dart2js] Fix -DDUMP_IR 
TBR: sigmund@google.com
Change-Id: Ib6e50b20c646e3e0eaecbdf9396596fd5c1a2ce2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139520
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2020-03-13 22:08:26 +00:00
pq a6a879577d remove non_const_const fix 
Change-Id: Ib2c96b06416b4f392f726de9af22bbf6700dd9dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139487
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-13 22:08:16 +00:00
Konstantin Shcheglov 7c5059f528 Issue 40704. Report INVALID_NULL_AWARE_OPERATOR for unnecessary '?['. 
Bug: https://github.com/dart-lang/sdk/issues/40704
Change-Id: I67b45a4b5c6afba38141b33b44e2fc28726dffd3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139483
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-13 20:42:56 +00:00
Brian Wilkerson 1d959fad1b Refactor the way context type is computed to improve performance 
Change-Id: Icab69d66d30c616c4800d18ae7543059a21e5e7f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139484
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-13 20:34:06 +00:00