dart-lang/sdk - sdk - Tonycloud git server

dart-lang/sdk

Fork 0

Commit Graph

Author	SHA1	Message	Date
Vijay Menon	dd5530a73e	[dartdevc] make ImmutableSet private Patch files should not add public members to the underlying library. Siggi was hitting this when wiring up modular testing for DDC: https://dart-review.googlesource.com/c/sdk/+/103680/3/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart#544 The ddk builder appears to have be swallowing this error - not yet sure why. Change-Id: I86098b25a344b2bb8b69fe3dc386d01f6f7cb309 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103740 Reviewed-by: Nate Bosch <nbosch@google.com> Reviewed-by: Sigmund Cherem <sigmund@google.com> Commit-Queue: Vijay Menon <vsm@google.com>	2019-05-29 20:04:24 +00:00
Vijay Menon	47e63b0eee	[dartdevc] encode part file metadata Fixes https://github.com/dart-lang/sdk/issues/37074 Hand-tested on flutter gallery. E.g.,: > dart.getParts('package:flutter_web_ui/ui.dart') (15) ["src/ui/canvas.dart", "src/ui/compositing.dart", "src/ui/debug_canvas_reuse_overlay.dart", "src/ui/geometry.dart", "src/ui/hash_codes.dart", "src/ui/initialization.dart", "src/ui/lerp.dart", "src/ui/natives.dart", "src/ui/painting.dart", "src/ui/pointer.dart", "src/ui/semantics.dart", "src/ui/browser_location.dart", "src/ui/text.dart", "src/ui/tile_mode.dart", "src/ui/window.dart"] Change-Id: Ied734d9f3739886d6679a9a9bbeae854e432bc52 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103602 Reviewed-by: Jake Macdonald <jakemac@google.com> Commit-Queue: Vijay Menon <vsm@google.com>	2019-05-29 14:48:40 +00:00
Vijay Menon	96c2d3c303	[dartdevc] enable testing of ddc internals Change-Id: I8f4753a9a1f2f9f61df0d045adf07ff75fe32907 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103820 Reviewed-by: Alexander Thomas <athom@google.com> Commit-Queue: Vijay Menon <vsm@google.com>	2019-05-28 19:33:05 +00:00

Author

SHA1

Message

Date

Vijay Menon

dd5530a73e

[dartdevc] make ImmutableSet private

Patch files should not add public members to the underlying library.

Siggi was hitting this when wiring up modular testing for DDC:
https://dart-review.googlesource.com/c/sdk/+/103680/3/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart#544

The ddk builder appears to have be swallowing this error - not yet sure why.

Change-Id: I86098b25a344b2bb8b69fe3dc386d01f6f7cb309
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103740
Reviewed-by: Nate Bosch <nbosch@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Vijay Menon <vsm@google.com>

2019-05-29 20:04:24 +00:00

Vijay Menon

47e63b0eee

[dartdevc] encode part file metadata

Fixes https://github.com/dart-lang/sdk/issues/37074

Hand-tested on flutter gallery.  E.g.,:
> dart.getParts('package:flutter_web_ui/ui.dart')
(15) ["src/ui/canvas.dart", "src/ui/compositing.dart", "src/ui/debug_canvas_reuse_overlay.dart", "src/ui/geometry.dart", "src/ui/hash_codes.dart", "src/ui/initialization.dart", "src/ui/lerp.dart", "src/ui/natives.dart", "src/ui/painting.dart", "src/ui/pointer.dart", "src/ui/semantics.dart", "src/ui/browser_location.dart", "src/ui/text.dart", "src/ui/tile_mode.dart", "src/ui/window.dart"]

Change-Id: Ied734d9f3739886d6679a9a9bbeae854e432bc52
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103602
Reviewed-by: Jake Macdonald <jakemac@google.com>
Commit-Queue: Vijay Menon <vsm@google.com>

2019-05-29 14:48:40 +00:00

Vijay Menon

96c2d3c303

[dartdevc] enable testing of ddc internals

Change-Id: I8f4753a9a1f2f9f61df0d045adf07ff75fe32907
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103820
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Vijay Menon <vsm@google.com>

2019-05-28 19:33:05 +00:00

3 Commits