9559e4d444
Initial documentation for a small sample of diagnostics and a script to generate a markdown file containing that documentation
...
Change-Id: I06602a29c95829b42add1d655ad8d7190ae7100a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105141
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-06-07 22:31:16 +00:00
30390c6ba1
Prepare to compute the documentation URL for diagnostics
...
Change-Id: Ib1b7e4887e18b90c1552f3f8501948ee8d8d2c1f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105260
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-06-06 16:41:46 +00:00
76750c58f2
Issue 35553. Report WRONG_TYPE_PARAMETER_VARIANCE_IN_SUPERINTERFACE.
...
Locally I see that out of 198 language_2/superinterface_variance/ tests:
* With summary2 we pass 197, and fail 1 test.
* With summary1 we pass 165, and Crash in 33 tests.
R=brianwilkerson@google.com , paulberry@google.com
Bug: https://github.com/dart-lang/sdk/issues/35553
Change-Id: I79b5d7d2931c2d0c42ae6f12c19324deb7af784f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103960
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-29 17:13:30 +00:00
9081f28fbb
[analyzer] fix a copy paste doc issue and 2 unused imports
...
Change-Id: I20f4ae5454c2bceafd3b86e279357dee3b321006
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103644
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2019-05-24 16:31:25 +00:00
704446d159
Disable implicit casts but keep dynamic casts when NNBD enabled
...
Change-Id: Ia0a3271c9137bc8c7fa4cdbd469cf93d9453b69c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103405
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2019-05-23 23:41:52 +00:00
a30819a2f6
Add a diagnostic associated with the default List constructor
...
Change-Id: I41ba3e34c2f209c27bf83015feed0a2ce7918ea0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100789
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-04-30 22:24:02 +00:00
9b3567a466
Rename poorly named error code and improve the message
...
Change-Id: I9b71b400cb597bc03abe837722dbff8be18465de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100783
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-04-29 19:07:59 +00:00
3d0825da5d
Improve the message when a mixin cannot be applied because the superclass does not implement a required class (issue 36775)
...
Change-Id: Ifdcf8de365dbdcb50aa70acc8552a302ef2c8e1f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100700
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-04-29 15:13:49 +00:00
c3669f787e
Add a diagnostic for missing arguments associated with required named parameters
...
Change-Id: I78a46a41ae1c361da0995bb851414e19ef375477
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100632
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-04-26 22:53:44 +00:00
b4d17f2eee
Add diagnostics related to default values
...
Change-Id: I4b30580e34fbf302a53778010fada54a2e100409
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99887
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-04-23 17:16:50 +00:00
73d99df7e0
Report when a potentially nullable type is used in an on clause
...
Change-Id: I6e9e779d5bb0f37cfd71d4d2dc38c1511c03d59f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99484
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-04-16 19:34:25 +00:00
0314d86af4
Add errors when a nullable type is used as a supertype
...
Change-Id: I82471ba67dd74db6425bb2081bd761eb2b490333
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99284
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-04-12 21:13:21 +00:00
ca78eed3ea
Issue 36529. Report Null typed spread in not-null-aware spreads.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/36529
Change-Id: I60c092a18b668605f53f3258f3d74c333e9d1427
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98923
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-04-09 01:53:49 +00:00
e58a8fade5
Fix typos in the diagnostic messages
...
Change-Id: I65a11e52933c37a63cb9d0a14b1961a20e16271f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98600
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-04-04 13:47:40 +00:00
0560014c79
Remove unused error codes
...
Change-Id: I47daa6dab610af657ca781db5ca88438988c3c87
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98162
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-03-29 15:37:26 +00:00
a8831e7481
Handle _FROM_DEFERRED_LIBRARY codes for ui as code
...
Change-Id: Ie75eea20cd692331c25e2bb20bc11db30fbd749a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96851
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
Auto-Submit: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-03-22 18:53:49 +00:00
2ceaccf5f6
Report EQUAL_ELEMENTS_IN_CONST_SET.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I6f358c4f78deabc575479070d3ff23efb438ae64
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97177
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-03-19 15:55:18 +00:00
daa6ee6da9
Report NOT_ITERABLE_SPREAD and NOT_MAP_SPREAD.
...
R=brianwilkerson@google.com
Change-Id: I6668787b5b88d5125852e38bd9d30010e36c354b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97160
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-03-17 17:27:03 +00:00
c3005ee81f
Add error codes for expressions in maps and map entries not in maps
...
Change-Id: I2fdebac61f697710b4fd945f694c28626dabee93
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96985
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-03-14 22:01:53 +00:00
0a337bb36f
Report CONST_SPREAD_EXPECTED_LIST_OR_SET and CONST_SPREAD_EXPECTED_MAP.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I70eb31a19c447d17b4cc60ae2ff3caadb35cc6bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96712
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-03-13 06:40:05 +00:00
16e40cef2f
Generate a diagnostic when a set or map literal is ambiguous
...
Change-Id: Ia105468cf921ee2548ed48e286297e10f921a986
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96541
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-03-12 17:50:40 +00:00
5a335957f2
[analyzer] fix #33119 , add strict-raw-types flag
...
When the flag is enabled, warnings are issued for raw types, for
example `List`.
Raw types (those without explicit type arguments) are allowed if any
of these are true, otherwise they are reported:
- none of the type arguments are `dynamic`.
- the type was inferred from a downwards context.
- the class/typedef has `@optionalTypeArgs` from package:meta.
Change-Id: I1e70dba5b3bf6118b274bbf72843e3578dbaa8fd
Reviewed-on: https://dart-review.googlesource.com/c/75629
Auto-Submit: Jenny Messerly <jmesserly@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2019-03-02 00:02:01 +00:00
15515d86e3
Reland "[analyzer] Constant verifier support for SetOrMapLiteral"
...
Original change's description:
> Revert "[analyzer] Constant verifier support for SetOrMapLiteral"
>
> This reverts commit 9c6315c199https://dart-review.googlesource.com/c/94581
> > Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
> > Auto-Submit: Mike Fairhurst <mfairhurst@google.com >
>
> TBR=paulberry@google.com ,brianwilkerson@google.com ,mfairhurst@google.com
>
> Change-Id: Id7f48506994cc5b8de506f9830f12d794f186e21
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://dart-review.googlesource.com/c/94981
> Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
> Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
TBR=paulberry@google.com ,brianwilkerson@google.com ,mfairhurst@google.com
Change-Id: I7e514b646c1c62532e6f19201db6ea3428cb96d2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/95000
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2019-03-01 08:01:24 +00:00
9bec44d1e2
Revert "[analyzer] Constant verifier support for SetOrMapLiteral"
...
This reverts commit 9c6315c199https://dart-review.googlesource.com/c/94581
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
> Auto-Submit: Mike Fairhurst <mfairhurst@google.com >
TBR=paulberry@google.com ,brianwilkerson@google.com ,mfairhurst@google.com
Change-Id: Id7f48506994cc5b8de506f9830f12d794f186e21
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/94981
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2019-03-01 07:43:04 +00:00
9c6315c199
[analyzer] Constant verifier support for SetOrMapLiteral
...
Change-Id: Iaa189aa7ad733af3f702546f1d7a379630b61aa7
Reviewed-on: https://dart-review.googlesource.com/c/94581
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Auto-Submit: Mike Fairhurst <mfairhurst@google.com >
2019-03-01 06:36:17 +00:00
f0155931a9
Fix null reference exception in _constantValuesEqual
...
See #35908 .
Change-Id: Icbbb28920447362407e53c45b816474d1ab9e280
Reviewed-on: https://dart-review.googlesource.com/c/94021
Commit-Queue: Paul Berry <paulberry@google.com >
Auto-Submit: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-02-23 01:15:21 +00:00
7ebd02cdaa
Work around for #35908 .
...
As a temporary workaround, we ignore types when comparing default values for overrides.
See https://github.com/dart-lang/sdk/issues/35908 for a more detailed
explanation for why this is necessary. Once summaries properly record
types of constant values, we will be able to revert this hack.
Change-Id: I04728231338274a088656a629e303c0f1745466d
Reviewed-on: https://dart-review.googlesource.com/c/93642
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-02-20 20:20:05 +00:00
39afa4e555
Revert "Add ExecutableElement(s) based InheritanceManager3, and switch analyzer to it."
...
This reverts commit 5d6bab4ed2https://dart-review.googlesource.com/c/93141
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
TBR=scheglov@google.com ,brianwilkerson@google.com
Change-Id: I98d478f56e8aea037cbcc8b6cb940c36edb732fd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/93440
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-02-15 16:38:08 +00:00
5d6bab4ed2
Add ExecutableElement(s) based InheritanceManager3, and switch analyzer to it.
...
Change-Id: I9d87619e05ae769f4df6a6ba26cd7901c7c98510
Reviewed-on: https://dart-review.googlesource.com/c/93141
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-02-14 18:11:18 +00:00
46aa511b49
Improve the message when using a prefix to reference an undefined name (issue 35936)
...
Change-Id: Iae25bdffc992e0a50687ab54c56118cd13dfa26f
Reviewed-on: https://dart-review.googlesource.com/c/93121
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-02-13 23:37:37 +00:00
b196cd2acb
Issue 34437. Restore checking that optional parameters in derived classes should have the same default values as overridden.
...
Downgrade INVALID_OVERRIDE_DIFFERENT_DEFAULT_VALUES_NAMED and INVALID_OVERRIDE_DIFFERENT_DEFAULT_VALUES_POSITIONAL to warnings.
Bug: https://github.com/dart-lang/sdk/issues/34437
Change-Id: I4399839e04135a5d9a557c0ab06f319d9759af23
Reviewed-on: https://dart-review.googlesource.com/c/91460
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-29 22:35:15 +00:00
1ba59eb13d
Make ERROR the default severity for StaticWarningCode. Remove _StrongModeTypeErrorProcessor.
...
As a preparatory step for re-landing https://dart-review.googlesource.com/c/sdk/+/91170
and making these two restored problems to warnings.
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I6266632ade84743b5725c54475fe402902576c00
Reviewed-on: https://dart-review.googlesource.com/c/91420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-01-28 22:08:17 +00:00
ec5ba8a252
Revert "Issue 34437. Restore checking that optional parameters in derived classes should have the same default values as overridden."
...
This reverts commit 6699384dddhttps://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8923238548150736816/+/steps/analyze_flutter/0/stdout
Original change's description:
> Issue 34437. Restore checking that optional parameters in derived classes should have the same default values as overridden.
>
> R=brianwilkerson@google.com , paulberry@google.com
>
> Bug: https://github.com/dart-lang/sdk/issues/34437
> Change-Id: Ic54d2e074bc764376f970c9c29ba260e7a373d93
> Reviewed-on: https://dart-review.googlesource.com/c/91170
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
TBR=paulberry@google.com ,scheglov@google.com ,brianwilkerson@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: https://github.com/dart-lang/sdk/issues/34437
Change-Id: I07c96c8131c16b2748a403f38d5f15b814131c63
Reviewed-on: https://dart-review.googlesource.com/c/91360
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-01-28 17:09:24 +00:00
6699384ddd
Issue 34437. Restore checking that optional parameters in derived classes should have the same default values as overridden.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug: https://github.com/dart-lang/sdk/issues/34437
Change-Id: Ic54d2e074bc764376f970c9c29ba260e7a373d93
Reviewed-on: https://dart-review.googlesource.com/c/91170
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-26 20:12:55 +00:00
a5f102a7d1
Analyzer: first pass at reporting unchecked nullable value usage.
...
Change-Id: I095c7feff821535a17c7cbb0c4bdb9bb04253f16
Reviewed-on: https://dart-review.googlesource.com/c/88752
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2019-01-16 18:38:34 +00:00
2c09a4cf33
update error message
...
fixes a small typo in the `INVOCATION_OF_NON_FUNCTION_EXPRESSION` message
Closes #35589
https://github.com/dart-lang/sdk/pull/35589
GitOrigin-RevId: b30d58449c7d2d7a786d71f64ce1a4251de72296
Change-Id: I623ebd0f5113e4bc8b1e07bfd963c27a28c7fef0
Reviewed-on: https://dart-review.googlesource.com/c/88603
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-01-07 23:38:43 +00:00
3cec3dd5bf
Issue 35548. Don't report CONST_CONSTRUCTOR_WITH_MIXIN_WITH_FIELD when mixin has a static field.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/35548
Change-Id: I46a2006574e31505a860a9e54640b643bb514ae7
Reviewed-on: https://dart-review.googlesource.com/c/88600
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-07 22:32:53 +00:00
eebafbc4a8
Issue 35090. Add noSuchMethod forwarders to implemented members.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/35090
Change-Id: I1a72d70effe49111921a0db2a2e5396197d3a51b
Reviewed-on: https://dart-review.googlesource.com/c/88542
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-01-07 19:40:19 +00:00
c39a58a9fe
Generate an error if a constant set contains two elements with the same value
...
Change-Id: Ie359a1ea639e9c928df32c727bcd2f075f92033f
Reviewed-on: https://dart-review.googlesource.com/c/88425
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-01-05 15:13:12 +00:00
2118fcf7b0
Rename StrongTypeSystemImpl
...
Change-Id: I394bd9bfa2b6d9ceeb87312e94a3e315e32846a1
Reviewed-on: https://dart-review.googlesource.com/c/86282
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-12-05 22:22:36 +00:00
6905e57f8b
Issue 35223. Skip setters that don't have exactly one parameter.
...
We have already reported a more serious problem about such setters.
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/35223
Change-Id: I10250be15897d55d29004655127f56ddf77be4aa
Reviewed-on: https://dart-review.googlesource.com/c/86080
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-12-04 20:30:13 +00:00
67472e59fb
Remove an unused error code and the fix associated with it
...
Change-Id: I5118cea64a9c687e7ebd102a09cbfbaf467d1e96
Reviewed-on: https://dart-review.googlesource.com/c/85320
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-11-25 19:11:46 +00:00
1d00a8a11f
Add checking for errors related to set literals
...
Change-Id: Iad1442da6be318a709f5782fbda4a9055f55dfac
Reviewed-on: https://dart-review.googlesource.com/c/84302
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-11-13 20:08:23 +00:00
f6128b48b6
Add constant evaluation for operators that now apply to bool as well as int
...
Change-Id: I080386cddfece2d789fcee7d13bdda01260cc724
Reviewed-on: https://dart-review.googlesource.com/c/84160
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-11-12 21:26:08 +00:00
c9ae39a9bf
Issue 34741. Update error message to make it less unclear.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/34741
Change-Id: If766d0aad5d87578a578849f269746a64430a68b
Reviewed-on: https://dart-review.googlesource.com/c/84100
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-11-12 19:00:34 +00:00
268993acb2
Provide support for is and as expressions
...
Change-Id: I853fee6a868314392d37f51f8dd36e2dda319c38
Reviewed-on: https://dart-review.googlesource.com/c/84050
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-11-12 17:10:20 +00:00
3a427f3294
Add an object representation for literal constant sets
...
Change-Id: If9ebebac0ba6891c7c5bd2398898f20a7ea82c6b
Reviewed-on: https://dart-review.googlesource.com/c/83940
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-11-09 17:29:31 +00:00
30f1c7cbab
Remove references to analyzer/analyzer.dart
...
Change-Id: I3b3affa957ed8cc8c66f2b32c45b7dcd820f9b1e
Reviewed-on: https://dart-review.googlesource.com/c/82713
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-11-03 00:19:22 +00:00
320c6150e8
Check overrides only against names directly defined in superinterfaces.
...
R=brianwilkerson@google.com
Change-Id: Id354887ff9f6bc0fcbc338839cb5f52fefd3c9b7
Reviewed-on: https://dart-review.googlesource.com/c/81221
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-10-23 16:43:21 +00:00
6d81edec7b
Remember super-interfaces as Interface objects in _ClassVerifier.
...
R=brianwilkerson@google.com
Change-Id: I0bd2cf89f64d894334501b68ba9fc5707e34bf74
Reviewed-on: https://dart-review.googlesource.com/c/81120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-10-22 18:33:37 +00:00
Brian Wilkerson