Commit Graph

166 Commits

Author SHA1 Message Date
rnystrom@google.com 10c9d938ab Place "packages" directories inside "tool".
Review URL: https://codereview.chromium.org//11362233

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14868 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-13 22:06:35 +00:00
ajohnsen@google.com ab69873a42 Make RegExp constructor non-const.
Another take of https://codereview.chromium.org/11410033/ with status changes applied for co19 tests.

BUG=

Review URL: https://codereview.chromium.org//11369210

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14837 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-13 10:18:06 +00:00
ajohnsen@google.com ec9fee9858 "Reverting 14829-14832"
BUG=

Review URL: https://codereview.chromium.org//11312203

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14833 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-13 07:28:13 +00:00
ajohnsen@google.com 8dc3edd7ce Make RegExp's constructor non-const.
BUG=

Review URL: https://codereview.chromium.org//11410033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14829 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-13 06:48:43 +00:00
floitsch@google.com 8e6f238f86 a === b -> identical(a, b)
Replace === null with == null.

BUG=http://dartbug.com/6380

Review URL: https://codereview.chromium.org//11361190

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14794 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-12 17:19:58 +00:00
rnystrom@google.com 46adf67738 Allow an empty "dependencies" key in a pubspec.
Review URL: https://codereview.chromium.org//11361201

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14773 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-10 01:00:58 +00:00
rnystrom@google.com 982aac12e6 Handle URLs in 'git clone' argument.
Review URL: https://codereview.chromium.org//11410016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14763 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-09 22:54:19 +00:00
gram@google.com 58a016634c Update utils to new library syntax.
This doesn't include adding partofs; that will have to be done later.
Review URL: https://codereview.chromium.org//11358145

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14693 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-08 17:42:40 +00:00
rnystrom@google.com bf31c85b6f Pass absolute path to git.
BUG=

Review URL: https://codereview.chromium.org//11364141

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14670 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-08 01:01:13 +00:00
rnystrom@google.com 9c0ace0797 Revert "Pass absolute path to git (redux)."
This reverts commit 9d638b8a9a48c7bae854685f9413d2c40a4911a1.

BUG=

Review URL: https://codereview.chromium.org//11361158

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14661 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-07 23:25:31 +00:00
rnystrom@google.com 930a3f1d7e Pass absolute path to git (redux).
Review URL: https://codereview.chromium.org//11312133

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14659 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-07 23:20:18 +00:00
rnystrom@google.com 0caf122ecd Revert "Pass absolute path to 'git clone'."
This reverts commit db4155692da9cda80ef558886eeea35e963fe1c6.

BUG=

Review URL: https://codereview.chromium.org//11360133

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14655 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-07 22:12:20 +00:00
rnystrom@google.com 8bea0cc487 Pass absolute path to 'git clone'.
Review URL: https://codereview.chromium.org//11390003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14654 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-07 22:03:53 +00:00
rnystrom@google.com f50263acb9 Revert "Try setting the working directory explicitly."
This reverts commit 71ae3f9bcae7ff111a3f360384ec148f1c2079b2.

BUG=

Review URL: https://codereview.chromium.org//11383003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14652 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-07 21:00:43 +00:00
rnystrom@google.com c5fb8014cb Try setting the working directory explicitly.
This shouldn't be necessary but I want to see if this makes the
Windows buildbots happy.

BUG=

Review URL: https://codereview.chromium.org//11377036

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14650 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-07 20:49:40 +00:00
ager@google.com b61bebe636 Allow Directory.create to create all missing path components.
Unified Directory.create/list/delete to take a named 'recursive'
argument.

Fixed bug in Path implementation on Windows.

R=sgjesse@google.com
BUG=dartbug.com/6024

Review URL: https://codereview.chromium.org//11364097

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14572 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-06 15:00:54 +00:00
rnystrom@google.com 5704507534 Show better error messages in network failures.
We had decent messages for a couple of failure modes. This tries
to catch some more.

Review URL: https://codereview.chromium.org//11369066

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14543 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-05 20:42:39 +00:00
rnystrom@google.com c561c7f4c8 Configure git explicitly when committing.
Review URL: https://codereview.chromium.org//11343059

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14314 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-30 23:31:16 +00:00
rnystrom@google.com 30f4763934 Revert "Explicitly configure git committer."
This reverts commit de38db47e7f5eca54ad1e338fec317cf67701448.

Review URL: https://codereview.chromium.org//11339058

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14313 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-30 22:19:21 +00:00
rnystrom@google.com 36ced3963a Explicitly configure git committer.
Review URL: https://codereview.chromium.org//11276042

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14312 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-30 22:09:41 +00:00
floitsch@google.com 9cc9214b58 Rename regexp methods to getters.
Review URL: https://codereview.chromium.org//11266050

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14094 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-25 19:31:56 +00:00
floitsch@google.com 2e778387b3 Make getKeys, getValues getters (keys, values).
Review URL: https://codereview.chromium.org//11267018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14093 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-25 19:22:11 +00:00
floitsch@google.com 3300f91153 Make first and last getters.
Review URL: https://codereview.chromium.org//11273041

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14082 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-25 15:19:31 +00:00
floitsch@google.com e7c5e69beb Make String.charCodes a getter.
Review URL: https://codereview.chromium.org//11263040

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14078 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-25 14:25:43 +00:00
floitsch@google.com 09f6d09d88 Make isEmpty a getter.
Review URL: https://codereview.chromium.org//11238035

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14022 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-24 15:04:32 +00:00
floitsch@google.com 0e47b363ae Make hasNext a getter instead of a method.
Review URL: https://codereview.chromium.org//11230011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14015 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-24 13:05:11 +00:00
lrn@google.com a083c1a108 Removed IllegalAccessException and UnsupportedOperationException.
Both were converted to StateError.

Review URL: https://codereview.chromium.org//11235054

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14012 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-24 12:36:10 +00:00
rnystrom@google.com 4c04a099d5 Apply patch from other client.
BUG=

Review URL: https://codereview.chromium.org//11235067

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13984 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 20:25:58 +00:00
floitsch@google.com 27cadf2b66 isEven, isOdd, isNegative, isMaxValue, isMinValue, isInfinite, isPositive, isSingleValue.
Review URL: https://codereview.chromium.org//11227042

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13974 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 16:15:36 +00:00
ager@google.com 57d5cd2278 Remove second sleep in pub and enable pub tests on Windows.
After the inherit fix I cannot reproduce the other 7zip
problem either so I'm removing the sleep call. All tests
pass on my machine.

Bob, could you test this with all of your migthty pub
power and see if you can make it break?

R=sgjesse@google.com,rnystrom@google.com
BUG=dartbug.com/5910

Review URL: https://codereview.chromium.org//11225056

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13964 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 13:56:54 +00:00
ager@google.com e18e79217d Do *not* make file handles inheritable on Windows.
This is the cause of the pub failures to unpack a file that has
just been created. The problem is that another 7-zip process has
inherited the file handle for a file that we are still writing.
When we are done writing the file, we cannot use it because the
other process still keeps the handle.

R=sgjesse@google.com,rnystrom@google.com
BUG=dartbug.com/5910

Review URL: https://codereview.chromium.org//11230051

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13960 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 13:04:02 +00:00
floitsch@google.com 9074fd0178 Make hashCode a getter and not a method.
Review URL: https://codereview.chromium.org//11191078

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13866 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-22 12:41:04 +00:00
regis@google.com 8c3cfbb381 Second round of cleanups for new optional parameter semantics.
Review URL: https://codereview.chromium.org//11194025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13759 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-17 20:58:19 +00:00
ager@google.com ff9e0f75fb Change Process.start to return a future that completes with a
Process object only when the process has been successfully started.

This is less error prone since you can use all the methods on a
Process object as soon as you can get your hands on it. Unfortunately,
this change leads to quite a few changes in test.dart. Some of those
changes will fix bugs as well. We used to have a problem with a
timeout that could fire just in between two steps in a chain of
commands that constitute one test run. This change should address
that issue as well.

BUG=dartbug.com/5305

Review URL: https://codereview.chromium.org//11091070

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13729 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-17 10:57:45 +00:00
regis@google.com adb534674c Change core lib, dart2js, and more for new optional parameters syntax and semantics (new semantics is not enforced yet).
Review URL: https://codereview.chromium.org//11090016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13684 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-16 16:03:47 +00:00
ajohnsen@google.com 1cbee26da4 Use correct newline-token on windows, in pub.
BUG=

Review URL: https://codereview.chromium.org//11174003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13678 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-16 09:09:49 +00:00
ajohnsen@google.com 5a104d7f2b Extract a list of lines from a process' stdout and stderr, in pub.
BUG=

Review URL: https://codereview.chromium.org//11169003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13677 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-16 08:34:20 +00:00
johnniwinther@google.com 19d27b1fe0 Pub fix for Windows
BUG=5859

Review URL: https://codereview.chromium.org//11170003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13676 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-16 08:09:51 +00:00
ricow@google.com f7b22d4cbb Download packages to temp dir inside system cache.
This fixes an issue where the rename will fail if your system temp directory is
on a different volume from your user directory (and thus your pub cache).
Review URL: https://codereview.chromium.org//11151035

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13674 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-16 06:18:49 +00:00
rnystrom@google.com e6fbcf3426 Add prefix.
Review URL: https://codereview.chromium.org//11142028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13671 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-15 22:52:38 +00:00
rnystrom@google.com ba0802348c Sleep before moving directory on Windows.
Gives 7zip more time to finish extracting before we access the
directory.

BUG=

Review URL: https://codereview.chromium.org//11151030

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13670 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-15 22:43:15 +00:00
rnystrom@google.com 4091f4ed21 Put a nasty sleep() on Windows.
We get "file in use" errors between downloading and extracting archives, so sleep for a bit.

BUG=

Review URL: https://codereview.chromium.org//11146022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13668 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-15 21:27:59 +00:00
rnystrom@google.com 1bb574612e Download to a temp dir and rename on success.
This prevents ghost packages ending up in your pub cache if a
download fails. Also added some more output during installation so
you can see what's happening.

BUG=

Review URL: https://codereview.chromium.org//11151026

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13666 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-15 20:59:56 +00:00
rnystrom@google.com fc169ee8b2 "Reverting 13451"
Review URL: https://codereview.chromium.org//11066091

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13452 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-09 23:32:21 +00:00
rnystrom@google.com 87f5622b44 Print out the working directory when git fails.
Also (sigh) re-enabling Windows again.

Review URL: https://codereview.chromium.org//11087039

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13451 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-09 23:26:43 +00:00
rnystrom@google.com 20788ffcba Show git command that failed.
Review URL: https://codereview.chromium.org//11066088

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13439 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-09 20:54:05 +00:00
rnystrom@google.com 182ae3e26c Update pub to use new import syntax.
Review URL: https://codereview.chromium.org//11093012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13391 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-09 01:25:43 +00:00
rnystrom@google.com eb33df709b Include stderr on git failure.
Also moves the git stuff out of io into its own library.

Review URL: https://codereview.chromium.org//11066066

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13388 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-09 00:56:57 +00:00
rnystrom@google.com 6a2cac8d2a Create destination directory before git cloning into it.
BUG=

Review URL: https://codereview.chromium.org//11076004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13334 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-05 23:13:14 +00:00
rnystrom@google.com f9b1655f8b Pass in DART_SDK from batch file on Windows.
Review URL: https://codereview.chromium.org//11027049

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13269 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-04 23:29:59 +00:00