dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
9,560 Commits 2 Branches 0 Tags
4efea1420e41285d8aec80dc6dfbb61bd8a67bc9
Commit Graph

56 Commits

Author SHA1 Message Date
ajohnsen@google.com 970cc5ba68 Move JSSyntaxRegExp to core as a private member. This removes the last refrences to dart:coreimpl. 
After this cleanup, RegExp no longer have a const constructor. Use 'new
RegExp(...)' from now on.

BUG=

Review URL: https://codereview.chromium.org//11365196

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14838 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-13 10:41:37 +00:00
floitsch@google.com 8e6f238f86 a === b -> identical(a, b) 
Replace === null with == null.

BUG=http://dartbug.com/6380

Review URL: https://codereview.chromium.org//11361190

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14794 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-12 17:19:58 +00:00
lrn@google.com 7e6ae8ea09 Renaming IndexOutOfRangeException to RangeError. 
It now extends ArgumentError.

Review URL: https://codereview.chromium.org//11275042

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14405 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-01 13:46:30 +00:00
floitsch@google.com 3300f91153 Make first and last getters. 
Review URL: https://codereview.chromium.org//11273041

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14082 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-25 15:19:31 +00:00
floitsch@google.com 09f6d09d88 Make isEmpty a getter. 
Review URL: https://codereview.chromium.org//11238035

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14022 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-24 15:04:32 +00:00
lrn@google.com a083c1a108 Removed IllegalAccessException and UnsupportedOperationException. 
Both were converted to StateError.

Review URL: https://codereview.chromium.org//11235054

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14012 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-24 12:36:10 +00:00
ajohnsen@google.com 7983141903 Move DualPivotQuicksort from coreimpl to core as _Sort. 
I've added a tempoary coreSort method in core, to coreimpl and other
uses, until the move is done.

BUG=

Review URL: https://codereview.chromium.org//11239004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13993 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-24 07:17:18 +00:00
lrn@google.com 9f32f0674a Add "contains" method to Collection. 
This versions does not implement "contains" on DOM lists.

Review URL: https://codereview.chromium.org//11195039

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13806 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-19 06:58:19 +00:00
lrn@google.com ae9664a9cc Revert "Add "contains" method to Collection." 
Review URL: https://codereview.chromium.org//11186045

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13769 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-18 10:55:02 +00:00
lrn@google.com c3c2ae61c6 Add "contains" method to Collection. 
Also added a Sequence interface to capture things with a length and
integer indexing. List and String implement that interface, and
there is a base skeleton class for collections that are Sequences.

BUG=1030

Review URL: https://codereview.chromium.org//11169004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13766 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-18 08:48:11 +00:00
lrn@google.com cd5be325f8 Make argument of List.sort optional with default Comparable.compare. 
BUG=1235

Review URL: https://codereview.chromium.org//11144016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13718 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-17 07:39:12 +00:00
ager@google.com abee5139e5 Reapply change to hide VM-only List implementation classes. 
The performance issue was that I had not updated the method
recognizer.

BUG=

Review URL: https://codereview.chromium.org//10990083

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13003 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-28 11:08:38 +00:00
ager@google.com fe66a0af1a Revert hiding of VM-only coreimpl list implementation types. While I 
investigate performance regression (even after fixing constructors
in the intrinsifier).

R=iposva@google.com,srdjan@google.com,fschneider@google.com
BUG=

Review URL: https://codereview.chromium.org//11000025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12963 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-27 14:07:56 +00:00
ager@google.com 8e6a2c8345 Hide VM-only coreimpl List implementation types. These should not be 
exposed as visible parts of coreimpl.

Review URL: https://codereview.chromium.org//10990055

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12952 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-27 12:37:30 +00:00
ager@google.com 81e81825c9 Make data setter private on GrowableObjectArray. 
There is no data setter on Lists. Additionally, this allows to
create buffer overflows.

R=vegorov@google.com,iposva@google.com
BUG=

Review URL: https://codereview.chromium.org//10982045

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12941 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-27 06:21:07 +00:00
lrn@google.com a1faa6f135 Change IllegalArgumentException to ArgumentError. 
Review URL: https://codereview.chromium.org//10989013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12841 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-25 12:27:52 +00:00
srdjan@google.com 7e0a30ee00 Remove unnecessary throws in growablearray. 
Review URL: https://codereview.chromium.org//10987004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12815 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-24 22:37:03 +00:00
lrn@google.com c0f42d2748 Made removeAt errors consistent between dart2js and VM. 
Reneabled test for VM.

Review URL: https://codereview.chromium.org//10960011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12632 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-20 12:52:54 +00:00
lrn@google.com eeeab5f0ad Add list.removeAt method. 
Review URL: https://codereview.chromium.org//10970009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12627 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-20 10:50:00 +00:00
kasperl@google.com 023546faf8 Remove more () from getters. 
This makes it possible to run all standard tests except co19
without ever using a getter that's defined with ().

R=iposva@google.com,hausner@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10928051

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12028 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-07 12:56:21 +00:00
srdjan@google.com 7f400ac01e Some code cleanups in arrays, fix rangeCheck (issue 2899). 
Review URL: https://chromiumcodereview.appspot.com//10905010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11572 260f80e4-7a28-3924-810f-c04153c831b5
 2012-08-30 00:47:24 +00:00
whesse@google.com 4789857341 Remove List.copyFrom from VM and from tests. It was removed from the List interface in r941. 
BUG=dart:1953

Review URL: https://chromiumcodereview.appspot.com//10898003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11437 260f80e4-7a28-3924-810f-c04153c831b5
 2012-08-28 12:06:45 +00:00
ajohnsen@google.com 8f50fb32fd Reapply 'Add reduce to Collection.' 
Implemented JS array's reduce and fix a template error that made snapshotting crash.

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//10832060


Review URL: https://chromiumcodereview.appspot.com//10827293

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@10557 260f80e4-7a28-3924-810f-c04153c831b5
 2012-08-13 09:19:53 +00:00
ajohnsen@google.com db92954d53 Revert "Add reduce to Collection." 
This reverts commit 9921e32dd33d6d6482d5fed9e85d68c180f670dd.

BUG=

Review URL: https://chromiumcodereview.appspot.com//10826264

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@10551 260f80e4-7a28-3924-810f-c04153c831b5
 2012-08-13 06:47:27 +00:00
ajohnsen@google.com ff34c5464e Add reduce to Collection. 
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//10832060

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@10548 260f80e4-7a28-3924-810f-c04153c831b5
 2012-08-13 05:57:55 +00:00
ajohnsen@google.com 96b8387429 Always set inserted range in List.insertRange. 
This fixes a bug where myList.insertRange(x, y, null) would fail to set
the new range to null.

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//10808099

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9855 260f80e4-7a28-3924-810f-c04153c831b5
 2012-07-24 17:01:17 +00:00
cshapiro@google.com 9c0c15ea7c Improve the error messages for IndexOutOfRangeException. 
Review URL: https://chromiumcodereview.appspot.com//10786045

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9729 260f80e4-7a28-3924-810f-c04153c831b5
 2012-07-18 00:33:23 +00:00
cshapiro@google.com 00b6963338 Fix some warnings in the core library identified by the static analyzer. 
This foray uncovered a latent bug in the byte array view constructor and
its use of default arguments.  That bug has been corrected and new tests
have been added to the test suite.

BUG=2136

Review URL: https://chromiumcodereview.appspot.com//10653002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9013 260f80e4-7a28-3924-810f-c04153c831b5
 2012-06-22 04:27:57 +00:00
asiva@google.com 861297e2a8 Fix build break. 
Review URL: https://chromiumcodereview.appspot.com//9999009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@6345 260f80e4-7a28-3924-810f-c04153c831b5
 2012-04-09 23:17:28 +00:00
asiva@google.com 8f208ad7ca Wire GrowableArray to use the internal VM object. 
This also fixes issue (5526318 : Make access to GrowableArray objects through the dart api more efficient)
Review URL: https://chromiumcodereview.appspot.com//10012042

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@6341 260f80e4-7a28-3924-810f-c04153c831b5
 2012-04-09 21:50:53 +00:00
srdjan@google.com ab73a42f2d List.add is void (returns null). Fix issue 1213. 
Review URL: https://chromiumcodereview.appspot.com//9431024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4475 260f80e4-7a28-3924-810f-c04153c831b5
 2012-02-22 17:46:38 +00:00
jjb@google.com a2f2769ec3 Wrote functions to convert collections and maps to strings and invoked 
these functions from the toString methods of all built-in Collection
and Map implementations. Wrote smoke tests and basher tests.
Review URL: https://chromiumcodereview.appspot.com//9431015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4421 260f80e4-7a28-3924-810f-c04153c831b5
 2012-02-22 02:28:01 +00:00
kasperl@google.com c34ec0121c Revert "Wrote functions to convert collections and maps to strings and invoked" 
This reverts r4345.

R=jjb@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9416053

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4347 260f80e4-7a28-3924-810f-c04153c831b5
 2012-02-17 06:36:06 +00:00
jjb@google.com b4db1d6cc0 Wrote functions to convert collections and maps to strings and invoked 
these functions from the toString methods of all built-in Collection
and Map implementations. Wrote smoke tests and basher tests.

BUG=4466785
Review URL: https://chromiumcodereview.appspot.com//9320028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4345 260f80e4-7a28-3924-810f-c04153c831b5
 2012-02-17 01:34:00 +00:00
gbracha@google.com d3bcc88674 Added method map to Collection interface and all its implementations (except classes generated from IDL for the DOM). 
Review URL: http://codereview.chromium.org//9114021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3223 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-12 01:25:01 +00:00
srdjan@google.com c91cb11962 Implement toString for ImmutableArray and GrowableObjectArray (Issue 952) 
Review URL: http://codereview.chromium.org//9027026

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2795 260f80e4-7a28-3924-810f-c04153c831b5
 2011-12-23 00:12:11 +00:00
srdjan@google.com 098d244ae0 Fix issue 920: do not allow length of a list go below 0. 
Review URL: http://codereview.chromium.org//9007015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2648 260f80e4-7a28-3924-810f-c04153c831b5
 2011-12-20 17:45:04 +00:00
regis@google.com 5db4de9756 Implement revised factories in the VM. 
Emit warnings when obsolete syntax is used.
Review URL: http://codereview.chromium.org//8921033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2394 260f80e4-7a28-3924-810f-c04153c831b5
 2011-12-13 19:35:07 +00:00
asiva@google.com 5d0ad4091f Fix type warnings in coreimpl lib. 
Review URL: http://codereview.chromium.org//8664003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1876 260f80e4-7a28-3924-810f-c04153c831b5
 2011-11-28 21:06:25 +00:00
srdjan@google.com 4c267997cd Fix bug 557: Disallow user side allocation of ImmutableArray. Also added "instantiation-checks" for some other VM-internal classes. 
Review URL: http://codereview.chromium.org//8648003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1811 260f80e4-7a28-3924-810f-c04153c831b5
 2011-11-23 19:48:25 +00:00
regis@google.com 9f230a34c6 Implement type checking of list literals (issue 220). 
Remove expose_core_impl flag.
Add tests.
Fix tests.
Cleanup type checking of map literals.
Review URL: http://codereview.chromium.org//8676001

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1809 260f80e4-7a28-3924-810f-c04153c831b5
 2011-11-23 19:34:23 +00:00
regis@google.com a5dc8b60d1 Fix code generation issue with new factory syntax. 
Convert VM core library to new factory syntax.
Review URL: http://codereview.chromium.org//8602004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1662 260f80e4-7a28-3924-810f-c04153c831b5
 2011-11-18 17:47:12 +00:00
srdjan@google.com 6d8d978d5a FIx issue 261: throw exception if index if idnexed oeprators if lists Array and GrowableArray is not int. 
Review URL: http://codereview.chromium.org//8387035

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@962 260f80e4-7a28-3924-810f-c04153c831b5
 2011-10-31 18:40:32 +00:00
ngeoffray@google.com 5496005d1d Add optional arguments to our indexOf/lastIndexOf methods. 
Review URL: http://codereview.chromium.org//8424012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@947 260f80e4-7a28-3924-810f-c04153c831b5
 2011-10-31 13:21:30 +00:00
ngeoffray@google.com 210fd33d0a Remove List.fromList constructor, and List.copyFrom. They are duplicates of the new range methods. 
Review URL: http://codereview.chromium.org//8422005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@941 260f80e4-7a28-3924-810f-c04153c831b5
 2011-10-31 09:49:15 +00:00
iposva@google.com 4906ccd1db - Remove the remaining Array interface. 
Review URL: http://codereview.chromium.org//8348025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@556 260f80e4-7a28-3924-810f-c04153c831b5
 2011-10-19 15:44:55 +00:00
ngeoffray@google.com ac91a5a8da Fix build failures due to forgotten change in the Array -> List transition. 
Review URL: http://codereview.chromium.org//8333017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@508 260f80e4-7a28-3924-810f-c04153c831b5
 2011-10-18 10:54:45 +00:00
ngeoffray@google.com 70c01beb9b Clean up (most) uses of Array. Still more to come in the VM corelib code base. 
Review URL: http://codereview.chromium.org//8321024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@507 260f80e4-7a28-3924-810f-c04153c831b5
 2011-10-18 10:02:59 +00:00
vsm@google.com cc71ad71ed Test fix: remove extraneous print 
TEST=corelib/ListInsertRangeTest

Review URL: http://codereview.chromium.org//8294020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@483 260f80e4-7a28-3924-810f-c04153c831b5
 2011-10-17 20:18:45 +00:00
ngeoffray@google.com 52aa068f73 Implement List.insertRange. 
Review URL: http://codereview.chromium.org//8271029

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@439 260f80e4-7a28-3924-810f-c04153c831b5
 2011-10-14 13:44:18 +00:00