dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
46,692 Commits 2 Branches 0 Tags
4eee6cb5ea554fe659de79a7883f103e781f2fb2
Commit Graph

1433 Commits

Author SHA1 Message Date
Bob Nystrom 4145a49503 Move Dart versions of math.min() and math.max() into VM patch file. 
For DDC and dart2js, we call the corresponding JS function. This is
shorter and avoids a strong mode type error in the Dart implementation.

R=jmesserly@google.com, lrn@google.com

Review-Url: https://codereview.chromium.org/2858353003 .
 2017-05-05 15:15:21 -07:00
Jacob MacDonald fc0c45c790 update dependencies to use url style paths 
BUG=
R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2860943003 .
 2017-05-04 12:44:56 -07:00
Jennifer Messerly 171f7ba592 fix #29544, mixins to a class with named constructors 
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2859703003 .
 2017-05-04 12:33:45 -07:00
Jennifer Messerly 6ab17db3da fix more mixin tests to work in strong mode 
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2861783002 .
 2017-05-04 11:30:14 -07:00
Vijay Menon d5ecaf1088 Loosen type check on runZoned errorHandler 
R=floitsch@google.com, lrn@google.com

Review-Url: https://codereview.chromium.org/2858843002 .
 2017-05-03 05:30:06 -07:00
Lasse R.H. Nielsen 7998f590b1 Update documentation on trignometric functions. 
Fixes #17515
BUG= http://dartbug.com/17515
R=floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/40220ec0766bb2b179d3623d3f298223df842279
Review-Url: https://codereview.chromium.org/2852053002 .
 2017-05-03 09:49:14 +02:00
Jennifer Messerly 5e82b8c2e9 fix #29530, field metadata generation 
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2861503002 .
 2017-05-02 14:45:34 -07:00
Jennifer Messerly eeb0e1d2ae fix #27258, don't allow dynamic set of a final field 
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2847893002 .
 2017-05-01 15:36:32 -07:00
Jennifer Messerly c305d183c3 fix #29504, dcall on object member when a temporary was involved. 
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2848153002 .
 2017-05-01 10:57:49 -07:00
Florian Loitsch 05e0e1ea40 Revert trigonometric function updates. 
The VM has a fingerprint on the function and failed during compilation.

Revert "Fix patch errors."

This reverts commit ff1d7488d9.

Revert "Update documentation on trignometric functions."

This reverts commit 40220ec076.

BUG=

Review-Url: https://codereview.chromium.org/2851163003 .
 2017-05-01 16:06:56 +02:00
Florian Loitsch ff1d7488d9 Fix patch errors. 
Review-Url: https://codereview.chromium.org/2853813002 .
 2017-05-01 15:57:40 +02:00
Erik Corry aa6353b6da Dart SDK Spelling b, c, and d. 
R=kmillikin@google.com
BUG=

Review-Url: https://codereview.chromium.org/2850783002 .
 2017-05-01 08:28:10 +02:00
danrubel c8784af933 rename .analysis_options --> analysis_options.yaml 
See https://github.com/dart-lang/sdk/issues/28385

R=brianwilkerson@google.com, vsm@google.com

Review-Url: https://codereview.chromium.org/2839383003 .
 2017-04-30 18:33:10 -04:00
Vijay Menon 7bedf63e1e dart:mirrors workaround for generic methods 
Fixes #29509

R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2852723002 .
 2017-04-28 20:02:13 -07:00
Vijay Menon 334373b1dc Temporarily disable overlapping summary check 
Turning this off to unblock the current roll.  We'll try flipping the
flag internally and shaking out the last violators.

R=keertip@google.com

Review-Url: https://codereview.chromium.org/2853543002 .
 2017-04-28 11:08:05 -07:00
Bob Nystrom 7f7c681893 Fix a batch of DDC SDK compile errors. 
R=floitsch@google.com, vsm@google.com

Review-Url: https://codereview.chromium.org/2848703003 .
 2017-04-27 17:27:02 -07:00
Vijay Menon aa3966dc84 Fix hot dynamic check in WhereIterator 
R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2843423002 .
 2017-04-27 06:35:37 -07:00
Konstantin Shcheglov 8e76c78cce Cache path -> URI mapping in SourceMapPrintingContext. 
This improves DDC compiling DDC from 30 to 25 seconds.

R=jmesserly@google.com, vsm@google.com
BUG=

Review-Url: https://codereview.chromium.org/2839733003 .
 2017-04-24 19:32:10 -07:00
Erik Corry 2fb5d08102 Spelling a 
R=ahe@google.com
BUG=

Review-Url: https://codereview.chromium.org/2841543002 .
 2017-04-24 14:53:51 +02:00
Erik Corry 6617737ff5 Replace 'the the' with 'the' 
R=kmillikin@google.com
BUG=

Review-Url: https://codereview.chromium.org/2830353002 .
 2017-04-24 08:50:37 +02:00
Vijay Menon 75b7bea014 Snapshot DDC trained on itself 
Note: path.canonicalize appears to normalize windows paths (c:/ vs c:\).

Fixes #29119

R=jmesserly@google.com, rnystrom@google.com

Review-Url: https://codereview.chromium.org/2836483002 .
 2017-04-21 16:19:57 -07:00
Jennifer Messerly d26bb56575 fix #27971, implement generic function RTTI 
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2832913003 .
 2017-04-21 15:40:44 -07:00
Jennifer Messerly bed6f8242a add an option to turn off errors from strong mode is-checks 
This adds an option and also has our tests run with it turned off.

R=vsm@google.com

Review-Url: https://codereview.chromium.org/2835743002 .
 2017-04-21 15:24:32 -07:00
Erik Corry 4b9bba55b4 Stoppp using trippple consonants 
R=ahe@google.com
BUG=

Review-Url: https://codereview.chromium.org/2833073002 .
 2017-04-21 17:50:13 +02:00
Jacob Richman 7149b90c7c Tighten up handling of JS types and add test. 
Side effect of this:
Fix bug where helpers in js_mirrors were specifying that name had to have type String when it could really also be a JS Symbol as well.
Fix bug where top level JS interop members using the external keyword but no @JS keyword were not implemented.
Update js_typed_interop_test.dart so it can work in DDC.
Add regression test for jsify call with native function type arguments.

BUG=
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2827333003 .
 2017-04-21 08:44:00 -07:00
Vijay Menon 21c38e6c8c Various DDC fixes for windows 
This gets most tests compiling and running on Windows.

Fixes #27450
Fixes #27797
Fixes #28752

R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2833633002 .
 2017-04-20 11:30:57 -07:00
Vijay Menon b98729503c Fix ddc perf issue 
This brings compilation time on large_class_declaration_test down from 30s to 4s.  Just analysis is about 3.2s.  (All #s without snapshotted tools.)

Fixes #29234

R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2834663002 .
 2017-04-20 11:24:35 -07:00
Vijay Menon 1112ad24cc Make conflicting summary check configurable 
Not sure this is a great idea.  DDC will go awry if multiple copies of
the same type exist.  Can analysis or any other analyzer-based tool?

R=brianwilkerson@google.com, paulberry@google.com

Review-Url: https://codereview.chromium.org/2829493002 .
 2017-04-20 09:20:08 -07:00
Vijay Menon 8a64625d81 Regenerate DDC artifacts 
TBR=jacobr@google.com

Review-Url: https://codereview.chromium.org/2830983002 .
 2017-04-19 16:26:22 -07:00
Jacob Richman 0dbb32f406 Run formatter on dev_compiler. 
BUG=
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2830503002 .
 2017-04-18 16:16:14 -07:00
Jacob Richman b280a7803d Dev compiler debugger related tweaks. 
Optimize dynamic call tracking using random sampling.
Apply source maps to improve dynamic call tracking accuracy.
Dynamic calls within the sdk are now attributed correctly.

Fix bug formatting modules where we were incorrectly flagging them as JS.

BUG=
R=jmesserly@google.com, vsm@google.com

Review-Url: https://codereview.chromium.org/2811343002 .
 2017-04-17 14:57:31 -07:00
Zachary Anderson 9ce608e89d [dart:io] Adds ProcessInfo.{max,current}Rss. Adds OS::MaxRSS on Fuchsia. 
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2822943002 .
 2017-04-17 14:41:40 -07:00
Vijay Menon a3d2e49198 Revert "Revert "Report error if the same uri appears in multiple summaries."" 
Relanding after fixing package_bundle_reader_test.dart.

Note, original CL (already reviewed here: https://codereview.chromium.org/2781483007/) is patch set 1.

Test fix is patch set #2.

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2825503002 .
 2017-04-17 10:11:21 -07:00
Vijay Menon dcdccf4750 Revert "Report error if the same uri appears in multiple summaries." 
This reverts commit 2afa21bb2c.

Breaking the bots.

TBR=jmesserly@google.com
BUG=

Review-Url: https://codereview.chromium.org/2821933002 .
 2017-04-17 08:07:36 -07:00
Vijay Menon 2afa21bb2c Report error if the same uri appears in multiple summaries. 
Fixes #27025

R=brianwilkerson@google.com, jmesserly@google.com

Review-Url: https://codereview.chromium.org/2781483007 .
 2017-04-17 07:32:59 -07:00
Jennifer Messerly b76e2d67cf fix #29346, ensure all nodes are implemented by DDC's code generator 
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2822633003 .
 2017-04-14 10:10:50 -07:00
Ben Konyi 6fbdd19ddb Various fixes for sync socket implementation. 
Revert "Revert "Added sync_socket.h include in sync_socket_win.cc""

This reverts commit 2bd6168e1ebf35f6dbd9b2724339362c493377fc.

Revert "Revert "Added synchronous socket implementation to dart:io.""

This reverts commit a47bce03f5502dac7fb12e777e87b5aa1cfc830b.

BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2814773004 .
 2017-04-12 14:20:48 -07:00
Jennifer Messerly 9bdc5bb751 add scripts to run/debug DDC output on simple test cases 
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2815913002 .
 2017-04-12 11:36:23 -07:00
Alan Knight 04bb68bb09 Better DDC sourcemap generation for lambdas 
This doesn't fix the entire problem, there's still a Chrome issue that it's not clear we can work around, but it helps some. https://bugs.chromium.org/p/chromium/issues/detail?id=676388

There are three distinct issues here affecting Chrome sourcemap usage for DDC programs with single-line lambdas.

1 - We may introduce a synthetic "as SomeType" in a parameter. The synthetic token ends up with a large negative length, from its offset to the beginning of the file, which can confuse sourcemaps.

2 - We have no entry for the blank line following the lambda. The devtools asks for the mapping from (selectedLine, 0) to (selectedLine +1, 0) and if there's no mapping for either it refuses to set the breakpoint. So this artificially forces the mapping from the last character on the line to be to the beginning of the next line instead.

3 - With a lambda we introduce a constructed Return JS node and make a block. Those nodes weren't getting annotated, so they had no source information.

BUG=
R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2815443003 .
 2017-04-12 11:31:16 -07:00
Ben Konyi b439bd9a54 Revert "Added synchronous socket implementation to dart:io." 
This reverts commit a1f87ebdb8.

Revert "Added sync_socket.h include in sync_socket_win.cc"

This reverts commit bdec13e865.

BUG=

Review-Url: https://codereview.chromium.org/2812153002 .
 2017-04-11 15:18:46 -07:00
Ben Konyi a1f87ebdb8 Added synchronous socket implementation to dart:io. 
BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2803543006 .
 2017-04-11 14:41:09 -07:00
Vijay Menon bc3089838c Reify implicit casts for FutureOr 
Before landing, two issues to resolve:
(1) We appear to allow sideways casts now without static error - e.g.,

List<Object> -> FutureOr<List<String>>

Is that intended?  If so, it breaks an assumption that implicit casts
are from supertype to subtype.

(2) LUB and FutureOr

It appears that the LUB of, e.g., String and Future<String> is Object.
See fixes in tests to record casts back to FutureOr.

Fixes #29251

R=leafp@google.com

Review-Url: https://codereview.chromium.org/2801683004 .
 2017-04-07 17:33:34 -07:00
Vijay Menon 10c5de82c8 Invoke debugger on nsm 
Missed this one when I added debugger statements earlier

R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2565183004 .
 2017-04-07 14:45:09 -07:00
Jennifer Messerly 8ada796a86 fix #29233, final fields can be settable in a mock 
also fix #29273, user mixins can override native methods

R=vsm@google.com

Review-Url: https://codereview.chromium.org/2803673007 .
 2017-04-07 14:12:49 -07:00
Vijay Menon 1975c8431a Migrate async tests to strong 
No modifications to the actual tests

R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2802973005 .
 2017-04-07 12:46:12 -07:00
Vijay Menon 5c3bcff375 DDC fix for foreign futures 
Fixes #29287

R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2804113002 .
 2017-04-06 14:52:59 -07:00
Jennifer Messerly 247fc68d21 fix #29228, let* precedence should match generated expression 
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2804833002 .
 2017-04-05 12:40:42 -07:00
Vijay Menon aa3fba7d8d Preserve async markers when parsing js_ast 
Fixes #29252

R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2797873002 .
 2017-04-05 12:13:22 -07:00
Jennifer Messerly e4e7dffadb fix #29182, generate top level const fields lazily 
This fixes an ordering issue, but also may help load time.

R=vsm@google.com

Review-Url: https://codereview.chromium.org/2797443007 .
 2017-04-04 16:18:46 -07:00
Konstantin Shcheglov 565408593b Remove _StdSink._isTranslatable field. 
The field is not used since https://github.com/dart-lang/sdk/commit/141b6351baacaedf23e740b5b7354970f2ac0979,
but it is final and not initialized, so this causes an error during
analyzer tests.

R=paulberry@google.com, zra@google.com
BUG=

Review-Url: https://codereview.chromium.org/2800453002 .
 2017-04-04 12:56:44 -07:00