685e4ff9e1
Revert "Remove unused option in server API"
...
Review URL: https://codereview.chromium.org/2382033003 .
2016-09-30 10:14:12 -07:00
2972bd0d6b
Remove unused option in server API
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/2382053002 .
2016-09-30 09:04:38 -07:00
74686371b3
Add support for getting the sessionId from instrumentation and sending it to the client
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/2359233002 .
2016-09-22 10:26:13 -07:00
ecc84b26a4
Break up another large file
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/2342733002 .
2016-09-15 07:49:27 -07:00
7343da76ba
Issue 27078. Describe RefactoringProblemSeverity values.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/27078
Review URL: https://codereview.chromium.org/2312073003 .
2016-09-06 17:46:24 -07:00
f4186fb463
Issue 27244. Add 'isDeprecated' to HoverInformation.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/27244
Review URL: https://codereview.chromium.org/2310153002 .
2016-09-06 11:31:11 -07:00
270695fc31
Adds PID to server.connected notification ( #26744 ).
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/2088663004 .
Fixes: https://github.com/dart-lang/sdk/issues/26744 .
2016-06-21 16:00:27 -07:00
7a9b2a3133
Use null aware operators to clean up code
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1941793002 .
2016-05-02 08:38:46 -07:00
21a1b757c1
Clean up hints after a new hint was introduced
...
R=jwren@google.com
Review URL: https://codereview.chromium.org/1890973002 .
2016-04-14 13:15:34 -07:00
f9b575e5b3
More strong mode changes to analysis_server
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1855643002 .
2016-04-01 18:00:04 -07:00
cbcb689184
Fix the way generated code is made strong mode clean
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org/1849973002 .
2016-03-31 13:43:07 -07:00
301a6a4725
Fix generated server code to be strong mode compliant
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1852473002 .
2016-03-31 10:44:42 -07:00
8c22a5f807
Format code in analysis_server
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1838933003 .
2016-03-29 08:27:14 -07:00
7d72c6e1f5
Deprecate the generated AST library and clean up imports
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1788223002 .
2016-03-12 08:50:48 -08:00
e7e205f00b
Add error codes to server protocol ( #25958 ).
...
See: https://github.com/dart-lang/sdk/issues/25958
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1774913006 .
2016-03-09 10:44:03 -08:00
3af20476d1
Add AnalysisContext.onResultInvalidated(descriptor).
...
This method will be used to remove index entries corresponding to
invalidated resolved units.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1776023002 .
2016-03-08 12:55:06 -08:00
9fe92127e5
update setAnalysisRoots to accept package spec file
...
As part of addressing https://github.com/dartino/atom-dartino/issues/13 ,
this CL updates the setAnalysisRoots API to allow package spec files
in the packageRoots map.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1711353003 .
2016-02-19 10:57:16 -05:00
5b95009a6b
Move ResolverProvider to analyzer so that it can be shared
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1658663002 .
2016-02-01 08:12:29 -08:00
1c5e2fd0fb
Use getResolvedCompilationUnit2() instead of resolveCompilationUnit2() in QuickAssist and QuickFix contributors.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1582613010 .
2016-01-15 12:15:45 -08:00
7c5e03435b
Deprecate UNIT_TEST_GROUP and UNIT_TEST_TEST.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1570003002 .
2016-01-07 20:03:39 -08:00
56fe38f0ab
Clean up imports in analysis_server and analyzer_cli (and one missed in analyzer)
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1527793003 .
2015-12-14 19:31:46 -08:00
e48f962af1
Validate that root paths are absolute and normalized.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25203
Review URL: https://codereview.chromium.org/1511833004 .
2015-12-09 15:05:22 -08:00
1f5973e24e
Explicitly specify that FilePath is not just absolute, but also a normalized path.
...
It was implied, and every client I know of uses absolute and normalized paths.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1506323002 .
2015-12-09 11:30:54 -08:00
2fdcb1bd74
Promote diagnostic.getDiagnostics() ( #25061 ).
...
* removes rolling average support
* removes "experimental" tag
* bumps API version
Fixes #25061 .
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1509033003 .
2015-12-09 09:29:26 -08:00
43f027fc05
Analysis request getReachableSources ( #24893 ).
...
Implements a new request to get reachable sources.
This solves a specific issue for flutter (e.g., inferring execution type by checking the transitive closure of reachabe sources for `dart:flutter`) but can be more generallly useful for other client-side smarts (e.g., "is this a web entry point?" or "is this a test?").
More context here: https://github.com/dart-lang/sdk/issues/24893
R=brianwilkerson@google.com , devoncarew@google.com
Review URL: https://codereview.chromium.org/1491013002 .
2015-12-02 13:26:35 -08:00
86216e5154
Consistently use implements when one interface inherits from another interface
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1481273002 .
2015-11-30 07:58:10 -08:00
0ae251793f
Make index provisional API.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1471073002 .
2015-11-23 12:54:55 -08:00
0a64b0694c
Make change builder provisional API
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1468133002 .
2015-11-23 10:18:58 -08:00
bb1914e175
Make FixContributor asynchronous.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1461313004 .
2015-11-20 14:57:00 -08:00
c0466f28f5
Rolling average work queue diagnostic ( #24933 ).
...
Background: https://github.com/dart-lang/sdk/issues/24933
Salient bits:
* sampling will only start if a client registers interest in diagnostics.
* sampling will stop if clients stop requesting diagnostics.
* sample results are coming back as a string (but a double would be better).
* the mapping of context folders to averages in not garbage collected; since it's only potentially leaking `_Average` objects (and not contexts) when folders are deleted, I think that's fairly benign.
BUG=24933
R=brianwilkerson@google.com , devoncarew@google.com
Review URL: https://codereview.chromium.org/1463923003 .
2015-11-20 14:24:47 -08:00
ae1bee3859
Make AssistContributor asynchronous.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1461343002 .
2015-11-20 12:18:26 -08:00
6d9cb5e48a
Move diagnostics to diagnostics domain ( #24931 ).
...
Still flagged `experimental` so no docs created.
See: https://github.com/dart-lang/sdk/issues/24931
BUG=24931
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1453433002 .
2015-11-16 14:10:10 -08:00
82e83bb34d
Experimental getDiagnostics request ( #24480 ).
...
* Adds `getDiagnostics` request with *very* provisional diagnostics payload (primary goal here is to plumb this fully through and iterate).
* Updates codegenerator to skip doc generation for experimental APIs.
Additional context here: https://github.com/dart-lang/sdk/issues/24480 .
BUG=24480
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1416093007 .
2015-11-05 15:05:21 -08:00
069ba985de
Fix protocol for EXTRACT_LOCAL_VARIABLE and coveringExpressionOffsets/lengths.
...
Unfortunately we have to make coveringExpressionOffsets and coveringExpressionLengths optional.
Otherwise new clients cannot correctly parse responses from old servers.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org/1407333006 .
2015-11-03 10:19:41 -08:00
879cf82b6b
Rework analyzed files support to use globs
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1413643006 .
2015-11-03 07:11:29 -08:00
e0636b183c
Make IndexableObjectKind parameterized.
...
LMK if this is a bad change.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1413563004 .
2015-10-19 10:13:43 -07:00
27eb09033f
Clean up wording of client usage expectations
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org/1409353002 .
2015-10-19 07:46:49 -07:00
c0d68a5437
DAS specification changes - spelling and ElementKind.FILE addition.
...
ElementKind.FILE will be used in search.findElementReferences
1. In the 'element' field of responce when a URI is at the given offset.
2. In the only element of the 'path' field of SearchResult(s) for URI references to a URI or a library identifier.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1409333002 .
2015-10-17 10:03:03 -07:00
67576340b0
Declare IndexableObject.file instead of Source.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1409203002 .
2015-10-16 14:43:49 -07:00
78da03cd97
Extract protocol_dart.dart APIs.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1398333002 .
2015-10-12 06:58:34 -07:00
9ad256cf18
Move the wire protocol support into the public API
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1398293002 .
2015-10-11 07:34:28 -07:00
8f4c63c92b
Restructure the public API for server
...
R=danrubel@google.com , paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1392253002 .
2015-10-09 07:57:00 -07:00
7bbd8c66a5
Move completion APIs to private location
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1383313002 .
2015-10-05 11:57:35 -07:00
ba318117d8
More documentation clean-up for server APIs
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1389713002 .
2015-10-05 11:04:09 -07:00
4aa6466ccb
Use IndexContributor(s) in LocalIndex.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1359113002 .
2015-09-23 08:17:33 -07:00
6be842b53b
Improve the documentation of extension points
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1335113004 .
2015-09-14 14:11:52 -07:00
ef2fc0d778
Add OCCURRENCES_CONTRIBUTOR_EXTENSION_POINT_ID.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1337143002 .
2015-09-11 13:59:28 -07:00
b15a031276
Navigation extension point.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1303033010 .
2015-09-01 13:06:25 -07:00
45862f401e
Send 'execution.launchData' only after full resolution.
...
We don't need to send them after each and every notice.
This information becomes ready somewhere in between parsing and full resolution.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1157823002
2015-05-24 10:39:21 -07:00
ad52c9eab9
Add support for specifying files needing analysis
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1152013002
2015-05-21 14:34:04 -07:00
Brian Wilkerson