Konstantin Shcheglov
3945c9aa71
Use builders in AstBuilder to build ClassDeclarationImpl, etc.
...
Relatved to https://dart-review.googlesource.com/c/sdk/+/259020
The goal is to avoid the need to update NodeListImpl.
I'm not 100% sure that we can fully achieve this, there is at least
one more place with switch / case.
Change-Id: Ic7468a7b9ded817b3315902cefdeaa7428ec6857
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259100
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-09-13 18:30:27 +00:00
Konstantin Shcheglov
7bfc648617
Use named parameters for more AST implementations.
...
Change-Id: I0b47f6b9e87fa773ca08ad1ec8e7afcca69a0527
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253521
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-08-02 20:03:14 +00:00
Jens Johansen
7a0b8f850b
[parser] Rename Token impl classes to avoid name conflicts
...
Change-Id: I72cefa071429b048facc16e2be0942077010072c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/238084
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2022-04-19 08:27:37 +00:00
Sam Rawlins
843a31fe45
Prefer string interpolations; other small fixes for lints 2.0.0
...
Change-Id: Ie66c42ac738adbcf07d0b7c5ccc77e34975008c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237801
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2022-03-18 22:13:21 +00:00
Danny Tuppeny
1e9fb81697
[analysis_server] Make CompilationUnit.lineInfo non-nullable
...
Change-Id: Ib628751a14dc3257cf7325432ab20f2bdb9d6f3b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234290
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-03-03 06:59:00 +00:00
Konstantin Shcheglov
ac9de46499
Share FeatureSets for analyzer tests.
...
Change-Id: Ibe2655ed43af3cab632d6e4506f2366c1bfbbc27
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234803
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-03-01 21:13:38 +00:00
Johnni Winther
2435848b13
[parser] Support 'augment' modifier on class declarations
...
This adds support for the 'augment' modifier on class declarations
needed for the static meta-programming prototype.
Change-Id: Iadd11f766a195076405f2803b2092199caf1ea8c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233180
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2022-02-18 09:39:23 +00:00
Konstantin Shcheglov
4e2dc38e0e
Report CONST_WITH_NON_CONSTANT_ARGUMENT for enums.
...
Bug: https://github.com/dart-lang/sdk/issues/48237
Change-Id: Iffde67714dcea7b022b22a149b573dd3e26668b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232132
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-02-09 15:53:27 +00:00
Johnni Winther
8cdc0e6474
[analyzer,cfe] Add support for macro class
...
This CL add the 'macros' experiment and adds support for the `macro`
modifier on class declarations. This is part of the prototyping of
the static meta-programming feature.
Change-Id: Ie4b8c5443fda3813307ea076c315baad6a90c3e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/224205
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2021-12-21 10:45:59 +00:00
Konstantin Shcheglov
b553298024
Deprecated TypeName, use NamedType instead.
...
Change-Id: Ic7c2bef44277db3d4b3de495fbf9fbadf15f3db8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/214223
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-09-23 06:08:34 +00:00
Konstantin Shcheglov
dea3861e5f
Stop using FeatureSet.forTesting() in analyzer/.
...
Change-Id: Ic4de7d6bcb3397aaa86ff6d82cce1531afbffa50
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213118
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-09-11 18:46:27 +00:00
Konstantin Shcheglov
0d579ac784
Resynthesize new Token instances, not shared static.
...
We will need separate instances to set offsets to them, when resynthesize
constant initializers and annotations.
See also https://buganizer.corp.google.com/issues/180549869
Change-Id: I04a7e8ff05c013aea7952b373a260b76f728a7e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/202420
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-06-04 01:56:06 +00:00
Paul Berry
126c5fa680
Initial parser support for constructor tear-offs.
...
This CL adds parser support for use of `<typeArguments>` as a
selector. This allows expressions like `List<int>` (type literal with
type arguments), `f<int>` (function tear-off with type arguments),
`C.m<int>` (static method tear-off with type arguments), `EXPR.m<int>`
(instance method tear-off with type arguments), and `EXPR<int>`
(tear-off of `.call` method with type arguments).
I will add parser support for `.new` as a constructor name in a
follow-up CL.
Change-Id: I157e732276421e8c3fd20c38c67ae9643993bd85
Bug: https://github.com/dart-lang/sdk/issues/46020 , https://github.com/dart-lang/sdk/issues/46044 .
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/197102
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
2021-05-25 13:58:10 +00:00
Konstantin Shcheglov
75308fc26b
Return Impl nodes from AstFactoryImpl and AstTestFactory.
...
Change-Id: I5d3f6eb8d07145079560c6f8820aa15e2f8183a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189580
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-03-07 23:24:10 +00:00
Konstantin Shcheglov
0506b1b2d3
Deprecate setters in API of AST.
...
Change-Id: Ib2ec164ef87b3a5a4bf028d592552e37451abd35
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189520
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-03-07 21:48:50 +00:00
Sam Rawlins
237c84249b
Remove unnecessary imports in analyzer
...
Change-Id: Ifb9a5c0a31cf3669febf2981b1d26b84f5b9d237
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180781
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2021-02-02 14:40:24 +00:00
Konstantin Shcheglov
9f986d2501
Migrate package:analyzer to null safety.
...
Change-Id: Iffe4370431587e46a141ddc72a86ceec29c163b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176486
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2021-02-01 18:56:04 +00:00
Sam Rawlins
13f9993511
Analyzer: Extract parser test base classes, helpers
...
Each of the *_Fasta test cases has a lot of test cases from the
corresponding *Mixin mixin. I started to combine _all_ of these
in parser_test.dart, but the file became too long; the formatter
was freezing IntelliJ.
So I've extracted out the non-test classes into parser_test_base.dart.
I'd like to extract each test class into its own file. For now, I
reduce half a dozen *_Fasta/*Mixin pairs into individual test classes.
Change-Id: I8dd7f28a6fe23e31f956cdb2f1d221669db376dc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176064
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-12-15 03:57:59 +00:00