Commit Graph

928 Commits

Author SHA1 Message Date
jmesserly@google.com d6b9207588 Reorganize mdv and observe functionality
* keep correct dart:html APIs
* move implementation into package:mdv and package:observe
* remove dart:mdv_observe_impl
* remove getValueWorkaround/setValueWorkaround from package:observe

R=blois@google.com, floitsch@google.com, justinfagnani@google.com

Review URL: https://codereview.chromium.org//17552019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24498 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-26 23:25:47 +00:00
blois@google.com edf30f6b20 Exposing Node.firstChild and Node.lastChild.
These are the most efficient way access children and are very commonly used.

BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//17909002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24476 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-26 16:53:50 +00:00
jmesserly@google.com 7fd6e0a3dc Restore adoptNode and importNode to dart:html
http://dom.spec.whatwg.org/#dom-document-importnode
These seem more relevant in a <template>/ShadowRoot world. In particular I wanted to port an MDV test that uses adoptNode.

R=blois@google.com

Review URL: https://codereview.chromium.org//17681003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24423 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-25 18:02:26 +00:00
kasperl@google.com a944ac501c Update status files after inlining change.
R=ngeoffray@google.com
BUG=

Review URL: https://codereview.chromium.org//17619002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24356 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 18:23:01 +00:00
kustermann@google.com 8356c667db Added async_helper and fixed broken asynchronous test.
R=ahe@google.com, efortuna@google.com, floitsch@google.com

Review URL: https://codereview.chromium.org//16958006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24339 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 15:47:00 +00:00
floitsch@google.com 48b1656690 Allow Object when doing lookups.
According to our typing rules a Set<Apple> is a Set<Fruit>. However, before this change, we couldn't use it as a Set<Fruit>:

===
bool foo(Set<Fruit> fruits) {
  // Would yield a type-error since we actually got a Set<Apple>.
  return fruits.contains(new Banana());
}

foo(new Set<Apple>());
===

R=ajohnsen@google.com, blois@google.com, lrn@google.com

Review URL: https://codereview.chromium.org//14246008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24326 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 12:45:10 +00:00
johnniwinther@google.com 2432ac4647 Support runtime check of function types.
New scheme for checking function subtyping:

1) Generate an $isX predicate on objects that are statically known subtypes of a given function type
2) Generate a signature encoding the whole function type on objects when a runtime check is needed.

A check succeeds if either 1) or 2) is true.

If too many predicates are needed a signature is generated instead, and if a signature is needed, no predicates are generated. Maximum number of predicates is currently determined by the magic constant MAX_FUNCTION_TYPE_PREDICATES in emitter.dart.

R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24286

Review URL: https://codereview.chromium.org//12334070

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24309 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 06:58:55 +00:00
johnniwinther@google.com 90bf6203ee Revert "Support runtime check of function types."
This reverts commit r24286.

BUG=

Review URL: https://codereview.chromium.org//17413013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24288 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-21 14:02:47 +00:00
johnniwinther@google.com 2ce76ed94a Support runtime check of function types.
New scheme for checking function subtyping:

1) Generate an $isX predicate on objects that are statically known subtypes of a given function type
2) Generate a signature encoding the whole function type on objects when a runtime check is needed.

A check succeeds if either 1) or 2) is true.

If too many predicates are needed a signature is generated instead, and if a signature is needed, no predicates are generated. Maximum number of predicates is currently determined by the magic constant MAX_FUNCTION_TYPE_PREDICATES in emitter.dart.

R=karlklose@google.com

Review URL: https://codereview.chromium.org//12334070

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24286 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-21 13:35:56 +00:00
kustermann@google.com 9aa27e6034 Mark canvasrenderingcontext2d_test/drawImage_image_element as flaky
R=ricow@google.com

Review URL: https://codereview.chromium.org//17520006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24277 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-21 09:48:12 +00:00
jmesserly@google.com 55ce585b19 fix analyzer error in path observer test
TBR=justinfagnani
(fixing bots)

Review URL: https://codereview.chromium.org//17151018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24167 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-19 02:37:56 +00:00
jmesserly@google.com 66398e12b5 Move PathObserver to mdv_observe package
(Since it doesn't actually depend on dart:html, didn't seem the right place for it)

R=blois@google.com

Review URL: https://codereview.chromium.org//17434008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24166 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-19 02:21:54 +00:00
blois@google.com b5f256b985 Fixing SerializedScriptValue letting Dart list members through to native lists.
BUG=10463
R=sra@google.com

Review URL: https://codereview.chromium.org//16832002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23948 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-13 00:56:32 +00:00
blois@google.com 09dab7ecf3 Fixing up element_types_test to work properly in checked mode, adding a few more element constructors.
Basically the constructors were failing in checked mode when they returned UnknownElement rather than the expected type. I adjusted the tests to account for this.

BUG=10796
R=efortuna@google.com

Review URL: https://codereview.chromium.org//16409016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23885 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-11 22:42:12 +00:00
blois@google.com ab50cfcc68 Adding annotations for native types of type Object or dynamic.
Also added generation warnings to try to detect these.

BUG=10946
R=sra@google.com

Review URL: https://codereview.chromium.org//16638013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23875 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-11 19:46:57 +00:00
blois@google.com 226159fedb Fixing new SVG test on IE.
For some reason IE is giving the bounding rect an extra pixel. Not really critical to the test, so loosening tolerances.
BUG=

Review URL: https://codereview.chromium.org//15897021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23872 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-11 18:52:23 +00:00
blois@google.com 959929af56 Adding tests for SVG's getBoundingClientRect.
BUG=10249
R=efortuna@google.com

Review URL: https://codereview.chromium.org//16336029

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23870 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-11 18:24:48 +00:00
blois@google.com 524a7d7ec7 Updating expectation for speech_recognition_test
Blink bug was fixed.

BUG=11035

Review URL: https://codereview.chromium.org//15947008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23760 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-07 18:49:45 +00:00
scheglov@google.com 80fea8fd8e More fixes for java2dart and status files.
Now DDA passes/fails the same tests as Java version.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//15675016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23705 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-06 18:13:44 +00:00
blois@google.com 8457ffe218 Attempting to fix XHR tests again.
They are still timing out on the test machines, but not locally.

TBR
BUG=

Review URL: https://codereview.chromium.org//16503004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23662 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-05 22:56:57 +00:00
blois@google.com 2b9aaf06bc Fixing xhr_test on FF.
It's currently timing out.

TBR
BUG=

Review URL: https://codereview.chromium.org//16493004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23661 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-05 22:35:18 +00:00
blois@google.com 0956f1c314 Fixing HttpRequest.upload.onProgress.
BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//16376006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23658 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-05 21:09:59 +00:00
blois@google.com 3b030702bc Fixing selectelement_test on IE9
It was failing because of innerHTML parsing semantics from the unittest.

TBR
BUG=

Review URL: https://codereview.chromium.org//15705012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23654 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-05 20:25:03 +00:00
blois@google.com 797769e39f Fixing SelectElement.options, adding support for optgroup.
BUG=8115
R=efortuna@google.com

Review URL: https://codereview.chromium.org//16409002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23652 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-05 19:45:36 +00:00
blois@google.com 63202addc4 Fixing safe_dom_test status
IE9 was broken on this because of the DocumentFragment issue, working now.

TBR
BUG=

Review URL: https://codereview.chromium.org//15896029

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23566 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-03 20:40:18 +00:00
blois@google.com 5bbd582932 Fixing some of the tests disabled from the chrome IDL roll.
Basically some native constructors were added which are not yet cross-platform, so skipping them for now.
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//16335012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23564 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-03 20:10:48 +00:00
vsm@google.com 4c6a598f7a Update test failure to pass
BUG=11032

TBR=antonm

Review URL: https://codereview.chromium.org//16336015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23556 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-03 18:52:02 +00:00
vsm@google.com 7e4902c886 More expectations fixes
Hopefully, this gets everything green.

TBR=blois, antonm

Review URL: https://codereview.chromium.org//15937019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23522 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-03 04:07:19 +00:00
vsm@google.com 7ddbc1942e Fix expectations, take 2
TBR=blois

Review URL: https://codereview.chromium.org//15949011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23521 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-03 01:22:57 +00:00
vsm@google.com b80f1069f1 Fix expectations for other browsers
TBR=blois

Review URL: https://codereview.chromium.org//15949010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23520 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-03 01:16:20 +00:00
vsm@google.com 1735f7a080 IDL roll and expectations fix
To the latest Blink.

TBR=blois

Review URL: https://codereview.chromium.org//16311002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23516 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-02 22:46:00 +00:00
vsm@google.com d5da0f0c0d Adjusted expectations from last Blink roll
TBR=antonm, blois

Review URL: https://codereview.chromium.org//15795004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23513 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-02 20:30:14 +00:00
blois@google.com c7afec7d69 Adding test for removed ShadowDOM layout test.
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org//15701010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23427 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-30 17:40:32 +00:00
blois@google.com 9894ee4817 I had just added this test to validate that SVG namespaced attrs are working, but it's proving to be very flaky. Removing until I can come up with an alternate scheme for testing.
TBR
BUG=

Review URL: https://codereview.chromium.org//15941011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23426 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-30 17:25:34 +00:00
blois@google.com 881e456c21 Cleaning up some DOM APIs which were marked as deprecated because they were moved or renamed.
There were basically two issues:
- localName and namespaceUri moved from Node down to Element.
- The transitionEnd event was polyfilled based on the deprecated webkitTransitionEnd event, so it was switched to the standard transtionEnd.

The Attr change was needed because the node map was using localName on Attr (inherited from Node), when it should have been using name. Attr is not actually exposed anywhere, so made it private.

BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//15814008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23423 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-30 16:31:09 +00:00
ricow@google.com 215d846a45 Skip html/audiocontext_test on safari as well.
R=kustermann@google.com

Review URL: https://codereview.chromium.org//16223004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23389 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-30 09:46:49 +00:00
efortuna@google.com 533a66bdac Reapply removeWhere and retainWhere for elements in dart:html
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//15810006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23371 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-29 23:40:52 +00:00
efortuna@google.com 54bafa2ebf "Reverting 23366"
BUG=

Review URL: https://codereview.chromium.org//15950008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23369 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-29 22:25:05 +00:00
efortuna@google.com 942392b7e6 Correctly implemented removeWhere and retainWhere for elements in dart:html.
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//16171012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23366 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-29 21:22:22 +00:00
antonm@google.com da87bfc7b0 Remove shadow_dom_layout_test.
TBR=sigmund@google.com

Review URL: https://codereview.chromium.org//15924007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23340 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-29 10:24:46 +00:00
efortuna@google.com 87182ddeac Make RTC work on Firefox (mostly).
BUG=
R=blois@google.com, sra@google.com

Review URL: https://codereview.chromium.org//16023011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23298 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 17:55:05 +00:00
floitsch@google.com 5d058bb0eb Adding isNotEmpty property to collection and string.
BUG= http://dartbug.com/3074
R=floitsch@google.com

Review URL: https://codereview.chromium.org//15263004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23294 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 17:30:37 +00:00
antonm@google.com 8f79798b65 Fix a test after recent uri change.
TBR=sgjesse@google.com

Review URL: https://codereview.chromium.org//16026004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23273 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 14:05:47 +00:00
sgjesse@google.com 9d6a64e81b Merge the dart:uri library into dart:core and update the Uri class
This merges the dart:uri library into dart:core removing the dart:uri library. Besides moving the library the Url class has been changed.

* Removed existing Uri constructor as it was equivalent with Uri.parse
* Remamed constructor Uri.fromComponents to Uri
* Moved toplevel function encodeUriComponent to static method Uri.encodeComponent
* Moved toplevel function decodeUriComponent to static method Uri.decodeComponent
* Moved toplevel function encodeUri to static method Uri.encodeFull
* Moved toplevel function decodeUri to static method Uri.decodeFull
* Rename domain to host
* Added static methods Uri.encodeQueryComponent and Uri.decodeQueryComponent
* Added support for path generation and splitting
* Added support for query generation and splitting
* Added some level of normalization

R=floitsch@google.com, lrn@google.com, nweiz@google.com, scheglov@google.com
BUG=

Review URL: https://codereview.chromium.org//16019002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23266 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 13:35:01 +00:00
kustermann@google.com 9aea5116c6 Revert "Remove suppression for html/worker_test/functional"
R=ricow@google.com

Review URL: https://codereview.chromium.org//15767006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23257 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 12:10:56 +00:00
kustermann@google.com 7a4047b9f1 Remove suppression for html/worker_test/functional
BUG=http://dartbug.com/9929
R=ricow@google.com

Review URL: https://codereview.chromium.org//15842012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23252 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 11:30:37 +00:00
antonm@google.com 9ef479fbe4 Lax restrictions on exact exeption type for now.
TBR=amouravski@google.com

Review URL: https://codereview.chromium.org//15789004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23126 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-24 08:41:55 +00:00
kustermann@google.com 6f8f27dfc0 First status file updates for chromeOnAndroid runtime
R=ricow@google.com

Review URL: https://codereview.chromium.org//15915007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23124 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-24 08:28:25 +00:00
amouravski@google.com f968d3465c Added tests to previously broken functionality and added null checks.
R=antonm@google.com

Review URL: https://codereview.chromium.org//15138002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23123 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-24 08:23:24 +00:00
blois@google.com 4238872986 Fixing test issue passing with custom elements.
BUG=

Review URL: https://codereview.chromium.org//15745019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23048 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-23 02:12:00 +00:00