e505d44db4
moved everything inside of the Docgen class into top level variables and functions. Also made most of the helper functions private.
...
This should aid unit testing as it would be possible to create a mirror system separately, and also generate one library object separately without everything being chained together by the docgen class.
R=efortuna@google.com
Review URL: https://codereview.chromium.org//17943002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24550 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-27 21:11:57 +00:00
fca7d29b2c
Disallow template instances when !parentNode || !owner.defaultView https://github.com/Polymer/mdv/commit/d035acecab7c2d1afd9eb67bb01818d7ed9eb11f
...
extract template element from attribute templates. https://github.com/Polymer/mdv/commit/13741f22d94cec1d7ca115f023cf3a25b9245def
Note: this is based on https://codereview.chromium.org/17552019/ (reorg mdv)
R=justinfagnani@google.com
Review URL: https://codereview.chromium.org//17706003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24546 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-27 19:59:04 +00:00
5089f391d2
Revert "Add support for V8 and Firefox stack traces in pkg/stack_trace."
...
This reverts commit r24502.
Review URL: https://codereview.chromium.org//17998002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24506 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-27 02:16:12 +00:00
0c93466054
Hide parent function name in name of closurized function to user (issue 5436).
...
Hide implicit parameter of closure to user.
R=iposva@google.com
Review URL: https://codereview.chromium.org//17904009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24504 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-27 00:49:49 +00:00
a92a52a4ff
Add support for V8 and Firefox stack traces in pkg/stack_trace.
...
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//17765004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24502 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-27 00:28:28 +00:00
d6b9207588
Reorganize mdv and observe functionality
...
* keep correct dart:html APIs
* move implementation into package:mdv and package:observe
* remove dart:mdv_observe_impl
* remove getValueWorkaround/setValueWorkaround from package:observe
R=blois@google.com , floitsch@google.com , justinfagnani@google.com
Review URL: https://codereview.chromium.org//17552019
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24498 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-26 23:25:47 +00:00
11ccfad71b
pkg/serialization: add format param to Serialization.read method
...
Made read/write params named instead of positional
R=alanknight@google.com
Review URL: https://codereview.chromium.org//17578002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24487 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-26 20:34:52 +00:00
b1c5a2c197
Refactoring docgen to make it more unit testable.
...
broke up a few other functions to be smaller and only do one thing (mostly).
separated documentLibraries into 3 smaller functions that returns things so that it can be unit tested.
BUG=
R=efortuna@google.com
Review URL: https://codereview.chromium.org//17893008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24486 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-26 20:08:57 +00:00
824ab9a487
outputs a new file called library_list.txt which will let the viewer know what libraries are available
...
R=amouravski@google.com
Review URL: https://codereview.chromium.org//17759005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24478 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-26 17:14:36 +00:00
7dc47c68d0
Getting docgen to work with the SDK.
...
R=amouravski@google.com
Review URL: https://codereview.chromium.org//17745007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24477 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-26 17:04:41 +00:00
d4ab0bdbe2
Revert revision 24444, pkg/unittest/test/unittest_test is still flaky timing out on firefox
...
R=kustermann@google.com
Review URL: https://codereview.chromium.org//17818003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24454 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-26 07:53:51 +00:00
92dd5f0e42
Triage pkg and standalone tests.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//17737007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24446 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-26 03:02:18 +00:00
be0b406aa6
Re-enable unittest_test on Firefox. I think the timeout issues was fixed in
...
r24439.
R=sigmund@google.com
Review URL: https://codereview.chromium.org//17737005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24444 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-25 23:58:03 +00:00
50d7725e97
Fix an error and a warning in unittest.
...
R=sigmund@google.com
Review URL: https://codereview.chromium.org//17762004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24439 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-25 23:00:33 +00:00
8e081d2f0e
finds packageDir from the returned list from listDir.
...
used pathos package and moved to listDir from pub/lib/src/io.dart
moved listLibraries into the docgen class, and changed return type to Strings.
R=amouravski@google.com
Review URL: https://codereview.chromium.org//17611006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24434 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-25 21:38:13 +00:00
0bbe2c4920
Added --exclude-lib=docgen so that it does throw an error about markdown when building.
...
R=efortuna@google.com
Review URL: https://codereview.chromium.org//17608007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24421 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-25 16:49:11 +00:00
887c8e7596
Move getters from Options to Platform
...
The getters for executable, script and version are now statics on
Platform. I kept them on Options for now, but updated most tests to
use Platform.
R=ajohnsen@google.com , floitsch@google.com , iposva@google.com
BUG=
Review URL: https://codereview.chromium.org//17406010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24401 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-25 12:56:23 +00:00
2b7ee700b9
Mark unittest_test as flaky timing out on firefox, not flaky failing
...
R=kustermann@google.com
Review URL: https://codereview.chromium.org//17570016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24390 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-25 09:59:15 +00:00
4e57b11976
Mark pkg/unittest/test/unittest_test as flaky timing out on firefox
...
Filed issue 11473
R=kustermann@google.com
Review URL: https://codereview.chromium.org//17589011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24383 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-25 07:34:30 +00:00
94f6029199
Add error-page support in VirtualDirectory.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//17589012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24378 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-25 06:00:19 +00:00
e740b1bfd0
"Reverting 24368"
...
BUG=
R=efortuna@google.com
Review URL: https://codereview.chromium.org//17621004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24369 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 21:48:39 +00:00
1bc841e74e
docgen working with a temporary link hack.
...
added checking the environment varaible DART_SDK first, just like how pub does it, also added checking for null in constructor of docgen.
R=efortuna@google.com
Review URL: https://codereview.chromium.org//16915007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24368 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 21:36:06 +00:00
2e5ee49022
Added the continueParsing option to ArgParser.
...
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//12545013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24366 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 20:55:13 +00:00
a944ac501c
Update status files after inlining change.
...
R=ngeoffray@google.com
BUG=
Review URL: https://codereview.chromium.org//17619002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24356 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 18:23:01 +00:00
8356c667db
Added async_helper and fixed broken asynchronous test.
...
R=ahe@google.com , efortuna@google.com , floitsch@google.com
Review URL: https://codereview.chromium.org//16958006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24339 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 15:47:00 +00:00
9f9d785362
Fix 'part of' for mime package.
...
BUG=
R=kasperl@google.com
Review URL: https://codereview.chromium.org//17583010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24331 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 13:14:00 +00:00
53badd793a
Add auto-detection of MIME-type in VirtualDirectory.
...
Default charset for text/* is still missing.
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//17573011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24328 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 13:05:39 +00:00
48b1656690
Allow Object when doing lookups.
...
According to our typing rules a Set<Apple> is a Set<Fruit>. However, before this change, we couldn't use it as a Set<Fruit>:
===
bool foo(Set<Fruit> fruits) {
// Would yield a type-error since we actually got a Set<Apple>.
return fruits.contains(new Banana());
}
foo(new Set<Apple>());
===
R=ajohnsen@google.com , blois@google.com , lrn@google.com
Review URL: https://codereview.chromium.org//14246008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24326 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 12:45:10 +00:00
8e5b350649
Add a new MIME-type package 'mime', with implementation for handling mime-type lookup by path (finename extension) and magic-number matching.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//17582009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24324 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 11:55:49 +00:00
54bd4df5de
Make unmodifiable_collection test import of self use package:-uri.
...
R=ajohnsen@google.com
Review URL: https://codereview.chromium.org//17591006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24320 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 10:31:13 +00:00
c9b66a7973
Add new VirtualHost class to http_server package, for handling multiple hosts on multiple sources (HttpServer's).
...
It uses a by-name aproach, and thus depends on the host field to be
present.
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//17581002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24318 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 10:07:19 +00:00
0539f11c4a
Add support for IfModifiedSince headers, in http_servers' VirtualDirectory.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//17582002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24314 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 09:23:33 +00:00
28acc13c57
Update status files.
...
BUG=
R=karlklose@google.com
Review URL: https://codereview.chromium.org//17573005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24313 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 09:09:07 +00:00
8a687aab84
Don't test links on Windows, as we can't create relative links, in http_server.
...
BUG=
Review URL: https://codereview.chromium.org//17570006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24312 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 09:07:29 +00:00
96a8fe6aed
Add support for following links, in VirtualDirectory.
...
A link must be relative, and not escape the 'root' directory. The
implementation is kept conservative, to increase security.
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//17582007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24310 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 08:21:51 +00:00
2432ac4647
Support runtime check of function types.
...
New scheme for checking function subtyping:
1) Generate an $isX predicate on objects that are statically known subtypes of a given function type
2) Generate a signature encoding the whole function type on objects when a runtime check is needed.
A check succeeds if either 1) or 2) is true.
If too many predicates are needed a signature is generated instead, and if a signature is needed, no predicates are generated. Maximum number of predicates is currently determined by the magic constant MAX_FUNCTION_TYPE_PREDICATES in emitter.dart.
R=karlklose@google.com
Committed: https://code.google.com/p/dart/source/detail?r=24286
Review URL: https://codereview.chromium.org//12334070
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24309 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 06:58:55 +00:00
3579b85204
pkg/serialization: cleanup
...
R=alanknight@google.com
Review URL: https://codereview.chromium.org//17379025
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24306 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-21 23:24:25 +00:00
90bf6203ee
Revert "Support runtime check of function types."
...
This reverts commit r24286.
BUG=
Review URL: https://codereview.chromium.org//17413013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24288 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-21 14:02:47 +00:00
2ce76ed94a
Support runtime check of function types.
...
New scheme for checking function subtyping:
1) Generate an $isX predicate on objects that are statically known subtypes of a given function type
2) Generate a signature encoding the whole function type on objects when a runtime check is needed.
A check succeeds if either 1) or 2) is true.
If too many predicates are needed a signature is generated instead, and if a signature is needed, no predicates are generated. Maximum number of predicates is currently determined by the magic constant MAX_FUNCTION_TYPE_PREDICATES in emitter.dart.
R=karlklose@google.com
Review URL: https://codereview.chromium.org//12334070
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24286 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-21 13:35:56 +00:00
bb2980367c
Fix virtual_directory_test and Fail, OK on dart2js/browsers.
...
BUG=
Review URL: https://codereview.chromium.org//16950015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24285 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-21 12:20:03 +00:00
3514a89c19
Use toNativePath() in http_server pkg, to get the native path string on Windows.
...
BUG=
Review URL: https://codereview.chromium.org//17550004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24283 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-21 11:54:52 +00:00
0ef921b335
First push of a new 'http_server' dart package.
...
The package will contain helper-classes for writing http server, such as
VirtualDirectory, VirtualHost etc.
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//17544005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24281 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-21 11:22:31 +00:00
dacb671c45
Remove accidential addition of safari to v8 bug suppression in 24260.
...
Review URL: https://codereview.chromium.org//17531003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24261 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-21 06:05:39 +00:00
1426d0ef14
Mark two sha1 tests as failing on dart2js-safari.
...
Filed http://dartbug.com/11407
Review URL: https://codereview.chromium.org//17534002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24260 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-21 05:57:52 +00:00
d1920cf1b7
Disable barback tests on the browser.
...
R=nweiz@google.com
Review URL: https://codereview.chromium.org//17379018
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24259 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-21 00:53:45 +00:00
c283aca3b7
Remove unneeded imports to fix broken bots.
...
Review URL: https://codereview.chromium.org//17511007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24258 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-21 00:44:15 +00:00
81e2bed5c5
First pass at build dependency graph for barback.
...
BUG=
R=nweiz@google.com
Review URL: https://codereview.chromium.org//16854005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24257 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-21 00:21:53 +00:00
4d097b2712
Dart formatter checkpoint.
...
More babysteps. Note: some of the style is tentative (e.g., still trying on cascades).
Comments welcome.
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//17470004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24255 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 22:35:48 +00:00
c89ab41bff
add logging support for exceptions
...
BUG=
R=gram@google.com
Review URL: https://codereview.chromium.org//17467008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24246 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 19:43:00 +00:00
0ec6fe103b
Allow translated messages that have no matching original message. Also clean up help text and get rid of type error for types whose name is no longer easily visible from analyzer.
...
R=efortuna@google.com
Review URL: https://codereview.chromium.org//17113002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24240 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 17:01:13 +00:00
janicejl@google.com