dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
59,003 Commits 2 Branches 0 Tags
4db2bbe94deacc8e83eeb3dcef6180234cbd6f54
Commit Graph

137 Commits

Author SHA1 Message Date
William Hesse 0999a7b75e Remove special handling of _htmltest.html tests. 
This removes the special category of html tests which was added in 2014, in cl
https://codereview.chromium.org//695893002

Change-Id: I42d2992e79e7b508465a7fffb4864b545f3af452
Reviewed-on: https://dart-review.googlesource.com/72000
Reviewed-by: Jonas Termansen <sortie@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2018-08-30 14:37:57 +00:00
William Hesse 3603bfaebd Remove remaining traces of content_shell and DumpRenderTree 
Change-Id: Iae15260fa588b101929095c865807efecfb678a2
Reviewed-on: https://dart-review.googlesource.com/71960
Reviewed-by: Jonas Termansen <sortie@google.com>
 2018-08-30 08:15:30 +00:00
Devon Carew 92a70946b0 Fix three missing return warnings. 
Change-Id: I69c5684a40bf46ac6a2b1ed304ea593b9d073922
Reviewed-on: https://dart-review.googlesource.com/68381
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-08-03 19:25:37 +00:00
William Hesse 18047b2757 Refactor test.dart by changing class Configuration to TestConfiguration 
Change-Id: I03624c2cefc6bf5c293ecf016c52de6740e5893f
Reviewed-on: https://dart-review.googlesource.com/67462
Reviewed-by: Alexander Thomas <athom@google.com>
 2018-07-31 11:11:16 +00:00
Devon Carew 5b5e36f0be Remove use of deprecated methods and constants. 
Change-Id: Ic6867233dd7d432eaa0973dbfca13d53f15cc80a
Reviewed-on: https://dart-review.googlesource.com/63663
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2018-07-04 17:18:06 +00:00
Lasse R.H. Nielsen 973a1a0219 Remove uses of upper-case constants in remaining SDK code. 
This includes Fasta, tools and observatory, so the checked-in SDK must
have the lower-case constants.

Change-Id: I8380ad041ad058f7d02ae19caccfecd434d13d75
Reviewed-on: https://dart-review.googlesource.com/50201
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-04-16 16:11:57 +00:00
Erik Corry 5ed2f25f40 There is no longer a safarimobilesim test runtime. 
And so there is no need to maintain status files for this platform.

R=whesse@google.com

Change-Id: Ie70e4b7308cfd9b1b179b2d1eeeb8f36dd1a62dc
Reviewed-on: https://dart-review.googlesource.com/34824
Commit-Queue: Erik Corry <erikcorry@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2018-01-17 13:13:17 +00:00
Stephen Adams 88388cb5ca Revert "Remove support for "packages" URL from testing server." 
This reverts commit f38f91bb7e.

Lots of browser bots are red with this change.
Hopefully it can be recommitted atomically with changes that fix the redness.

TBR=whesse@google.com

BUG=

Review-Url: https://codereview.chromium.org/2997753002 .
 2017-08-10 17:04:21 -07:00
William Hesse f38f91bb7e Remove support for "packages" URL from testing server. 
This support was only needed for testing Dartium.
This also removes the dependency upon package_resolver from test.py.

BUG=
R=eernst@google.com, mkroghj@google.com

Review-Url: https://codereview.chromium.org/2994073002 .
 2017-08-10 14:33:07 +02:00
Bob Nystrom 012774c78e Remove Dartium support from test.dart. 
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2981223002 .
 2017-07-20 12:46:50 -07:00
Bob Nystrom 556c0550bf Simplify CommandOutput and friends. 
- Merge CommandOutputImpl and CommandOutput. There were no classes that
  implemented CommandOutput that didn't extend the Impl.
- Remove "Impl" from the other class names.
- Make stuff private when possible. Likewise final.
- Other tiny style changes.

R=whesse@google.com

Review-Url: https://codereview.chromium.org/2946783002 .
 2017-06-23 12:13:31 -07:00
Bob Nystrom b452b39962 Basic support for dev_compiler in test.dart. 
It can compile and run tests on Chrome. There are a lot of failing tests
that I (or the team) will need to triage, but I think at least basic
tests are working as expected.

There is code that could be cleaned up to more neatly factor how dart2js
and dartdevc are handled now that there are two separate compilers to
JS. There's also some redundant code between the path for testing
compile errors (enqueueStandardTest()) and the path for running a test
in the browser.

R=whesse@google.com

Review-Url: https://codereview.chromium.org/2947473002 .
 2017-06-21 13:19:28 -07:00
Bob Nystrom 7e2d9ac85d Revert "Revert "Replace the configuration map with a typed object."" 
This reverts commit 8bada4873a.

R=nweiz@google.com

Review-Url: https://codereview.chromium.org/2919573003 .
 2017-05-31 15:39:23 -07:00
Bob Nystrom 8bada4873a Revert "Replace the configuration map with a typed object." 
This reverts commit 06f75fe5cd.

Review-Url: https://codereview.chromium.org/2914893003 .
 2017-05-31 15:08:21 -07:00
Bob Nystrom 06f75fe5cd Replace the configuration map with a typed object. 
This is a pretty massive change but my hope is it will make
test.dart easier to maintain going forward. Instead of
passing around a stringly-typed Map<String, dynamic> all
throughout the program, we parse the options and then create
a Configuration object that has typed getters for all of the
various bits of configuration data.

This is a little tedious because it means declaring a new
option requires also declaring a corresponding field in the
Configuration class and passing it through the constructor.
I think it's worth it.

Also, enum-like configuration properties like architecture
and runtime now have their own classes as well. Moved a
bunch of stuff from TestUtil into those classes now that
there is an object to hang those methods off of.

In the process, I found a few typos in string literals where
the code wasn't correctly looking up a configuration
property.

Added more sanity checking and validation to status file
parsing. You will get an error at parse time if you try to
refer to a variable that isn't in the whitelist of known
variables. Also, you'll get an error if you try to compare
a variable to a value that it isn't expected to have.

Many other small-scale cleanups.

Aside from the status file validation, this should behave
mostly the same as current test.dart except that tests
may be enqueued in a slightly different order. The
rewritten code for expanding configurations iterates
through the architecture, runtime, etc. options in a
slightly different order.

R=whesse@google.com

Review-Url: https://codereview.chromium.org/2901923003 .
 2017-05-31 14:47:31 -07:00
Bob Nystrom 7ce978bf91 Tighten types in test.dart even more. 
This removes all implicit casts and many implicit uses of dynamic. It
adds a gratuitous number of explicit "as" casts and arguably makes the
code worse.

This is an interim step towards replacing the big configuration map
with an actual typed object. These "as" casts should help catch places
where the configuration object is being used and where the code will
need to be changed to use a new object.

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2903703002 .
 2017-05-30 14:02:24 -07:00
Bob Nystrom e0180925f6 Tighten up a bunch of types in test.dart. 
This doesn't get rid of all implicit dynamic and casts, but it covers
many of them.

Also did some minor modernization when I noticed it:

- Using "var" for local variables where inference does the right thing.
- camelCase for variable names.
- More collection literals.

There are (or should be!) zero behavioral changes.

R=whesse@google.com

Review-Url: https://codereview.chromium.org/2863253002 .
 2017-05-15 15:26:40 -07:00
William Hesse c235977ddb Increase startup time allowed for browsers 
On a cold, overloaded system, IE sometimes takes more than 60 seconds to start.

BUG=https://github.com/dart-lang/sdk/issues/28955
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2878423002 .
 2017-05-15 13:36:44 +02:00
Vyacheslav Egorov 7b2e162775 Gardening: update path to capture_screenshot.ps1 script 
R=kustermann@google.com
BUG=

Review-Url: https://codereview.chromium.org/2857923002 .
 2017-05-03 16:04:20 +02:00
Erik Corry 2fb5d08102 Spelling a 
R=ahe@google.com
BUG=

Review-Url: https://codereview.chromium.org/2841543002 .
 2017-04-24 14:53:51 +02:00
Martin Kustermann 0de8c02b6c Try work around issues executing powershell scripts on windows on the bots 
R=ricow@google.com

Review-Url: https://codereview.chromium.org/2817553005 .
 2017-04-12 12:28:20 +02:00
Martin Kustermann a3e9cd8ff6 Attempt at capturing screenshot on IE if tests time out 
The hypothesis is that a modal dialog from Internet Explorer causes
the currently running test to hang until test.dart kills the browser.

Capturing a screenshot might give an insight into there is a dialog showing up.

BUG=https://github.com/dart-lang/sdk/issues/28955
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2811093003 .
 2017-04-12 10:57:58 +02:00
William Hesse ac23816bb7 Fix an error where html_test (which is usually null) is used without checking for null, when reporting status back to the test controller. 
BUG=
R=ahe@google.com

Review-Url: https://codereview.chromium.org/2804543004 .
 2017-04-06 17:16:38 +02:00
William Hesse 87f38760e6 Add retry to test scripts' attempt to delete temporary Chrome config dirs. 
BUG=https://github.com/dart-lang/sdk/issues/29282
R=sortie@google.com

Review-Url: https://codereview.chromium.org/2803613005 .
 2017-04-06 16:05:59 +02:00
Asger Feldthaus 902d9ee7e8 Do some housekeeping in tools/testing/dart 
- Fix dartanalyzer warnings about unused variables and missing returns
- Remove trailing whitespace
- Add a dummy pubspec.yaml so editors recognize it as a Dart project

R=whesse@google.com

Review-Url: https://codereview.chromium.org/2633213003 .
 2017-01-17 16:02:45 +01:00
William Hesse 7e9a9804d9 Add suppression to test.dart for flaky content_shell crashes 
BUG=https://github.com/dart-lang/sdk/issues/26739
R=kustermann@google.com

Review URL: https://codereview.chromium.org/2081173002 .
 2016-06-27 14:44:11 +02:00
William Hesse fb117bb484 Fix analyzer warnings for browser_controller. 
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org/2069243002 .
 2016-06-15 22:22:34 +02:00
William Hesse f76236db74 Revert "Revert "Make Safari tests more robust."" 
This reverts commit b9cdd0e1b2.
This change should now work, because the buildbot recipes use the
renamed flag --reset-browser-configuration.

BUG=
R=ahe@google.com

Review URL: https://codereview.chromium.org/2070513002 .
 2016-06-15 04:29:33 -07:00
Peter von der Ahé b9cdd0e1b2 Revert "Make Safari tests more robust." 
This reverts commit 199806da03.

That commit failed because tools/bots/compiler.py is being ignored, and test.py is invoked based on recipes not included in this repository.

TBR

Review URL: https://codereview.chromium.org/2065053003 .
 2016-06-15 10:39:36 +02:00
Peter von der Ahé 199806da03 Make Safari tests more robust. 
R=whesse@google.com

Review URL: https://codereview.chromium.org/1871883002 .
 2016-06-15 10:16:14 +02:00
William Hesse 7c9219a48e Revert "Delay Firefox browser startup in test scripts, to flatten load." 
This reverts commit 40b69fd615.

BUG=https://github.com/dart-lang/sdk/issues/26060
R=kevmoo@google.com

Review URL: https://codereview.chromium.org/1921553005 .
 2016-04-26 21:29:45 +02:00
William Hesse 40b69fd615 Delay Firefox browser startup in test scripts, to flatten load. 
BUG=https://github.com/dart-lang/sdk/issues/26060
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org/1882813002 .
 2016-04-26 15:33:52 +02:00
William Hesse c0096e6f0c Print name of previous test when a browser test times out. 
Remove timeout multiplier for dart2js browser tests.

BUG=https://github.com/dart-lang/sdk/issues/26060
R=kustermann@google.com

Review URL: https://codereview.chromium.org/1867283002 .
 2016-04-13 12:35:27 +02:00
William Hesse c63b10b611 Format the test scripts in /tools/testing/dart using dartfmt 1.16.0-dev.3.0. 
R=ahe@google.com

Review URL: https://codereview.chromium.org/1859973002 .
 2016-04-06 14:49:18 +02:00
William Hesse 7407ecded4 Start browsers sequentially in testing scripts, as needed. 
BUG=https://github.com/dart-lang/sdk/issues/26060
R=ahe@google.com

Review URL: https://codereview.chromium.org/1859523002 .
 2016-04-06 11:34:52 +02:00
ricow@google.com 8d4af95d99 Don't report firefox crash reports 
This disables firefox crash reporting (which will show a pop up dialog)

R=whesse@google.com
BUG=

Review URL: https://codereview.chromium.org//1027093004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45202 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-16 11:17:12 +00:00
whesse@google.com 8257b1874e Restart ie11 browser while running tests. Update status files. 
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//888013002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43329 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-30 10:33:07 +00:00
whesse@google.com 5406811398 Restart IE 10 browser as we do with Android browsers on buildbot, to improve stability 
BUG=22203

Review URL: https://codereview.chromium.org//867083003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43294 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-29 16:24:00 +00:00
whesse@google.com 014a89563a Add debug logging for android testing. 
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//863663002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43005 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-20 11:39:09 +00:00
ricow@google.com 4598291567 Add info about which command line was used to start a browser. 
This will help us if we see hanging browsers.

R=kustermann@google.com

Review URL: https://codereview.chromium.org//790793009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42728 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-09 10:46:40 +00:00
kevmoo@google.com 47de553025 tools/testing: move code into individual libraries 
R=ricow@google.com

Review URL: https://codereview.chromium.org//748773004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42108 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-04 15:32:57 +00:00
whesse@google.com 0059ade0dd Add android device id to test output for failing tests. 
BUG=
R=kustermann@google.com

Review URL: https://codereview.chromium.org//755263002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41960 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-25 16:11:42 +00:00
whesse@google.com 12845acbf3 Revert "Add android device id to test output in test scripts." 
This reverts r41933

BUG=
R=kustermann@google.com

Review URL: https://codereview.chromium.org//758563004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41934 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-24 17:53:30 +00:00
whesse@google.com d91010512a Add android device id to test output in test scripts. 
BUG=
R=kustermann@google.com

Review URL: https://codereview.chromium.org//752173002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41933 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-24 17:40:13 +00:00
whesse@google.com 6ac0684ab8 Working SimpleHTML test front end 
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//695893002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41517 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-05 12:54:34 +00:00
whesse@google.com 0928369fc9 Improve browser testing scripts to better handle tests that reload themselves. 
BUG=dartbug.com/18558
R=ricow@google.com

Review URL: https://codereview.chromium.org//702543006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41490 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-04 14:46:45 +00:00
ahe@google.com d83ee35044 Terminate browsers in sequence. 
Also make iframe larger.

R=whesse@google.com

Review URL: https://codereview.chromium.org//660823002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41189 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-20 12:32:50 +00:00
whesse@google.com b21c902607 Add support in test scripts backend for simple HTML tests. 
BUG=dartbug.com/20698
R=ricow@google.com

Review URL: https://codereview.chromium.org//632283002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40956 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-07 15:29:39 +00:00
whesse@google.com f9b0a27ee9 test.dart: Serve the browser test driver page from the test file HTTP server. 
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//540933002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39907 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-05 11:01:26 +00:00
whesse@google.com 48065a1f91 Update test scripts to run under the Dart 1.6 vm. 
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//483353003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39443 260f80e4-7a28-3924-810f-c04153c831b5
 2014-08-21 09:30:10 +00:00