Commit Graph

154 Commits

Author SHA1 Message Date
Aart Bik 751cf1974a [dart/fuzzer] Add DBC as execution mode.
Rationale:
More coverage is better!
Change-Id: Ic04f4caf7d02e1db9398f3d51ae44f6b51d6542d
Reviewed-on: https://dart-review.googlesource.com/c/78862
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
2018-10-09 18:56:28 +00:00
Aart Bik 69550e2837 [dart/fuzzer] Increase #tests to 125
Rationale:
With 8 isolates per machine, this gives an even
8 x 125 = 1000 tests per machine on the cluster
Change-Id: I06e21f271ec5452c1d5559666b3f0f1eaea439dd
Reviewed-on: https://dart-review.googlesource.com/c/78620
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
2018-10-08 18:16:44 +00:00
Sergey G. Grekhov e8e9677fad [co19] co19_2 roll.
* co19_2 tests enabled for vm-kernel CQ builders.

Change-Id: I5ccc27d1110c22960e550b060a7e140bc1ac68b1
Reviewed-on: https://dart-review.googlesource.com/c/76820
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2018-10-05 06:35:43 +00:00
Alexander Thomas ced7ee6f4b [dart/fuzzer] Use multiple isolates
Change-Id: I8e3882d3a45a3ac8111d2a18c619c7bc20fc4b3d
Reviewed-on: https://dart-review.googlesource.com/c/78161
Reviewed-by: Aart Bik <ajcbik@google.com>
2018-10-04 21:56:33 +00:00
Alexander Thomas cf007d1f40 [infra] Add missing entries to the test matrix
TBR=whesse@google.com

Change-Id: I159e1a784a88eb1c040046edfdb881b6962be672
Reviewed-on: https://dart-review.googlesource.com/c/78160
Reviewed-by: Alexander Thomas <athom@google.com>
2018-10-04 19:59:54 +00:00
Alexander Thomas 1af136987b [infra] Prepare test matrix for the Dart 1 removal
* Remove all obsolete builders (only the try jobs used the test matrix).
* Add all missing Dart 2 builders.

Change-Id: I5c97e34928beb9023d87aaa638f759af16a7ccc4
Reviewed-on: https://dart-review.googlesource.com/c/77881
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
2018-10-04 15:50:14 +00:00
Alexander Thomas 93c5dcd00a [infra] Add fuzz testing builder to the test matrix
Change-Id: I8a9af496eea3b2c82ff30d158971227df78b9dab
Reviewed-on: https://dart-review.googlesource.com/c/77620
Reviewed-by: Aart Bik <ajcbik@google.com>
2018-10-02 20:02:21 +00:00
Zach Anderson 3c40b5670d [test] Shard the dartkb tests.
Change-Id: I3a97e340e83ddf1df4438262f176392540ecbbc2
Reviewed-on: https://dart-review.googlesource.com/76745
Commit-Queue: Zach Anderson <zra@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2018-09-28 19:45:28 +00:00
William Hesse b01f461280 Add product mode macos dart executable to fileset for running tests
Change-Id: I0c4d70271c1949e642329371706740ea448a3a59
Reviewed-on: https://dart-review.googlesource.com/76670
Reviewed-by: William Hesse <whesse@google.com>
2018-09-26 14:09:09 +00:00
Alexander Thomas c38eab4fa9 [infra] Remove Dart 1 builders from the CQ (Part II)
TBR=whesse@google.com

Change-Id: Ia3529510b7c4c3b17ba07d76e2da9dd8d6e9ccff
Reviewed-on: https://dart-review.googlesource.com/76541
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2018-09-26 07:11:21 +00:00
Alexander Thomas 8ff692acf4 [infra] Remove Dart 1 builders from the CQ (Part I)
* Remove obsolete vm-kernel-legacy and analyzer-cfe builders.

Change-Id: I6b316359b1a2c5ce2adcf276578a9b9be5db5c15
Reviewed-on: https://dart-review.googlesource.com/76480
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2018-09-25 19:03:54 +00:00
Alexander Thomas fc04f56430 [infra] Remove deleted Dart 1 builders (app/precomp) from the test matrix
Change-Id: I5f7d4e2755db531e9a62e611e51f7c62d6fdd521
Reviewed-on: https://dart-review.googlesource.com/69681
Reviewed-by: William Hesse <whesse@google.com>
2018-09-25 11:51:21 +00:00
Alexander Markov 654c4babc8 [vm/bytecode] Fix a couple of assertions when running with bytecode
Also, add more tests to dartkb bots.

Change-Id: I6fbcbe73d6b9065ec03e64bf150b4ebd742e4d28
Reviewed-on: https://dart-review.googlesource.com/75981
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
2018-09-21 22:54:39 +00:00
Zach Anderson bfeb270b21 [tests] Try dartkb with different vm flags
This change modifies the test matrix to run with --compiler=dartkb with
--enable_interpreter and --use_bytecode_compiler in sequence.

Change-Id: Ie1be3ffdd97e65ceafb8838fd1b159746ba4c2cb
Reviewed-on: https://dart-review.googlesource.com/75206
Commit-Queue: Zach Anderson <zra@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
2018-09-18 15:30:15 +00:00
Zach Anderson 568b13905f [vm] Fixes for dartkb testing
The "vm" test suite is cauing the kernel bytecode compiler to
OOM on the bot, so this CL removes it from the test matrix for
dartkb. This CL also protects against non-utf8 data coming in
on the error message pipe during process spawning.

Change-Id: Iab110a49a49ea12d21037719716a228776343602
Reviewed-on: https://dart-review.googlesource.com/74490
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
2018-09-12 20:02:10 +00:00
Kevin Moore 0f1fa9eeae Remove pkg/dart_messages
Not used

Fixes https://github.com/dart-lang/sdk/issues/27832

Change-Id: Ia1e00fc8be2c904f21a95e89640099fa900a15a5
Reviewed-on: https://dart-review.googlesource.com/74461
Reviewed-by: Peter von der Ahé <ahe@google.com>
2018-09-11 16:20:06 +00:00
William Hesse 44679beac8 Add script to add commit hash and metadata to the json record of a test.py run.
Change-Id: I9ca9940d7435fa21ddbfe23f457f193e9de21cad
Reviewed-on: https://dart-review.googlesource.com/74220
Reviewed-by: Jonas Termansen <sortie@google.com>
2018-09-10 15:19:34 +00:00
Alexander Thomas b72b00631b [infra] Fix typo in test matrix (#32229)
This fixes the problem that the dartkp-obfuscate builder was running the
wrong tests.

TBR=whesse@google.com

Change-Id: I7b2d2ca309a9b460f14a392414f6f594834b6a05
Reviewed-on: https://dart-review.googlesource.com/74140
Reviewed-by: Alexander Thomas <athom@google.com>
2018-09-10 13:22:41 +00:00
Alexander Thomas c0697ad738 [co19] Roll co19_2 and enable for dart2js
Change-Id: I72b493a65ef5c854b122d76d80549d30141157fd
Reviewed-on: https://dart-review.googlesource.com/71243
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2018-09-06 09:09:29 +00:00
Alexander Thomas 38c0287019 [infra] Add vm-kernel-checked builder to the test matrix
Change-Id: If83bc9f95cf02f44d4cf88d8076fa490f78e6cd5
Reviewed-on: https://dart-review.googlesource.com/73200
Reviewed-by: Martin Kustermann <kustermann@google.com>
2018-09-05 15:31:58 +00:00
Alexander Thomas 14dda998dc [infra] Add dartkp-obfuscate builder to the test matrix (#32229)
Change-Id: I866e0ac6a4ce848d31d36667c712b381a5723098
Reviewed-on: https://dart-review.googlesource.com/72600
Reviewed-by: Martin Kustermann <kustermann@google.com>
2018-09-03 08:04:21 +00:00
Janice Collins f40ff153a9 Enable --use-fasta-parser with the analyzer by default.
Based on Devon's change at:

https://dart-review.googlesource.com/c/sdk/+/67090

Change-Id: I80b7943826e248bf37d9bbbb769330d24b0dd6ae
Reviewed-on: https://dart-review.googlesource.com/70160
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
2018-08-28 19:29:17 +00:00
Devon Carew 28f902744b Disable the analyzer cfe bots.
Change-Id: I4cbe50cd552347a2be9098f1f583fae4a3a3daaa
Reviewed-on: https://dart-review.googlesource.com/71880
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-08-28 16:25:16 +00:00
Zach Anderson 51bed8a0ed [test matrix] Add back --compiler=dartkb
This was removed by https://dart-review.googlesource.com/c/sdk/+/69970
but the --compiler flag isn't being picked up automatically. See e.g.:
https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8937641495482850608/+/steps/vm_tests/0/stdout

Change-Id: Ia0bd7d708c8e7f8ada536915b9147423b37bc4cf
Reviewed-on: https://dart-review.googlesource.com/70783
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
2018-08-20 21:45:09 +00:00
William Hesse e29176ea0d Add --use-cfe and --analyzer-use-fasta-parser flags to smith:configuration
Use them in test_matrix.json for the analyzer builders.

Bug: https://github.com/dart-lang/sdk/issues/34151
Change-Id: I4abe0bcc8b62ee372df32c0402fad3cd9042cb27
Reviewed-on: https://dart-review.googlesource.com/70282
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2018-08-17 14:42:43 +00:00
Alexander Thomas a558e71b19 [infra] Re-add --dart2js-batch to dart2js builders in the test matrix
TBR=whesse@google.com

Change-Id: Icb64186f3fe9b6a2b7319334ec7e2b9e169fac66
Reviewed-on: https://dart-review.googlesource.com/70341
Reviewed-by: Alexander Thomas <athom@google.com>
2018-08-16 20:32:10 +00:00
Alexander Thomas 54fc71ddca [infra] Fix dart2js-csp-chrome builder
TBR=whesse@google.com

Change-Id: I9da1267d27e017ff4e13b27e823a7f27640c4561
Reviewed-on: https://dart-review.googlesource.com/70240
Reviewed-by: Alexander Thomas <athom@google.com>
2018-08-16 07:23:01 +00:00
William Hesse e5dd9c44b4 Remove test.py flags from builders in test_matrix, use configuration instead.
The -n<named configuration> flag is being used instead of the
command-line flags in the test.py builder steps.  Remove the unused flags.

Bug: https://github.com/dart-lang/sdk/issues/34066
Change-Id: I07a451273741618e23f85e900eac040e29c84c0a
Reviewed-on: https://dart-review.googlesource.com/69970
Reviewed-by: Alexander Thomas <athom@google.com>
2018-08-15 15:26:42 +00:00
Devon Carew 59a68b5310 Merge the analyzer-use-cfe-linux, analyzer-use-cfe-mac, and analyzer-use-cfe-win bots.
Change-Id: I72c3e4c8154b5950793f8df9bcc3d48a793f73eb
Reviewed-on: https://dart-review.googlesource.com/70142
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-08-15 14:35:11 +00:00
Alexander Thomas 94f80d6ee5 [infra] Remove Dart 1 front-end builder from the test matrix
TBR=whesse@google.com

Change-Id: I55598120c81083cb83caa497d7792bb0438bf5d8
Reviewed-on: https://dart-review.googlesource.com/69964
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2018-08-15 10:29:01 +00:00
William Hesse 14f6fbb457 Fix test_matrix.json for dartkp product mode builder.
Mark a test slow that otherwise times out on dartdevc kernel mode.

Change-Id: Id27683c54982f9a6afd1e41f566dd12aa67040de
Reviewed-on: https://dart-review.googlesource.com/69962
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
2018-08-14 17:18:02 +00:00
Devon Carew 580f809949 Convert the current analyzer --use-cfe test results to language2 status file entries.
Change-Id: I39a1573b0c0e5c85524cb654a5febea09fb9577a
Reviewed-on: https://dart-review.googlesource.com/69720
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-08-13 19:46:56 +00:00
William Hesse d8e01be7d5 Update named configurations to agree with builder flags
Change-Id: I437c741ebeb684ce1660b3fcd80ab2aa756e501b
Reviewed-on: https://dart-review.googlesource.com/68882
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2018-08-13 12:09:47 +00:00
Alexander Thomas ba10df6611 [infra] Switch pkg bots to Dart 2
* Update named configs for unit tests to Dart 2.
* Bump json_rpc_2 in front_end package.
* Use named configurations in unit tests.
* Fix typing issues.

Change-Id: Id3b393a0d2abe92c8eaec10fa8057fb35d18a4c6
Reviewed-on: https://dart-review.googlesource.com/67341
Reviewed-by: Jens Johansen <jensj@google.com>
2018-08-13 07:04:06 +00:00
Devon Carew be6309690f Analyze pkg/dart2js_tools on the bots.
Change-Id: I727012f8584a4d92d5333da303147a1c947d4fb6
Reviewed-on: https://dart-review.googlesource.com/69247
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-08-10 06:04:10 +00:00
Alexander Thomas af02ccae83 [infra] Fix filesets for new vm-kernel-precomp builders
TBR=whesse@google.com

Change-Id: I81a836d532a355db5e3a74a244af71605e0c04c3
Reviewed-on: https://dart-review.googlesource.com/69102
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2018-08-09 11:50:36 +00:00
Alexander Thomas 7eda513405 [infra] Add new vm-kernel-precomp builders to the test matrix
TBR=whesse@google.com

Change-Id: Ia88f17cee0fb1f69d4bf17eb35dbdaa606aee71b
Reviewed-on: https://dart-review.googlesource.com/68942
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2018-08-08 17:19:27 +00:00
William Hesse 0986b2bfa2 Clean up test.py named configurations code
Drops the debug printing of configurations, and the checking
that the named configurations agree with the flags passed.

Change-Id: Id19ca002668a757d44017873a5d0c8bb06472564
Reviewed-on: https://dart-review.googlesource.com/68680
Reviewed-by: William Hesse <whesse@google.com>
2018-08-07 13:53:37 +00:00
William Hesse e0f6fdfff1 Refactor testing:TestConfiguration to use smith:Configuration by inclusion.
Change-Id: I5c116ad082a24c25a07b9ceb6aaf8c9cbe3f11e3
Reviewed-on: https://dart-review.googlesource.com/68361
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2018-08-06 16:19:08 +00:00
Devon Carew 42b02e02e7 Add more test steps to the analyzer --use-cfe bots.
Change-Id: Ifb756a9faf4c57bd8426b8d94a88e69d9cb890a0
Reviewed-on: https://dart-review.googlesource.com/68421
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-08-04 06:35:53 +00:00
Devon Carew 5313553961 Run the analysis server 'analysis-server-cold' with --use-cfe.
Change-Id: Ia4774d9f01b723f36a9728487ddcabcdac854bdd
Reviewed-on: https://dart-review.googlesource.com/67940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-08-02 19:50:48 +00:00
Devon Carew b1c9b67b68 Add initial content for the analyzer --use-cfe builders.
Change-Id: Ic44cb58bcf664d244c510b52800eaebfbef9b391
Reviewed-on: https://dart-review.googlesource.com/67580
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2018-08-01 19:45:39 +00:00
William Hesse 2a23bc2e0b Update named configurations on builders, turn off checking temporarily.
The named configurations aren't used yet, and checking that they agree
with the existing flags will now just print error messages, not make
the builder fail.

Change-Id: Ia0778855d3c45da8e3314f9cff0967ec1fc7893b
Reviewed-on: https://dart-review.googlesource.com/67807
Reviewed-by: William Hesse <whesse@google.com>
2018-08-01 16:50:41 +00:00
William Hesse 0fd93a5c6e Test.dart exits with non-zero exit code if named configuration disagrees with flags.
Change-Id: I05e869c3f37aa786cd39185b51dda627133aa5e9
Reviewed-on: https://dart-review.googlesource.com/67805
Reviewed-by: Alexander Thomas <athom@google.com>
2018-08-01 16:01:16 +00:00
William Hesse f10b4005cd Code to load a named configuration and check it against the existing options.
First stab at loading named configuration, plus temporary test code

Change-Id: I5835fe34a024a6052021c8189629a1578bed2355
Reviewed-on: https://dart-review.googlesource.com/63880
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2018-08-01 12:55:13 +00:00
William Hesse 7413644de8 Change builder names from -ff- to -firefox-
Change-Id: I69317cb92364de2b38f7967cb3ce9e3b307c7678
Reviewed-on: https://dart-review.googlesource.com/67780
Reviewed-by: Alexander Thomas <athom@google.com>
2018-08-01 12:28:13 +00:00
William Hesse cf77a3b00f [Test.dart] Use Compiler, Runtime, etc. classes from pkg:smith.
Change-Id: I1251c94e87fe6953f7604b5ef8f6ae5c49ab36d3
Reviewed-on: https://dart-review.googlesource.com/67522
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2018-08-01 09:45:17 +00:00
Danny Tuppeny 3dc201e168 Update ChangeBuilder to not include empty edits (Take 2)
Combination of Brian's change:
https://dart-review.googlesource.com/c/sdk/+/63901

and Devon's change:
https://dart-review.googlesource.com/c/sdk/+/66405

Change-Id: I57e5d1f7d3a653f225aba2d690190fe1ff18a5b1
Reviewed-on: https://dart-review.googlesource.com/67344
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
2018-07-31 13:44:06 +00:00
William Hesse 21db860271 Remove non-strong dart2js builders from test_matrix.json
Change-Id: I76c4a1f0df8f6e8f6ddd03fd35c9a069845687ef
Reviewed-on: https://dart-review.googlesource.com/67346
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-07-30 17:47:44 +00:00
Alexander Thomas 3665cad81c [infra] Shard analyzer unit tests
TBR=whesse@google.com

Change-Id: I8616b3674258cb4406ace7bd81d4a91df124ff83
Reviewed-on: https://dart-review.googlesource.com/66960
Reviewed-by: Alexander Thomas <athom@google.com>
2018-07-27 08:24:12 +00:00