dart-lang/sdk - sdk - Tonycloud git server

dart-lang/sdk

Fork 0

Commit Graph

Author	SHA1	Message	Date
Jacob Richman	2dcd56ef43	Format all tests. There are far too many files here to review everyone carefully. Spot checking most of the diffs look good as test code is generally written with less care than application code so lots of ugly formatting get through. If people notice files where the automated formatting bothers them feel free to comment indicating file names and I'll move spaces within comments to make the formatting cleaner and use comments to force block formatting as I have done for other case where formatting looked bad. BUG= R=efortuna@google.com Review-Url: https://codereview.chromium.org/2771453003 .	2017-04-17 14:53:02 -07:00
Srdjan Mitrovic	b3405d5ebc	Add --no-background-compilation to tests that expect to run code in optimized form BUG= R=asiva@google.com Review URL: https://codereview.chromium.org/1759973002 .	2016-03-02 16:30:58 -08:00
fschneider@google.com	68a90e4386	Fix crash in optimized code caused by missing IC data. When inling intrinsified methods like String.isEmpty that are not native, we have to emit the full unoptimized code so that those method can be correctly optimized and inlined later. Also, remove an invalid assertion in the type propagator: ToNullableCid may be called on values from the callee graph in the inliner where type propagation has not yet been performed. BUG=https://code.google.com/p/dart/issues/detail?id=12691 TEST=tests/language/optimized_isempty_test.dart R=srdjan@google.com Review URL: https://codereview.chromium.org//23123012 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26629 260f80e4-7a28-3924-810f-c04153c831b5	2013-08-26 09:46:30 +00:00

Author

SHA1

Message

Date

Jacob Richman

2dcd56ef43

Format all tests.

There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.

BUG=
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2771453003 .

2017-04-17 14:53:02 -07:00

Srdjan Mitrovic

b3405d5ebc

Add --no-background-compilation to tests that expect to run code in optimized form

BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org/1759973002 .

2016-03-02 16:30:58 -08:00

fschneider@google.com

68a90e4386

Fix crash in optimized code caused by missing IC data.

When inling intrinsified methods like String.isEmpty that are
not native, we have to emit the full unoptimized code so that
those method can be correctly optimized and inlined later.

Also, remove an invalid assertion in the type propagator: ToNullableCid
may be called on values from the callee graph in the inliner where
type propagation has not yet been performed.

BUG=https://code.google.com/p/dart/issues/detail?id=12691
TEST=tests/language/optimized_isempty_test.dart
R=srdjan@google.com

Review URL: https://codereview.chromium.org//23123012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26629 260f80e4-7a28-3924-810f-c04153c831b5

2013-08-26 09:46:30 +00:00

3 Commits