dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
59,003 Commits 2 Branches 0 Tags
4db2bbe94deacc8e83eeb3dcef6180234cbd6f54
Commit Graph

3222 Commits

Author SHA1 Message Date
Peter von der Ahé f1d902f4a0 Ignore --supermixin and -D options 
Change-Id: Ia817ad9236ee0947a87faa4c570eedc239a1a84a
Reviewed-on: https://dart-review.googlesource.com/c/78542
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-10-10 13:38:57 +00:00
Peter von der Ahé f1b6d81404 Remove Target.strongMode 
Change-Id: I60f72904f4a9ae3427b2a2633a22f70a6b6f8ea9
Reviewed-on: https://dart-review.googlesource.com/c/79020
Commit-Queue: Peter von der Ahé <ahe@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-10-10 12:49:18 +00:00
Peter von der Ahé 8c872e0e3a Remove TargetFlags.strongMode 
Change-Id: Ibf8661e5444d16666c54f1d81c626893b000521a
Reviewed-on: https://dart-review.googlesource.com/c/78986
Commit-Queue: Jens Johansen <jensj@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-10-10 12:11:41 +00:00
Peter von der Ahé ee97806084 Replace strongMode with legacyMode in CompilerOptions 
Also, remove --strong and --strong-mode flags (use --legacy-mode
flag to enable legacy mode).

Change-Id: I577ab5f755a2bee88f0f4d63915a6e852e792f06
Reviewed-on: https://dart-review.googlesource.com/c/79000
Commit-Queue: Jens Johansen <jensj@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-10-10 12:04:26 +00:00
Dmitry Stefantsov aa6fb2d3a4 [fasta] Report errors for bounds violations 
Fixes #33308.

Bug: http://dartbug.com/33308
Change-Id: Iae087928468ed6883c438db95644135dc7ef0a6a
Reviewed-on: https://dart-review.googlesource.com/c/57621
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2018-10-10 12:03:36 +00:00
Peter von der Ahé f942af451b Remove kernel interpreter 
The test isn't normally run, and all 12 testcases caused a crash.

Change-Id: Ie1576e32b70f01aa775c3305bff2bc992eebf86f
Reviewed-on: https://dart-review.googlesource.com/c/78940
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2018-10-10 08:42:21 +00:00
Kevin Millikin 4e4e9ec74a Implement int-to-double literal conversion. 
The implementation strategy is to replace int literals with double
literals during type inference, provided they occur in a double
context and can be represented exactly as a double.  This requires us
to keep integer literals larger than the 64-bit range until after type
inference and to keep the source text of 64-bit integers until after
type inference for error reporting.

We postpone the check for web int literals as well because the
expression generator that was performing it isn't otherwise needed.

Fixes https://github.com/dart-lang/sdk/issues/34357.

Change-Id: Ia78c031565cad83961675fc4fb1cc871eaed01d3
Reviewed-on: https://dart-review.googlesource.com/c/78122
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-10-09 09:15:28 +00:00
Aske Simon Christensen 79e8b3d57f Make importing two libraries with the same name a warning 
Bug: https://github.com/dart-lang/sdk/issues/34612
Change-Id: I2697b56fb02d6bee8ea3bc2d06329100e287ae34
Reviewed-on: https://dart-review.googlesource.com/c/78242
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2018-10-09 06:56:13 +00:00
Kevin Millikin 9d150c6443 Avoid a downcast error 
The field that we use to hold redirecting constructors is a Kernel
field, and not a ShadowField.

Fixes https://github.com/dart-lang/sdk/issues/34715

Change-Id: Iea2ce41f0229a7b9c2354bf3c6c3b586a3ffec33
Reviewed-on: https://dart-review.googlesource.com/c/78540
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Daniel Hillerström <hillerstrom@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
 2018-10-08 15:03:45 +00:00
Johnni Winther 127c3fed6c Handle data URIs in dart2js 
Change-Id: Ifca03b51aa16e2b4676490c94dafe335e1a94171
Reviewed-on: https://dart-review.googlesource.com/c/76901
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2018-10-08 13:00:34 +00:00
Peter von der Ahé e4840ec239 Remove byte_store and performance_logger stubs 
Change-Id: Ia64c6c42a8737a23d7f708bd6905088f9444951e
Reviewed-on: https://dart-review.googlesource.com/c/78200
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
 2018-10-08 12:03:38 +00:00
Peter von der Ahé 935af1e77f Use unique package paths in incremental_load_from_dill_test.dart 
Change-Id: I94cb9ddffa604bdb682af0da0df4810b7523954d
Reviewed-on: https://dart-review.googlesource.com/c/78462
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-10-08 10:09:25 +00:00
Dan Rubel 358b580941 more fasta parser tests 
Change-Id: I41f45835ca36fc5752ae537e67dce55299493e43
Reviewed-on: https://dart-review.googlesource.com/c/78260
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-10-05 15:36:41 +00:00
Kevin Millikin 796d628ab6 Improve error reporting from Kernel scripts 
* Ensure that we have a .dill file and it has the correct version before
  we start decoding it in dump.dart.

* Throw errors, not strings.  Ensure that they have a useful
  toString().

* Do not print usage except when the command is invoked
  incorrectly (wrong number of arguments).  Once we get into the
  command it's less likely that it's been invoked incorrectly and more
  likely that something else has gone wrong.

  Because these utilities are invoked from other scripts (like the
  fasta command), printing their usage for problems other than
  invoking them correctly doesn't match the way that they were invoked
  and it's confusing.

Change-Id: I7832383594d2b3719a0a7a7392ba4685717a79d2
Reviewed-on: https://dart-review.googlesource.com/c/78206
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-10-05 12:19:01 +00:00
Dan Rubel b6a8e31492 Improve error message when var is used as a type name 
... and Address comments in
https://dart-review.googlesource.com/c/sdk/+/78101

Change-Id: I8b3bc9888185d9802a389baa3f197f9b29927b7f
Reviewed-on: https://dart-review.googlesource.com/c/78103
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-10-05 11:56:26 +00:00
Dan Rubel 1472053545 Add fasta regress test for 34563 
Change-Id: Ic5971e44e1853215f8e841d589ea9ef12bdef179
Reviewed-on: https://dart-review.googlesource.com/c/78100
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-10-05 10:39:21 +00:00
danrubel 9c75ab7aa9 More common fasta/analyzer parser error codes 
Change-Id: I49128f2721eac1a96c15a96c823a31376f098126
Reviewed-on: https://dart-review.googlesource.com/c/78102
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-10-04 18:54:55 +00:00
danrubel a712a910cf Revise class and mixin header recovery 
This updates the fasta parser to use the "incorrect" keyword
when "extend" or "on" is used instead of "extends" in a class declaration and
when "extend" or "extends" is used instead of "on" in a mixin declaration.

Change-Id: I6bef3f897e24c3c0100180d2bf9f4d2ec7608eef
Reviewed-on: https://dart-review.googlesource.com/c/78101
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-10-04 18:51:44 +00:00
danrubel def9d4c405 Cleanup endMethod and endFactoryMethod parameter recovery 
This CL moves missing parameter recovery code out of the AstBuilder into
the parser, and adds guard code in the AstBuilder to assert that param is not null.

Change-Id: I8e68194ad3de4b8a4be755f8fa2943344393267a
Reviewed-on: https://dart-review.googlesource.com/c/78000
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-10-04 14:06:27 +00:00
Peter von der Ahé 2a6b566ca2 Move byte store to package:analyzer 
Change-Id: I1fc41cc0b2e2848565a5411d0512a4ca086ab659
Reviewed-on: https://dart-review.googlesource.com/c/77761
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
 2018-10-04 09:15:54 +00:00
Peter von der Ahé 45cb0815bc Move PerformanceLogger to package:analyzer 
Change-Id: I89a60ae9ab639c7907a92976e1eb8007d0f4ee9b
Reviewed-on: https://dart-review.googlesource.com/c/77760
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
 2018-10-04 08:44:43 +00:00
Peter von der Ahé 3a2308f5c2 Move jenkins_smi_hash to package:analyzer 
Change-Id: Ic458da90e5bdb6b3b7fee26088b17dd560ff3a68
Reviewed-on: https://dart-review.googlesource.com/c/77861
Commit-Queue: Peter von der Ahé <ahe@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-10-04 07:43:09 +00:00
Janice Collins 644342a6e6 Prepare for analyzer 0.33.0 publish. 
Change-Id: Idaf40321b8ba861670f5492bec7697865726b428
Reviewed-on: https://dart-review.googlesource.com/c/77982
Commit-Queue: Janice Collins <jcollins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-10-03 22:36:17 +00:00
danrubel ab3ef0914c Allow "yield" as label 
Fix https://github.com/dart-lang/sdk/issues/33672

Change-Id: I1d070fd2fd3901d8159aa760b094398efee8643c
Reviewed-on: https://dart-review.googlesource.com/77501
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-10-03 18:32:07 +00:00
danrubel f529ab10f0 Allow "operator" as a static method name 
Fix https://github.com/dart-lang/sdk/issues/33673

Change-Id: Ia2ec01a3b9cf701f7f85f4891d2fb45f1f01e444
Reviewed-on: https://dart-review.googlesource.com/77500
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-10-03 18:32:07 +00:00
Aske Simon Christensen eacf720d2b Functions to demangle mixin application class names 
Demangle all names in messages to avoid printing mangled names in
user-facing output.

Point messages about implicit mixin application classes at the subclass
name for consistency with named mixin application classes.

Change-Id: I90973986c422f271af99e18b3deb5847adf4d430
Reviewed-on: https://dart-review.googlesource.com/c/77380
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2018-10-03 14:56:43 +00:00
Aske Simon Christensen bb2775b16a Only perform override check on declared members. 
The code in class_hierarchy.dart that looped over override pairs
included implementations inherited from its superclass as potential
overriders, presumably in a broken attempt to include some interface
checks into the mix.

With this problem fixed, the special case in kernel_class_builder.dart
that excluded overriders not declared in the current class (i.e.
declared in a mixin) could be removed without incurring false
positives.

These override checks performed on members from a mixin produce an
extra context message indicating the class where the two members meet,
giving rise to the override relation (similarly to interface checks).

Since the same member can now override more than one member (or even
the same member more than once), the diagnostics message duplication
check has been extended to also include the context in the comparison.

Fixes https://github.com/dart-lang/sdk/issues/34235
Fixes https://github.com/dart-lang/sdk/issues/34285

Change-Id: I990e5719ae1749fd1aad1ad478aaa6e173cb170b
Reviewed-on: https://dart-review.googlesource.com/c/76900
Reviewed-by: Daniel Hillerström <hillerstrom@google.com>
 2018-10-03 14:56:43 +00:00
Aske Simon Christensen d3bd06d4e8 Check class interface requirements using override check code. 
When a member in the interface of a non-abstract class is found to
have an implementation with the correct name which does not override
the representative declaration of the member in the interface (and thus
has not been checked against that member for override validity), call
the override check to check interface validity.

Override relations thus checked produce an extra context message
explaining that the override relation must hold because both members
are inherited by a non-abstract class.

Fixes https://github.com/dart-lang/sdk/issues/32014

Change-Id: I955f057e35fa30f33c19da37c9cea1262042431c
Reviewed-on: https://dart-review.googlesource.com/c/74642
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-10-03 14:56:43 +00:00
Peter von der Ahé ed42aab273 Move source.dart to package:analyzer 
Change-Id: Ide66d4f69b8588f04967c510eae0a733b4b3f0c5
Reviewed-on: https://dart-review.googlesource.com/c/77860
Auto-Submit: Peter von der Ahé <ahe@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-10-03 12:56:49 +00:00
Peter von der Ahé 82da68f3f5 Move api_signature to package:analyzer 
Change-Id: I5dd66495316bc4b894d0fad791b77a882bb07ade
Reviewed-on: https://dart-review.googlesource.com/c/77822
Auto-Submit: Peter von der Ahé <ahe@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-10-03 12:56:49 +00:00
Peter von der Ahé 829ba8a118 Remove unused file_repository.dart 
Change-Id: I87bb89eb4bce69843e5219b410927e45da73230f
Reviewed-on: https://dart-review.googlesource.com/c/77840
Auto-Submit: Peter von der Ahé <ahe@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-10-03 12:53:54 +00:00
Peter von der Ahé b8cef2cefe Move flat_buffers to package:analyzer 
Change-Id: Ie9e6c8d3c56a17e689f23434a3045c23de59eeee
Reviewed-on: https://dart-review.googlesource.com/c/77821
Auto-Submit: Peter von der Ahé <ahe@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-10-03 12:48:44 +00:00
Peter von der Ahé 27b17c76d8 Remove unused uri_resolver.dart 
Change-Id: Ica49f8446bc57dc9d7bd4d8460231dc9272542c6
Reviewed-on: https://dart-review.googlesource.com/c/77820
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-10-03 12:48:44 +00:00
Peter von der Ahé 29d57107dd Move dependency_walker to package:analyzer 
Change-Id: I9882c2be31366cc85a1623a2b324ce4ec200aa20
Reviewed-on: https://dart-review.googlesource.com/c/77804
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-10-03 12:25:06 +00:00
Peter von der Ahé 440b9c61a7 Handle duplicated declaration used as prefix. 
Fixes https://github.com/dart-lang/sdk/issues/34645

Change-Id: I24842b6146c1e3b38ae0b6561ae0e1bec63db2a9
Reviewed-on: https://dart-review.googlesource.com/c/77802
Auto-Submit: Peter von der Ahé <ahe@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2018-10-03 09:57:14 +00:00
Peter von der Ahé eb0ec965e3 Move codegen/tools.dart to package:analyzer 
Change-Id: Iab61e0dfcdd0969d1bf35e27c13c336a944d14e6
Reviewed-on: https://dart-review.googlesource.com/c/77780
Commit-Queue: Peter von der Ahé <ahe@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-10-03 07:41:43 +00:00
Peter von der Ahé fd9a2cb510 Remove unused stuff 
Change-Id: Id3372bc0d64711438dee3eb5503ee6c809b3d40c
Reviewed-on: https://dart-review.googlesource.com/c/77740
Commit-Queue: Peter von der Ahé <ahe@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
 2018-10-03 06:59:25 +00:00
Peter von der Ahé bc49637085 Convert package:dev_compiler to use onDiagnostic 
Change-Id: I67eaae26c40452dd94c4135e813cfdd89e2fb087
Reviewed-on: https://dart-review.googlesource.com/c/77563
Reviewed-by: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-10-03 06:46:55 +00:00
Peter von der Ahé 44c6312df8 Consolidate VM dependencies on front_end 
Also, convert package:vm to use onDiagnostic.

We're consolidating all dependencies on package:front_end in one file per tool.

The idea is, if you want to depend on something in the package:front_end, you modify pkg/front_end/lib/src/api_unstable/vm.dart and consult with the front-end team.

These consolidated files will help us when designing a public API in the future.

Change-Id: I66bafdd0ae29605fd12f8d6c589dbc761e5c7a97
Reviewed-on: https://dart-review.googlesource.com/c/77581
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-10-03 05:41:30 +00:00
Peter von der Ahé 097e8d86b8 Use context severity when calling onProblem 
Change-Id: Id1aef8c9185e4d1e660cc342d54a12923a890a43
Reviewed-on: https://dart-review.googlesource.com/77060
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
 2018-10-02 17:02:10 +00:00
Peter von der Ahé 002a3e090d Improve error message on unresolved constructor redirections 
Change-Id: Ifd3975becaeeb312a5c3ca12228828ea49a00d2b
Reviewed-on: https://dart-review.googlesource.com/76942
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
 2018-10-02 17:02:10 +00:00
Peter von der Ahé a1ebe68359 Change how compile-time NSM is handled 
Change-Id: I8dc408c1ffec9307e776288a8fb99604c7dedd6b
Reviewed-on: https://dart-review.googlesource.com/76664
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
 2018-10-02 16:53:03 +00:00
Peter von der Ahé 158290349a Reject diagnostics with missing arguments 
That is, arguments that are null or empty.

Change-Id: I9b580f44ed960f2a0270c91fd8c98b9b43c7ceed
Reviewed-on: https://dart-review.googlesource.com/76604
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
 2018-10-02 13:59:20 +00:00
Peter von der Ahé df32b2ae49 Ignore synthetic tokens when compiling bodies 
Change-Id: Id5f6c4158e70f5a444a6baec1374da20f961a4ec
Reviewed-on: https://dart-review.googlesource.com/76603
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
 2018-10-02 13:59:20 +00:00
Peter von der Ahé f3047f1b9c Improve diagnostics with constructor names 
Change-Id: I4065ca11064b7569c869f9ea665c85fd287432ce
Reviewed-on: https://dart-review.googlesource.com/76602
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
 2018-10-02 13:59:20 +00:00
Peter von der Ahé 1972ad92d7 Related information (context) may be null 
Change-Id: Ic4cb0195722c5d5bbb83cd4463f12c0c32e0fc1a
Reviewed-on: https://dart-review.googlesource.com/77561
Commit-Queue: Peter von der Ahé <ahe@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-10-02 12:36:54 +00:00
Peter von der Ahé 248954117a Consolidate dart2js front-end dependencies 
Also, convert dart2js to use onDiagnostic.

Change-Id: Ifdf89349eaf2ebe8cfcd1994712b3d1be2dd4197
Reviewed-on: https://dart-review.googlesource.com/77400
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2018-10-02 12:34:28 +00:00
Peter von der Ahé 4306245660 Address review comments from 63144 and 74640 
Change-Id: I886bdb75902689a9880f9bac78f3d5dd07839fc3
Reviewed-on: https://dart-review.googlesource.com/76943
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
 2018-10-02 08:03:43 +00:00
Peter von der Ahé 645fbc8a3f Add CompilerOptions.onDiagnostic 
Change-Id: I116eb4b3ce03ae50d8b314531e0b463d4fe58649
Reviewed-on: https://dart-review.googlesource.com/77362
Commit-Queue: Peter von der Ahé <ahe@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2018-10-01 13:28:46 +00:00
danrubel a73e0a840a Fix parsing partial named constructor 
Fix https://github.com/dart-lang/sdk/issues/34614

Change-Id: I22d96780a32bc58f83e81c5c9d01c6c4992be581
Reviewed-on: https://dart-review.googlesource.com/77200
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-09-28 19:53:10 +00:00