Brian Wilkerson
6c712f157b
Add a fix to create a mixin
...
Change-Id: Id0f31949a5639a00e884abc61b2cfcb5bc552b44
Reviewed-on: https://dart-review.googlesource.com/75130
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-09-17 12:43:41 +00:00
Brian Wilkerson
a80b13e2f9
Add an assist to convert from a class to a mixin
...
Change-Id: Id47de8ffe8c381973c5a4ca53f7459782e62d37f
Reviewed-on: https://dart-review.googlesource.com/74963
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-09-15 16:12:22 +00:00
Brian Wilkerson
0bb8cbd9cb
Use void in place of Null in analyzer_plugin
...
Change-Id: I21a3d3646c5906256e21fb8d7d71f8433b1b39e9
Reviewed-on: https://dart-review.googlesource.com/69500
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-08-11 15:30:28 +00:00
Konstantin Shcheglov
53a51d17db
Support for optional ImportPrefixGenerator to generate prefixes for new imports.
...
Only one import is generated for each library.
If there is already an import for a library, new prefix is not asked.
If a prefix was generated once, it is not possible to force another
import with a different prefix.
R=brianwilkerson@google.com
Change-Id: I1676a1953002060b5e7155ce90abf87b3bfe270e
Reviewed-on: https://dart-review.googlesource.com/55326
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-05-16 20:15:03 +00:00
Konstantin Shcheglov
d9d7cb12a6
Replace DartFileEditBuilder.importLibraries() with importLibrary().
...
It now returns the text of the URI that will be actually used, so
we can show it in the quick fix message without computing it separately.
R=brianwilkerson@google.com
Change-Id: I16a455d8f6a3c3e3a9c5779c94d654de32992006
Reviewed-on: https://dart-review.googlesource.com/55501
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-05-16 18:46:22 +00:00
Konstantin Shcheglov
d624b8580a
Add DartEditBuilder.writeReference().
...
R=brianwilkerson@google.com
Change-Id: Id8a09c8c53987af49905a4cf6fa6a11b55dbd90c
Reviewed-on: https://dart-review.googlesource.com/54062
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-05-07 19:52:48 +00:00
Konstantin Shcheglov
296ab86012
Revert "Add DartEditBuilder.writeTopLevelElementReference()."
...
This reverts commit 23a1534432 .
Reason for revert: a different API is more suitable.
Original change's description:
> Add DartEditBuilder.writeTopLevelElementReference().
>
> R=brianwilkerson@google.com , paulberry@google.com
>
> Change-Id: Ib1511a91a7f021002e4b2f109cebe82b2814985d
> Reviewed-on: https://dart-review.googlesource.com/53687
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
> Reviewed-by: Paul Berry <paulberry@google.com >
TBR=paulberry@google.com ,scheglov@google.com ,brianwilkerson@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Change-Id: Ia5a8f1976d8ffc21de5672cce3dee73c3297cfcf
Reviewed-on: https://dart-review.googlesource.com/53881
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-05-07 03:50:28 +00:00
Konstantin Shcheglov
23a1534432
Add DartEditBuilder.writeTopLevelElementReference().
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: Ib1511a91a7f021002e4b2f109cebe82b2814985d
Reviewed-on: https://dart-review.googlesource.com/53687
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2018-05-04 16:37:26 +00:00
Konstantin Shcheglov
b4a2259b5f
Enhance DartEditBuilder.writeConstructorDeclaration() to support parameter/initializer/bodyWriter.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: If6be2f3e095ae03355c04ea3f6a8524e478c1552
Reviewed-on: https://dart-review.googlesource.com/52989
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-04-30 15:56:19 +00:00
Konstantin Shcheglov
9f0e391e28
Rename writeParameterSource() to writeParameter() and make 'type' optional.
...
R=brianwilkerson@google.com
Change-Id: I0658a642f5877ba2c3e8e69e173fb9cfba4ef719
Reviewed-on: https://dart-review.googlesource.com/47584
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-03-21 21:00:19 +00:00
Brian Wilkerson
3d183f6999
Add support for selection ranges to ChangeBuilder
...
Change-Id: Icd4c1bcf2ecb66020a9a7f478a037c478e8a109f
Reviewed-on: https://dart-review.googlesource.com/42024
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-02-16 19:23:06 +00:00
pq
06614a7b19
Proposed API for optionally building override cc displayText.
...
Change-Id: Ic3ea3317da1220c7d396348ae93e40ab672ecc59
Reviewed-on: https://dart-review.googlesource.com/40500
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-11 18:01:13 +00:00
Konstantin Shcheglov
f6febf35b1
Don't write EOLs before/after new class members.
...
R=brianwilkerson@google.com
Change-Id: Ie70423802985fc762fea2cb55a2936a3e3f3add0
Reviewed-on: https://dart-review.googlesource.com/39851
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-08 00:40:11 +00:00
Brian Wilkerson
740a0e751e
Rework part of DartChangeBuilder to deal better with type parameters (issue 31199)
...
Change-Id: I1946e6070c0dcffaa02f61b9c7f857168a050a27
Reviewed-on: https://dart-review.googlesource.com/38483
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-02-05 18:21:36 +00:00
Brian Wilkerson
d87fcfd233
Correctly update positions when adding edits before them (issue 30444)
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/2997073002 .
2017-08-16 10:29:26 -07:00
Brian Wilkerson
6a7b9f441b
Convert DartChangeBuilder to use AnalysisSession
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2969833002 .
2017-07-03 08:41:40 -07:00
Brian Wilkerson
aadafd1bd5
Use DartEditBuilder to write types and remove dead code
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2972463003 .
2017-07-01 12:03:44 -07:00
Brian Wilkerson
d1bb233f52
Remove timeStamp from the ChangeBuilder API
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2962223002 .
2017-06-29 13:48:46 -07:00
Brian Wilkerson
1e9ae646ff
Clean up some hints
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2939723002 .
2017-06-13 09:24:50 -07:00
Brian Wilkerson
d824acbf71
Update AssistProcessor to use ChangeBuilder
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2928313002 .
2017-06-12 07:28:02 -07:00
Brian Wilkerson
a8919b8237
Support a short-hand way to create linked edit groups
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2928723003 .
2017-06-07 09:07:39 -07:00
Brian Wilkerson
b5c630426c
Update a few more methods in FixProcessor, and fix some bugs in ChangeBuilder
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2916923002 .
2017-06-02 07:36:51 -07:00
Brian Wilkerson
bbe8892c3b
Override ChangeBuilder methods in subclass to specify better type information
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2906373002 .
2017-05-29 17:23:58 -07:00
Brian Wilkerson
3085734ef6
Generate common types into a separate library
...
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2880443006 .
2017-05-13 08:12:14 -07:00
Brian Wilkerson
bef53e72e4
Remove unintentional dependency on analysis_server
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2875323002 .
2017-05-12 10:07:37 -07:00
Brian Wilkerson
6c2023bd07
Move ChangeBuilder to analyzer_plugin
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2860383002 .
2017-05-05 07:52:27 -07:00