dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
59,003 Commits 2 Branches 0 Tags
4db2bbe94deacc8e83eeb3dcef6180234cbd6f54
Commit Graph

6298 Commits

Author SHA1 Message Date
Paul Berry ba5e14b195 Store return type and parameters separately in GenericFunctionTypeElementForLink. 
This will allow us to create a synthetic
GenericFunctionTypeElementForLink representing the function type
defined by an old-style typedef.  That in turn will be necessary to
fix some incompatibilities between the summary linker and element
model representations of typedefs.

Change-Id: Ia3622d58cac25976022bf79a0ac47b190f1f411c
Reviewed-on: https://dart-review.googlesource.com/c/78920
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-10-09 23:09:16 +00:00
Brian Wilkerson ba1b30af37 Add AST support for type arguments on named constructors 
Change-Id: If64ec8db3cf63858ea2ff446118be34cd3c3c203
Reviewed-on: https://dart-review.googlesource.com/c/78870
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-10-09 22:19:16 +00:00
Paul Berry b3af151325 Rework detection of uninstantiated bound errors. 
We now determine whether a type is simply bounded in the summary
linker, so that we can take advantage of the linker's circularity
detection logic.

Fixes #34635.
Fixes #34636.

Change-Id: I6c5040dbaeb79957d8a84e3f76e6a51834b57f05
Reviewed-on: https://dart-review.googlesource.com/c/78867
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-10-09 22:07:02 +00:00
Konstantin Shcheglov f35465dafd Remove DynamicElementImpl.library property. 
R=brianwilkerson@google.com

Change-Id: I2be6a79916639564605ef519a1b55475cb55a36e
Reviewed-on: https://dart-review.googlesource.com/c/78340
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-10-09 20:51:54 +00:00
Konstantin Shcheglov 9cde31ba1d Try interface candidates in reverse order. 
R=brianwilkerson@google.com

Change-Id: I616cdc280299da321834140678d39c28e5ecb614
Reviewed-on: https://dart-review.googlesource.com/c/78711
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-10-09 20:12:46 +00:00
Brian Wilkerson 2cf6ba2996 Generate the right error message for type arguments on a named constructor 
Change-Id: If6e9e943b71b00429c8fc5618f1337e8b7ac46b6
Reviewed-on: https://dart-review.googlesource.com/c/78560
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-10-09 18:38:39 +00:00
Paul Berry 5976fe373f Fix up InferredTypeTest_Driver to use InferredTypeMixin directly. 
This prevents tests marked as failing in InferredTypeTest from being
inherited by InferredTypeTest_Driver.

Change-Id: I4a364cd951dbf2bdf73e0bdda4b5f2630c91ea55
Reviewed-on: https://dart-review.googlesource.com/c/78863
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-10-09 18:25:18 +00:00
Paul Berry 4400df4190 Convert strong_mode_test.dart to triple-slash comment style. 
Change-Id: Iba3ca6bc14269b89e55d36b662f0fa46b6710c5b
Reviewed-on: https://dart-review.googlesource.com/c/78800
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-10-09 17:12:44 +00:00
Danny Tuppeny 3d06427075 Fix MOVE_FILE test paths for Windows 
- Wrap all paths with separators in convertPath() for Windows
- Ensure convertPathForImport does the right thing for relative paths
- Use the correct convertPath for imports/exports/parts

Change-Id: Ie95e41686479f175c9ba661180fdf5ad90b409e8
Reviewed-on: https://dart-review.googlesource.com/c/78740
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
 2018-10-09 15:00:07 +00:00
Paul Berry 219dc1be87 Rework the class hierarchy of StrongModeStaticTypeAnalyzer2Test. 
The tests are moved into a mixin,
StrongModeStaticTypeAnalyzer2TestCases, which both
StrongModeStaticTypeAnalyzer2Test and
StrongModeStaticTypeAnalyzer2Test_Driver apply separately.  This
allows tests to be marked as failing in
StrongModeStaticTypeAnalyzer2Test without affecting
StrongModeStaticTypeAnalyzer2Test_Driver.

Change-Id: Iabd641d5ecf03fd0481baf053e689d68a0e0e7a1
Reviewed-on: https://dart-review.googlesource.com/c/78705
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-10-09 00:45:10 +00:00
Konstantin Shcheglov dd7fec41ec Issue 34693. Use isOverrideSubtypeOf() to check that the implemented member is a valid override of the member from the super-constraint. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/34693
Change-Id: I5dcc576e7494c166cb4539d7694fea0209d49219
Reviewed-on: https://dart-review.googlesource.com/c/78680
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-10-09 00:22:20 +00:00
Mike Fairhurst 7f531b5112 Analyzer: Fix missing errors during (a)sync(*) yield of void. 
Change-Id: Iff1d87862b2f684c0ce36b0f07620f62f2e49a85
Reviewed-on: https://dart-review.googlesource.com/c/78323
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-10-08 22:27:59 +00:00
Paul Berry 28780d34df Convert element.dart to triple-slash comment style. 
Change-Id: I8af3b0fb06f10ffbc1b9fca6489d3e82ea77dcc6
Reviewed-on: https://dart-review.googlesource.com/c/78600
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-10-08 20:22:59 +00:00
Paul Berry 5ea1d2fb20 Convert idl.dart to triple-slash comment style. 
Change-Id: If16a8ea5da0f2cd805d3360e1d70cd19be8066a8
Reviewed-on: https://dart-review.googlesource.com/c/78621
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-10-08 19:04:02 +00:00
Konstantin Shcheglov ca8809fcfa Don't use variableElement.computeConstantValue() in ConstantVisitor. 
...when we are using Analysis Driver.

This method causes switching to the task-model based way of computing
constants. And so filling  SdkAnalysisContext with data. And because
SDK instances are long-lived, we were keeping this data as well.

R=brianwilkerson@google.com

Change-Id: Ie6f4a4ce8a05238b9640aef961af394d64373573
Reviewed-on: https://dart-review.googlesource.com/c/78420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-10-08 16:34:04 +00:00
Konstantin Shcheglov ebf042d599 Null out Completer in _DiscoverAvailableFilesTask. 
It might have caused a memory leak.
It is hard to say - there ware some references from Closure, from
other Closure, and eventually from the _completer.

R=brianwilkerson@google.com

Change-Id: I18c75f48e74e9ae04265170751224261f51ccf76
Reviewed-on: https://dart-review.googlesource.com/c/78322
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-10-05 20:35:12 +00:00
Mike Fairhurst 198b05279b Fix #33599 circular typedef stack overflow. 
Fix #33599 stack overflow for recursive function type parameters

Bug: 33599
Change-Id: I31a14e9f941bfd6bb7c2dba09f671d887e535b2a
Reviewed-on: https://dart-review.googlesource.com/c/76040
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2018-10-05 15:59:42 +00:00
Mike Fairhurst 765b8e2d66 More void cleanup 
Change-Id: I21e23ab6dec654242d049935e2665389e61dd3d7
Reviewed-on: https://dart-review.googlesource.com/c/78189
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-10-05 15:34:31 +00:00
Dan Rubel b6a8e31492 Improve error message when var is used as a type name 
... and Address comments in
https://dart-review.googlesource.com/c/sdk/+/78101

Change-Id: I8b3bc9888185d9802a389baa3f197f9b29927b7f
Reviewed-on: https://dart-review.googlesource.com/c/78103
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-10-05 11:56:26 +00:00
pq 3dcb5d13fd normalize pubspec paths 
Change-Id: Ic56b9e305714e2c9e716b79b26aaf42e37e2a7a3
Reviewed-on: https://dart-review.googlesource.com/c/78144
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2018-10-04 22:08:00 +00:00
danrubel 9c75ab7aa9 More common fasta/analyzer parser error codes 
Change-Id: I49128f2721eac1a96c15a96c823a31376f098126
Reviewed-on: https://dart-review.googlesource.com/c/78102
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-10-04 18:54:55 +00:00
danrubel a712a910cf Revise class and mixin header recovery 
This updates the fasta parser to use the "incorrect" keyword
when "extend" or "on" is used instead of "extends" in a class declaration and
when "extend" or "extends" is used instead of "on" in a mixin declaration.

Change-Id: I6bef3f897e24c3c0100180d2bf9f4d2ec7608eef
Reviewed-on: https://dart-review.googlesource.com/c/78101
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-10-04 18:51:44 +00:00
pq 588b0d1222 make pubspec file path to absolute 
Change-Id: I952c201e9319fd78969429c8e7a5a9d7b59d59e6
Reviewed-on: https://dart-review.googlesource.com/c/78143
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2018-10-04 17:59:40 +00:00
Brian Wilkerson 291f8abff8 More hint cleanup in analyzer 
Change-Id: I44c3d8bc0295cc9dfd760fde26843831378f6c20
Reviewed-on: https://dart-review.googlesource.com/c/78140
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-10-04 16:44:11 +00:00
danrubel def9d4c405 Cleanup endMethod and endFactoryMethod parameter recovery 
This CL moves missing parameter recovery code out of the AstBuilder into
the parser, and adds guard code in the AstBuilder to assert that param is not null.

Change-Id: I8e68194ad3de4b8a4be755f8fa2943344393267a
Reviewed-on: https://dart-review.googlesource.com/c/78000
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-10-04 14:06:27 +00:00
Peter von der Ahé 2a6b566ca2 Move byte store to package:analyzer 
Change-Id: I1fc41cc0b2e2848565a5411d0512a4ca086ab659
Reviewed-on: https://dart-review.googlesource.com/c/77761
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
 2018-10-04 09:15:54 +00:00
Peter von der Ahé 45cb0815bc Move PerformanceLogger to package:analyzer 
Change-Id: I89a60ae9ab639c7907a92976e1eb8007d0f4ee9b
Reviewed-on: https://dart-review.googlesource.com/c/77760
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
 2018-10-04 08:44:43 +00:00
Peter von der Ahé 3a2308f5c2 Move jenkins_smi_hash to package:analyzer 
Change-Id: Ic458da90e5bdb6b3b7fee26088b17dd560ff3a68
Reviewed-on: https://dart-review.googlesource.com/c/77861
Commit-Queue: Peter von der Ahé <ahe@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-10-04 07:43:09 +00:00
Peter von der Ahé 6b547e2683 Convert analyzer to use onDiagnostics 
Change-Id: I224894b47a03c8b5cf48ddd3a125ba09a9a47a23
Reviewed-on: https://dart-review.googlesource.com/c/77842
Commit-Queue: Peter von der Ahé <ahe@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2018-10-04 07:29:34 +00:00
Janice Collins 644342a6e6 Prepare for analyzer 0.33.0 publish. 
Change-Id: Idaf40321b8ba861670f5492bec7697865726b428
Reviewed-on: https://dart-review.googlesource.com/c/77982
Commit-Queue: Janice Collins <jcollins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-10-03 22:36:17 +00:00
Konstantin Shcheglov 1085dd13d1 Use separate 'type index' for mixin, some nodes might be unresolved. 
R=brianwilkerson@google.com

Change-Id: Idf4bde1e4927bd0f1b69d6e0acef2cb97ade0bf9
Reviewed-on: https://dart-review.googlesource.com/c/77940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-10-03 20:26:13 +00:00
Konstantin Shcheglov 3daa63bc4c Revert OverrideVerifier back to the old InheritanceManager. 
This partially reverts https://dart-review.googlesource.com/c/sdk/+/77521

There is still one pre-existing issue, will be fixed later.

R=brianwilkerson@google.com

Change-Id: Ide556a65ef2e46f1621ac60b1b7a32207d804b31
Reviewed-on: https://dart-review.googlesource.com/c/77920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-10-03 19:23:05 +00:00
danrubel ab3ef0914c Allow "yield" as label 
Fix https://github.com/dart-lang/sdk/issues/33672

Change-Id: I1d070fd2fd3901d8159aa760b094398efee8643c
Reviewed-on: https://dart-review.googlesource.com/77501
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-10-03 18:32:07 +00:00
danrubel f529ab10f0 Allow "operator" as a static method name 
Fix https://github.com/dart-lang/sdk/issues/33673

Change-Id: Ia2ec01a3b9cf701f7f85f4891d2fb45f1f01e444
Reviewed-on: https://dart-review.googlesource.com/77500
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-10-03 18:32:07 +00:00
Paul Berry 57f8542ea5 Fix warnings in analyzer package. 
Change-Id: Id2db43c7e7822a912879c742629eeefcdeedd9a9
Reviewed-on: https://dart-review.googlesource.com/77724
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-10-03 17:53:57 +00:00
Paul Berry c57a844841 Characterize behavior of FunctionTypeImpl.forTypedef when typeArguments not provided. 
I believe that in order to fix #34558 I will need to modify how
function types are built for typedefs.  Before doing so, I want to
make sure I fully understand the (flawed) behavior of
FunctionTypeImpl.forTypedef.

See #34657 for more details about how the behavior of forTypedef is
flawed (and how I believe it ought to behave).

Change-Id: I15e981175da46e444425984a70cfda54e9e3749b
Reviewed-on: https://dart-review.googlesource.com/c/77721
Auto-Submit: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-10-03 14:07:37 +00:00
Peter von der Ahé ed42aab273 Move source.dart to package:analyzer 
Change-Id: Ide66d4f69b8588f04967c510eae0a733b4b3f0c5
Reviewed-on: https://dart-review.googlesource.com/c/77860
Auto-Submit: Peter von der Ahé <ahe@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-10-03 12:56:49 +00:00
Peter von der Ahé 82da68f3f5 Move api_signature to package:analyzer 
Change-Id: I5dd66495316bc4b894d0fad791b77a882bb07ade
Reviewed-on: https://dart-review.googlesource.com/c/77822
Auto-Submit: Peter von der Ahé <ahe@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-10-03 12:56:49 +00:00
Peter von der Ahé b8cef2cefe Move flat_buffers to package:analyzer 
Change-Id: Ie9e6c8d3c56a17e689f23434a3045c23de59eeee
Reviewed-on: https://dart-review.googlesource.com/c/77821
Auto-Submit: Peter von der Ahé <ahe@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-10-03 12:48:44 +00:00
Peter von der Ahé 29d57107dd Move dependency_walker to package:analyzer 
Change-Id: I9882c2be31366cc85a1623a2b324ce4ec200aa20
Reviewed-on: https://dart-review.googlesource.com/c/77804
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-10-03 12:25:06 +00:00
Peter von der Ahé eb0ec965e3 Move codegen/tools.dart to package:analyzer 
Change-Id: Iab61e0dfcdd0969d1bf35e27c13c336a944d14e6
Reviewed-on: https://dart-review.googlesource.com/c/77780
Commit-Queue: Peter von der Ahé <ahe@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-10-03 07:41:43 +00:00
Konstantin Shcheglov b628a62aa8 Remove ConstantValueComputer and DirectedGraph. 
We use different graph implementation in Analyzer, CFE has its own.
And ConstantValueComputer is not used in Analyzer or anywhere internally.

R=brianwilkerson@google.com

Change-Id: I1abaca5205fa0af7c50675d2935b0d6f21373b31
Reviewed-on: https://dart-review.googlesource.com/c/77672
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-10-03 01:51:03 +00:00
Paul Berry 621c41f091 Add mixin support to InterfaceTypeImpl.isMoreSpecificThan. 
In the long run we should eliminate the code duplication between
InterfaceTypeImpl.isMoreSpecificThan and TypeSystem.isMoreSpecificThan
(see #34653), but this gets us past the immediate bug.

Fixes #34641.

Change-Id: I0a7935cff7a0d73728a918db7513e46ff73bc984
Reviewed-on: https://dart-review.googlesource.com/c/77676
Auto-Submit: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-10-03 00:01:16 +00:00
Konstantin Shcheglov 80db08809c Pass InheritanceManager2 into resolver, use for BinaryExpression. 
Ideally I think we should not use Expression.staticParameterElement to
get back to the corresponding parameter of the invoked FunctionType,
and do this check directly during resolution.

R=brianwilkerson@google.com

Change-Id: I6dbb5bf63f7eaad7f19b31129319e32dd4455acc
Reviewed-on: https://dart-review.googlesource.com/c/77641
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-10-02 21:48:36 +00:00
Konstantin Shcheglov 3ef994c287 Some clean ups in InheritanceOverrideVerifier. 
R=brianwilkerson@google.com

Change-Id: I326556fb2d7b16fa05daa872a04bdf413bcfce18
Reviewed-on: https://dart-review.googlesource.com/c/77670
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-10-02 21:31:40 +00:00
Konstantin Shcheglov 4df3626d19 Remove support for (non)nullable types from Analyzer. 
R=brianwilkerson@google.com

Change-Id: Ia26c203ed4fa238d1a546fe67e009fa542ed8f82
Reviewed-on: https://dart-review.googlesource.com/77666
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-10-02 20:05:15 +00:00
Brian Wilkerson d2c5a24fd9 Recognize mixins as subtypes of their superclass constraints in hint generation (issue 34633) 
Change-Id: I84b86e998ec353c13b18a460f2a7ca8cb0802204
Reviewed-on: https://dart-review.googlesource.com/77665
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-10-02 19:20:35 +00:00
Brian Wilkerson 72d3798764 Improved completion support for mixins 
Change-Id: I77aea1b03e00725c48458b0e6ee9b1936ea5685c
Reviewed-on: https://dart-review.googlesource.com/c/77661
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-10-02 18:27:33 +00:00
Brian Wilkerson a074a87b25 Convert more analyzer tests to use ResourceProviderMixin 
Change-Id: I0b6d54501a7f52f0b8ae2faa72992cd22dfc6c58
Reviewed-on: https://dart-review.googlesource.com/77600
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-10-02 16:57:43 +00:00
Konstantin Shcheglov b8c831592a Record superInterface and use it for OverrideVerifier. 
R=brianwilkerson@google.com

Change-Id: Ib6fe2b14affc8f8d00c32f123a4b587ae6d8fb56
Reviewed-on: https://dart-review.googlesource.com/77521
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-10-02 14:02:31 +00:00