dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
77,026 Commits 2 Branches 0 Tags
4adebc6d2aa781ac79fc686beae139b00a4db514
Commit Graph

27 Commits

Author SHA1 Message Date
Srujan Gaddam b0d35855d8 [dart:html] Add nullability to node signature 
Closes https://github.com/dart-lang/sdk/issues/41616

When merging interfaces, nullable and non-nullable types
should not be treated as the same. This also fixes some nullability
information that was not included in dart.idl but is part of the
Chromium IDL.

Change-Id: I6e94176d905b63364bc93dc2120d194452cf05f2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144464
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
 2020-04-23 04:56:28 +00:00
Nate Bosch 55f81f2210 Mass format python with yapf 
- Add `.style.yapf` with configuration to use Google style.
- Run `yapf` on all `.py` files in this repo.
- Manually fix one trailing space in a doc string.
- Run `git cl format runtime` to satisfy presubmit.

Change-Id: I7e6bd11e91f07926b9188362599af398551eed79
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111600
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2019-08-05 20:34:31 +00:00
Terry Lucas 9f09ef0af3 - Fixed callback signatures with indexed_db open method to expose VersionChangeEvent and 
Event type parameters instead of dynamic.
- Fixed missing interceptor in dart2js for MutationEvent (even though its deprecated
and should not be used).  The MutationEvent is created when a node is deleted. Enabled
Dart MutationEvent class generation.
- Fixed/re-enabled all indexed_db tests to run and pass successfully.

Stephen please take a look - target in VersionChangeEvent is a final field, per your suggestion,
instead of a getter.  The MutationEvent is returned in the browser and without the MutationEvent
Dart class the error:

     Uncaught TypeError: t1.get$target is not a function


R=vsm@google.com,gabrielchow@google.com,sra@google.com

Change-Id: Ic36aea8c33b4263a32ff9d047ba3e6b979e03b10
Reviewed-on: https://dart-review.googlesource.com/41569
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2018-02-23 14:29:45 +00:00
Harry Terkelsen 1745ba77f5 fix all instances of "the the" 
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/1980573003 .
 2016-05-13 12:38:25 -07:00
Terry Lucas e1a33e9981 Moved ChromiumSubscribeUniform to web_gl 
Fixed to return null if dictionary returned form blink is null
Cleanup up logging/error reporting

TBR=alanknight@google.com,jacobr@google.com

Committed: https://github.com/dart-lang/sdk/commit/01f6e4ed0f8882001e5a308cc8e36dcb62e9b5bc

Review URL: https://codereview.chromium.org/1752983003 .
 2016-03-02 08:15:45 -08:00
Jacob Richman f478562b0a Dartium 45 roll 
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1682783002 .
 2016-02-09 10:50:43 -08:00
terry@google.com 580cb00cbb Added more diag info 
Reviewers=vsm@google.com,alanknight@google.com

R=alanknight@google.com

Review URL: https://codereview.chromium.org//1022483002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44562 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-18 19:22:53 +00:00
terry@google.com 5c84e1b473 Added --examine to produce analysis of IDL files 
Reviewers=vsm@google.com,alan@google.com

R=vsm@google.com

Review URL: https://codereview.chromium.org//1001983003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44467 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-13 15:53:55 +00:00
terry@google.com e0fff4e457 Changes to support roll 39 IDLs 
Reviewers=vsm@google.com,asiva@google.com

Review URL: https://codereview.chromium.org//952133004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44099 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-27 18:10:08 +00:00
terry@google.com 905ee314e0 Starting cleanup 
Reviewers=vsm@google.com,leafp@google.com

R=vsm@google.com

Review URL: https://codereview.chromium.org//609403004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40784 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-29 20:11:59 +00:00
vsm@google.com 94095d64a2 Merge 38 changes to bleeding edge 
TBR=terry@google.com,leafp@google.com
BUG=

Review URL: https://codereview.chromium.org//605083004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40774 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-29 15:56:25 +00:00
vsm@google.com 1c4bb5f363 Revert "Chrome 38 script changes from integration branch" 
This reverts commit r40567.

TBR=leafp@google.com

Review URL: https://codereview.chromium.org//589253002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40570 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-22 21:11:34 +00:00
vsm@google.com 9e25106514 Chrome 38 script changes from integration branch 
TBR=leafp@google.com

Review URL: https://codereview.chromium.org//593853002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40567 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-22 20:45:57 +00:00
vsm@google.com e379d380bc Migrate to Chrome 37 IDL 
This enables terry's new scripts with fixes from vsm and leafp (tested in the dartium_integration branch).

R=leafp@google.com

Review URL: https://codereview.chromium.org//569783002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40219 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-12 21:18:06 +00:00
terry@google.com ddf659197c Reviewers=vsm,leafp 
Fixed emitting problems with default/optional.

R=leafp@google.com, vsm@google.com

Review URL: https://codereview.chromium.org//551713003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40054 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-09 20:59:03 +00:00
terry@google.com ecceb75d35 Begin hookup of Blink IDL parser for dart:* libraries. 
BUG=
R=vsm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39948

Review URL: https://codereview.chromium.org//444743002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40026 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-09 13:18:24 +00:00
terry@google.com ac72bce2f1 "Reverting 39948" 
BUG=

Review URL: https://codereview.chromium.org//554853002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39999 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-08 20:58:19 +00:00
terry@google.com cf0c6a3565 Begin hookup of Blink IDL parser for dart:* libraries. 
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//444743002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39948 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-08 02:33:50 +00:00
vsm@google.com 8f11ff5abd Strip out gcc preprocessor support 
Blink IDL no longer uses #if-style syntax for enabling features.

R=terry@google.com

Review URL: https://codereview.chromium.org//213463003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34447 260f80e4-7a28-3924-810f-c04153c831b5
 2014-03-26 20:22:00 +00:00
whesse@google.com e7afc18bb9 Print more information when Dartium IDL bindings processing fails during build. 
BUG=
R=kustermann@google.com

Review URL: https://codereview.chromium.org//63173005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30053 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-07 16:00:25 +00:00
vsm@google.com 992776552a Fixes for Blink roll. 
TBR=jacobr@google.com,asiva@google.com

Review URL: https://codereview.chromium.org//19820007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25395 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-24 04:46:29 +00:00
podivilov@google.com 44ba9c6d61 Relax feature defines restrictions. 
Checks in fremontcutbuilder don't take into account nested conditions (e.g. PagePopupController.formatMonth).
The check in databasebuilder is too aggressive as we never use conditionals in dart.idl.

R=blois@google.com

Review URL: https://codereview.chromium.org//14767027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22498 260f80e4-7a28-3924-810f-c04153c831b5
 2013-05-08 08:04:25 +00:00
antonm@google.com 7db2784f62 Allow spaces around conditions. 
R=ager@google.com, blois@google.com

Review URL: https://codereview.chromium.org//14049015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21495 260f80e4-7a28-3924-810f-c04153c831b5
 2013-04-15 18:56:06 +00:00
antonm@google.com 4fd23f8c65 Check for conditionals used. 
There should be nor unused conditionals, nor
unknown ones.

R=ager@google.com, blois@google.com

Review URL: https://codereview.chromium.org//13932009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21421 260f80e4-7a28-3924-810f-c04153c831b5
 2013-04-15 08:28:37 +00:00
antonm@google.com 115ff4b40b Map enums to strings. 
R=blois@google.com,podivilov@chromium.org

Review URL: https://codereview.chromium.org//13704011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20984 260f80e4-7a28-3924-810f-c04153c831b5
 2013-04-05 17:00:25 +00:00
antonm@google.com 04082f2d09 Proper support for typedefs. 
And allow them in WebKit IDLs.

R=ager@google.com,blois@gogole.com,podivilov@chromium.org,sra@google.com

Review URL: https://codereview.chromium.org//12313148

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19146 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-27 15:48:26 +00:00
efortuna@google.com 01fb2bbc86 Moved most of html lib generating scripts into tools. 
BUG=

Review URL: https://codereview.chromium.org//11691009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16557 260f80e4-7a28-3924-810f-c04153c831b5
 2012-12-28 22:26:48 +00:00