dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
77,026 Commits 2 Branches 0 Tags
4adebc6d2aa781ac79fc686beae139b00a4db514
Commit Graph

4316 Commits

Author SHA1 Message Date
Michal Terepeta 97093b2594 Watch Bazel generated files for changes 
This introduces a way to see what paths have been searched for by
the `BazelWorkspace` and adds a polling-based watcher to detect
when files generated by Bazel appear (or have changed). This allows
us to re-analyze things automatically instead of, e.g., restarting
the server.

Change-Id: I60eae29b0e4fcc3a91d8d2275c6898e45548ea03
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168649
Commit-Queue: Michal Terepeta <michalt@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-12-09 09:39:19 +00:00
Danny Tuppeny 0fa6674ea9 [Analyzer] Include required-named params in defaultArgumentListString and LSP complete-function-calls 
Change-Id: I8b4c09305df6e868e7447c538be4a3b540aa7e57
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174802
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-12-08 20:47:04 +00:00
Konstantin Shcheglov 993bd8a380 Fix NPE in AddAsync when implicit return type. 
R=brianwilkerson@google.com, pquitslund@google.com

Change-Id: Id684a3c5d93aa353b0ad5a89407378bd3c9522e2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175328
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-12-08 17:43:04 +00:00
Konstantin Shcheglov b3bcf36a8e Fix for crash in EncapsulateField when in extension. 
R=brianwilkerson@google.com, pquitslund@google.com

Change-Id: Ie8b06ad2eea1c4976ca119a39c086cd15faab013
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175330
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-12-08 17:25:40 +00:00
Danny Tuppeny 2f2f9fc5ba [Analyzer] Support completeFunctionCalls for LSP SuggestionSet completions 
Fixes https://github.com/Dart-Code/Dart-Code/issues/2992.

Change-Id: I95ee3735b7f10d9ad06c729c7b5e6aabeee005e0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175251
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-12-07 19:10:38 +00:00
Brian Wilkerson d55dc9c42a Enable code completion in asset paths 
Change-Id: I9f8051f08b011abf74d1d3e7a73d996f501fe9e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175186
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-12-07 16:34:27 +00:00
Lasse R.H. Nielsen 6e29700e16 Update List constructor documentation, deprecate constructor. 
Emphasize that the operation is going away,
and mark constructor as deprecated.

TEST= Refactoring+deprecation only, covered by existing tests.

Change-Id: I82aa044cd2cf7bf347b624371399f44bda8f4a07
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/173261
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
 2020-12-07 16:20:28 +00:00
Konstantin Shcheglov 959f345d5e Another attempt to log more data for getAssists. 
I don't understand what happens - we had catch-all, but still get
these exceptions in crash logs. I'm removing the catch, with a hope
that we will get right exception, with more data.

Change-Id: I9415e52a535d7e2bf77641ed77035ba0d8bd762d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175009
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-12-04 17:18:15 +00:00
Danny Tuppeny 9a82c5447b [Analyzer] Use ${0} for solo-tabstops in LSP snippets 
Fixes https://github.com/Dart-Code/Dart-Code/issues/2975.

Change-Id: I9c4974c9f04fa10565c831672da067f5b0a2d43f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174926
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-12-03 17:51:43 +00:00
Danny Tuppeny c5129a2b12 [Analyzer] Increase version to 1.32.1 and add changelog section 
Fixes https://github.com/dart-lang/sdk/issues/42572

Change-Id: I6d3776b663f8485bf7df4119e68085b275b584bf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174803
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-12-03 17:39:03 +00:00
Danny Tuppeny bb971209d1 [Analyzer] Update to latest version of LSP spec 
Change-Id: I16418caeacad044269fd3d79e28b9b800ce798f1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174804
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-12-02 20:11:08 +00:00
Brian Wilkerson bfac5c3009 Enable the flutter use case tests involving requiredIf and fix a couple of bugs 
Change-Id: I764d64f7df35a6e5fac4232c0f8907ecb15d1c98
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174562
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-12-01 22:28:27 +00:00
Konstantin Shcheglov f6362881d5 Make 'uniqueName' a field in ErrorCode. 
It started as a way to speed up IgnoreValidator, becaus computing
uniqueName as a concatenation of 'runtimeType' and 'name' was expensive.
We solved it in a better way, but I think this change is still useful.

Change-Id: I7d3cb8c91f4ca27a0aa3b93f8572cf12c6757bae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174322
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-12-01 21:41:08 +00:00
Brian Wilkerson 9cd76088ef Consolidate the yaml extensions in one library 
Change-Id: Ide0e02145581c1a77c4af2764821c63a333d9dd1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174520
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-12-01 18:09:35 +00:00
Brian Wilkerson a4dfaeb51c Add support for generating optional named arguments when necessary 
This is needed, for example, when renaming an optional named parameter
when a simple 'renameParameter' isn't sufficient. The existing arguments
need to be preserved.

This also removes the 'statements' style of code template because it
wasn't fully supported and isn't currently needed.

Change-Id: I66035c88fcffef77f7de9eedff4efbaf2720ccb1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174482
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-30 23:57:35 +00:00
Konstantin Shcheglov 9296c0cbdf Re-throw CaughtExceptionWithFiles when an exception during getAssists(). 
There is a surge of ConflictingEditException reported, and I don't
know how to reproduce it. We need more details.

Change-Id: I591d6a0e8337258deaf48b4cc56fa9c2f2557104
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174221
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-28 05:41:16 +00:00
Konstantin Shcheglov b29e1d93c2 Clean up WithNullSafetyMixin in analysis_server. 
Also fixes a bug in DartCompletionRequestImpl.

Change-Id: I5110226da6e238dae8e632972b969b0e1b17c94b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174222
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-11-28 04:56:37 +00:00
Danny Tuppeny 2076989667 [Analyzer] Split LSP completion resolution info into base/sub-classes 
Change-Id: I57f61b8d0467c32562d865de3b87d75995cfb35f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174129
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-27 18:39:05 +00:00
Danny Tuppeny 247b452f81 [Analyzer] Provide resourceProvider to YAML completion producers 
Change-Id: Ida7ba7d542975568d1b1c054a3bc68100cc17b42
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-27 18:09:25 +00:00
Brian Wilkerson 9eb5d7c0bb Remove obsolete services key 
Change-Id: Iefad14d2899f114cc572351384b0bc280cf28aa6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174200
Reviewed-by: Danny Tuppeny <danny@tuppeny.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-27 16:58:45 +00:00
Brian Wilkerson 1f0e6143f8 Add code completion support for the flutter section in pubspec.yaml 
Change-Id: I1097661d4b4ec329cb315ee908d35a9db9baed18
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174160
Reviewed-by: Danny Tuppeny <danny@tuppeny.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-26 21:19:39 +00:00
Brian Wilkerson 59912baaa8 Support comparison of alternate completion models 
This restores the ability to compare completions being computed under
different conditions, though at the moment it requires code changes
rather than being controlled by command-line arguments (largely because
there is only one condition available to be tested).

It also removes an unused getter.

Change-Id: I67d56b8543f33234400fe3289ab14813d01bf8ff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/173640
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-24 15:42:28 +00:00
Danny Tuppeny 7edcd83073 [Analyzer] Re-create progress tokens after each use + fix race 
Change-Id: Ibc6dd59c71d40c5f0127a2881dade13cde8cfd87
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/173271
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-23 11:40:33 +00:00
Danny Tuppeny 4fe5b79c07 [Analyzer] Fix off-by-one error in LSP position -> offset calculation 
Fixes https://github.com/dart-lang/sdk/issues/44274.

Change-Id: Ia1e3c0f1037ad26fca9eeef27d4c7ada0a318d55
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/173270
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-11-21 16:29:23 +00:00
Devon Carew fe859d499f [analysis server] remove the angular dart plugin specific crash reporting 
Change-Id: Ibc187ddf60ff016f216ce90b2f62de1dafcc34bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/173364
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2020-11-21 02:43:24 +00:00
Sam Rawlins 19a96e4d5e Analyzer: override element type in ExportDirective and ImportDirective 
This reduces the number of explicit casts needed for null safety.

Change-Id: I8ad0ab9cddbbe81e5fbf66b95ae4ae1cb57efebc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172743
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-11-20 15:22:46 +00:00
Danny Tuppeny db263169e5 [Analyzer] Enable code completion for YAML files in LSP 
Change-Id: I13a6fe43f7b822b9c88fd0e1ca69091f82d70119
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/173000
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-11-19 15:40:44 +00:00
Danny Tuppeny 732305f11e [Analyzer] Don't show duplicate LSP code actions on same line 
Fixes https://github.com/Dart-Code/Dart-Code/issues/2960.

Change-Id: I63361728e80c7db843db9e2b31e76eae78f85400
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172562
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-19 10:55:33 +00:00
Danny Tuppeny 3bf25c6c40 [Analyzer] Support fix-all-for-file in LSP code fixes 
Change-Id: Ic3628ee80c409feab178e237bccc5054501549e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172400
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-19 10:44:13 +00:00
Devon Carew 289bc8ce38 [analysis_server] rename and re-word analysis server CLI flags 
Change-Id: If8084297b82596794500ee95f4683747152b7bb0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172660
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-18 02:16:29 +00:00
pq 29a9fe27d2 bulk fix details server protocol 
Change-Id: Id96fd8508018159959448c383baa53ad69b5828f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172621
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-17 21:45:28 +00:00
pq f0c9321b14 bulk fix change mapping 
Striving to do the "simplest thing that could possibly work" this may just be a conversation starter.


Change-Id: Id3deab6fd1541febbc090c696352563e6b5ce932
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172460
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-17 00:45:30 +00:00
pq 5e9454cbbf infer set type from invocation expressions 
Fixes: https://github.com/dart-lang/sdk/issues/44199

Change-Id: I61b76fdcd65fae180d3a1cc1926fe26d2e90ae49
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172340
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-11-16 19:23:06 +00:00
Devon Carew 8bf0f4ed8c [analysis_server] remove the custom args parser 
Change-Id: I2c7bfd290bd12d3b608f4b3628ec31a0ea522157
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171961
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2020-11-16 18:32:08 +00:00
Brian Wilkerson 25ff121c41 Offer to add async when a function should returns Future<void> but does not include a return statement 
Bug: https://github.com/dart-lang/sdk/issues/43726
Change-Id: I8d44c8aa10cdd9af4391126b61a691a6a544a441
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172028
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-11-16 16:28:15 +00:00
Brian Wilkerson c88f99b0b7 Initial support for code completion in yaml files 
Change-Id: I21276fe32d1c0d8525980edf3b1a5e93de5ae572
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172024
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2020-11-16 16:26:36 +00:00
Devon Carew f5e26456bf Remove the --completion-model flag from the analysis server. 
Change-Id: I6bedbb0b5c4b8bedba18d2e3b788db0a9686f6df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172026
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-16 03:31:18 +00:00
Brian Wilkerson c3f96e863f Remove uses of useNewRelevance and clean up associated code 
Change-Id: I04dd3b33d229348042609c5a656d1ad68a95913d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172120
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-11-15 00:18:07 +00:00
Devon Carew 94fa3c89c7 [analysis_server] remove the analysis server's --use-new-relevance flag 
Change-Id: Ia7a182e11fbe62ba2814e56c59804b14b70f88cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172083
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2020-11-14 03:00:16 +00:00
Devon Carew 5a649b22e9 [analysis_server] re-order the server's command line flags 
Change-Id: I9a8295f302683c77cdbecd587ae9c546111838a8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172080
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2020-11-14 00:25:34 +00:00
Brian Wilkerson 9c334a8f3c Support conditional change lists for data-driven fixes 
Change-Id: I2e2c383fc2e8c1b101dec90f81486c4e63038911
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172061
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-13 21:50:05 +00:00
Devon Carew 4a7aad370f rename DartUnitHighlightsComputer2 to DartUnitHighlightsComputer 
Change-Id: I08f15cfbba260dddc1e87f0a91d823df04214e49
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171800
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2020-11-12 23:12:15 +00:00
Devon Carew 2ba123b86e [analysis server] remove the --file-read-mode cli option for the analysis server 
Change-Id: I279233cd0b7ec09a7d2fdcd50837552f56f2584d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171763
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2020-11-12 21:42:50 +00:00
Brian Wilkerson 601a8883d2 Allow variables to be declared in templates 
While this would allow some variabless to be deduplicated, the real
purpose is to support conditional change lists, which will be added in
the next CL.

Change-Id: I8692b8620e04533d3db0c385964567d629317d6c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171741
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-12 19:10:09 +00:00
Devon Carew 2f9cb8e81b Remove support for v1 of analysis highlighting. 
Change-Id: I65bc645de9565628d82d1ff969616f3e38582275
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171682
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-12 18:36:19 +00:00
Brian Wilkerson 08312459f3 Fix a bug in the convert_to_null_aware assist/fix 
Bug: https://github.com/dart-lang/sdk/issues/44173
Change-Id: I3b09732fe79577fc394b41a18d58fa8627be5eae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171703
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-12 17:48:17 +00:00
Danny Tuppeny 44e680ac53 [Analyzer] Add LSP support for Format Selection/Range 
Fixes https://github.com/Dart-Code/Dart-Code/issues/812.

Change-Id: I099654483f3799344d68640b4d00df88e6bbca01
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171722
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-12 16:20:36 +00:00
Danny Tuppeny a36f85b5e6 [Analyzer] Generate minimal edits when formatting files using LSP 
Fixes https://github.com/Dart-Code/Dart-Code/issues/1626

Change-Id: Id36a86df736ed7d31320abfd2acf1118be3f600b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171590
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-12 16:20:36 +00:00
Brian Wilkerson 813b0d029a Rename a parse method and make it consistent with newer methods 
Change-Id: I3cde98229649557eb32a291afeab7558943cf140
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171631
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-11-12 06:20:56 +00:00
pq c84ada0fd4 be aware of cascades when scraping type params for var replacement 
Fixes: https://github.com/dart-lang/sdk/issues/44156

Change-Id: I5ceb69d4a3fa4bbc68cdb7af2f9eb065ac8ae0f4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171627
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-11-11 21:08:29 +00:00