453647022f
[analysis_server] Don't fail on invalid/complex setters in LSP code completion
...
Fixes https://github.com/dart-lang/sdk/issues/52050 .
Change-Id: I6cf5420d5e017b501481cb436a7d1b17f46c0e44
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/295542
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2023-04-17 17:11:03 +00:00
b78d89ce0c
Fix DynamicTypeImpl to InterfaceTypeImpl cast exception in AddTypeAnnotation, when ambiguous SetOrMapLiteral.
...
Saw it in crash logs.
Change-Id: I631e4da816b689ec017f44ecd2a5dc70122ceec1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/295501
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2023-04-17 16:34:37 +00:00
36caf084b9
Issue 51953. Quick fix for ParserErrorCode.DEFAULT_IN_SWITCH_EXPRESSION
...
Bug: https://github.com/dart-lang/sdk/issues/51953
Change-Id: I21d7abdda8b7197cffb87a359c97f12e54cf427a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/295390
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2023-04-14 21:15:18 +00:00
cae0bfa66f
assist to destructure local record variable assignments
...
First, basic cut.
See: https://github.com/dart-lang/sdk/issues/52025
Change-Id: I3388f5ec96a45211669e3ac8a5975ff39feea4bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/295381
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2023-04-14 21:04:20 +00:00
90c434254f
Add support for patterns for Add type quick fix
...
Bug: 51866
Change-Id: Id38d0c8405931cad057ec3db1e0c0e3d297d7b4c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/294880
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
2023-04-14 20:09:52 +00:00
0d6067232b
Issue 51980. Reduce relevance of 'break' inside 'switch'.
...
Bug: https://github.com/dart-lang/sdk/issues/51980
Change-Id: Ic3a365c85a36a18739b20482c8c7c136210b12b6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/295387
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2023-04-14 19:37:38 +00:00
1925041a31
Issue 52019. Late instance field is not a static context.
...
Bug: https://github.com/dart-lang/sdk/issues/52019
Change-Id: I6416a2e65c93b08ad145c2e64129873ae414ccfb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/295383
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2023-04-14 17:58:24 +00:00
9a6b637444
Issue 51989. Add 'Convert to switch statement' assist.
...
Bug: https://github.com/dart-lang/sdk/issues/51989
Change-Id: I297cbc077604d0c750dc0d78d8480b33852f3a64
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/295201
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2023-04-14 17:19:25 +00:00
a42a163f3b
[analysis_server] Handle missing null in missing enum case fix
...
When switching over a nullable expression, the `null` value should also
be handled for exhaustiveness.
The analyzer reports a lint for missing nulls, but the correction
producer was unable to fix the problem as it only adds missing enum
constants.
This change makes the fix producer add missing null cases.
Change-Id: I92065b36b6a370d5165e302d84391568894c5dc5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/294981
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2023-04-13 21:55:57 +00:00
63fd5aa364
Issue 52014. Make an implicit name of a named PatternField explicit when the pattern variable is renamed.
...
Bug: https://github.com/dart-lang/sdk/issues/52014
Change-Id: Ifcc8ba255cb536cba11360ef4326525c1e037b44
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/295101
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2023-04-13 21:02:37 +00:00
2f30f88916
Mark deprecated Hints with Warning aliases as deprecated
...
This will help with any references to deprecated Hints in other
codebases, like nnbd_migraion or linter...
Change-Id: Iccd43d8e3113e6e3e0e458bf959c7f4d48185f35
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/294182
Reviewed-by: Nate Bosch <nbosch@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2023-04-13 20:07:36 +00:00
f70238a83b
Issue 52015. Extract local variable into SwitchCase / SwitchPatternCase.
...
Bug: https://github.com/dart-lang/sdk/issues/52015
Change-Id: I069ecfbd2be5375bdba9977872bc9e0c88431f62
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/295100
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2023-04-13 19:18:38 +00:00
05965ef720
+ fix dangling library comments
...
Change-Id: Ia857fec46ddf83d307cd19450cea88aab8c86a38
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/294430
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2023-04-11 20:17:38 +00:00
68ef7530d7
switch expression conversions (and unnecessary breaks removed)
...
All auto-converted. A bunch more will be convertible when we address: https://github.com/dart-lang/sdk/issues/52005
EDIT: updated w/ 64 fewer breaks
Change-Id: I9b6009e316341e7c9b9c2f2c651b6eada385960d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/294423
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2023-04-11 19:56:05 +00:00
9a6335fe14
Add "Unwrap 'if' body" assist.
...
Sometimes I realize that the `if` statement is not necessary, and
want to replace it with its `then` statement. With this Quick Assist
we can make the change without temporarily unbalancing `{` and `}`.
Change-Id: Icab454ad21e4babaada3cf58a4a3cccdb84c2ebe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/294283
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2023-04-10 23:51:55 +00:00
b603d4c4ac
[deps] rev tools, web_socket_channel, webdev
...
Revisions updated by `dart tools/rev_sdk_deps.dart`.
tools (https://github.com/dart-lang/tools/compare/cd799be..58d9147 ):
58d9147 2023-04-07 Christopher Fujino [unified_analytics] Add NoOpAnalytics (#77 )
web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/40eb236..b28bae6 ):
b28bae6 2023-04-07 Rexios Allow passing through custom http client in IO socket connect (#259 )
1064b47 2023-04-07 Nate Bosch Fix deprecated_new_in_comment_reference (#262 )
webdev (https://github.com/dart-lang/webdev/compare/22b34e3..7546291 ):
75462913 2023-04-07 Elliott Brooks Run mono_repo generate (#2081 )
9964ebab 2023-04-07 dependabot[bot] Bump actions/labeler from 4.0.2 to 4.0.3 (#2067 )
3dee56b5 2023-04-07 Anna Gringauze Remove eval error message on async frames (#2073 )
d6b3e9ce 2023-04-07 Elliott Brooks Dart Code Metrics follow-up (#2072 )
48e3211a 2023-04-07 Elliott Brooks Update the release script to take into account `pubspec_overrides.yaml` (#2080 )
fd75f511 2023-04-06 Elliott Brooks Reset Webdev to 3.0.5-dev (#2077 )
Change-Id: Iac863f7c4822fe6b9585e80e95d69467e8d60b6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/294364
Reviewed-by: Nate Bosch <nbosch@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
Auto-Submit: Devon Carew <devoncarew@google.com >
2023-04-10 17:44:36 +00:00
cf8aaebc4a
[analysis_server] Prevent colon from automatically triggering completion in switch statements
...
See https://github.com/dart-lang/sdk/issues/51980 .
Change-Id: I66d52018f22442241a3203c08e3a58d5f1c2fbff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/294300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2023-04-08 16:17:20 +00:00
b1c0f16a51
Issue 51961. Suggest getter names inside pattern of named PatternField without name, inside RecordPattern.
...
Bug: https://github.com/dart-lang/sdk/issues/51961
Change-Id: I33b499829887dc221c2d18fe4586ec08207c026f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/293863
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2023-04-06 19:55:08 +00:00
da1898e0c7
[analysis_server] Prevent "dart fix" prompts if do-not-show preferences cannot be persisted
...
See https://github.com/dart-lang/sdk/issues/51968 .
Change-Id: I67e0a85f171b9ff5c508063458fc92491c8e5c70
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/294000
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2023-04-06 15:59:07 +00:00
7ba94c9202
Issue 51961. Suggest getter names inside pattern of named PatternField without name, inside ObjectPattern.
...
Bug: https://github.com/dart-lang/sdk/issues/51961
Change-Id: Ibd6f762f4e363f26daaca21515a9c23c748f8cc9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/293901
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2023-04-05 22:47:19 +00:00
b6cf3f9c22
Fix npe in UserPromptPreferences
...
Bug: https://github.com/dart-lang/sdk/issues/51968
Change-Id: I7bcaee7266b6c39ca21e11d3cc5e4eed94981294
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/293920
Reviewed-by: Jacob Richman <jacobr@google.com >
Commit-Queue: Janice Collins <jcollins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2023-04-05 22:31:06 +00:00
2427527612
Suggest type names during completion in CaseClause and SwitchExpression body.
...
Change-Id: Iea7c2c3d0879191265c368b5e79fbf2cfaab0dd0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/293821
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2023-04-05 20:48:24 +00:00
006c60690e
Increase timeout for SelectionCoverageTest.
...
Change-Id: Ic1e88478b500f87744dec64f3990f2681351a178
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/293742
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2023-04-05 18:34:08 +00:00
a02f252ef1
Revert "Add support for patterns for Add type quick fix"
...
This reverts commit f4773e49c0https://dart-review.googlesource.com/c/sdk/+/293460
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Bug: 51866
Change-Id: I5d1f933fa7b88495f941b30001873c33206975f0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/293820
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Auto-Submit: Keerti Parthasarathy <keertip@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2023-04-05 18:13:37 +00:00
f4773e49c0
Add support for patterns for Add type quick fix
...
Bug:51866
Change-Id: I42d4443c38fc7708a2b174a80b689adfc0a37aaa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/293460
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2023-04-05 17:53:59 +00:00
b565a2f4c7
[analysis_server] Fix code completion for mixin declarations and class
...
declarations with class modifiers.
Fixes what modifiers are suggested considering you can only use 'base'
on mixins and mixin classes.
Also fixes some existing bugs with classes suggesting 'sealed' after
'abstract'.
Change-Id: I3fcd1470dc015cb0c9c1c358041ca226aa298dc8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/293340
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Kallen Tu <kallentu@google.com >
2023-04-05 16:05:35 +00:00
23b73d7ca4
ignore unreachable constructors in reflective tests
...
These were flagged as unused by `unreachable_from_main` but they are
used by `dart:mirrors`.
Change-Id: I3637b4b234f0bf7fe795977cb7ec6a1ca5449810
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/293006
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2023-04-04 21:37:18 +00:00
784998da98
Fix for EXPECTED_TOKEN, replace ':' with '=>' in SwitchExpressionCase.
...
Change-Id: I38080d8ec445bb6466c26c0233ac6dc719ba6f40
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/293084
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2023-04-04 19:14:25 +00:00
c399536c3f
Remove print() from getProcessUsage() test.
...
Change-Id: I0209e96e933713fa04e87f7c41e4be19b81c4001
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/293163
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2023-04-04 16:15:39 +00:00
b7fbf1e4b2
[analysis_server] Fix completion snippet context for inside enum declarations
...
Previously we'd fail to match anything here and end up using "top level", showing snippets for creating classes. This adds enums to "inClass" showing things like "function" snippets.
I didn't split class/enums because right now we don't have any snippets that would differ, though we might want to do this if that changes.
Fixes https://github.com/Dart-Code/Dart-Code/issues/4473 .
Change-Id: I67c8e2a67698fb15136cba68b63549acf29ee596
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/292884
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2023-04-04 15:08:41 +00:00
5c5f4ef65e
Add a timer to send analytics data periodically.
...
Change-Id: Iaf58e3b7f45868579892ded8c005843d2f45b443
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289402
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
2023-04-04 03:27:27 +00:00
525376cc88
Fix ConvertToSwitchExpression when SwitchStatement is empty.
...
Change-Id: Id7ab8319ff5a9e41b353ed1363ce0d5159fe4ff2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/292984
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2023-04-03 23:44:48 +00:00
4cb8bd0c37
Issue 51931. Fix for LATE_PATTERN_VARIABLE_DECLARATION.
...
Bug: https://github.com/dart-lang/sdk/issues/51931
Change-Id: I2b3c42389a5184086e66a1fc35c045d2581a2d8b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/293004
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2023-04-03 22:35:58 +00:00
40973edbb5
Handle type arguments when replacing an empty map pattern
...
Change-Id: I4c917d60d93a316459f2478cc21a7845af46781b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/292920
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2023-04-03 21:02:18 +00:00
aa1f415e4f
Add a fix for invalid_inside_unary_pattern
...
Closes 51915
Change-Id: I378f66d70c083dd5852a9c8a04e3ddf59aff66d7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/292981
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2023-04-03 20:56:10 +00:00
db0dfec609
Issue 51893. Report PATTERN_NEVER_MATCHES_VALUE_TYPE in some cases.
...
Bug: https://github.com/dart-lang/sdk/issues/51893
Change-Id: Ia7582df3942a077e81f0343e83359c303d152b1b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/292420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2023-04-03 20:31:45 +00:00
bb85a2d183
Fix for UNNECESSARY_WILDCARD_PATTERN
...
Change-Id: I0afbfdf60d03019b781b6634623565b6b2477dda
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/292980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2023-04-03 20:18:25 +00:00
7f9ec2513a
Fix for LintNames.type_literal_in_constant_pattern
...
Change-Id: I44bc36da4176f6e7cca74b7d0273807734b31a59
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/292921
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2023-04-03 19:51:52 +00:00
fabe2af5e3
Issue 51762. Update CompletionResponsePrinter sorting.
...
Bug: https://github.com/dart-lang/sdk/issues/51762
Change-Id: I46019bea72ac1656c97acb9da88da7dc577d8ef5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/292640
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2023-04-03 19:07:34 +00:00
f1007d4aa2
[analysis_server] Prevent switch-expression snippets showing up in patterns
...
+ don't assume a semicolon on the end of a switch expression.
Change-Id: Ie141996bc79e3764c70dea66f570ca17046eecdf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/292880
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2023-04-03 17:34:41 +00:00
30a8b2ee4b
Use raw strings for assertResponse() that don't do any interpolation.
...
We use this pattern to find expectations to update.
Change-Id: Ibae370cfdf85dd83122b5571f3a05d86355c647f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/290344
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2023-04-02 00:33:28 +00:00
40fd297793
Extend MakeFinal to support pattern variable declarations
...
Fixes 51872
Change-Id: I517eddd8c716ae14a023d483d03c29e99d2d8ebb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/292400
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2023-03-31 23:37:52 +00:00
39c9220927
Add a fix to replace an empty map pattern
...
Change-Id: If4544e6f33d96ad9e5a8790de1211a15befc64b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/292284
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2023-03-31 16:30:22 +00:00
386db23227
Add support for patterns to replace null assert with cast fix
...
Bug: 51880
Change-Id: I3b4bebefdb1122531ec9070ed70a15933d06dd70
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/292100
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
2023-03-31 14:48:50 +00:00
2828256821
If verify_error_fix_status_test fails, output the status file path.
...
This will save me a lot of time because I keep forgetting where the
status file is.
Change-Id: I3ab6ad59f66c4e84515bad3a6b7689b6b47ecddf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/292283
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2023-03-31 14:40:47 +00:00
5fda05d041
Add support for patterns to RemoveQuestionMark fix.
...
Bug: 51885
Change-Id: I11cbba03c73ef380ea2bba2db4d6c9267dbb803c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/292123
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2023-03-30 22:06:04 +00:00
2ff94f8882
[analysis_server] Allow action in response to showMessageRequest to be null
...
This allows for users to dismiss a notification without taking any action (something that VS Code / LSP allows for but this API did not).
Change-Id: Icf384008cfcfde6f150c63d3f2889e81e79d1dc1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/292080
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2023-03-30 19:48:18 +00:00
f7bc72fce6
[analyzer/cfe] Remove interface mixin, final mixin and sealed mixin.
...
Added error messages for when users try to use invalid mixins + a language test that tests that (and tests in each of the front ends).
Removed the tokens from the parser listeners.
Removed all behaviours and error reporting related to these invalid mixins.
Change-Id: I558595826dae7e2c176bd1929e97caa2335c167c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/290614
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Kallen Tu <kallentu@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2023-03-30 11:56:08 +00:00
cb4761f6e8
support "effectively exhaustive" switch statement conversions
...
Fixes: https://github.com/dart-lang/sdk/issues/51884
Change-Id: Ia3f63e9c469035be4047647c75b956332f7b7909
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/291880
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2023-03-29 21:55:07 +00:00
76761576a2
[analysis_server] Move "dart fix" prompt into base server for use by both protocols
...
Change-Id: I5abc6172b1cdb83c855064eb5a7b81a5d4930c07
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/291823
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2023-03-29 20:50:37 +00:00
Danny Tuppeny