93c361dd36
This is an updated version of https://codereview.chromium.org/16374007/
...
Original submission is the first patch, fixes are the second.
There were two issues with the original-
- Issue with URI sanitization where relative URIs on IE were being dropped.
- Analyzer issue on missing members for CustomElement.
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//23525003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26757 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 01:03:01 +00:00
24e9f22c90
Revert "First rev of Safe DOM"
...
This reverts commit 26681.
Some IE issues with URL validation that I need to investigate further.
BUG=
Review URL: https://codereview.chromium.org//23523002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26682 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 02:18:48 +00:00
63ecf1a3fd
First rev of Safe DOM
...
BUG=
R=jacobr@google.com , jmesserly@google.com
Review URL: https://codereview.chromium.org//16374007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26681 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 01:48:13 +00:00
90873051ad
Making almost all dom_ methods private. Exceptions will be addressed in a later CL.
...
Current ones that still remain to be made private include createElement(NS),
createRange, all the Element properties, and childNodes.
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//23055008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26605 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-23 18:25:40 +00:00
4f6536ba66
Use new Dart API functions
...
Dart_GetNativeIntegerArgument
Dart_GetNativeBooleanArgument
Dart_GetNativeDoubleArgument
R=vsm@google.com
Review URL: https://codereview.chromium.org//22859038
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26500 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-22 01:15:58 +00:00
0820807ae6
Fixing dart2js codesize regression from blink roll.
...
New ErrorEvent.error was pulling in everything.
BUG=
R=sra@google.com
Review URL: https://codereview.chromium.org//22986022
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26468 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 20:27:54 +00:00
ec11e52f62
Revert "Revert "Adding polyfill support for custom elements.""
...
This fixes the issues in the custom elements polyfills.
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//23301012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26412 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 00:08:46 +00:00
508affefed
Revert "Adding polyfill support for custom elements."
...
Caused issues with DocumentFragment and some lingering changes from the blink roll.
BUG=
Review URL: https://codereview.chromium.org//22957010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26410 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 23:28:22 +00:00
72651260aa
Adding polyfill support for custom elements.
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//22967006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26405 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 22:56:08 +00:00
69bea8b4e8
Suppress getPresentationAttribute
...
Should fix analyzer bot.
TBR=jacobr@google.com ,blois@google.com
Review URL: https://codereview.chromium.org//23004006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26364 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 16:19:05 +00:00
339b0bdd70
Attempt to land Dartium roll a second time.
...
BUG=
Review URL: https://codereview.chromium.org//23064024
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26363 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 15:54:49 +00:00
c6ebe4e4e0
rollback problem blink merge cl
...
Review URL: https://codereview.chromium.org//23163010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26339 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 06:22:24 +00:00
785c8416bc
Changes required for Dartium roll
...
Merge checkpoint. Everything compiles.
BUG=
Review URL: https://codereview.chromium.org//22886009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26335 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 01:50:17 +00:00
24c3ca0b47
Fix for issue 12489.
...
R=vsm@google.com
Review URL: https://codereview.chromium.org//23295016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26327 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-19 20:44:33 +00:00
7c85f03cc9
Move _HTMLElement to HtmlElement
...
The old HtmlElement is now HtmlHtmlElement. The custom tests don't break for now. I'll modify them in a separate CL to inherit from HtmlElement instead.
R=blois@google.com
Review URL: https://codereview.chromium.org//23151005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26248 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-16 00:46:10 +00:00
5aa944301a
Update dart:chrome to include fileSystem, and update summary docs.
...
The dart:chrome library already includes the file system module but
this wasn't included properly at the top level of the API object,
making it unavailable.
The documentation from the generator included in the API has also
been updated.
BUG=None
R=blois@google.com , kathyw@google.com
Review URL: https://codereview.chromium.org//23202004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26241 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-15 23:27:37 +00:00
f010ffa98d
- Add a new toNative which accepts Dart_NativeArguments as a parameter.
...
Currently it is implemented as two calls to the API to get at the native
wrapper (will be made one call in another CL).
- Use the new API call Dart_SetWeakHandleReturnValue to return a string
from the cache directly without having to call Dart_NewHandle(...)
R=vsm@google.com
Review URL: https://codereview.chromium.org//22694004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26148 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-14 20:45:40 +00:00
affaf4c2df
Renaming Crypto's new horribly generic class 'Key' to CryptoKey.
...
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//21929004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26142 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-14 19:54:44 +00:00
4d51b41ff8
Initial Dartium custom element support
...
This will need to be rebased with Stephen's CL or vice versa. The test mod is taken from his CL.
R=blois@google.com
Review URL: https://codereview.chromium.org//22912004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26141 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-14 19:47:07 +00:00
59c29150b4
Removing overloaded operations in dart2js.
...
BUG=
R=sra@google.com
Review URL: https://codereview.chromium.org//22933003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26041 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-12 22:23:42 +00:00
3304c64b52
Make includeAncestors match a separate method.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//22305005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25979 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-09 20:41:48 +00:00
9fdbcf176c
Add includeAncestors to dartium matches call.
...
BUG=
Review URL: https://codereview.chromium.org//22529004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25975 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-09 20:21:50 +00:00
8963a49505
Event delegation
...
Fix for https://code.google.com/p/dart/issues/detail?id=6270
BUG=
R=blois@google.com , jmesserly@google.com
Review URL: https://codereview.chromium.org//21607003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25969 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-09 17:37:32 +00:00
cd7a678e83
Use DartExceptionState
...
R=blois@google.com
Review URL: https://codereview.chromium.org//22605010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25953 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-08 22:56:57 +00:00
f58ea07d46
EventTargets should be EventTargets
...
systemnative.py keys off the ext_attr. Recent IDL changes removed the EventTarget attribute however.
Types marked with isEventTarget are handled specially during GC.
R=jacobr@google.com
Review URL: https://codereview.chromium.org//22507005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25947 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-08 21:18:13 +00:00
68b7394e53
Treat EventTarget as a secondary superclass
...
This matches the C++. It's brittle, but it's not clear how to get
this out of idl right now.
R=blois@google.com
Review URL: https://codereview.chromium.org//22594012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25906 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-07 22:15:10 +00:00
2b37129071
Fixing polyfill for Element.createShadowRoot.
...
Chrome roll changed it from webkitCreateShadowRoot to createShadowRoot, polyfills need to be updated. This change should probably be reverted once everyone adapts to the new API.
TBR
BUG=
Review URL: https://codereview.chromium.org//22513002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25851 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-07 01:32:58 +00:00
0094164ae8
Regenerating DOM types from IDL roll.
...
TBR=vsm
BUG=
Review URL: https://codereview.chromium.org//22352004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25849 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-07 00:57:08 +00:00
abb3ca866b
Do not generate calls to Dart_EnterScope/Dart_ExitScope around native
...
callbacks as an ApiLocalScope is auto created by the VM when making
external native calls.
R=vsm@google.com
Review URL: https://codereview.chromium.org//22392006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25846 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-06 23:57:50 +00:00
c5dd3d3ba7
MERGE: 152953-155080
...
TBR=jacobr@google.com ,blois@google.com
Review URL: https://codereview.chromium.org//22357003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25832 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-06 21:17:56 +00:00
7376bf6cf2
Alter the native code generator to directly use
...
Dart_SetBooleanReturnValue
Dart_SetIntReturnValue
Dart_SetDoubleReturnValue
instead of
Dart_Handle retval = toDart(...); // Calls Dart_Boolean, Dart_NewInteger,
// Dart_Double.
Dart_SetReturnValue(args, retval);
R=vsm@google.com
Review URL: https://codereview.chromium.org//21156011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25698 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-01 00:58:22 +00:00
1311f1d755
Fixing WebGLLoseContext on Firefox.
...
BUG=11874
R=efortuna@google.com
Review URL: https://codereview.chromium.org//21287002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25697 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-01 00:35:25 +00:00
651836e67b
Fixing some SVG collections not working on Dartium.
...
Issue was that we were generating code calling native methods which were not present for these SVG collections.
BUG=11204
R=vsm@google.com
Review URL: https://codereview.chromium.org//21085008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25682 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-31 20:18:42 +00:00
59a514b316
Moving AngleInstancedArrays from dart:html to dart:web_gl.
...
It's a new type which for some reason was added to Canvas rather than with the rest of the WebGL stuff.
BUG=11357
R=efortuna@google.com
Review URL: https://codereview.chromium.org//21297002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25649 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-30 22:26:34 +00:00
c75ffac982
Added shim for scrollX and scrollY for IE 9.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//20385002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25529 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-26 18:09:13 +00:00
9f8be9f84a
Fix Dartium test break
...
I had to revert this line - it's breaking a test on Dartium.
TBR=efortuna@google.com
Review URL: https://codereview.chromium.org//20174003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25460 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-25 01:50:42 +00:00
a439ba51c0
Fix dartium build breakage
...
TBR=efortuna@google.com
Review URL: https://codereview.chromium.org//20214002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25458 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-25 00:47:17 +00:00
28541ed31f
Regenerate dart:html from new Blink IDL files
...
This includes some script updates. See:
https://codereview.chromium.org/19605006
for the IDL roll.
R=efortuna@google.com
Review URL: https://codereview.chromium.org//19789017
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25456 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-25 00:08:44 +00:00
992776552a
Fixes for Blink roll.
...
TBR=jacobr@google.com ,asiva@google.com
Review URL: https://codereview.chromium.org//19820007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25395 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-24 04:46:29 +00:00
1fdd1a34b2
Utility methods used for dartium debugger integration.
...
In addition, added back two DOM methods required by the chrome dev tools that had been removed from dart:html
I'm not thrilled about adding back className but the devtools use className in 495 places so figuring out which places are actually talking about classNames of inspected objects and which ones are just internal uses of className inside the devtools would be a pain.
As the browser has a String "class" attribute I do think it is natural to provide at least a read only className in addition to classes.
This changes goes along with the larger CL
https://codereview.chromium.org/18169002/
which I will be sending out for general review in a little bit.
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//18125007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25032 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-15 22:57:04 +00:00
4fe143407c
Update dart:chrome APIs and include chrome.fileSystem
...
chrome.fileSystem is needed to do integration testing.
BUG=None
R=blois@google.com
Review URL: https://codereview.chromium.org//19090002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24988 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-15 01:09:52 +00:00
2a070f0c72
Add point to Window class and Window polyfills of screen.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//18920008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24987 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-13 00:40:26 +00:00
a9ea9a28ad
Convert decodeAudioData to return a Future.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//19018006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24893 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-10 22:58:33 +00:00
f50bfde69f
Fixing CustomEvent.detail leaks.
...
Basically CustomEvent.detail does no conversion of objects and will pass JS objects through unmodified.
This fix restricts CustomEvent.detail for Dart down to serialized script values, but JS allows anything (which can lead to memory leaks).
With this fix, CustomEvent.detail is essentially handled similar to MessageEvent.data.
BUG=https://code.google.com/p/dart/issues/detail?id=6220
R=vsm@google.com
Review URL: https://codereview.chromium.org//18811006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24884 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-10 20:12:25 +00:00
71d6d11712
Update idlsync.py to work with chrome generator.
...
BUG=None
R=vsm@google.com
Review URL: https://codereview.chromium.org//18855009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24871 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-10 00:29:19 +00:00
875d28e015
Fixing mapping of attribute maps on FireFox.
...
Not sure when/why this broke (most likely FF change), but one of the MDV tests started failing because of it:
http://chromegw.corp.google.com/i/client.dart/builders/dart2js-ff-win7-1-2/builds/5798/steps/dart2js%20tests/logs/stdio
Closest thing I can find in reference to this type refers to it going away in WebKit:
http://trac.webkit.org/changeset/42107
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//18302005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24870 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-10 00:25:30 +00:00
cc9f39dfba
Add back appendBlob and send variants in WebSocket.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//18850007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24854 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-09 17:26:51 +00:00
ad95ee86e2
Make multiple attempts to write binding files to disc
...
Our dartium-win builders are currently flaky on the compile step. Sometimes
we're not able to write the generated dart bindings to disc (we get an IOError:
Permission denied).
This change makes sure we do multiple attempts for writing out the generated
files before we give up. Hopefully we can eliminate this hack as soon as we
found the root cause.
TBR=efortuna@google.com
Review URL: https://codereview.chromium.org//18676003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24772 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-04 11:55:19 +00:00
842b1f41c3
Make type parameter in toDataUrl have an optional default value as per the spec.
...
BUG=
R=amouravski@google.com
Review URL: https://codereview.chromium.org//18500010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24753 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-03 21:19:16 +00:00
5937290e27
Enabling logger information for multiemitter.py and add more debug information
...
TBR=ricow@google.com
Review URL: https://codereview.chromium.org//18326018
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24725 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-03 13:59:13 +00:00
blois@google.com