dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
38,070 Commits 2 Branches 0 Tags
43dc5c223de80888614f1a006d2f8c11d9fb94de
Commit Graph

231 Commits

Author SHA1 Message Date
Brian Wilkerson cbcb689184 Fix the way generated code is made strong mode clean 
R=paulberry@google.com

Review URL: https://codereview.chromium.org/1849973002 .
 2016-03-31 13:43:07 -07:00
Brian Wilkerson 301a6a4725 Fix generated server code to be strong mode compliant 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1852473002 .
 2016-03-31 10:44:42 -07:00
Brian Wilkerson 0d743fbacf Start making server strong mode clean 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1842063003 .
 2016-03-31 08:27:05 -07:00
Brian Wilkerson 8c22a5f807 Format code in analysis_server 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1838933003 .
 2016-03-29 08:27:14 -07:00
pq e7e205f00b Add error codes to server protocol (#25958). 
See: https://github.com/dart-lang/sdk/issues/25958

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1774913006 .
 2016-03-09 10:44:03 -08:00
Dan Rubel 9fe92127e5 update setAnalysisRoots to accept package spec file 
As part of addressing https://github.com/dartino/atom-dartino/issues/13,
this CL updates the setAnalysisRoots API to allow package spec files
in the packageRoots map.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1711353003 .
 2016-02-19 10:57:16 -05:00
Konstantin Shcheglov 7c5e03435b Deprecate UNIT_TEST_GROUP and UNIT_TEST_TEST. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1570003002 .
 2016-01-07 20:03:39 -08:00
William Hesse 634e5a1d02 Refs #25328 Use a portable shebang 
BSD systems don't place bash in /bin and a lot of the dart tools
hardcode a #!/bin/bash shebang that fails the 'all' target build
(not able to execute dart2js since the interpreter is not found).

Solve the issue by using #!/usr/bin/env as the shebang. For scripts
that need to pass arguments to bash modify the script to use the set
command as the first executed line of shell.

BUG=
R=whesse@google.com

Review URL: https://codereview.chromium.org/1552313002 .
 2016-01-05 16:26:28 +01:00
Konstantin Shcheglov 2f0f398c73 Fix lints: unnecessary_brace_in_string_interp 
Also fixes two cases of empty_constructor_bodies.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1521883002 .
 2015-12-13 13:05:00 -08:00
Konstantin Shcheglov 1f5973e24e Explicitly specify that FilePath is not just absolute, but also a normalized path. 
It was implied, and every client I know of uses absolute and normalized paths.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1506323002 .
 2015-12-09 11:30:54 -08:00
pq 2fdcb1bd74 Promote diagnostic.getDiagnostics() (#25061). 
* removes rolling average support
* removes "experimental" tag
* bumps API version

Fixes #25061.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1509033003 .
 2015-12-09 09:29:26 -08:00
pq 43f027fc05 Analysis request getReachableSources (#24893). 
Implements a new request to get reachable sources.

This solves a specific issue for flutter (e.g., inferring execution type by checking the transitive closure of reachabe sources for `dart:flutter`) but can be more generallly useful for other client-side smarts (e.g., "is this a web entry point?" or "is this a test?").

More context here: https://github.com/dart-lang/sdk/issues/24893

R=brianwilkerson@google.com, devoncarew@google.com

Review URL: https://codereview.chromium.org/1491013002 .
 2015-12-02 13:26:35 -08:00
pq c0466f28f5 Rolling average work queue diagnostic (#24933). 
Background: https://github.com/dart-lang/sdk/issues/24933

Salient bits:

* sampling will only start if a client registers interest in diagnostics.
* sampling will stop if clients stop requesting diagnostics.
* sample results are coming back as a string (but a double would be better).
* the mapping of context folders to averages in not garbage collected; since it's only potentially leaking `_Average` objects (and not contexts) when folders are deleted, I think that's fairly benign.

BUG=24933
R=brianwilkerson@google.com, devoncarew@google.com

Review URL: https://codereview.chromium.org/1463923003 .
 2015-11-20 14:24:47 -08:00
pq 6d9cb5e48a Move diagnostics to diagnostics domain (#24931). 
Still flagged `experimental` so no docs created.

See: https://github.com/dart-lang/sdk/issues/24931

BUG=24931
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1453433002 .
 2015-11-16 14:10:10 -08:00
pq 82e83bb34d Experimental getDiagnostics request (#24480). 
* Adds `getDiagnostics` request with *very* provisional diagnostics payload (primary goal here is to plumb this fully through and iterate).
* Updates codegenerator to skip doc generation for experimental APIs.

Additional context here: https://github.com/dart-lang/sdk/issues/24480.

BUG=24480
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1416093007 .
 2015-11-05 15:05:21 -08:00
pq 7a6bf51504 Doc generator tweak to skip experimental domains. 
Prevents domains flagged as experimental from having server apidocs generated.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1419793004 .
 2015-11-03 13:12:00 -08:00
Konstantin Shcheglov 069ba985de Fix protocol for EXTRACT_LOCAL_VARIABLE and coveringExpressionOffsets/lengths. 
Unfortunately we have to make coveringExpressionOffsets and coveringExpressionLengths optional.
Otherwise new clients cannot correctly parse responses from old servers.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/1407333006 .
 2015-11-03 10:19:41 -08:00
Paul Berry ac5578d03d Refactor analysis server code generation to re-use logic from analyzer. 
The code generation infrastructure logic is now shared.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1431683002 .
 2015-11-02 16:18:03 -08:00
Brian Wilkerson 27eb09033f Clean up wording of client usage expectations 
R=paulberry@google.com

Review URL: https://codereview.chromium.org/1409353002 .
 2015-10-19 07:46:49 -07:00
Konstantin Shcheglov c0d68a5437 DAS specification changes - spelling and ElementKind.FILE addition. 
ElementKind.FILE will be used in search.findElementReferences

1. In the 'element' field of responce when a URI is at the given offset.

2. In the only element of the 'path' field of SearchResult(s) for URI references to a URI or a library identifier.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1409333002 .
 2015-10-17 10:03:03 -07:00
Paul Berry 9767634564 Fix manual editing of integration_test_methods.dart. 
In commit 9ad256cf18,
integration_test_methods.dart (an auto-generated file) was edited
manually.  The only necessary changes were to imports--the other changes
were the result of sorting declarations and running the formatter.

This CL replicates the necessary changes in the code generator and
re-runs it, un-doing the other changes.  This should fix the test
"pkg/analysis_server/tool/spec/check_all_test".

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1397353002 .
 2015-10-12 06:49:02 -07:00
Brian Wilkerson 9ad256cf18 Move the wire protocol support into the public API 
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1398293002 .
 2015-10-11 07:34:28 -07:00
Konstantin Shcheglov b107dec41a Spec change: include covering expressions into Extract Local protocol. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1388783003 .
 2015-10-05 14:44:32 -07:00
pq 8697392367 AnalysisError hasFix attr (Implements #23874). 
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1385523002 .
 2015-10-05 09:46:17 -07:00
Konstantin Shcheglov 9d48af9ee3 Specification change for the 'libraryName' and 'partOfLibraryName' fields in Outline. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//1375163003 .
 2015-10-01 09:53:20 -07:00
Konstantin Shcheglov da29a447c4 New analysis.implemented notification specification. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1372623004 .
 2015-09-25 09:57:29 -07:00
Konstantin Shcheglov 173cb44a85 Add '<!doctype html>' to spec. 
The new task model's HTML parser reports an error otherwise.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//1351323004 .
 2015-09-21 10:10:57 -07:00
Brian Wilkerson 42d1d4532d Reformat code to minimize churn 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1310263003 .
 2015-09-09 08:19:18 -07:00
Konstantin Shcheglov c67b274852 Explicitly document that NavigationRegion.targets cannot be empty. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1328273002 .
 2015-09-08 13:16:43 -07:00
Konstantin Shcheglov 58f5005cb1 Add the optional 'superOnly' request parameter for 'search.getTypeHierarchy'. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1325543006 .
 2015-09-03 13:03:01 -07:00
Paul Berry 03a156c891 Plumb "enableSuperMixins" option through analysis server (implements DEP 34). 
Partially addresses #23772.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//1301533003 .
 2015-08-20 09:47:26 -07:00
Guillermo López-Anglada 3193083293 remove dead code 
Fixes #24037
 2015-08-14 15:32:35 +02:00
Brian Wilkerson 87c7ee011f Merge pull request #23979 from guillermooo-forks/clean-up-to_html 
remove unused switch case
 2015-08-10 09:03:58 -07:00
Brian Wilkerson f6eb7c13a8 Merge pull request #24024 from guillermooo-forks/optional-newline-generated-doccomments 
add optional param to control whether to add newline
 2015-08-10 07:56:14 -07:00
guillermooo 70a0e29758 add optional param to control whether to add newline 
A new parameter enables client classes to decide whether the want
a newline char added at the end of a chunk of generated doc
comment text.
 2015-08-08 16:37:19 +02:00
guillermooo 0b00d198c0 add links to index in spec input file 2015-08-06 22:28:26 +02:00
guillermooo 09addad383 generate index 2015-08-06 22:17:50 +02:00
guillermooo 69a062a01f add index element to analysis server doc file 2015-08-06 21:59:56 +02:00
guillermooo c4418424ae remove unused switch case 2015-08-05 08:05:19 +02:00
Konstantin Shcheglov aa30cad380 Proposal for the 'edit.organizeDirectives' request. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/23921

Review URL: https://codereview.chromium.org//1258563008 .
 2015-08-03 07:59:26 -07:00
Paul Berry e93b52a66f Deprecate option "enableNullAwareOperators" in analysis server. 
As of analyzer version 0.25.2, this option is no longer needed;
null-aware operators are always enabled.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1255113005 .
 2015-07-28 11:31:03 -07:00
Brian Wilkerson 1487e5ad91 Merge pull request #23867 from guillermooo-forks/make-indentation-configurable 
make indentation configurable for codegen tools
 2015-07-22 10:27:48 -07:00
Konstantin Shcheglov c4652486b4 Fix for a copy/paste problem in GET_NAVIGATION_INVALID_FILE. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1243073004 .
 2015-07-21 08:46:55 -07:00
Konstantin Shcheglov a049c5aba0 Update DAS protocol version to 1.9.0 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1241213002 .
 2015-07-20 12:24:37 -07:00
Konstantin Shcheglov 55cb93b422 Add '--useAnalysisHighlight2' option to generate version 2 of semantic highlight. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1241193002 .
 2015-07-20 10:37:46 -07:00
Brian Wilkerson 15a0f755e8 Improve error messages for invalid requests 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1246573002 .
 2015-07-20 10:23:01 -07:00
guillermooo 5eeaf9ac07 update documentation 2015-07-19 21:26:59 +02:00
guillermooo 856aee812a make indentation configurable for codegen tools 2015-07-19 21:16:15 +02:00
Brian Wilkerson 2ffa8de794 Add notification of analyzed files 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1232393005 .
 2015-07-13 15:07:33 -07:00
Brian Wilkerson 10b7db100f Revert "Update Analysis Server highlight API and implementation." 
This reverts commit 739847402b.

Rolling the wire protocol API version forward caused existing clients to break, so we're rolling it back until we can find a backward compatible way of adding the new functionality.

R=paulberry@google.com

Review URL: https://codereview.chromium.org//1236433003 .
 2015-07-13 09:49:55 -07:00