97c613aad4
More strong mode changes in analysis_server
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1852113002 .
2016-04-03 17:56:30 -07:00
8c22a5f807
Format code in analysis_server
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1838933003 .
2016-03-29 08:27:14 -07:00
c0d40223bf
Issue 25945. Include static/propagateInvokeType for MethodInvocation names into hover.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25945
Review URL: https://codereview.chromium.org/1814893002 .
2016-03-17 10:29:10 -07:00
cf3b9b9548
Fix analysis_server test to not expect redundant error.
...
R=brianwilkerson@google.com , pquitslund@google.com
Review URL: https://codereview.chromium.org/1803203002 .
2016-03-15 14:17:09 -07:00
bd76934452
Remove old index and search implementations.
...
Also rename the new implementation files and classes to remove the
'2' suffix.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1801883002 .
2016-03-14 12:19:40 -07:00
7d72c6e1f5
Deprecate the generated AST library and clean up imports
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1788223002 .
2016-03-12 08:50:48 -08:00
5831cfb1bb
Fix issue where errors aren't reported for a new overlay
...
A new overlay was not being marked as an explicitly added
source, even if it's within the directory of an analysis
context. As a result, errors were not being reported.
I believe this only happens if there's no underlying file.
Therefore it seems difficult to reproduce in an IDE, but
it comes up in a stress test.
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1753083003 .
2016-03-03 10:42:45 -08:00
c4d7f41650
Move folderMap from AnalysisContext to ContextManager
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1750683002 .
2016-02-29 14:04:46 -08:00
bdd0d637fe
We need to perform analysis differently based on some option settings (such as strong mode), but there is currently a single SDK that is shared across all contexts no matter which option values are being used. This causes us to inconsistently analyze different portions of the SDK depending on which outer context was the first to request the analysis.
...
This is at least a first step toward solving this problem by allowing multiple SDKs to be created, one for each unique set of options.
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1686613002 .
2016-02-09 11:05:34 -08:00
e7e52ae2c0
Issue 25542. If an element does not have its own documentation, use the documentation from the overridden superclass member or an implemented interface.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25542
Review URL: https://codereview.chromium.org/1632033002 .
2016-01-25 17:09:48 -08:00
cba8d0d7c3
Issue 25538. Fix for 'analysis.implemented' notification and private members.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25538
Review URL: https://codereview.chromium.org/1615023002 .
2016-01-21 09:49:18 -08:00
5dc34340a1
Issue 25538. Fix for notification and private methods.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25538
Review URL: https://codereview.chromium.org/1610773003 .
2016-01-21 08:01:51 -08:00
6824bd9b32
Fix for enum signatures.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1529593002 .
2015-12-14 10:53:08 -08:00
38a4193b5f
Issue 25244. Disable invalid overrides.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25244
Review URL: https://codereview.chromium.org/1519413002 .
2015-12-13 15:50:12 -08:00
2f0f398c73
Fix lints: unnecessary_brace_in_string_interp
...
Also fixes two cases of empty_constructor_bodies.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1521883002 .
2015-12-13 13:05:00 -08:00
168556a3e4
Tweaks for hover.
...
1. Include full signature of classes - extends, with and implements clauses.
2. Provide statis type only for variables - for all other elements the static type is always the same as in the signature.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1513943005 .
2015-12-11 14:25:46 -08:00
62656833d4
Wraps up the server-side of the 'Allow a user to configure which hints are "fatal"' ask ( #24452 ).
...
* migrates error filtering from a predicate to a process that can customize severities.
* moves filtering/processing from the `dart` task into the `getErrors` request and the errors notification.
See: https://github.com/dart-lang/sdk/issues/24452
(Pending a thumbs-up, support for CLI to follow.)
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1517723002 .
2015-12-10 13:35:11 -08:00
72cf3cbe91
Remove unnecessary 'noSuchMethod' declarations.
...
Also format these file.
I don't like how the new formatter changed the code :-(
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1507813004 .
2015-12-08 11:39:37 -08:00
4f654473ff
Merge remote-tracking branch 'origin/master' into analyzer-breaking-0.27
2015-12-06 08:41:24 -08:00
2be2c5e55c
Fix for navigation reginos for instance creations with import prefixes.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1498163003 .
2015-12-04 14:24:09 -08:00
b9644af695
Remove the old task model
...
Review URL: https://codereview.chromium.org/1490233007 .
2015-12-03 10:14:06 -08:00
1933891bad
Issue 25057. A static member cannot be implemented.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25057
Review URL: https://codereview.chromium.org/1488443002 .
2015-11-29 19:20:25 -08:00
c302b65584
Use async/await in all analysis domain tests.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1478513002 .
2015-11-24 14:18:37 -08:00
cfb7d61a9c
Issue 25034. Record only the target source's errors.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25034
Review URL: https://codereview.chromium.org/1477553002 .
2015-11-24 14:00:00 -08:00
670db50707
Generate separate navigation regions for 'super' and optional 'name'.
...
Also support for navigation regions for RedirectingConstructorInvocation.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1465303003 .
2015-11-23 14:27:03 -08:00
a689bf4180
Report error for ignored priority file. Ignore subscription for ignored files.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1462693002 .
2015-11-18 17:31:58 -08:00
abe8d87e0e
Implement AnalysisServer.getContainingContext() using ContextManager.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1455163005 .
2015-11-18 14:10:35 -08:00
03eed1c3c9
Fix for duplicate priority sources.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1408163008 .
2015-10-29 17:46:00 -07:00
7b75a53fef
Fix for regions reported with multiple targets.
...
We should merge them into single NavigationRegion(s) with multiple targets.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1403373018 .
2015-10-28 16:38:12 -07:00
2f9c4af993
Error Suppression FTW.
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1420363005 .
2015-10-28 09:59:05 -07:00
52fb3b3bab
Introducing a lint server plugin.
...
Avoids introducing an unwanted dependency on the options plugin to server (efects discovered: https://codereview.chromium.org/1411313005/ ). Also soon to be future home for fixes and completions.
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1410553005 .
2015-10-26 12:11:38 -07:00
289bd0a056
[Atom] Issue 424. Fix for 'getNavigation' and index expressions.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-atom/dartlang/issues/424
Review URL: https://codereview.chromium.org/1402353009 .
2015-10-25 11:29:54 -07:00
afa746230f
Lint option change propagation test.
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1417963004 .
2015-10-21 15:22:13 -07:00
6c85fe785a
Analysis Options error notifications.
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1411013003 .
2015-10-21 09:59:19 -07:00
18a29ba8a8
Tweak for make test passing with useTaskModel = true.
...
A real fix after final actual switching.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1410493005 .
2015-10-16 08:29:35 -07:00
91e5facc0f
Registry memory leak fixes.
...
Fixes #24549 .
A few notes:
* does away with registry in favor of context-associated configurations
* pulls in linter rev that does the context association
* bumps analyzer version before publishing (needed to update analyzer_cli)
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1406043002 .
2015-10-15 14:24:20 -07:00
a30bcd7b97
Issue 24599. Fix for requesting navigation for directives.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24599
Review URL: https://codereview.chromium.org/1405033002 .
2015-10-15 10:54:06 -07:00
cae05d6bd4
Context invalidation on option changes (Implements #24574 ).
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1399893004 .
2015-10-14 20:42:50 -07:00
9ad256cf18
Move the wire protocol support into the public API
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1398293002 .
2015-10-11 07:34:28 -07:00
695256d586
Linter hookup into AS.
...
Note the TODO to fix the extension manager interaction hijinx. Really we should ensure that we are only using the one in engine. At the moment, it's easy to get this wrong (as the initialization heroics herein testify).
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1392683003 .
2015-10-09 13:40:07 -07:00
90e975b656
Suppress scanner errors for non-existent URIs.
...
Fixes #23754 .
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1378503003 .
2015-10-06 10:25:50 -07:00
0e7f4b5717
Fix hover documentation for parameters.
...
R=paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org/1384583007 .
2015-10-05 07:04:20 -07:00
66a122a9db
Stop defensively copying AST structures before resolution
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1383043002 .
2015-10-02 12:38:18 -07:00
62fd9ac787
Issue 24487. Annotations with constructor resolution should produce navigation reginos to constructors.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24487
Review URL: https://codereview.chromium.org/1378713004 .
2015-10-02 10:44:58 -07:00
03e379de7a
Compute Outline.kind/libraryName actually.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24279
Review URL: https://codereview.chromium.org/1380103005 .
2015-10-01 13:09:38 -07:00
c4d0ff8a4c
pkg: Eliminate flaky analysis test failure.
...
Running in debug mode (or any slower configuration) makes this test fail since
it waits for a max of 100 event loop iterations for the analysis results.
Instead wait without limit until results are ready, with checking every few milliseconds.
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1379153002 .
2015-10-01 19:34:50 +02:00
1d28f99524
Fix for 'implemented' notification after an incremental change.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//1374943005 .
2015-09-30 11:08:41 -07:00
83f94a2114
Add navigation region for 'library' directives.
...
Dart Editor uses presence of a navigation region as a sign that there is something that can be renamed, and enables the Rename action.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1373593002 .
2015-09-25 12:35:51 -07:00
df827a06ae
The 'analysis.implemented' notification implementation.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1368793003 .
2015-09-25 12:33:02 -07:00
5fd8b38737
Tweak navigation for 'part of' directives.
...
This makes it consistent with import/export/part directives, where only URIs are navigation sources.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1365663002 .
2015-09-23 10:14:49 -07:00
Brian Wilkerson