William Hesse
232684aac0
Update co19 to revision dec2b67aaab3bb7339b9764049707e71e601da3d
...
BUG=
R=kustermann@google.com
Review-Url: https://codereview.chromium.org/2954443002 .
2017-06-22 11:46:13 +02:00
William Hesse
d8ec6450d0
Fix compiler==none case in browser testing (Dartium case)
...
Error was introduced in https://codereview.chromium.org/2947473002/
BUG=
R=kustermann@google.com
Review-Url: https://codereview.chromium.org/2950173004 .
2017-06-22 11:30:23 +02:00
Bob Nystrom
b452b39962
Basic support for dev_compiler in test.dart.
...
It can compile and run tests on Chrome. There are a lot of failing tests
that I (or the team) will need to triage, but I think at least basic
tests are working as expected.
There is code that could be cleaned up to more neatly factor how dart2js
and dartdevc are handled now that there are two separate compilers to
JS. There's also some redundant code between the path for testing
compile errors (enqueueStandardTest()) and the path for running a test
in the browser.
R=whesse@google.com
Review-Url: https://codereview.chromium.org/2947473002 .
2017-06-21 13:19:28 -07:00
William Hesse
823e7c6b03
Revert "Merge branch 'co19roll'"
...
This reverts commit 42cc7d570c .
BUG=
TBR=sortie@google.com
Review-Url: https://codereview.chromium.org/2952573003 .
2017-06-21 07:15:25 +02:00
William Hesse
42cc7d570c
Merge branch 'co19roll'
...
Update co19 status files with results from buildbot.
Update co19 to revision dec2b67aaab3bb7339b9764049707e71e601da3d
BUG=
R=sortie@google.com
Review-Url: https://codereview.chromium.org/2948763003 .
2017-06-21 06:34:55 +02:00
Terry Lucas
97d188418a
Update to latest WebKit changes:
...
- Fix DevConsole crash with JS see Issue https://github.com/dart-lang/sdk/issues/29873
CL https://codereview.chromium.org/2941143002
- Fix debugging in WebStorm, NULL returned for JS objects see Issue https://github.com/dart-lang/sdk/issues/29854
CL https://codereview.chromium.org/2945063002
TBR=jacobr@google.com
Review-Url: https://codereview.chromium.org/2952643002 .
2017-06-20 09:08:00 -07:00
William Hesse
ea2167bbac
Make debian package builder more robust in uninstall step
...
BUG=
R=lrn@google.com
Review-Url: https://codereview.chromium.org/2950783002 .
2017-06-20 13:34:54 +02:00
William Hesse
2b6fbc7069
Revert co19 roll attempt
...
Revert "Status files updated according to buildbot log (#29929 )"
This reverts commit 5b7a7958b2 .
Revert "Fix Dartium DEPS typo in co19 roll"
This reverts commit 4996568879 .
BUG=
Review-Url: https://codereview.chromium.org/2949543002 .
2017-06-19 13:17:55 +02:00
William Hesse
4996568879
Fix Dartium DEPS typo in co19 roll
...
BUG=
TBR=sortie@google.com
Review-Url: https://codereview.chromium.org/2951443002 .
2017-06-19 13:06:40 +02:00
Sergey G. Grekhov
5b7a7958b2
Status files updated according to buildbot log ( #29929 )
...
* DEPS ans status files updated to the last co19 commit
* Commented lines deleted from .status file
* DEPS ans status files updated to the last co19 commit
* DEPS ans status files updated to the fix of https://github.com/dart-lang/co19/issues/110
* Fix for https://github.com/dart-lang/co19/issues/87 added
* Fix for https://github.com/dart-lang/co19/issues/88 added
* Status files updated according to buildbot log
2017-06-19 12:55:32 +02:00
Florian Loitsch
dbfaa36728
Add summary command to bot.
...
Looks at the latest build results and gives information. For now
just prints, if a bot has an error.
R=johnniwinther@google.com
Review-Url: https://codereview.chromium.org/2944653002 .
2017-06-19 10:22:50 +02:00
Terry Lucas
8ab1a87aba
Typedefs and IDL file order between platforms could generated different files.
...
TBR=alanknight@google.com ,vsm@google.com
Review-Url: https://codereview.chromium.org/2948493002 .
2017-06-18 11:54:29 -07:00
Siva Chandra
bac83e0973
Replace the --platform vm_option with --kernel-binaries option.
...
This new flag value specifies the directory in which the VM should look
up the platform.dill file. A future change will require the VM to load
another kernel binary from disk. This binary will also live in the same
directory that --kernel-binaries specifies. This way, we avoid adding a
different flag for each of the different binaries.
R=asiva@google.com
Review-Url: https://codereview.chromium.org/2933203004 .
2017-06-16 12:22:31 -07:00
William Hesse
f99509ad42
Fix bad merge in refactoring
...
The land of https://codereview.chromium.org/2933973002 merged badly
with https://codereview.chromium.org/2934243002/
BUG=https://github.com/dart-lang/sdk/issues/28955
R=sortie@google.com
Review-Url: https://codereview.chromium.org/2938383002 .
2017-06-16 10:10:54 +02:00
Terry Lucas
1e1bab0bff
Updated to latest WebKit changes
...
TBR=asiva@google.com
Review-Url: https://codereview.chromium.org/2939193002 .
2017-06-15 14:31:48 -07:00
Bob Nystrom
a6ca718e98
Simplify Command classes.
...
- Get rid of separate CommandBuilder class and singleton pattern. It
was being passed around explicitly even though half of the places
that received a CommandBuilder as a parameter still directly called
CommandBuilder.instance instead of using it.
- Get rid of Command caching. As far as I can tell, it makes no
measurable difference in runtime performance or memory usage. Even
with a large invocation of a lot of configurations and tests, the
Command classes don't seem to be a significant use of memory.
- Shorten the factory names. "get" adds no value, and we know it
returns a "Command" since it's on Command.
R=whesse@google.com
Review-Url: https://codereview.chromium.org/2933973002 .
2017-06-15 14:19:03 -07:00
Siva Chandra
65a5707189
Add a vmservice_sdk directory in runtime/bin.
...
This directory has a libraries.json file pointing to vmservice_io and
_vmservice in the source tree. The script tools/patch_sdk.dart has been
updated to use this new directory as the sdk directory when compiling
dart:vmservice_io. This way, to build vmservice_io.dill, we
do not need to copy the dart files pertaining to vmservice_io and
_vmservice.
Fixes #29859
R=sigmund@google.com
Review-Url: https://codereview.chromium.org/2938903003 .
2017-06-15 13:08:10 -07:00
Sigmund Cherem
5a63b0e339
Add flutter mode to patched_sdk
...
This is needed to create a platform.dill for flutter.
R=aam@google.com
Review-Url: https://codereview.chromium.org/2931773003 .
2017-06-14 17:29:36 -07:00
Bob Nystrom
979026abef
Don't allow "none" as a runtime for dartk.
...
Also, add a little sanity checking in TestCase.
Fix #29842 .
R=ahe@google.com
Review-Url: https://codereview.chromium.org/2941603002 .
2017-06-14 10:31:09 -07:00
William Hesse
e64ee95959
Move ie11 timeout handling code to BrowserControllerTestOutcome
...
Only content_shell testing uses the BrowserCommandOutputImpl class.
Rename the class to ContentShellCommandOutputImpl.
BUG=https://github.com/dart-lang/sdk/issues/28955
BUG=https://github.com/dart-lang/sdk/issues/29869
R=kustermann@google.com
Review-Url: https://codereview.chromium.org/2934243002 .
2017-06-14 15:50:41 +02:00
William Hesse
d98d32b63c
Report ie11 timeouts in debug log, not as errors (attempt 2)
...
BUG=https://github.com/dart-lang/sdk/issues/28955
R=kustermann@google.com
Review-Url: https://codereview.chromium.org/2938813002 .
2017-06-14 14:17:27 +02:00
Siva Chandra
1fe6097cc8
Generate vmservice_io.dill along with platform.dill.
...
R=asiva@google.com
Review-Url: https://codereview.chromium.org/2940473002 .
2017-06-13 15:40:17 -07:00
Siva Chandra
a879f91420
Remove dart:_vmservice and dart:vmservice_io from platform.dill.
...
A mirrors test which now passes has been removed from the blacklist.
R=asiva@google.com
Review-Url: https://codereview.chromium.org/2931193002 .
2017-06-13 13:49:38 -07:00
William Hesse
dc08a02cbc
Revert co19 roll attempt.
...
After status files are updated with failures from this run, we will try again.
R=brian.wilkerson@google.com
Revert "DEPS ans status files updated to the last co19 commit (#29604 )"
This reverts commit 70b2b3f6b1 .
Revert "Fix typos introduced in DEPS by 70b2b3f6b1bb2def061f80b7693cd89e23fa9134"
This reverts commit 9e9f7210d0 .
BUG=
Review-Url: https://codereview.chromium.org/2933403002 .
2017-06-13 20:31:19 +02:00
William Hesse
9e9f7210d0
Fix typos introduced in DEPS by 70b2b3f6b1
...
BUG=
TBR=brian.wilkerson@google.com
Review-Url: https://codereview.chromium.org/2939553004 .
2017-06-13 19:59:53 +02:00
Sergey G. Grekhov
70b2b3f6b1
DEPS ans status files updated to the last co19 commit ( #29604 )
...
* DEPS ans status files updated to the last co19 commit
* Commented lines deleted from .status file
* DEPS ans status files updated to the last co19 commit
* DEPS ans status files updated to the fix of https://github.com/dart-lang/co19/issues/110
* Fix for https://github.com/dart-lang/co19/issues/87 added
* Fix for https://github.com/dart-lang/co19/issues/88 added
2017-06-13 19:49:18 +02:00
Alan Knight
6042ae4bd8
Get the name and message from DOMException correctly
...
BUG=
R=jacobr@google.com , terry@google.com
Review-Url: https://codereview.chromium.org/2931903003 .
2017-06-13 08:59:33 -07:00
Terry Lucas
b3a90540f1
Fix sound not playing in Dartium checked mode.
...
Checked mode failure with optional args and Promise missing convertNativePromiseToDartFuture calls.
Easiest solution is to emit proper code instead of re-plumbing the Dartium emitter for operations
with optional arguments that are Promises.
https://github.com/dart-lang/sdk/issues/29810
TBR=alanknight@google.com ,kevmoo@google.com
Review-Url: https://codereview.chromium.org/2940543002 .
2017-06-12 22:50:12 -07:00
Bob Nystrom
571839ed90
Remove negated variables now that we support "!".
...
R=lrn@google.com
Review-Url: https://codereview.chromium.org/2924183002 .
2017-06-12 15:50:59 -07:00
Bob Nystrom
19cb0cafb7
Simplify test_suite.dart.
...
- Get rid of baseCommand, which is only ever an empty list.
- Move some utility classes out of the giant test_suite.dart.
R=whesse@google.com
Review-Url: https://codereview.chromium.org/2915843003 .
2017-06-09 16:46:49 -07:00
Terry Lucas
3cbacefbe3
Fix HTMLCanvasElement.getContext it can return RenderingContext2 now which will be tree shaken without this annotation.
...
R=alanknight@google.com ,sigmund@google.com
Review-Url: https://codereview.chromium.org/2932793002 .
2017-06-08 20:44:30 -07:00
Bob Nystrom
8bc4e89219
Remove unused record and replay functionality.
...
R=whesse@google.com
Review-Url: https://codereview.chromium.org/2920633002 .
2017-06-08 09:18:03 -07:00
Sigmund Cherem
9c32854d44
Use the correct sources for dartium in patched_sdk for vm
...
BUG=
R=ahe@google.com , paulberry@google.com
Review-Url: https://codereview.chromium.org/2923043004 .
2017-06-06 12:03:16 -07:00
William Hesse
33fe148c51
Update checked-in SDK to 1.24.0-dev.6.8
...
BUG=
R=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2922273003 .
2017-06-06 17:05:09 +02:00
Martin Kustermann
2c41c608f1
Roll dartium to pull in changes art_SaveCompilationTrace/_Dart_LoadCompilationTrace
...
R=whesse@google.com
Review-Url: https://codereview.chromium.org/2927553002 .
2017-06-06 13:36:46 +02:00
Terry Lucas
ffa45b00fe
Updated to latest WebKit change. Support --dump-render-tree switch.
...
TBR=alanknight@google.com
Review-Url: https://codereview.chromium.org/2923673002 .
2017-06-05 13:45:15 -07:00
Ryan Macnak
b69b3e58f0
Update test.py's --arch=all to match that of build.py.
...
R=zra@google.com
Review-Url: https://codereview.chromium.org/2918403002 .
2017-06-05 13:07:30 -07:00
Terry Lucas
c630b89171
Update to latest WebKit
...
TBR=alanknight@google.com
Review-Url: https://codereview.chromium.org/2913993005 .
2017-06-02 12:11:48 -07:00
Alexander Aprelev
6573c74301
Reenable vm tests with -cdartk DFE parser.
...
This was accidentally disabled in 7e2d9ac85d .
BUG=#28264
R=asiva@google.com
Review-Url: https://codereview.chromium.org/2920733004 .
2017-06-02 09:34:11 -07:00
William Hesse
ae4c38bf54
Fix versionchecker script
...
BUG=
R=lrn@google.com
Review-Url: https://codereview.chromium.org/2919933003 .
2017-06-02 11:28:57 +02:00
Lasse R.H. Nielsen
5720e3556c
Add negation to single-identifier tests in status files.
...
Optimize some regegps too.
Fixes #29756
BUG= http://dartbug.com/29756
R=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2913963002 .
2017-06-02 10:38:14 +02:00
Bob Nystrom
db06324975
Remove temp code to ignore "--failure-summary".
...
Now that the BuildBots aren't passing it, we don't need to accept it.
R=whesse@google.com
Review-Url: https://codereview.chromium.org/2916123002 .
2017-06-01 15:45:55 -07:00
William Hesse
e161ad12ac
Allow test.py to run dartdoc tests. Run dartdoc tests on pub bots.
...
BUG=
R=jcollins@google.com
Review-Url: https://codereview.chromium.org/2914233002 .
2017-06-01 18:53:04 +02:00
Erik Ernst
80c5b67980
Added find-shard to bot.dart.
...
R=johnniwinther@google.com
Review-Url: https://codereview.chromium.org/2915043002 .
2017-06-01 16:25:29 +02:00
William Hesse
dfbce8f779
Start working on version 1.25 of Dart SDK
...
BUG=
R=kasperl@google.com
Review-Url: https://codereview.chromium.org/2920753003 .
2017-06-01 13:54:22 +02:00
Johnni Winther
f1472ed8bb
Fix gardening/bot help messages
...
R=floitsch@google.com
Review-Url: https://codereview.chromium.org/2919693003 .
2017-06-01 11:32:58 +02:00
Johnni Winther
0e61716730
Add BuildBotClient to abstract http/logdog access
...
+ support error handling for logdog
R=floitsch@google.com
Review-Url: https://codereview.chromium.org/2912343002 .
2017-06-01 10:02:04 +02:00
Ryan Macnak
189dafd99f
Roll Dartium to "Add _Dart_CreateCoreJITSnapshotAsBlobs to framework.order for MacOS."
...
Review-Url: https://codereview.chromium.org/2919673002 .
2017-05-31 17:55:08 -07:00
Bob Nystrom
a9d4afc077
Handle "ff" as a runtime name in status files.
...
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2917843002 .
2017-05-31 17:49:22 -07:00
Bob Nystrom
7e2d9ac85d
Revert "Revert "Replace the configuration map with a typed object.""
...
This reverts commit 8bada4873a .
R=nweiz@google.com
Review-Url: https://codereview.chromium.org/2919573003 .
2017-05-31 15:39:23 -07:00