dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
47,883 Commits 2 Branches 0 Tags
42e2ae40e8a9ecb04f4c19dfe13381601609706e
Commit Graph

198 Commits

Author SHA1 Message Date
Jennifer Messerly 71c7914061 fix checking of dsend generic type bounds 
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2935553002 .
 2017-06-12 16:17:39 -07:00
Jennifer Messerly cb038cda2f fix test runner to understand mutlitests that expect an error 
R=rnystrom@google.com, vsm@google.com

Review-Url: https://codereview.chromium.org/2930203002 .
 2017-06-12 16:07:17 -07:00
Jennifer Messerly 334354f968 fix #29753, use ES5 constructors for ddc 
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2934623003 .
 2017-06-12 15:31:32 -07:00
Vijay Menon 06c4619b3e Fix int test 
Fixes #29822

R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2927703005 .
 2017-06-08 17:42:35 -07:00
Leaf Petersen cb8cc2526b Add codegen test for equality. 
Adds a DDC test tracking the generated code and its correctness. Some
test harness changes to support running codegen tests.

BUG=
R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2930733002 .
 2017-06-07 12:42:30 -07:00
Vijay Menon 75afaf5a24 Support reflectClass on parameterized classes 
Internal pageloader usage hits this.

R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2899343004 .
 2017-05-25 13:27:35 -07:00
Alan Knight 0bb2d5e548 Update DDC html libraries to match SDK 
BUG=
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2899083007 .
 2017-05-25 09:33:23 -07:00
Vijay Menon 92d39a4e08 One more minor mixin fix 
We need to preserve the Mixin constructor to make sure metadata (e.g.,
implements) is injected in the right place.

R=jacobr@google.com

Review-Url: https://codereview.chromium.org/2779063002 .
 2017-05-19 07:41:29 -07:00
Vijay Menon 1f94f3dc0a Fix status for FF 
TBR=alanknight@google.com

Review-Url: https://codereview.chromium.org/2895543002 .
 2017-05-18 19:29:40 -07:00
Vijay Menon b82b0e29ed DDC fixes for SpeechRecognition 
R=alanknight@google.com

Review-Url: https://codereview.chromium.org/2896463002 .
 2017-05-18 17:05:51 -07:00
Vijay Menon 36356c28c1 Better stack trace support 
- Caches stack trace objects (package:stack_trace appears to rely on this)
- Better support for stack traces on primitives

R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2869463002 .
 2017-05-09 14:58:34 -07:00
Jennifer Messerly 811a9eed1d Revert "Revert "fix #27256, track type bounds for generic functions"" 
This reverts commit 3a23e604e2.

The problem was unrelated to the CL; it appears to be a dart:async break of package:async.

In the meantime we have turned on --unsafe-force-compile to DDC's shapshotting step

Review-Url: https://codereview.chromium.org/2869733006 .
 2017-05-09 14:20:25 -07:00
Alan Knight 3a23e604e2 Revert "fix #27256, track type bounds for generic functions" 
This reverts commit b58f826976.

BUG=

Review URL: https://codereview.chromium.org/2870543005 .
 2017-05-09 12:58:03 -07:00
Jennifer Messerly b58f826976 fix #27256, track type bounds for generic functions 
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2867493002 .
 2017-05-09 11:42:40 -07:00
Jennifer Messerly 171f7ba592 fix #29544, mixins to a class with named constructors 
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2859703003 .
 2017-05-04 12:33:45 -07:00
Jennifer Messerly 6ab17db3da fix more mixin tests to work in strong mode 
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2861783002 .
 2017-05-04 11:30:14 -07:00
Jennifer Messerly d26bb56575 fix #27971, implement generic function RTTI 
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2832913003 .
 2017-04-21 15:40:44 -07:00
Jennifer Messerly bed6f8242a add an option to turn off errors from strong mode is-checks 
This adds an option and also has our tests run with it turned off.

R=vsm@google.com

Review-Url: https://codereview.chromium.org/2835743002 .
 2017-04-21 15:24:32 -07:00
Jacob Richman 7149b90c7c Tighten up handling of JS types and add test. 
Side effect of this:
Fix bug where helpers in js_mirrors were specifying that name had to have type String when it could really also be a JS Symbol as well.
Fix bug where top level JS interop members using the external keyword but no @JS keyword were not implemented.
Update js_typed_interop_test.dart so it can work in DDC.
Add regression test for jsify call with native function type arguments.

BUG=
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2827333003 .
 2017-04-21 08:44:00 -07:00
Vijay Menon 1975c8431a Migrate async tests to strong 
No modifications to the actual tests

R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2802973005 .
 2017-04-07 12:46:12 -07:00
Peter von der Ahé 4827ac4f38 Remove references to renamed test. 
R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2790893002 .
 2017-04-04 09:51:29 +02:00
Jacob Richman 509bcd58e1 Fix type checks and display for JS interop types. 
Re-enable formatter test that had been disabled when someone changed type
name display for Foo<dynamic> types.
Fix bug in how type names were displayed for JS interop types.

BUG=
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2789663005 .
 2017-04-03 08:34:20 -07:00
Vijay Menon 46d6c56c96 Fix ddc async test code 
Fortunately, not too many false passes.

R=jacobr@google.com

Review-Url: https://codereview.chromium.org/2792703002 .
 2017-03-31 15:57:08 -07:00
Vijay Menon 466d4ffb9c Add runtime tests for ignored checks 
Tests for https://codereview.chromium.org/2788933002/

R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2789933002 .
 2017-03-31 13:31:59 -07:00
Jennifer Messerly 1c504f8945 Fix #28120, strong mode allows field overrides 
Fix #28119, DDC supports field overrides without @virtual
Fix #28801, devirtualize private fields in DDC where possible
Fix #28589, stop supporting @virtual in strong mode

R=leafp@google.com, vsm@google.com

Review-Url: https://codereview.chromium.org/2781443003 .
 2017-03-28 10:26:36 -07:00
Vijay Menon 50ceaa4c04 Fix for #29003 
This is an alternative to the other CL.  It just uses the result of
dart.mixin instead of declaring a new class.  That preserves the assumption (at least at runtime) that the mixin class directly inherits from Object.

We were also not declaring interfaces for ClassTypeAliases.

R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2783443002 .
 2017-03-27 16:06:13 -07:00
Vijay Menon ac68d598cf Add patch code for List.filled growable param 
Looks like a missing param doesn't break patch_sdk.  I think this was a recent add.

Fixes #28508

R=jakemac@google.com, jmesserly@google.com

Review-Url: https://codereview.chromium.org/2771953004 .
 2017-03-24 14:27:47 -07:00
Vijay Menon 27d14402fa Skip test on chrome canary 
TBR=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2770033004 .
 2017-03-24 08:07:51 -07:00
Leaf Petersen dba842bcc8 Handle casts from Number to FutureOr<double>. 
Fixes https://github.com/dart-lang/sdk/issues/29128 .

BUG=
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2772573003 .
 2017-03-23 13:33:33 -07:00
Vijay Menon 4d983162d5 Fix status for canary 
This particular test seems to have frequent canary only errors.  Not
sure there is a better way - e.g., alway ignore on Canary?

TBR=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2769873004 .
 2017-03-23 10:21:32 -07:00
Jennifer Messerly f021a7019b fixes #27586, prefer downwards context type in generic inference 
fixes #27625, Object constraints were not tracked in inference
fixes #27933, pin return type from downwards inference

We now prefer to pick the bound (lower or upper) that had some information on, and it also improves inference error messages somewhat (still a ways to go).

The way this works is we now have a type representing an unknown type: ?. We use ? when performing downward inference steps, instead of `dynamic`. This allows more accurate tracking of type constraints.

For example: given:

    var x = await Future.wait([a, b]);

Future.wait<T>'s argument type is Iterable<Future<T>>. Since we didn't know T, we previously pushed down Iterable<Future<dynamic>>. The dynamic caused loss of information. Now we push down Iterable<Future<?>>, allowing us to infer the right type there.

R=leafp@google.com, vsm@google.com

Review-Url: https://codereview.chromium.org/2456803004 .
 2017-03-17 16:59:56 -07:00
Vijay Menon 6cf2ac1f62 Fix FF test status and re-enable 
With sra's num parse fixes and couple more, FF should be green again (as well as Chrome Canary).

R=alanknight@google.com

Review-Url: https://codereview.chromium.org/2750503009 .
 2017-03-14 09:28:10 -07:00
Vijay Menon f9cb23d2eb Fix DDC status, take 2 
They *do* pass on Chrome 59.

TBR=sra@google.com

Review-Url: https://codereview.chromium.org/2749853002 .
 2017-03-14 07:35:29 -07:00
Vijay Menon 9c1a75bf34 Fix DDC status 
These tests appear to pass on FF, but fail on Chrome.

TBR=sra@google.com

Review-Url: https://codereview.chromium.org/2748133002 .
 2017-03-14 07:28:58 -07:00
Vijay Menon 406a82723f Fix expectations 
TBR=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2744853002 .
 2017-03-10 08:53:08 -08:00
Vijay Menon b4163fa8bb Fix test expectation 
TBR=jacobr@google.com

Review-Url: https://codereview.chromium.org/2739103003 .
 2017-03-09 14:55:21 -08:00
Vijay Menon 402e025c63 Add option to suppress type-check whitelisting 
Run most tests without the whitelisting.

See #27223

R=leafp@google.com

Review-Url: https://codereview.chromium.org/2739863003 .
 2017-03-08 17:51:32 -08:00
Vijay Menon f6e964fca9 Fix dangling ddc references in libraries.dart 
Our internal tooling is complaining about this when building / checking the ddc sdk.  It appears to use the analyzer's summary builder tool which seems less forgiving about dangling references / missing files.

R=srawlins@google.com

Review-Url: https://codereview.chromium.org/2740573003 .
 2017-03-07 15:27:46 -08:00
Vijay Menon d5372c79ae Bump timeout 
This test seems to timeout often on travis lately.

TBR=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2731243003 .
 2017-03-06 16:45:59 -08:00
Vijay Menon 2acb2eb669 Update for latest tests and sdk 
TBR=leafp@google.com

Review-Url: https://codereview.chromium.org/2731333002 .
 2017-03-06 09:36:14 -08:00
Jacob Richman a6a206062d Custom formatter cleanup Fix case where displaying a class constructor generated unreadable huge output. Fix case where exceptions were throw. Correct display of statics, fix indentation bugs. Add improved custom formatter test to main repro. As a drive by fix, switch hashCode to use a symbol instead of the name $identityHash as $identityHash was making custom formatter test output unstable. 
BUG=
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2703263002 .
 2017-02-28 17:47:53 -08:00
Jennifer Messerly fe294f3753 unfork DDC's copy of most SDK libraries 
There's some changes in strong mode errors we may want to follow up on.

Unforks the following: async, collection, convert, core, developer, internal, io, isolate, math, mirrors.

Does not unfork: html, indexed_db, js, js_util, svg, typed_data, web_audio, web_gl, web_sql.

R=vsm@google.com

Review-Url: https://codereview.chromium.org/2698353003 .
 2017-02-28 17:10:52 -08:00
Vijay Menon 53971cb67e Fix Function.apply 
Fixes #27257.

R=alanknight@google.com, jmesserly@google.com

Review-Url: https://codereview.chromium.org/2716583006 .
 2017-02-24 19:24:48 -08:00
William Hesse 72b58ee3b6 Fix corelib_strong/sort_test on dev_compiler 
BUG=
R=jacobr@google.com, vsm@google.com

Review-Url: https://codereview.chromium.org/2683583009 .
 2017-02-08 23:06:52 +01:00
Jennifer Messerly 5817ba47e2 fix #28642, handling of top and bottom types in DDC 
in particular: void, Null, and combinations with FutureOr<T>

R=leafp@google.com

Review-Url: https://codereview.chromium.org/2671113002 .
 2017-02-06 14:56:10 -08:00
Vijay Menon c88a17ff55 Some test cleanup 
These tests occasionally time out on travis.  uri_test as well, but
there are two tests with that name, so I added code to disambiguate in
the logs.

R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2666593002 .
 2017-01-31 10:23:26 -08:00
Vijay Menon 50ccf6d9b5 Fix DOM constructors in inline JS 
R=jacobr@google.com

Review-Url: https://codereview.chromium.org/2659063002 .
 2017-01-27 09:47:13 -08:00
Vijay Menon fd94337b42 Fix for Animation and other polyfills 
The polyfill code needs to run before dart_sdk is loaded.  Otherwise, the registerExtension step on these types does not work.

Also fixes #27605

R=jacobr@google.com

Review-Url: https://codereview.chromium.org/2649613003 .
 2017-01-25 16:18:49 -08:00
Vijay Menon a91cc9cc9e Use microtasks in dart.async 
Not quite sure about this, but it makes ordering match for the example in  #28509

R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2653253002 .
 2017-01-25 16:14:01 -08:00
Jacob Richman d90ed8c295 Fix noSuchMethod handling of methods that are also extension methods. Fix noSuchMethod handling of methods with names that are rewritten in DDC e.g. "_get" instead of "[]" Fix some mirror system handling of symbols with names that are rewritten in DDC 
BUG=
R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2623053004 .
 2017-01-24 11:16:21 -08:00