Commit Graph

2017 Commits

Author SHA1 Message Date
Brian Wilkerson fcb23e967c Remove the unused class SingleContextManager
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2945313002 .
2017-06-21 11:21:25 -07:00
Brian Wilkerson 53e01faa43 Remove unused implementation of SearchEngine and rename the driver-based implementation
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2949823002 .
2017-06-21 09:33:51 -07:00
Brian Wilkerson 6e89075952 Disable finding plugin locations in the pubspec
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2947153002 .
2017-06-21 09:30:32 -07:00
Brian Wilkerson 6e8453ed94 Fix invalid initializing formal by adding a field
R=pquitslund@google.com

Review-Url: https://codereview.chromium.org/2946093002 .
2017-06-21 07:56:26 -07:00
Mike Fairhurst 47c9dcad97 Update plugin whitelist to accomodate angular plugin rename
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2947953002 .
2017-06-20 12:01:51 -07:00
Brian Wilkerson 5582824e3c Rename the plugin location key and directory name
R=mfairhurst@google.com

Review-Url: https://codereview.chromium.org/2952583003 .
2017-06-20 11:06:39 -07:00
Brian Wilkerson 24996fbfe7 Add support to pass the location of the analysis options file to plugins
R=mfairhurst@google.com

Review-Url: https://codereview.chromium.org/2947743002 .
2017-06-20 07:41:03 -07:00
Konstantin Shcheglov f9dc588a27 Don't compute 'dart:core' LibraryElement during completion.
AnalysisResult already has TypeProvider, which can give us Object type.

R=brianwilkerson@google.com, danrubel@google.com
BUG=

Review-Url: https://codereview.chromium.org/2946643002 .
2017-06-19 08:18:08 -07:00
Brian Wilkerson e0216fef7f Remove ability to disable new analysis driver
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2937323003 .
2017-06-19 08:13:14 -07:00
Konstantin Shcheglov 9600dab0e0 Enable 'analysis.implemented' with the new analysis driver.
It is not very efficient on large files, but works well enough for small
files. I will work on making it more efficient in following CLs.

R=brianwilkerson@google.com, devoncarew@google.com
BUG= https://github.com/dart-lang/sdk/issues/29113

Review-Url: https://codereview.chromium.org/2942753002 .
2017-06-16 09:13:45 -07:00
Dan Rubel 305f358fa4 update statement completion for fasta scanner
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2936143002 .
2017-06-14 11:15:50 -04:00
Devon Carew e523061acc Minor tweaks to the diagnostics page.
BUG=
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2937623005 .
2017-06-13 19:22:28 -07:00
Brian Wilkerson 62d0376231 Run the sorter to reduce code churn
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2933753002 .
2017-06-12 07:37:14 -07:00
Brian Wilkerson d824acbf71 Update AssistProcessor to use ChangeBuilder
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2928313002 .
2017-06-12 07:28:02 -07:00
Devon Carew 44854543ea Tweak the look of the ast and element links in the diagnostics page.
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2933043003 .
2017-06-12 07:15:35 -07:00
Brian Wilkerson c0617d2015 Add access to AST ane element model data to the status pages
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2928033006 .
2017-06-11 09:44:15 -07:00
Florian Loitsch a8c2d1adba Add library tag to common_usage_sorter.dart.
Review-Url: https://codereview.chromium.org/2931163002 .
2017-06-09 21:33:21 +02:00
Devon Carew 64af69ac51 Bind the diagnostics server on ipv4 ports.
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2930003002 .
2017-06-09 10:43:51 -07:00
pq b502bb6956 Prioritize required name param completions (flutter-intellij#1049).
R=danrubel@google.com

Fixes: https://github.com/flutter/flutter-intellij/issues/1049
Review-Url: https://codereview.chromium.org/2927343002 .
2017-06-09 10:20:16 -07:00
Konstantin Shcheglov 756cca3222 Catch exceptions in ByteStreamServerChannel._outputLine() and close the channel.
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2928703007 .
2017-06-08 12:33:43 -07:00
Brian Wilkerson 6d8b7c8806 Finish refactoring FixProcessor to use ChangeBuilder
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2930793002 .
2017-06-08 07:56:08 -07:00
Devon Carew 79c2668d2b add memory usage to the diagnostics page
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2927783002 .
2017-06-07 11:28:34 -07:00
Brian Wilkerson a8919b8237 Support a short-hand way to create linked edit groups
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2928723003 .
2017-06-07 09:07:39 -07:00
Brian Wilkerson db0a8a76ae Move CompletionTarget and OpType for use by plugins
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2924703002 .
2017-06-06 07:07:19 -07:00
Brian Wilkerson dc972240d4 Remove unused IdeOptions
R=pquitslund@google.com

Review-Url: https://codereview.chromium.org/2924633002 .
2017-06-05 14:12:17 -07:00
Brian Wilkerson e8a5e404c3 Move LocalDeclarationVisitor for use by contributors that will be moved to analyzer_plugin
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2918343002 .
2017-06-05 10:24:54 -07:00
Brian Wilkerson db7d3d0fe7 Move relevance constants for use in plugins
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2923573002 .
2017-06-05 10:10:56 -07:00
Devon Carew 0b79e4d20d update the analyzer and analysis server perf tags
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2917183003 .
2017-06-03 19:51:27 -07:00
Devon Carew 4f2867d86c Add clientID and clientVersion to the diagnostics page.
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2925463002 .
2017-06-03 17:53:52 -07:00
Devon Carew 511963d715 Add an analytics domain to the analysis server.
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2922603002 .
2017-06-02 14:38:53 -07:00
Devon Carew 428c0ff59d Expose the exceptions info in the diagnostics page.
BUG=
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2914383002 .
2017-06-02 09:57:09 -07:00
Brian Wilkerson b5c630426c Update a few more methods in FixProcessor, and fix some bugs in ChangeBuilder
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2916923002 .
2017-06-02 07:36:51 -07:00
Devon Carew 7e32f3bd7c Remove dead code related to the diagnostics server.
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2918553002 .
2017-06-01 10:31:27 -07:00
Devon Carew 6c1625743c Relax a null check in context_manager.dart.
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2915673002 .
2017-06-01 09:50:00 -07:00
Brian Wilkerson d7d3ee40dd Report plugin errors to the instrumentation service
R=mfairhurst@google.com

Review-Url: https://codereview.chromium.org/2913913002 .
2017-05-31 08:01:07 -07:00
Devon Carew 02f7f5fee7 Updates to the diagnostics page.
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2918533002 .
2017-05-31 07:15:20 -07:00
Devon Carew c817241ad6 Update the analysis server diagnostic page - re-enable code completion and overlay pages,
and refactor the css and navigation.

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2911313002 .
2017-05-30 18:46:33 -07:00
Devon Carew 24b0d1489f Fix an npe in context_manager.dart.
BUG=

Review-Url: https://codereview.chromium.org/2917453002 .
2017-05-30 14:29:53 -07:00
Max Kim 82490f0d2f Allow replacementOffset and replacementLength overriding from plugin autocompletion. In cases where a plugin overrides the original Dart autocompletion offset/length or another plugin's offset/length - the suggestion for the plugin is dropped and an error notification is logged.
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2913833002 .
2017-05-30 13:54:11 -07:00
Devon Carew 1e7ff6bccf Add the analysis options path to the diagnostics page.
BUG=
R=brianwilkerson@google.com, paulberry@google.com

Review-Url: https://codereview.chromium.org/2913493002 .
2017-05-30 13:29:25 -07:00
Konstantin Shcheglov 9737664106 [Extract Method] When no selection, check for implicitly selected closure.
R=brianwilkerson@google.com, devoncarew@google.com
BUG=

Review-Url: https://codereview.chromium.org/2907213002 .
2017-05-30 11:11:46 -07:00
Brian Wilkerson f6c6c01211 Update some of the fixes to use ChangeBuilder
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2910683002 .
2017-05-30 08:01:52 -07:00
Devon Carew 03e0a93092 show the enableAssertInitializer setting in the diagnostics page
BUG=
R=brianwilkerson@google.com, danrubel@google.com

Review-Url: https://codereview.chromium.org/2911563002 .
2017-05-26 08:36:26 -07:00
Brian Wilkerson a7cc00e01a Make server forward getNavigation requests to plugins
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2908633002 .
2017-05-25 14:49:35 -07:00
Brian Wilkerson f65c7ecbdf Fix a recent regression with nested contexts
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2903303002 .
2017-05-25 13:17:08 -07:00
Brian Wilkerson 1c8b59dc31 Update status pages to show package map and plugins
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2904983003 .
2017-05-25 12:51:19 -07:00
Brian Wilkerson 013411c10b Allow plugins to provide completions for non-dart files
R=maxkim@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2910463002 .
2017-05-25 10:53:07 -07:00
Brian Wilkerson 61e3486ed1 Find drivers even when the file is not a dart file
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2898213004 .
2017-05-23 17:23:30 -07:00
Konstantin Shcheglov ab9ee72a34 Switch server tests to strong mode.
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2903523003 .
2017-05-23 14:58:53 -07:00
Brian Wilkerson 0929b7736e Convert quick assist support to use AnalysisDriver
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2899843002 .
2017-05-22 13:45:55 -07:00