8efdee06d6
Begin adding return types in analysis_server
...
Change-Id: Id0daa52236bdc90cba6bfd7cf81d1b4cf47603c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133544
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-28 21:18:30 +00:00
85083ca5ab
Enable avoid_return_types_on_setters in analysis_server
...
Change-Id: Idc4a05c30ce153d59d3b9e96b3803b18dc8c6edb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133437
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-28 16:25:18 +00:00
a6e01c23e2
Fix more windows tests in migration tool
...
No need to HTML-escape the root path; no HTML will be included.
Change-Id: Ibf9a19000a11207782b7b0d0f9222397f6d042fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133426
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-01-27 19:08:56 +00:00
548127daa1
Fix Windows analyzer tests.
...
Don't map the unit path in the region renderer.
Change-Id: I2c947302626e320dea587efc0240316fc62d0dc1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133164
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-01-27 16:16:06 +00:00
81c5d11691
Change tests of lint-based quick fixes to not require the lint marker in the result
...
Change-Id: I2a7e35c9754a5108e3d664684b8c2109b5689c58
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133409
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-27 01:48:25 +00:00
61199914d7
Convert dartfix to use underscores rather than hyphens for fix names
...
Change-Id: I0bd264e8c0e196aa7a5a8cb46fc940242a844f07
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133406
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-26 22:56:36 +00:00
d29c5c174c
Refactor dartfix to make the handling of lint fixes uniform
...
Change-Id: Ib329ec89bf19fa0c7d76b7f9ccdd796e20f71a9a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133404
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-25 23:09:55 +00:00
9609975262
Update generators to not produce type annotations for variable declarations
...
Change-Id: Ia19c94b430192c606d12449011503d5ca8172feb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133380
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-25 16:31:15 +00:00
9918987c59
Enable prefer_if_null_operators and prefer_spread_collections in analysis_server
...
Change-Id: I14fa2e9a3196be1d5f5d7991104e7363c72b3fe9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133334
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-25 16:31:07 +00:00
4cc45ec612
Cleanup some analyzer hints
...
Change-Id: Iba36b028895c56ef1f9831ef00650fde6527fbfe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133361
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-24 23:00:13 +00:00
2edd8d17c0
Migration: replace ?. with . where appropriate.
...
Change-Id: Id32f60caec0c25099704652c03fafc8b184bf4d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133241
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2020-01-24 19:58:43 +00:00
c9b56d3530
Remove support for default fixes from dartfix
...
Change-Id: I497f48ee0930829adf44a510101181578a4a9c86
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133242
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-24 18:33:05 +00:00
322b2493b7
NNBD preview: Fix recent display issues; fixes #40307
...
Change-Id: Ief1a795fdf6b52a77c43ed0435d96bb4350fd1f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133202
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-01-24 17:32:09 +00:00
bc9348829e
NNBD preview: change the Edit Details response to be JSON
...
* Also changes Edit Details to be an ordered list
* Also changed explanation to not include a `.` at the end;
append it in JS if needed
* Also add POST click handler to unblock the POST edit work.
Change-Id: Ifc11f8d9e0194b58cd7d81028bac19e89887c7e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133169
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-01-24 04:33:01 +00:00
3d7dd5bfe0
Remove the notion of required fixes from dartfix and the server
...
Change-Id: I55389e1978d11820142961b5997d2187d1e61bae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132973
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2020-01-24 01:05:41 +00:00
169dd530f3
de-dup mutiply exported elements
...
Change-Id: Id83d93207e32d069274b61a1352c99fb1bb940ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133151
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2020-01-23 23:54:01 +00:00
0263d4daf3
NNBD preview: Make navigation directories collapsible; closes #40109
...
Change-Id: Icc6ef0627533ac1ff925bd69c3e5b172fca9c514
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133140
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
2020-01-23 22:17:19 +00:00
8f0e00eb1c
Migration: Fix hang in preview server when an exception occurs.
...
See https://github.com/dart-lang/language/issues/791 for a detailed
explanation.
Change-Id: Iafcc2fa52b622e5db9dfc49ede595d0435a69f84
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133080
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Janice Collins <jcollins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2020-01-23 20:00:39 +00:00
2ffe48efd9
Update a preview site after adding or removing a hint
...
The code to update the graph is still missing, but I believe that this
gets us closer to having everything plumbed through.
Change-Id: If3e66e3c77a04a8f043dcccf4346b379d16e573f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133000
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-23 16:43:57 +00:00
e0f97cda30
Migration: switch to using the FixBuilder.
...
Change-Id: I41e978439d36a26e55be71071a931390eb3dbf57
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133020
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2020-01-23 16:06:57 +00:00
90b74dcc97
element info for Function call suggestions
...
Fixes: https://github.com/dart-lang/sdk/issues/40286
Change-Id: Iaf9e36d4f29f4b2908be4ab42f0e8e997bdc8a90
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133001
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2020-01-23 00:40:01 +00:00
d0d232b66c
Report an exception to the client if EditDomainHandler.dartfix encounters an exception.
...
Previously, an exception happening during EditDomainHandler.dartfix
would result in no response being sent, so dartfix would simply hang.
Change-Id: I5cadf78042cb91f1b11b1438a1699818f4dae74c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132963
Reviewed-by: Janice Collins <jcollins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2020-01-22 23:39:19 +00:00
500822341e
First steps to allow migration to be incrementally rerun
...
Change-Id: Ib4e682739a732ad9b8863ecb780ad88e5cbd9c6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132921
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2020-01-22 20:23:38 +00:00
6e091bd781
Function call() suggestions
...
Fixes: https://github.com/dart-lang/sdk/issues/39761
Change-Id: If7dbe8b29fd081cd77310343a4cba0d7355c45e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132920
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-01-22 19:44:48 +00:00
6b32a519bf
Add an Edits panel, listing all edits in a page; #40115
...
Change-Id: I7e6f60d25bf85030fd4d3a700677d789f3978345
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132803
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-01-22 16:02:08 +00:00
ce5a0f5e32
Migration: fix instrumentation when dropping the condition and else parts of an "if"
...
When migrating an unnecessary "if" test like this one:
if (x != null) {
Do something;
} else {
Do something else;
}
We make two modifications to the user's file:
- Drop "if (x != null) {"
- Drop "} else { Do something else; }"
With this change, the first modification has a description of
NullabilityFixDescription.discardCondition and the second has a
description of NullabilityFixDescription.discardElse. Previously,
both modifications had a description of
NullabilityFixDescription.discardElse, which was confusing.
Change-Id: I6407d7616b7a2d2c8af853ab48c3480959c4fdb9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132682
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2020-01-22 15:29:37 +00:00
47950b5153
Migration: add logic to remove unnecessary "as" expressions.
...
Only works when the FixBuilder is enabled.
Change-Id: I9f2ee95603f9b6b247eae1ba00e817a71fc299d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132681
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-01-22 00:05:34 +00:00
1c56176084
Parse --packages file as package_config.json or .packages, depending on the content.
...
Bug: https://github.com/dart-lang/sdk/issues/38554
Bug: https://github.com/dart-lang/sdk/issues/39762
Change-Id: Ibce0cabd75ecbfd3aa4e573418c2127ff7f9687e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132744
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-01-21 23:07:59 +00:00
a32e4363cb
Fix some lints from function typed parameters that were not converted automatically
...
Change-Id: I926b54c298d398e9a316b9c042fcae98f9210815
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132622
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-21 18:01:13 +00:00
5584c96fde
Enable prefer_single_quotes in analysis_server
...
All of the changes except in the analysis options file are from dartfix.
Change-Id: Icd9bf02ad07f71d1fc365979c7dfe18a792dc595
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132624
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-21 17:52:52 +00:00
48aa6470ca
Migration: plumb more fix reasons through FixBuilder to instrumentation.
...
Now there are only two circumstances in which an AtomicEdit won't have
information about the reason for the change:
- The AtomicEdit object was associated with adding or removing parens,
in which case we don't compute information about the reason for the
change because it's not straightforward to compute, and it should be
clear to the user anyway.
- Information about the reason for the change hasn't been plumbed
through properly (this should be addressed in follow-up CLs).
Since we are rapidly approaching a situation where nearly all
AtomicEdits will have reason information, the separation between
AtomicEdit and AtomicEditWithInfo now seems silly, so I just moved the
`info` object into AtomicEdit and removed AtomicEditWithInfo entirely.
Change-Id: I61afd9cd58b71d4695685e65d0142a2693b8e6b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132451
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-01-21 15:58:02 +00:00
ad3449c804
Add a server diagnostic page for viewing overlays/contents
...
Fixes https://github.com/dart-lang/sdk/issues/40196 .
Bug: https://github.com/dart-lang/sdk/issues/40196
Change-Id: I2bfa9df792cf3a7ac8284df9b75a78bea5cde705
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132662
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <danny@tuppeny.com >
2020-01-21 15:54:02 +00:00
7070347bbb
Generate single quoted strings where possible
...
Change-Id: I27546bbfb85f78021e515d00c2531b83b47fc71f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132480
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-20 21:52:34 +00:00
fdc8f08af9
Dartfix: add fixes, cleanup output, fix bug
...
This adds support for running the remaining lint fixes that were already
implemented but not yet supported in dartfix.
It cleans up the output by shortening the descriptions of most of the
pre-existing fixes.
It also marks the recently added fixes as not being default, because
making them default was unintentional and should be considered to be
a bug.
Change-Id: I381924144c89a8c8666d6f16009724ae0f2e1fbc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132540
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-20 21:44:29 +00:00
c790eccdf4
NNBD preview: Load region details when requested; Closes #40112
...
Change-Id: Ibcda2aa18c340c070e32160a470545b99d7751f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132560
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-01-20 18:46:28 +00:00
93ebbe2c7a
Enable use_function_type_syntax_for_parameters in analysis_server
...
Change-Id: I93cddc986c23e53557c647befc92d118b3d6ed43
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132459
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-19 17:11:11 +00:00
31bfacfda4
Migration: change API to make use of FixBuilder's "changes" data structure.
...
The new FixBuilder component of the migration engine communicates the
changes it produces using a "changes" data structure of type Map<int,
List<AtomicEdit>>, and is not compatible with the old
SingleNullabilityFix class (which made the incorrect assumption that
each SourceEdit was associated with a single fix). This CL changes
the migration engine's instrumentation API to use this data structure,
and changes its listener API to avoid reference to the
SingleNullabilityFix class. This allows SingleNullabilityFix to be
deleted.
This required changing AtomicEditWithReason so that it can hold
multiple fix reasons, and a NullabilityFixDescription. It does so
using a new object, AtomicEditInfo, and AtomicEditWithReason is
renamed to AtomicEditWithInfo.
In addition, the old FixInfo class is removed, since it carries the
same information as the new AtomicEditWithInfo class.
This required deleting the "incremental workflow" functionality from
UnitRenderer. This functionality was disabled, and I believe it
wouldn't have worked anyway (since it, too, made the incorrect
assumption that each SourceEdit was associated with a single fix).
Change-Id: Id965cfd803b408c66f15436017b87fc3e46521c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132306
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-01-19 16:50:01 +00:00
87fe06a03e
stop suggesting keywords in method type argument lists
...
Fixes: https://github.com/dart-lang/sdk/issues/40213
Change-Id: I2779d445e98c9056dd15afd2de657d92087ebff1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132400
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-01-17 21:56:35 +00:00
8fda644e10
lambda generation for positional args
...
Fixes: https://github.com/dart-lang/sdk/issues/40202
(See issue for animation of UX.)
Change-Id: I029a7768b887fedef4873f3fa23171d21df8808f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132380
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-01-17 21:10:17 +00:00
c9324972e8
NNBD preview: Fix html-escaping bug in region text
...
Change-Id: Icc6e52bf6f49f92fa67cd39f3985804e533b2972
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132305
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-01-17 19:08:17 +00:00
93b40dc037
NNBD preview: Flip non-null reasons back on
...
Change-Id: Idaf6adfc8a9960c8e6f6f8e421a795fdb374a921
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132163
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-01-16 22:42:58 +00:00
81003d8147
fix extension completions in mixins
...
* ensures extension member completions get added for mixins
* restructures and adds tests
Change-Id: I525450584b05e485027e46d775423e6d6f9f8e99
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132030
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2020-01-16 20:48:48 +00:00
43694c3db1
NNBD preview: Move reasons/details into separate fixed panel
...
#40112 , still needs more work before closing
Change-Id: Ic963e4678ca0692ebcbf1c8cf3ab955d9ae81427
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132028
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-01-16 20:43:39 +00:00
f4f890ed30
Highlight null and throw keywords
...
DartUnitHighlightsComputer2 does not highlight the "null" and "throw" keywords.
This will highlight them both as keywords.
Change-Id: I38a45435f7a35e9a56f289e7797c4a5d00134f08
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131071
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Auto-Submit: Simon Binder <simolus3@gmail.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-16 19:36:58 +00:00
05fdb62234
extension completions w/o dotTarget
...
Fixes: https://github.com/dart-lang/sdk/issues/39093
Change-Id: I9a576e4387b6a869a4779f15c16f7272f99d2acd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131848
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-01-16 14:54:01 +00:00
f689f145b1
Only call applyFileRemoved for analyzable files
...
Currently this is called for non-Dart files and may be contributing to a crash in Flutter - see https://github.com/flutter/flutter/issues/46616#issuecomment-574224525 and following comments.
Bug: https://github.com/flutter/flutter/issues/46616
Change-Id: I52fe539c265426dcd2ea978c2fbc8abfdfe4998f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131835
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <danny@tuppeny.com >
2020-01-16 14:44:06 +00:00
e08e18f369
Add edits for more fixes in the preview tool
...
Change-Id: Ice5cff20f4df1215265b75cf2b1c1fad83aec2a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131946
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-16 14:16:06 +00:00
b2842d9214
NNBD preview: alert user to disconnected preview server
...
Change-Id: Id6b84b5c5b948f5c562e9a4b9e10eecdb06f30a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131941
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-01-16 07:48:39 +00:00
9937277327
NNBD preview: Change navigation to be a tree; not interactive yet #40109
...
Change-Id: I42550b89533d4c1acba7998887f7601de2569f18
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131903
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-01-16 06:37:29 +00:00
74bf68a99d
Improve printPercentage(..) in pkg/analysis_server/lib/src/status/pages.dart to take an optional fractionDigits to pass to num.toStringAsFixed(..)
...
Change-Id: I641cf541626ef149663fc3f652b9f1ca1dfb02a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131847
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-01-15 19:56:55 +00:00
Brian Wilkerson