4b9bba55b4
Stoppp using trippple consonants
...
R=ahe@google.com
BUG=
Review-Url: https://codereview.chromium.org/2833073002 .
2017-04-21 17:50:13 +02:00
7149b90c7c
Tighten up handling of JS types and add test.
...
Side effect of this:
Fix bug where helpers in js_mirrors were specifying that name had to have type String when it could really also be a JS Symbol as well.
Fix bug where top level JS interop members using the external keyword but no @JS keyword were not implemented.
Update js_typed_interop_test.dart so it can work in DDC.
Add regression test for jsify call with native function type arguments.
BUG=
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2827333003 .
2017-04-21 08:44:00 -07:00
21c38e6c8c
Various DDC fixes for windows
...
This gets most tests compiling and running on Windows.
Fixes #27450
Fixes #27797
Fixes #28752
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2833633002 .
2017-04-20 11:30:57 -07:00
b98729503c
Fix ddc perf issue
...
This brings compilation time on large_class_declaration_test down from 30s to 4s. Just analysis is about 3.2s. (All #s without snapshotted tools.)
Fixes #29234
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2834663002 .
2017-04-20 11:24:35 -07:00
1112ad24cc
Make conflicting summary check configurable
...
Not sure this is a great idea. DDC will go awry if multiple copies of
the same type exist. Can analysis or any other analyzer-based tool?
R=brianwilkerson@google.com , paulberry@google.com
Review-Url: https://codereview.chromium.org/2829493002 .
2017-04-20 09:20:08 -07:00
8a64625d81
Regenerate DDC artifacts
...
TBR=jacobr@google.com
Review-Url: https://codereview.chromium.org/2830983002 .
2017-04-19 16:26:22 -07:00
0dbb32f406
Run formatter on dev_compiler.
...
BUG=
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2830503002 .
2017-04-18 16:16:14 -07:00
b280a7803d
Dev compiler debugger related tweaks.
...
Optimize dynamic call tracking using random sampling.
Apply source maps to improve dynamic call tracking accuracy.
Dynamic calls within the sdk are now attributed correctly.
Fix bug formatting modules where we were incorrectly flagging them as JS.
BUG=
R=jmesserly@google.com , vsm@google.com
Review-Url: https://codereview.chromium.org/2811343002 .
2017-04-17 14:57:31 -07:00
9ce608e89d
[dart:io] Adds ProcessInfo.{max,current}Rss. Adds OS::MaxRSS on Fuchsia.
...
R=rmacnak@google.com
Review-Url: https://codereview.chromium.org/2822943002 .
2017-04-17 14:41:40 -07:00
a3d2e49198
Revert "Revert "Report error if the same uri appears in multiple summaries.""
...
Relanding after fixing package_bundle_reader_test.dart.
Note, original CL (already reviewed here: https://codereview.chromium.org/2781483007/ ) is patch set 1.
Test fix is patch set #2 .
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2825503002 .
2017-04-17 10:11:21 -07:00
dcdccf4750
Revert "Report error if the same uri appears in multiple summaries."
...
This reverts commit 2afa21bb2cTBR=jmesserly@google.com
BUG=
Review-Url: https://codereview.chromium.org/2821933002 .
2017-04-17 08:07:36 -07:00
2afa21bb2c
Report error if the same uri appears in multiple summaries.
...
Fixes #27025
R=brianwilkerson@google.com , jmesserly@google.com
Review-Url: https://codereview.chromium.org/2781483007 .
2017-04-17 07:32:59 -07:00
b76e2d67cf
fix #29346 , ensure all nodes are implemented by DDC's code generator
...
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2822633003 .
2017-04-14 10:10:50 -07:00
6fbdd19ddb
Various fixes for sync socket implementation.
...
Revert "Revert "Added sync_socket.h include in sync_socket_win.cc""
This reverts commit 2bd6168e1ebf35f6dbd9b2724339362c493377fc.
Revert "Revert "Added synchronous socket implementation to dart:io.""
This reverts commit a47bce03f5502dac7fb12e777e87b5aa1cfc830b.
BUG=
R=zra@google.com
Review-Url: https://codereview.chromium.org/2814773004 .
2017-04-12 14:20:48 -07:00
9bdc5bb751
add scripts to run/debug DDC output on simple test cases
...
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2815913002 .
2017-04-12 11:36:23 -07:00
04bb68bb09
Better DDC sourcemap generation for lambdas
...
This doesn't fix the entire problem, there's still a Chrome issue that it's not clear we can work around, but it helps some. https://bugs.chromium.org/p/chromium/issues/detail?id=676388
There are three distinct issues here affecting Chrome sourcemap usage for DDC programs with single-line lambdas.
1 - We may introduce a synthetic "as SomeType" in a parameter. The synthetic token ends up with a large negative length, from its offset to the beginning of the file, which can confuse sourcemaps.
2 - We have no entry for the blank line following the lambda. The devtools asks for the mapping from (selectedLine, 0) to (selectedLine +1, 0) and if there's no mapping for either it refuses to set the breakpoint. So this artificially forces the mapping from the last character on the line to be to the beginning of the next line instead.
3 - With a lambda we introduce a constructed Return JS node and make a block. Those nodes weren't getting annotated, so they had no source information.
BUG=
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2815443003 .
2017-04-12 11:31:16 -07:00
b439bd9a54
Revert "Added synchronous socket implementation to dart:io."
...
This reverts commit a1f87ebdb8bdec13e865https://codereview.chromium.org/2812153002 .
2017-04-11 15:18:46 -07:00
a1f87ebdb8
Added synchronous socket implementation to dart:io.
...
BUG=
R=zra@google.com
Review-Url: https://codereview.chromium.org/2803543006 .
2017-04-11 14:41:09 -07:00
bc3089838c
Reify implicit casts for FutureOr
...
Before landing, two issues to resolve:
(1) We appear to allow sideways casts now without static error - e.g.,
List<Object> -> FutureOr<List<String>>
Is that intended? If so, it breaks an assumption that implicit casts
are from supertype to subtype.
(2) LUB and FutureOr
It appears that the LUB of, e.g., String and Future<String> is Object.
See fixes in tests to record casts back to FutureOr.
Fixes #29251
R=leafp@google.com
Review-Url: https://codereview.chromium.org/2801683004 .
2017-04-07 17:33:34 -07:00
10c5de82c8
Invoke debugger on nsm
...
Missed this one when I added debugger statements earlier
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2565183004 .
2017-04-07 14:45:09 -07:00
8ada796a86
fix #29233 , final fields can be settable in a mock
...
also fix #29273 , user mixins can override native methods
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2803673007 .
2017-04-07 14:12:49 -07:00
1975c8431a
Migrate async tests to strong
...
No modifications to the actual tests
R=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2802973005 .
2017-04-07 12:46:12 -07:00
5c3bcff375
DDC fix for foreign futures
...
Fixes #29287
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2804113002 .
2017-04-06 14:52:59 -07:00
247fc68d21
fix #29228 , let* precedence should match generated expression
...
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2804833002 .
2017-04-05 12:40:42 -07:00
aa3fba7d8d
Preserve async markers when parsing js_ast
...
Fixes #29252
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2797873002 .
2017-04-05 12:13:22 -07:00
e4e7dffadb
fix #29182 , generate top level const fields lazily
...
This fixes an ordering issue, but also may help load time.
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2797443007 .
2017-04-04 16:18:46 -07:00
565408593b
Remove _StdSink._isTranslatable field.
...
The field is not used since https://github.com/dart-lang/sdk/commit/141b6351baacaedf23e740b5b7354970f2ac0979 ,
but it is final and not initialized, so this causes an error during
analyzer tests.
R=paulberry@google.com , zra@google.com
BUG=
Review-Url: https://codereview.chromium.org/2800453002 .
2017-04-04 12:56:44 -07:00
4827ac4f38
Remove references to renamed test.
...
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2790893002 .
2017-04-04 09:51:29 +02:00
509bcd58e1
Fix type checks and display for JS interop types.
...
Re-enable formatter test that had been disabled when someone changed type
name display for Foo<dynamic> types.
Fix bug in how type names were displayed for JS interop types.
BUG=
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2789663005 .
2017-04-03 08:34:20 -07:00
46d6c56c96
Fix ddc async test code
...
Fortunately, not too many false passes.
R=jacobr@google.com
Review-Url: https://codereview.chromium.org/2792703002 .
2017-03-31 15:57:08 -07:00
3be5099a8c
Don't format on DDC presubmit
...
The primary presubmit (PRESUBMIT.py) now enforces this on git cl
upload. It also uses a difference version of the formatter, so
dropping this avoids that annoyance.
R=jacobr@google.com
Review-Url: https://codereview.chromium.org/2791643003 .
2017-03-31 15:06:16 -07:00
466d4ffb9c
Add runtime tests for ignored checks
...
Tests for https://codereview.chromium.org/2788933002/
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2789933002 .
2017-03-31 13:31:59 -07:00
08f085727e
Fix ignore on FutureOr
...
I'll look into adding tests - these eventually supposed to *not* get ignored (see #27223 )
R=leafp@google.com
Review-Url: https://codereview.chromium.org/2788933002 .
2017-03-31 09:30:16 -07:00
a7465d942f
Update test expectations to reflect errors that are now warning.
...
BUG=
Review-Url: https://codereview.chromium.org/2785183003 .
2017-03-30 14:54:35 -07:00
bc923bed16
[dart:io] Reland: Adds Platform.localeName
...
The Mac OS build broke because a typedef wasn't added until 10.12.
related #29126
Review-Url: https://codereview.chromium.org/2786183003 .
2017-03-30 13:51:46 -07:00
e75df3cce3
Revert "[dart:io] Adds Platform.localeName"
...
This reverts commit ae6d854ec6https://codereview.chromium.org/2791453002 .
2017-03-30 13:35:02 -07:00
ae6d854ec6
[dart:io] Adds Platform.localeName
...
related #29126
R=fschneider@google.com
Review-Url: https://codereview.chromium.org/2785073002 .
2017-03-30 13:31:11 -07:00
84864e3415
DDC fix for Edge
...
Patch from zjd.
R=jacobr@google.com
Review-Url: https://codereview.chromium.org/2780903004 .
2017-03-29 12:22:45 -07:00
7a809bcc02
Add requirejs to repo for DDC
...
Fixes #29140
R=jakemac@google.com , whesse@google.com
Review-Url: https://codereview.chromium.org/2782213002 .
2017-03-29 08:05:40 -07:00
cf25e7f5cb
Fix top-level inference errors for most of the newly failing tests.
...
Update analyzer status files and DDC expections.
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2779843004 .
2017-03-28 12:16:09 -07:00
1c504f8945
Fix #28120 , strong mode allows field overrides
...
Fix #28119 , DDC supports field overrides without @virtual
Fix #28801 , devirtualize private fields in DDC where possible
Fix #28589 , stop supporting @virtual in strong mode
R=leafp@google.com , vsm@google.com
Review-Url: https://codereview.chromium.org/2781443003 .
2017-03-28 10:26:36 -07:00
27ab6478b9
Report errors for the new top-level inference rules.
...
We also stop type inference most of these cases with task based analysis.
Summary based analysis is not changed yet.
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2782533002 .
2017-03-28 09:41:04 -07:00
50ceaa4c04
Fix for #29003
...
This is an alternative to the other CL. It just uses the result of
dart.mixin instead of declaring a new class. That preserves the assumption (at least at runtime) that the mixin class directly inherits from Object.
We were also not declaring interfaces for ClassTypeAliases.
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2783443002 .
2017-03-27 16:06:13 -07:00
ac68d598cf
Add patch code for List.filled growable param
...
Looks like a missing param doesn't break patch_sdk. I think this was a recent add.
Fixes #28508
R=jakemac@google.com , jmesserly@google.com
Review-Url: https://codereview.chromium.org/2771953004 .
2017-03-24 14:27:47 -07:00
d8c8a7b327
Mark tests no longer expected crash
...
Brian: looks like these started working on a recent CL of yours.
TBR=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2769333003 .
2017-03-24 08:46:21 -07:00
27d14402fa
Skip test on chrome canary
...
TBR=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2770033004 .
2017-03-24 08:07:51 -07:00
dba842bcc8
Handle casts from Number to FutureOr<double>.
...
Fixes https://github.com/dart-lang/sdk/issues/29128 .
BUG=
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2772573003 .
2017-03-23 13:33:33 -07:00
053d2ce14f
Fix for dcall on callable class
...
(Note, regenerated files aren't being uploaded)
Fixes #29148
R=leafp@google.com
Review-Url: https://codereview.chromium.org/2774623004 .
2017-03-23 13:14:58 -07:00
4d983162d5
Fix status for canary
...
This particular test seems to have frequent canary only errors. Not
sure there is a better way - e.g., alway ignore on Canary?
TBR=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2769873004 .
2017-03-23 10:21:32 -07:00
c3505f7d72
Fix async iterator runtime type errors
...
Seeing errors on the bots triggered by a recent SDK change (FutureOrT typing?). See travis for current breakage.
TBR=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2769883002 .
2017-03-22 20:15:00 -07:00
Erik Corry