4e3d3bdd9f
Add support for converting from server to plugin protocol objects
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2830903004 .
2017-04-21 08:37:12 -07:00
6407af5dcb
Clean up TODOs
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2830793007 .
2017-04-20 15:19:16 -07:00
aa36e43426
Add plugin support for getAssists
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2832643005 .
2017-04-20 13:52:34 -07:00
b9c214f374
Compete try-statements
...
R=brianwilkerson@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2834513004 .
2017-04-20 13:09:23 -07:00
e1a2c81d0b
Update PluginWatcher to be more efficient
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2830933005 .
2017-04-20 12:39:50 -07:00
f8e18d0888
Revert "Update PluginWatcher to be more efficient"
...
Review-Url: https://codereview.chromium.org/2834673002 .
2017-04-20 10:53:03 -07:00
a3697af085
Update PluginWatcher to be more efficient
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2830063002 .
2017-04-20 09:25:37 -07:00
ba3ed4ba37
Initial support for getting fixes from plugins
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2830863002 .
2017-04-19 15:00:00 -07:00
0829174516
Complete for-each and switch statements
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2826283002 .
2017-04-19 14:44:41 -07:00
91d6dcf9fb
We cannot use relative URIs to reference files outside of a package.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2830733002 .
2017-04-19 10:09:14 -07:00
23c0caf4dc
Revert "New Lint quick-fix: prefer_collection_literals ( #29378 )"
...
This reverts commit 6a56c86c81R=karlklose@google.com , loitsch@google.com
TBR=casanueva@google.com
BUG=
Review-Url: https://codereview.chromium.org/2827863003 .
2017-04-19 12:49:07 +02:00
6a56c86c81
New Lint quick-fix: prefer_collection_literals ( #29378 )
2017-04-18 18:55:08 -07:00
6a19d96ee2
Complete for-statement
...
R=brianwilkerson@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2824233002 .
2017-04-18 15:20:31 -07:00
c386e41f25
New Lint quick-fix: avoid_init_to_null ( #29367 )
2017-04-18 14:13:53 -07:00
b9f9ad24f1
Add completion for do-stmt, refactor for reuse
...
R=brianwilkerson@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2816943005 .
2017-04-17 10:56:26 -07:00
124f874b4a
Make copy of the drivers list in SearchEngineImpl2 to avoid ConcurrentModificationError.
...
I think this happens when a driver is disposed why search is in
progress. So, we need to make defensive copies.
This also makes me realize that we don't handle situations when
a driver instance is disposed, but it has pending requests, such as
getResult(), getIndex(), etc - actually any getXXX(), and search. As
it is now, I think we just leave these Future(s) and they never
complete.
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2818163003 .
2017-04-17 09:41:52 -07:00
d55dc29727
Temp fix to allow plugins to serve the getErrors APIs.
...
Had to allow a means of supplementing existing errors/line info, but
then also for where dart has no response whatsoever (like html), need a
way to provide analysis options and line info in addition to errors.
Happy to clean it up, but also not very motivated to make it perfect
since it should be temporary.
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2815643004 .
2017-04-13 10:37:39 -07:00
3dcf0e31c5
Split error code to ease future improvements
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2813553006 .
2017-04-11 13:35:38 -07:00
4cf6da3a9f
More enhancements to ChangeBuilder
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2809943002 .
2017-04-11 12:15:30 -07:00
3406c4c1be
Fix renaming that got dropped
...
R=brianwilkerson@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2812733002 .
2017-04-11 09:52:51 -07:00
3e9d358131
Add missing checks for null imported/exportedLibraries.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2812673002 .
2017-04-10 11:29:38 -07:00
3be10faaee
Issue 29303. Prefer import updates and SDK imports over other imports.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/29303
Review-Url: https://codereview.chromium.org/2808803003 .
2017-04-10 09:52:43 -07:00
9a852506c6
Tweaks to the analysis server --help output.
...
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2810553002 .
2017-04-10 07:06:19 -07:00
e572bf93ec
Add 4 integration tests for the analysis domain.
...
BUG=
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2808623002 .
2017-04-08 20:56:00 -07:00
eadc6af226
Statement completion framework with a few examples
...
R=brianwilkerson@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2803313002 .
2017-04-07 13:55:50 -07:00
46b0c1da56
merge fasta.Keyword into analyzer.Keyword
...
R=paulberry@google.com
Review-Url: https://codereview.chromium.org/2797133008 .
2017-04-06 16:52:01 -04:00
99aefce48c
do not allow built-in keywords to specified when refactoring
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2802433002 .
2017-04-04 17:13:42 -04:00
0ea61b64ab
Bug fixes and added support for creating source edits
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2790173003 .
2017-04-03 10:56:41 -07:00
dd49e79f74
Add context information to driver and add hooks for plugin management
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2795743002 .
2017-04-03 10:13:45 -07:00
4a2cca3a52
Add getStatementCompletion to the API spec
...
R=brianwilkerson@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2784673003 .
2017-03-30 10:13:21 -07:00
394a106074
Remove unused imports.
...
BUG=
R=danrubel@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2786553002 .
2017-03-29 07:10:44 -07:00
483066a697
Fix for Quick Fix to import SDK classes.
...
It's not 100% replacement, we handle SDK libraries just as any other
library, if it has not been imported yet somewhere, we don't know
about it. But probably this covers the most often case of using a
library in a new file of the project that already uses this SDK
library.
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2781963002 .
2017-03-28 14:15:52 -07:00
84f2f4a677
Enhance the change builders
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2776233002 .
2017-03-28 08:29:30 -07:00
5a237935f0
Fix tests to verify defaultArgListString specified as null are null.
...
* introduces a sentinel default value to ensure that we know when asserting if `null` was specified or the result of an excluded optional arg
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2769223004 .
2017-03-24 11:53:00 -07:00
4a9cabf493
Arglist children: default value gen fixes.
...
* fixed arglist codegen (include params)
* fixed defaultTextRange generation (and added tests)
* cleanup (followup from https://codereview.chromium.org/2768273003/
R=brianwilkerson@google.com , danrubel@google.com
See: https://github.com/flutter/flutter-intellij/issues/832
Review-Url: https://codereview.chromium.org/2771123002 .
2017-03-24 09:36:24 -07:00
6f846bcd53
<Widget> boilerplate for Flutter children: suggestions.
...
Cleanup (tracked in TODOs) and consolidation to follow.
R=brianwilkerson@google.com , danrubel@google.com
See: https://github.com/flutter/flutter-intellij/issues/832
Review-Url: https://codereview.chromium.org/2768273003 .
2017-03-23 15:20:42 -07:00
61d5c85b48
Allow navigation from var when there is an inferred type (issue 29091)
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2769813005 .
2017-03-23 10:34:09 -07:00
03398561a1
IdeOptions awareness for Driver (for access via IDEA registry).
...
R=brianwilkerson@google.com
See: https://github.com/flutter/flutter-intellij/issues/463
Review-Url: https://codereview.chromium.org/2768003003 .
2017-03-23 09:33:37 -07:00
df06af12eb
Completion boilerplate for Flutter cons children (flutter-intellij#463)
...
* plumbs IDE options into completion requests
* simple POC test
More tests and a bit of cleanup to come.
R=brianwilkerson@google.com
See: https://github.com/flutter/flutter-intellij/issues/463
Review-Url: https://codereview.chromium.org/2771653002 .
2017-03-22 15:14:28 -07:00
a231501692
Format generated files.
...
BUG=
R=brianwilkerson@google.com , jacobr@google.com
Review-Url: https://codereview.chromium.org/2765953002 .
2017-03-21 15:54:16 -07:00
d95508183d
Introducing IdeOptions.
...
* add simple `IdeOptions` class
* remove unused `ServerOptions`
R=brianwilkerson@google.com
See: https://github.com/flutter/flutter-intellij/issues/463
Review-Url: https://codereview.chromium.org/2765063002 .
2017-03-21 14:48:27 -07:00
9a66373ee9
Fix errors and warnings
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2760993002 .
2017-03-20 11:30:32 -07:00
221125d1ac
Add quick-fix to convert child: to children:
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2753123003 .
2017-03-17 14:49:42 -07:00
319b726f8b
Guard analysis server's getAnalysisResult, must be dart
...
Otherwise spews errors inside html files when users do things like
autocomplete in the middle of them.
BUG=
R=brianwilkerson@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2755023002 .
2017-03-17 10:42:00 -07:00
a993294503
Format all analyzer packages
...
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2753923003 .
2017-03-16 16:11:43 -07:00
9a9074bf6b
Add assist to convert child: to children: in Flutter new-exprs
...
R=brianwilkerson@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2749283004 .
2017-03-16 07:44:05 -07:00
550443f147
Improve performance of PluginLocator by caching results
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2754473005 .
2017-03-16 07:28:34 -07:00
f33d072d91
Correct target of ADD_MISSING_REQUIRED_ARGUMENT fixes (flutter-intellij#788)
...
* corrects insert target of `ADD_MISSING_REQUIRED_ARGUMENT` fixes
* updates `assertHasFix` to optionally verify fix target
R=brianwilkerson@google.com
Fixes: https://github.com/flutter/flutter-intellij/issues/788
Review-Url: https://codereview.chromium.org/2749373002 .
2017-03-15 13:27:27 -07:00
8afab37d55
Add PluginWatcher to watch for new plugins that need to be run
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2750483006 .
2017-03-15 11:26:14 -07:00
985160c08d
Replace making getInnermostContext public with making a getFolder method
...
This way SingleContextManager can fulfill the interface too (it can't
provide a ContextInfo, and the concept of `innermost` doesn't really
exist).
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2754473004 .
2017-03-14 16:13:16 -07:00
Brian Wilkerson