dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
85,733 Commits 2 Branches 0 Tags
3e17635bca7c90a88440f3fced7cfcf324ce1c19
Commit Graph

1433 Commits

Author SHA1 Message Date
Janice Collins e63e4937e9 Add a fix for HintCode.UNUSED_ELEMENT_PARAMETER. 
This repurposes an existing lint CorrectionProducer to handle both
the lint and the hint.

Bug: https://github.com/dart-lang/sdk/issues/49074
Change-Id: Iacd597ca2151cdb80be9ddae0847128b4cc700a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246989
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
 2022-06-08 16:57:02 +00:00
Brian Wilkerson 9e8132da51 Prepare to gather analytics about the number of analysis roots and priority files and the kinds of refactorings 
Let me know if there are other values you can think of related to
requests that ought to be captured, especially in LSP.

Change-Id: Id9e92f54dd9ade3541d3ca8dc11450fb6affee0b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247328
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Danny Tuppeny <danny@tuppeny.com>
 2022-06-07 13:37:18 +00:00
pq 3290d7a137 [data driven] support moving symbols across packages 
See: https://github.com/dart-lang/sdk/issues/48997

Change-Id: Iad16b9eae0523bc4bc14537af642b05efa75b6f7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246663
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-06 16:53:38 +00:00
Danny Tuppeny 086727ee6f [analysis_server] Migrate from using Markdown/TypeScript spec for LSP types to JSON model 
Change-Id: I58dbbbee48febc45304b27a95fedfef289479265
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247340
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-06 14:27:48 +00:00
Konstantin Shcheglov 09967d8c25 Use textual state dumps for Cider tests. 
This allows us to see which files were read, unlinked summary created,
how many many references to data we have, how we discard data from the
byte store, how we discard libraries from LinkedElementFactory,
and linked summaries from the byte store, etc.

Change-Id: I4eb57d96db8e1f816e7b932b727a6a92e6b07248
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247244
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-06-05 03:11:37 +00:00
Brian Wilkerson 84402e7824 Capture analytics about notifications 
Let me know if there's other information you think we should be
reporting or if this won't accurately capture the time it takes to
handle notifications.

Change-Id: I7c57316ad37bd6bb9add9ab6d27e6f3428f4b491
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247241
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Danny Tuppeny <danny@tuppeny.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-03 19:51:12 +00:00
Brian Wilkerson fad5a668a9 Use a JSON encoding for percentile data being sent to analytics 
Change-Id: Ie96f81e9cdc7585a5027db7b44f7f39cb7e763b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247240
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-03 16:38:21 +00:00
Alexandre Ardhuin 42778832a1 allow rename on extension via fix_data.yaml 
Closes https://github.com/dart-lang/sdk/pull/49164

GitOrigin-RevId: 3bc7a3de9781d0005c041145affe6c0ed3ae744b
Change-Id: I7e0357cd928636d0556d3dea2aac083529d089c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246983
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-03 00:39:55 +00:00
Konstantin Shcheglov 30d0fd72cd Use initialized 'late final' in GoogleAnalyticsManagerTest. 
Change-Id: I2d9775cf5f53e060162e0dd59f0fecc1a38f59fb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246991
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-06-02 21:52:35 +00:00
Brian Wilkerson f9acb37545 Add some tests of analytics 
Change-Id: Icd4b86346d199649b156776df9835414a1ad41cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246980
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-02 19:39:55 +00:00
Janice Collins be13f8b89a Add a fix to remove print expression statements for avoid_print. 
Bug: https://github.com/dart-lang/sdk/issues/45921
Change-Id: I9dc1726e19fdd592d42bc3d7eb6aa6a1b1944279
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246051
Commit-Queue: Janice Collins <jcollins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-02 18:30:57 +00:00
Konstantin Shcheglov 7c652aff38 Change FileResolver() constructor to named parameters. 
Change-Id: I9040d4947ce431002ef9469244aa582e3dd2de2d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246760
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
 2022-06-01 16:46:56 +00:00
Danny Tuppeny 20b7de7b57 [analysis_server] Provide UseCurlyBraces as a fix for always_put_control_body_on_new_line 
Fixes https://github.com/Dart-Code/Dart-Code/issues/3981.

Change-Id: I3fc5579e2150c8e0faa5f7692b837a27c9ce732d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-27 17:55:30 +00:00
Konstantin Shcheglov b253c4a004 Suggest static fields/getters. 
Change-Id: Ibf422215f1f1a6ddb062302a6c3e7b831b176468
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229324
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-26 16:44:31 +00:00
Konstantin Shcheglov 4cf8091c8d Remove PartWithoutLibraryResult, consider a part to be a library instead. 
Bug: https://github.com/dart-lang/sdk/issues/49046
Change-Id: I20413cd2b2ff284d2e4b92949f057c97b98fb49b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246042
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-25 20:51:04 +00:00
Ahmed Ashour a6fcb56901 Fix typos 
Fixes #49094

TEST=ci

Change-Id: I23cdcb5ad2fc83e5e91d80e34b66af186c0cb923
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245820
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Slava Egorov <vegorov@google.com>
Reviewed-by: Slava Egorov <vegorov@google.com>
 2022-05-24 09:10:51 +00:00
Keerti Parthasarathy 19d0d888f5 Add support for import rename 
Change-Id: I7358e697d022302f060eb751415c28087c9642a4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245741
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2022-05-23 23:17:30 +00:00
Brian Wilkerson 1827c4caf4 Fix an exception in sort_constructors_first 
Change-Id: I08f4f626e948240e4a6e6faba190714f3c22d155
Fixes: https://github.com/dart-lang/sdk/issues/48966
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245622
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-22 01:08:36 +00:00
Brian Wilkerson c038e3b3c1 Clean up in analytics 
This
- converts PercentileCalculator to sort entries, as previously suggested,
- adds the number of values to the dump of a PercentileCalculator, and
- fixes the name of a class to conform to conventions.

Change-Id: Icb25a3adfc922b6d5b394883853eeeff968e4b89
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245460
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-19 21:53:01 +00:00
Ahmed Ashour 2bb220a95d [analyzer] CreateConstructor to handle undefined enum constructor 
Fixes #48481

Change-Id: I237bcbf1cb3202435c9bda31467a76f27e3dc896
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245169
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-19 20:52:21 +00:00
Konstantin Shcheglov e28972166c Return PartWithoutLibraryResult when a part without its library. 
Change-Id: I5eb384d77c263b489b10e112a79115bf028e79af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245081
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-18 16:45:53 +00:00
Brian Wilkerson d4c4408f10 Add initial support for gathering analytics in the analysis server 
I'm primarily interested in feedback on the general approach, which is
to have a single object to which all significant events are reported and
which is responsible for reporting or aggregating the data as
appropriate.

I removed a getter from AnalysisServer that should no longer be used,
though I haven't changed the code that directly references the
underlying analytics object so that existing code won't be impacted.

I also added a couple of references to the new class, but because we're
always creating a noop version there won't be any impact on users at
this point.

Once the overall approach has landed I'll start wiring up the existing
methods and adding new methods as appropriate.

Change-Id: I419f409c9df82fdc62a14128bb1f67723e9cf55f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244983
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-17 20:46:16 +00:00
Ahmed Ashour 36acc59dcb [analyser] support code completion for errors and enable-experiment 
Fixes #48904

Change-Id: I45a4f5feefe066dabeaab3f754d6d0e091a4aea5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-16 21:20:36 +00:00
Ahmed Ashour 8a5eb80d8a [analyzer] ConvertToInitializingFormal to handle DefaultFormalParameter 
Fixes #48994

Change-Id: Iff632f9509d07dc5cca7510b18f4d16b23751226
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244926
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-16 16:52:15 +00:00
Ahmed Ashour cbd12a4672 [analyzer] AddMissingEnumCaseClauses to handle final and static fields. 
Fixes #49003

Change-Id: I2df2f4bef2dc63645497f9070807c12d0dd9acf5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244626
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-16 14:32:15 +00:00
Ahmed Ashour 3c10e484c9 Flutter Widget Key to be nullable 
Fixes #46913

Change-Id: Id2d72ce497eaa1512c2bb95f023c9ff0160c5005
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210128
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-11 19:20:24 +00:00
Danny Tuppeny 80fb1a56db [analysis_server] Add shared protocol.dart file for LSP 
In an upcoming change some types will between these files. To reduce the size of that (already very large) CL and because the distinction between spec-generated/custom-generated types was unnecessary anyway, this adds a single import for LSP protocol-related types.

Change-Id: I322447d6c979538c12014d87875176e1bf2adca7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244244
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-11 15:28:35 +00:00
Ahmed Ashour e630a3adef [analyzer] fix for use_key_in_widget_constructors should use super parameters when possible. 
Fixes #48946

Change-Id: I45afc5717eb17845f50ef4aa77fb554fb88e2ec6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244242
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2022-05-10 18:20:33 +00:00
Ahmed Ashour a67c07c40f Fix for use_key_in_widget_constructors to add key at the end 
Fixes #48917

Change-Id: Ie9a1e06188ad958ba89cd7b37081878211b3e90b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243905
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-10 14:15:43 +00:00
Konstantin Shcheglov 359e597cec Switch Workspace to Packages. 
PackageMapUriResolver is still based on Map.

Change-Id: I7d68f9dbc7d970b22c8e1a01d8e816b3e5723f34
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244047
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-05-09 22:42:32 +00:00
Ahmed Ashour 087c57f488 [analyzer] fix for use_key_in_widget_constructors to handle non-constant value 
Fixes #48915

Change-Id: I9103f02f6b5a7668e0a937e27e237b310fa22958
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243462
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-09 15:54:25 +00:00
Brian Wilkerson 748ee46cf4 Stop using main in test code in more places, part 4 
This is the last set of changes in the analysis_server package.

Change-Id: I0cffd41118ba985fc1d90cc3ae25447abb62a212
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243934
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2022-05-08 14:32:41 +00:00
Alexandre Ardhuin 04bcc30c58 add trailing comma fix for literals 
This PR extends the`add_trailing_comma` fix to handle for the [upcoming support of list/set/map literals in `require_trailing_commas`](https://github.com/dart-lang/linter/pull/3340).

It's likely the tests in this PR will fail until sdk update the linter dependency to include https://github.com/dart-lang/linter/pull/3340

Closes https://github.com/dart-lang/sdk/pull/48968

GitOrigin-RevId: 24b374ec39b313640f7c06fbf8f725c09d3ed7ac
Change-Id: I066a8524d18a4213eb5300b9310bdb4a562f0e27
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243920
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-06 15:07:20 +00:00
Konstantin Shcheglov f7d4d0d85c Add failing tests for SortConstructorFirst with comments. 
Bug: https://github.com/dart-lang/sdk/issues/48966
Change-Id: I2d34a7cc240171759dd331f23118745a5d8ff80e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243841
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-05 19:03:35 +00:00
Brian Wilkerson 477b3a1cbd Stop using main in test code in more places, part 2 
Change-Id: Ifbcdd950f2643349dfd645c1f4a26c3ee0c916e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243682
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-05 17:16:15 +00:00
Brian Wilkerson 6af134d78b Stop using main in test code in more places 
Change-Id: If3bac4c92d7a165528d45479e6594cbdcfc1708c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243641
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2022-05-04 19:25:55 +00:00
Danny Tuppeny 4261df2dbd [analysis_server] Remove qualified static members from code completion 
Change-Id: Ia8ef009fa99cd495ca0ed3f825f3d951136341e2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243620
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-04 14:22:24 +00:00
Keerti Parthasarathy 630ad11de4 Add rename constructor 
Change-Id: Ie4815ed4b4db93cfad9307702fc86172685cfb17
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/242160
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2022-05-03 04:51:37 +00:00
Brian Wilkerson f484e2e5db Remove some dead code related to handler domains 
Change-Id: I4e96188349b726e144c5a799db5f019be7d809eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243040
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-04-29 13:34:33 +00:00
Ahmed Ashour 3428b449d1 Fix the type of (after-first) named parameter in ArgumentList. 
Fixes #48514
Fixes #48310

Change-Id: I6cab8052a91a51a4c44470e5be81b78ef68e56cc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/242281
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-04-23 16:06:52 +00:00
Ahmed Ashour 1f27a7dca9 Add fix for MUST_CALL_SUPER 
Fixes #33985

Change-Id: I5ff66bc01dde162979a21ebe8374398c2ffea783
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/240846
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-04-23 04:57:51 +00:00
Konstantin Shcheglov 994b2e2f47 Deprecate newAnalysisOptionsYamlFile2(), use newAnalysisOptionsYamlFile(). 
Change-Id: Ia86808f649459e6c4c9c7d4e488273c1e593a85b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241515
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-04-19 15:49:57 +00:00
Konstantin Shcheglov 20b560226e Rename newFile2() to newFile(). 
Change-Id: I1c2a4f15dee607a0a6241dfaf2d764a7d284389b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241510
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-04-19 02:59:57 +00:00
Brian Wilkerson 4e6bb1722c Fix a bug in convert_to_super_parameters 
Fixes: https://github.com/dart-lang/sdk/issues/48831
Change-Id: I7f4e490849750ef48ece2a925be13621e07bdcb8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241505
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-04-19 00:01:37 +00:00
Ahmed Ashour 4a143e26d5 Correct quick fix for prefer_initializing_formals when the types are different. 
Fixes #48804

Change-Id: I8cb5ed2f6fb5fb9296aafb64eb1930914a644431
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241221
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-04-18 15:20:07 +00:00
Ahmed Ashour 06f5a50982 Add fix for UNDEFINED_ENUM_CONSTANT to suggest similar names 
Fixes #47643

Change-Id: Ic5e5d6464c0480c3060540077b59f229d15e7501
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241000
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-04-18 15:18:12 +00:00
Ahmed Ashour 3d99bccc7d Correct the use_super_parameters quick fix 
Fixes #48803

Change-Id: Ia4ddaae80ef4fcf7a5053a492a0f75d118aea6af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241220
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-04-15 22:30:14 +00:00
Ahmed Ashour afe4bb9942 Add a fix to remove var for VAR_RETURN_TYPE 
Bug: #48779

Change-Id: I753a7205594457c1f7de29e146ed7dd05a772359
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/240841
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-04-15 19:49:34 +00:00
Konstantin Shcheglov 833795d54c Enforce use_super_parameters in analysis_server/. 
Change-Id: I834e56b62df36782772e299e4279c408e9f8ec0d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241241
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-04-15 18:13:44 +00:00
Ahmed Ashour cf53208676 Add fix for undefined_enum_constant. 
Bug: #47643
Change-Id: I45b59338be548214a220390bb0947451a84451f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239667
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-04-15 15:50:24 +00:00