a032a4c952
Revert "Fix file name handling on windows"
...
This appears to break on bazel.
BUG=
R=nshahan@google.com
Review URL: https://codereview.chromium.org/2422403002 .
2016-10-17 15:27:48 -07:00
2305865365
Start cleaning up the HTML tests.
...
My initial goal was just to move some of the HTML tests off unittest,
but that ended up slurping in some other changes as well. I haven't
finished going through all of the tests, but this puts the
infrastructure in place and fixes a batch of them. I'll do more next.
Changes:
- Add a "minitest" package. This shims just enough of the unittest/test
API to make it easy to swap it out for unittest without having to
rework the entire test.
- Go through the HTML tests from A-J and change them to use minitest
when possible. The ones that aren't possible use asynchrony.
Minitest doesn't support async tests (yet, maybe).
- Triage those tests and enable ones that are passing. Mark them failing
if failing. Filed a couple of tracking bugs for the common issues,
but for other cases, I just left a comment.
- In the process of this, I went ahead and make some of the affected
tests strong mode clean if they weren't already and it was easy.
- Synchronize changes between dev_compiler's fork of expect and
pkg/expect. We'll want to unfork those at some point. D-:
This gets dev_compiler from 1985 tests to 2042.
R=jacobr@google.com , vsm@google.com
Review URL: https://codereview.chromium.org/2413073002 .
2016-10-13 08:47:27 -07:00
96f485b075
Fix file name handling on windows
...
Paths on windows were having the drive letter (ex: c:\) recognized as
a URI scheme.
Fixes #27450
R=vsm@google.com
Review URL: https://codereview.chromium.org/2413823002 .
2016-10-12 14:30:15 -07:00
d8505ee264
Fix library name insert and access inconsistency on windows
...
Make naming of libraries on windows consistent with the behaivor on
linux and mac.
Fixes #27576
R=vsm@google.com
Review URL: https://codereview.chromium.org/2415653002 .
2016-10-12 14:14:00 -07:00
b30571884f
Use expect instead of unittest for json_lib_test.
...
One step closer to removing the deprecated unittest.
R=vsm@google.com
Review URL: https://codereview.chromium.org/2402123002 .
2016-10-10 09:42:40 -07:00
0132d6114a
Fix for the missing new keyword on an external factory call.
...
Added a test for calling an external factory and updated expected test failures/errors from turning on the tests: js_typed_interop_test
Fixes #27443
R=jacob314@gmail.com , vsm@google.com
Review URL: https://codereview.chromium.org/2394103002 .
2016-10-06 10:24:38 -07:00
6144c10409
Fix analyzer error
...
Analyzer was complaining that final field was not set. The other constructor
does set, so doing so here as well. We may be able to remove this flag soon,
but I see downstream uses.
TBR=jmesserly@google.com
Review URL: https://codereview.chromium.org/2382463002 .
2016-09-28 10:21:15 -07:00
68d2121fd0
Use .packages instead of pubspec.yaml
...
This runs tests against sdk versions of packages instead of whatever
random version we have in pubspec.yaml.
Travis may be unhappy with the lack of a pubspec.yaml. Here's the try:
https://travis-ci.org/dart-lang/sdk/builds/163270204
R=jmesserly@google.com , rnystrom@google.com
Review URL: https://codereview.chromium.org/2371113004 .
2016-09-28 09:49:31 -07:00
1129d3d121
fix #27421 , DDC did not generate implicit super calls in some cases
...
this would happen when there was a chain of implicit super calls, leading to an implicit super with field initializers
R=vsm@google.com
Review URL: https://codereview.chromium.org/2365053003 .
2016-09-23 17:06:10 -07:00
ead14fbd74
Update global_compile tool
...
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2363053003 .
2016-09-23 13:30:18 -07:00
adc71ab396
re-land fix #27110 with proper DDC side of changes
...
R=leafp@google.com
Review URL: https://codereview.chromium.org/2362563004 .
2016-09-22 15:47:55 -07:00
aa85651820
fix #27403 , use AST summaries in DDC
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/2353133004 .
2016-09-20 17:55:09 -07:00
bad7f76374
Fix crashes due to attempts to create an identifier name containing the word <bottom>. Likely there is a better fix but this appears to work for now.
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2354603003 .
2016-09-19 14:52:12 -07:00
a4734d4b33
fix #27353 , support @checked covariant parameters in DDC
...
Seems pretty straightforward. Just added a simple test for now.
R=leafp@google.com
Review URL: https://codereview.chromium.org/2340463009 .
2016-09-15 15:42:04 -07:00
7341e3d34c
Cleanup. Fix new analyzer errors due to recent strong mode changes.
...
BUG=
Review URL: https://codereview.chromium.org/2338323004 .
2016-09-15 10:45:05 -07:00
35e7c4c5f5
Always write the source map even if it is inlined. This simplifies bazel rules.
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2342643003 .
2016-09-15 10:33:22 -07:00
ecc84b26a4
Break up another large file
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/2342733002 .
2016-09-15 07:49:27 -07:00
bda62939a2
Support generating inlined source maps and wrapping module contents within a JavaScript eval block to improve the debugging experience.
...
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org/2337213003 .
2016-09-14 10:54:47 -07:00
1f10422fd5
Update uses of deprecated API in ddc
...
R=jmesserly@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/2338883002 .
2016-09-13 11:44:38 -07:00
e52613f151
Fix error message
...
R=jacobr@google.com
Review URL: https://codereview.chromium.org/2329493002 .
2016-09-09 09:02:50 -07:00
48817e61f7
fix strong mode messages in pkg/dev_compiler
...
R=vsm@google.com
Review URL: https://codereview.chromium.org/2314193002 .
2016-09-07 09:06:24 -07:00
9af2fb0115
More DDC mirrors support
...
(Note, this is a straight migration of the old DDC repo CL. :-))
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2301973002 .
2016-09-01 10:13:31 -07:00
2bc19eaa64
Remove deprecated code
...
Updating to the latest analyzer.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/2289263004 .
2016-08-30 15:39:38 -07:00
feb77b40a4
Bind this in ng2 hack code
...
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2291873002 .
2016-08-29 16:41:29 -07:00
6a1a03add4
Make source map paths relative
...
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2288453002 .
2016-08-26 16:31:53 -07:00
8081afc785
fix travis bots
...
- increase timeout so we load all tests
- mark a few more failures
- skip unittest tests until we re-triage them
Review URL: https://codereview.chromium.org/2279053002 .
2016-08-25 13:23:14 -07:00
bc50963a61
fix writing summaries
...
I also renamed "outPath" so this bug is less likely to happen in the future :)
R=vsm@google.com
Review URL: https://codereview.chromium.org/2279833002 .
2016-08-25 10:40:09 -07:00
c1139934a7
fix #626 , add AMD module format and make it default
...
R=nweiz@google.com , vsm@google.com
Review URL: https://codereview.chromium.org/2249233002 .
2016-08-25 09:39:36 -07:00
8442efa4d3
Support call methods on functions
...
Fixes #624
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2255993002 .
2016-08-18 07:51:17 -07:00
d90d172d8b
Remove deprecated DirectoryBasedDartSdk
...
We're getting bot failures due to analyzer deprecation messages.
R=brianwilkerson@google.com , jmesserly@google.com
Review URL: https://codereview.chromium.org/2258873002 .
2016-08-18 07:47:45 -07:00
36273565e3
fixes #610 , incorrect help output
...
R=nweiz@google.com
Review URL: https://codereview.chromium.org/2244703003 .
2016-08-12 15:06:41 -07:00
0aa5cbd128
fix #620 , infer the input files from sources
...
also simplifies build of packages used by our tests
this caused a bunch of tests that use parts to start passing
R=nweiz@google.com
Review URL: https://codereview.chromium.org/2234343003 .
2016-08-11 13:19:36 -07:00
3ddb76b95c
Reify type params on map literals
...
Fixes #621
R=jmesserly@google.com , leafp@google.com
Review URL: https://codereview.chromium.org/2211293002 .
2016-08-05 07:16:02 -07:00
0fd3e8821c
Fix wrt analyzer tip
...
This sidesteps #618 for now.
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2209473002 .
2016-08-02 14:42:06 -07:00
bd789e912b
Remove source file check
...
This is breaking downstream build rules.
TBR=leafp@google.com
Review URL: https://codereview.chromium.org/2199123003 .
2016-08-02 13:35:50 -07:00
e51f9de339
fixes #616 , statics on callable functions
...
also fixes `this` for them
R=vsm@google.com
Review URL: https://codereview.chromium.org/2200913002 .
2016-08-01 17:12:37 -07:00
344124e4a1
fix optional params to mock methods, allow all signatures
...
switches to use the same technique as `dsend`
R=vsm@google.com
Review URL: https://codereview.chromium.org/2201973002 .
2016-08-01 16:21:59 -07:00
437cca2923
Rename build-root to library-root
...
First step on #557 . Will eliminate the deprecated flag once upstream
uses are switched over.
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2197243002 .
2016-08-01 08:30:32 -07:00
b2353d7513
Fix analyzer error
...
This is breaking travis.
TBR=jmesserly@google.com
Review URL: https://codereview.chromium.org/2199473002 .
2016-07-29 14:31:46 -07:00
d2ec49d1f7
Working compiler in browser.
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2183603003 .
2016-07-29 09:18:13 -07:00
0f29ee9618
Remove DDC custom error list now that strong mode analyzer handles it
...
R=leafp@google.com
Review URL: https://codereview.chromium.org/2102053003 .
2016-07-27 13:10:57 -07:00
18769af805
restore code_generator file from b770039, the nSM mock fix
...
Review URL: https://codereview.chromium.org/2189683002 .
2016-07-27 09:49:58 -07:00
3d03bee32d
Library custom formatters
...
R=alanknight@google.com , jacobr@google.com , jmesserly@google.com
Review URL: https://codereview.chromium.org/2164763005 .
2016-07-22 14:15:53 -07:00
c3ee6dc5ee
fix #606 , allow specifying the summary file extension
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org/2176763002 .
2016-07-22 11:39:35 -07:00
c1e97b495f
fix #603 , support mock objects
...
if noSuchMethod is used to implement an abstract member, this will be detected and appropriate code will be generated.
R=leafp@google.com
Review URL: https://codereview.chromium.org/2158173003 .
2016-07-19 13:24:02 -07:00
144d3dbd0c
Catch file-not-found exception
...
If a non-existing file was passed to DDC before it would just throw an
uncaught exception and crash. Now the exception is caught and an error
message is printed together with the usage information.
BUG=https://github.com/dart-lang/dev_compiler/issues/605
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2161693002 .
2016-07-18 14:37:43 -07:00
fceb82f49d
Fix null aware generic invocation.
...
Fixes #600
BUG=
R=jacobr@google.com
Review URL: https://codereview.chromium.org/2132763002 .
2016-07-07 13:07:17 -07:00
72664da9dd
Print usage when no source files are passed
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2113203002 .
2016-06-30 17:51:11 -07:00
87bcbf9147
Move type tagging logic out of setSignature
...
setSignature is only called for classes with constructors or static
members, so previously _runtimeType was only set explicitly on such
classes. Now _runtimeType is not set on any classes except for Object,
and all other types inherit _runtimeType from Object.
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2076713002 .
2016-06-27 15:29:15 -07:00
d27eda4ffc
implement user-defined nSM, Object members on functions
...
fix #591 and fix #59
R=vsm@google.com
Review URL: https://codereview.chromium.org/2061373003 .
2016-06-22 17:18:52 -07:00
Vijay Menon