Commit Graph

52 Commits

Author SHA1 Message Date
ager@google.com 9d93351ada Add documentation of double and int.
There is a bit of comment duplication in here, but I think it is worth
it to have all the methods documented on api.dartlang.org for all the
types.

R=lrn@google.com
BUG=dartbug.com/4668

Review URL: https://codereview.chromium.org//10959067

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12773 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-24 12:28:10 +00:00
ager@google.com 02b566ee62 Add documentation to the Object class in the core library.
R=lrn@google.com
BUG=

Review URL: https://codereview.chromium.org//10974004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12770 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-24 11:07:34 +00:00
iposva@google.com eee4bbc1ef - Add definition of "int hashCode()" to Object.
- Implement hashCode in the VM.
- Mark hashCode as unimplemented in dart2js.
- Update test using the identity hashcode.
Review URL: https://codereview.chromium.org//10956026

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12669 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-21 00:32:58 +00:00
rnystrom@google.com b81b2cd656 If transformException() returns a future, act like chain().
Review URL: https://codereview.chromium.org//10958021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12661 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-20 22:35:04 +00:00
ager@google.com f40be94bf3 Add minimal documentation to the num class.
I have kept the documentation to a minimum and only added a few
details. We can beef this up later if desirable.

R=lrn@google.com
BUG=

Review URL: https://codereview.chromium.org//10961013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12635 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-20 13:30:35 +00:00
lrn@google.com c0f42d2748 Made removeAt errors consistent between dart2js and VM.
Reneabled test for VM.

Review URL: https://codereview.chromium.org//10960011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12632 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-20 12:52:54 +00:00
lrn@google.com eeeab5f0ad Add list.removeAt method.
Review URL: https://codereview.chromium.org//10970009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12627 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-20 10:50:00 +00:00
ahe@google.com 3f1932a563 Handle backslashes and newlines when escaping strings.
Review URL: https://codereview.chromium.org//10943027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12568 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 15:43:41 +00:00
ager@google.com 576532edcc Bug cleanup: unify on allowing radices from 2 to 36 in
num.toRadixString. Add test and documentation.

R=lrn@google.com,floitsch@google.com
BUG=dartbug.com/461

Review URL: https://codereview.chromium.org//10937011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12562 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 14:15:39 +00:00
lrn@google.com ee569ce10a Reapply conversion of most core interfaces to abstract classes.
Previous commit was reverted due to hitting an unrelated error.

TBR=ahe@google.com

Review URL: https://codereview.chromium.org//10939030

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12551 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 10:48:14 +00:00
johnniwinther@google.com 4bb37a7a90 Normalization of patch signatures.
This is the second part of the patch refactoring which will require identical signatures on patches and their origins.

Review URL: https://codereview.chromium.org//10911325

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12542 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 09:00:47 +00:00
karlklose@google.com d90d5b1698 Reapply 'Add runtimeType() to Object which returns canonicalized instances of Type'.
This CL fixes a bug in https://chromiumcodereview.appspot.com/10908142/ which generated unneeded type information leading to runtime regression.

Original committed in 12491 and reverted in

R=ngeoffray@google.com

Review URL: https://codereview.chromium.org//10941031

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12540 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 08:56:06 +00:00
ahe@google.com 34c503ae73 Don't invoke user-defined code in NoSuchMethodError.toString.
Review URL: https://codereview.chromium.org//10939020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12533 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 07:55:50 +00:00
ricow@google.com 055ca720df Revert 12494.
This is causing failures in checked mode

TBR
Review URL: https://codereview.chromium.org//10948009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12501 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-18 14:52:10 +00:00
ricow@google.com 5bcc7e0092 Revert r12491
This is causing checked mode failures on the buildbot.
Review URL: https://codereview.chromium.org//10949003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12500 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-18 14:40:15 +00:00
lrn@google.com 60bfeadcf6 Convert most interfaces in dart:core to abstract classes.
Review URL: https://codereview.chromium.org//10950006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12494 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-18 12:43:10 +00:00
ager@google.com c5880541c8 Bug cleanup: add comment about unspecified behavior if the object
iterated over with an iterator is changed during the iteration.

R=ngeoffray@google.com
BUG=dartbug.com/442

Review URL: https://codereview.chromium.org//10945007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12493 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-18 12:39:57 +00:00
karlklose@google.com 59e0304206 Add runtimeType() to Object which returns canonicalized instances of Type.
BUG=3903

Review URL: https://chromiumcodereview.appspot.com//10908142

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12491 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-18 12:12:07 +00:00
ager@google.com 243087be1b Bug cleanup: change String.trim comment to be less ambiguous.
R=ahe@google.com
BUG=dartbug.com/435

Review URL: https://codereview.chromium.org//10951004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12490 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-18 12:07:23 +00:00
lrn@google.com 94362c5d72 Make identical(a,b) a compile-time constant in dart2js.
Introduces the 'identical' top-level function in dart:core.

Review URL: https://codereview.chromium.org//10908287

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12465 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-18 05:54:20 +00:00
lrn@google.com 99749ca619 This reapplies the change to remove "dynamic" from Object.
TBR=kasperl@google.com

Review URL: https://codereview.chromium.org//10908291

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12449 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-17 19:14:49 +00:00
lrn@google.com 54d6cbda76 Revert "Remove Object.dynamic."
Some test expectations were missing.

TBR=kasperl@google.com

Review URL: https://codereview.chromium.org//10933122

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12433 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-17 12:10:29 +00:00
lrn@google.com 9cc07e2f3f Remove Object.dynamic.
Review URL: https://codereview.chromium.org//10914286

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12432 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-17 12:00:44 +00:00
ager@google.com 751bcb38d7 Document the syntax and semantics of Dart regular expressions (the same as JS regexps).
R=lrn@google.com
BUG=dartbug.com/89

Review URL: https://codereview.chromium.org//10909266

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12431 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-17 11:42:35 +00:00
lrn@google.com 26fab5183a Move parseInt parseDouble to int/double classes as a static method.
Remove math dependency from core/coreimpl in dart2js.
The existing Math.parseInt and Math.parseDouble are kept *for now*, but
simply redirect to the static methods.
They will be removed in time (when library code is ready for it).

Review URL: https://codereview.chromium.org//10913271

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12417 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-17 07:25:38 +00:00
cshapiro@google.com ffa3604282 Eliminate the const constructor from the Expando class.
Review URL: https://codereview.chromium.org//10909209

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12354 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 21:26:01 +00:00
kasperl@google.com 1b994e881f Change RegExp constructor to insist on proper named optional parameters.
R=bak@google.com,lrn@google.com
BUG=

Review URL: https://codereview.chromium.org//10910253

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12329 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 14:00:32 +00:00
ager@google.com 665aaf939f Patch print directly in corelib instead of going through coreimpl.
R=ajohnsen@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10928145

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12316 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 11:50:19 +00:00
kasperl@google.com 997e534c28 Change Duration to take proper named optional parameters.
R=bak@google.com,lrn@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10905255

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12314 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 11:17:31 +00:00
lrn@google.com 292da5cc48 Make int an abstract class.
This looks deceptively simple (the only real change is in init, which
just copies the code for double, and the rest are just renaming for
consistency). It seems to work.

Review URL: https://chromiumcodereview.appspot.com//10933039

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12304 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 07:17:27 +00:00
sethladd@google.com d0f038fae0 fix doc for future
BUG=

Review URL: https://codereview.chromium.org//10918208

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12294 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 03:44:19 +00:00
kasperl@google.com 55140fd125 Remove support for operator negate and replace occurrences with unary
operator -.

In the VM, I have disabled the operator negate support in the parser but I
have not removed the keyword because the token is used in quite a few other
places.

R=ahe@google.com,iposva@google.com,hausner@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10911206

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12233 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-12 05:29:03 +00:00
bak@google.com d3b5cfba18 First partial step at removing interfaces in libraries.
- Changes interfaces without default implmenetations to abstract class.
  - Changed final fields in interfaces to getters.
  - Changed dart_analyzer to allow methods with empty bodies in abstract class.
  - Updated the co19 status file since two tests now are passing.
Review URL: https://chromiumcodereview.appspot.com//10917187

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12201 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 14:57:09 +00:00
ager@google.com 2e49065159 Reapply changes to Expando patching.
R=ajohnsen@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10911201

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12181 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 11:03:50 +00:00
lrn@google.com f52c24b62f Rename NoSuchMethodException to NoSuchMethodError.
Moved NoSuchMethodError to errors.dart.
No changes in co19 tests, but test status updated.

Review URL: https://chromiumcodereview.appspot.com//10909166

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12172 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 09:52:25 +00:00
ager@google.com 1adc0b35a2 Revert Expando changes. There are checked-mode errors that I need
to sort out.

Revert "Patch expando directly in corelib instead of going through coreimpl."

Revert "Fix merge error."

R=ajohnsen@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10918163

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12158 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 05:39:05 +00:00
ager@google.com e3f4f6696e Patch expando directly in corelib instead of going through coreimpl.
R=ajohnsen@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10908173

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12156 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 05:27:31 +00:00
eub@google.com 8f83439c21 Fix some doc comments that didn't use Markdown syntax for code blocks.
Review URL: https://chromiumcodereview.appspot.com//10905165

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12138 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-10 17:52:45 +00:00
lrn@google.com 9ae63b5684 Revert "Remove dart2js specific core.dart and coreimpl.dart files."
TBR=johnniwinter@google.com

Review URL: https://chromiumcodereview.appspot.com//10911179

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12101 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-10 08:50:40 +00:00
lrn@google.com d47489ba3c Remove dart2js specific core.dart and coreimpl.dart files.
Review URL: https://chromiumcodereview.appspot.com//10908167

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12100 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-10 08:05:49 +00:00
kasperl@google.com 9beb871852 Get rid of a lot of () for getters.
R=bak@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10919146

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12017 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-07 11:50:07 +00:00
hausner@google.com 226547298c Eliminate unnecessary factory constructors in abstract core classes
It is now a runtime error to instantiate an explicitly marked
abstract class, so these factory constructors are no longer
necessary.
Review URL: https://chromiumcodereview.appspot.com//10917100

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11965 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-06 16:30:27 +00:00
lrn@google.com 1541f37ce7 Remove errors.dart in dart2js compiler.
Another step towards removing core.dart and use the unified library
only.

BUG=4910

Review URL: https://chromiumcodereview.appspot.com//10914116

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11924 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-06 08:34:06 +00:00
rnystrom@google.com 2f2df82784 Support transforming the exception in Future.transform().
Review URL: https://chromiumcodereview.appspot.com//10908040

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11844 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-04 21:52:31 +00:00
bak@google.com 5782b0beba - Removed named constructor Stopwatch.start() due to conflict with instance methods start().
This change reduces errors reported by dart_analyser when cheking corelib.
- Change comment format in newissues.dart.
Review URL: https://chromiumcodereview.appspot.com//10908066

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11801 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-04 10:56:29 +00:00
ager@google.com 30e6b3d485 Remove stale comment.
R=ajohnsen@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10907053

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11789 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-04 07:50:26 +00:00
ager@google.com 5e0098f34e Fix lib/core/core.dart and lib/coreimpl/coreimpl.dart files.
Where did these files come from?

R=lrn@google.com,ajohnsen@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10918053

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11788 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-04 07:42:53 +00:00
ager@google.com 156e6a71b5 First corelib cleanup patch after unification.
Do not go through coreimpl for object implementation. Instead, use patching
in core directly.

This leads to error message issues in dart2js which I have patched up
the best way I could find.

R=ajohnsen@google.com,johnniwinther@google.com,lrn@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10918047

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11784 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-04 07:26:02 +00:00
hausner@google.com 35d7793891 Throw AbstractClassInstantiationError if an abstract class is instantiated
This is the second try to my previous attempt to implement the
new abstract class handling. Instead of a compile-time error,
the VM now throws an AbstractClassInstantiationError at runtime
if an abstract class is instantiated. Added the new error class
to the core library.

For now I'm still using the rule that a class is abstract if it is explicitly
marked as abstract, or if it defines a new abstract method.
Review URL: https://chromiumcodereview.appspot.com//10916039

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11708 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-31 18:06:42 +00:00
iposva@google.com 0dd77bf634 - Change "static final" to "static const" in the
pkg/, language/, utils/ and lib/core/ directories.
Review URL: https://chromiumcodereview.appspot.com//10919024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11703 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-31 17:47:17 +00:00