...instead of ensuring this separately for complete closures of every library.
This improves initial analysis performance from about 44 seconds to 39.
This also makes WorkOrder.moveNext less expensive - to about 5.6% during initial analysis.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1412273004 .
Adds a new block of status that reports the last 10 performed tasks.
For example:
<p>Recent Tasks</p>
GatherUsedLocalElementsTask for source /Users/pquitslund/src/git/clones/analyzer_cli/test/mocks.dart
GatherUsedImportedElementsTask for source /Users/pquitslund/src/git/clones/analyzer_cli/test/mocks.dart
GenerateHintsTask for source /Users/pquitslund/src/git/clones/analyzer_cli/test/mocks.dart
GenerateLintsTask for source /Users/pquitslund/src/git/clones/analyzer_cli/test/mocks.dart
VerifyUnitTask for source /Users/pquitslund/src/git/clones/analyzer_cli/test/mocks.dart
LibraryUnitErrorsTask for source /Users/pquitslund/src/git/clones/analyzer_cli/test/mocks.dart
DartErrorsTask for source /Users/pquitslund/src/git/clones/analyzer_cli/test/mocks.dart
LibraryErrorsReadyTask for source /Users/pquitslund/src/git/clones/analyzer_cli/test/mocks.dart
GetContentTask for source /Users/pquitslund/src/git/clones/analyzer_cli/.analysis_options
GenerateOptionsErrorsTask for source /Users/pquitslund/src/git/clones/analyzer_cli/.analysis_options
R=brianwilkerson@google.com, keertip@google.com
Review URL: https://codereview.chromium.org/1420783004 .
It's not perfectly useful - it computes just cumulative timings.
So, it includes not just time for extracting and gathering inputs, but also actual time to compute them.
But it is still useful to compare between runs after changes to tasks inputs, because computing time
should be the same, so the difference is this extracting/gathering time.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1406983007 .
Actually only some methods of the 'edit' domain are potentially fatal.
Alternative solutions:
1. Don't make anything fatal.
2. Add areExceptionsFatal to RequestHandler.
3. Let every domain to decide whether exceptions in some method or none of them are fatal.
R=brianwilkerson@google.com, danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org/1404353007 .
I guess this happens when a "resolved" CompilationUnit is not actially resolved.
I don't know why we get such units, but I saw this situation twice in IDEA.
So, probably we need to fix at least throwing NPE here.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1418513002 .
ElementKind.FILE will be used in search.findElementReferences
1. In the 'element' field of responce when a URI is at the given offset.
2. In the only element of the 'path' field of SearchResult(s) for URI references to a URI or a library identifier.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1409333002 .
Fixes#24549.
A few notes:
* does away with registry in favor of context-associated configurations
* pulls in linter rev that does the context association
* bumps analyzer version before publishing (needed to update analyzer_cli)
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1406043002 .
TL;DR Moves all plugin registration to AE's extension manager.
The rub is that plugin registration wasn't happening right which cropped up in integration testing. Included is a test that verifies that options are getting properly threaded through to the linter. (This test failed when we had two Extension Managers.)
R=brianwilkerson@google.com, scheglov@google.com
Review URL: https://codereview.chromium.org/1398033004 .
Konstantin Shcheglov