b0b841d976
corelib: Do not print value in ArgumentError.notNull
...
R=lrn@google.com
Review URL: https://codereview.chromium.org/1460903003 .
2015-11-23 12:25:58 +01:00
50aa43569d
Add "growable" parameter to List.filled constructor.
...
Fixes issue #24884
BUG= http://dartbug.com/24884
R=floitsch@google.com
Review URL: https://codereview.chromium.org/1440663003 .
2015-11-13 09:30:46 +01:00
ed0b187d58
Add data-URI support class to dart:core (next to Uri).
...
R=floitsch@google.com , fschneider@google.com
Committed: https://github.com/dart-lang/sdk/commit/bbc66c2c41e61d82d6b85fdd16e2b0f1204c2a33
Review URL: https://codereview.chromium.org/1381033002 .
2015-11-12 13:02:20 +01:00
df5ef1b136
Revert "Add data-URI support class to dart:core (next to Uri)."
...
This reverts commit bbc66c2c41R=ricow@google.com
Review URL: https://codereview.chromium.org/1432203002 .
2015-11-11 11:42:04 +01:00
d20d3f6419
dart2js CPS: Triage an issue in the corelib tests.
...
R=asgerf@google.com
BUG=https://github.com/dart-lang/sdk/issues/24878
Review URL: https://codereview.chromium.org/1434933002 .
2015-11-11 11:32:49 +01:00
bbc66c2c41
Add data-URI support class to dart:core (next to Uri).
...
R=floitsch@google.com
Review URL: https://codereview.chromium.org/1381033002 .
2015-11-11 10:27:08 +01:00
371a5dc932
Get tools/test.py --noopt green.
...
More specifically ./tools/test.py --noopt -mall -ax64,simarm,simarm64,simmips --exclude-suite=pkg
- Add missing dart:io entry point.
- Add checks that Dart_FinalizeLoading, Dart_Precompile, Dart_CreatePrecompiledSnapshot are called in order.
- Add checks for --precompilation flag.
- Add checks for dropped class in Dart_New/Allocate/AllocateWithNativeFields.
R=fschneider@google.com
Review URL: https://codereview.chromium.org/1407393005 .
2015-10-21 10:35:01 -07:00
a8e3eb4e10
Fix bug in Uri.removeFragment.
...
It used the external getters for the existing port and query, which
are non-null even when the port or query are absent. This introduced
a new default-valued/empty part.
Also reordered declarations to have fields > constructors > rest.
Fixes issue #24593
BUG= http://dartbug.com/24593
R=asgerf@google.com
Review URL: https://codereview.chromium.org/1396973004 .
2015-10-15 12:42:36 +02:00
a50105543f
dart2js cps: Add a pass for eliminating bounds checks.
...
The analysis uses a watered-down octagon domain which reduces range
analysis to a graph problem.
There are more ideas to try out to improve on this, but I think this is
a nice baseline to work from.
BUG=
R=sra@google.com
Review URL: https://codereview.chromium.org//1353443002 .
2015-10-13 16:40:54 +02:00
f1a40e23c1
dart2js cps: Status updates and minor fixes for host checked mode.
...
CPS should now run the test suite cleanly in host-checked mode. Let's keep it that way.
BUG=
R=floitsch@google.com
Review URL: https://codereview.chromium.org/1377323003 .
2015-10-02 15:36:21 +02:00
4e94938f7e
Fix some cases where Map.containsValue did not accept Object as argument.
...
Add tests.
Also remove a left-over check in SplayTreeMap.
BUG= https://github.com/dart-lang/dev_compiler/issues/344
R=wibling@google.com
Review URL: https://codereview.chromium.org//1360053003 .
2015-09-23 11:26:55 +02:00
d755dd65b9
Update range errors to agree on the numbers.
...
Also ensure that typed-data errors are consistent with other lists.
Fixes issue #24295
BUG= http://dartbug.com/24295
R=floitsch@google.com , iposva@google.com , sra@google.com
Review URL: https://codereview.chromium.org//1318943005 .
2015-09-11 13:05:36 +02:00
d9caf4a725
Move cps-ir section to the end of the file and update test expectations.
...
BUG=
R=kmillikin@google.com
Review URL: https://codereview.chromium.org//1312583008 .
2015-09-07 15:37:39 +02:00
7ae093a3b8
Split double_parse_test into more multitests.
...
The 03 multitest cases are the ones that fail on arm using the
system strtod. Separating them out makes it easier to do suppresions
of only the parts of the tests that fail in a given configuration.
R=floitsch@google.com
Review URL: https://codereview.chromium.org//1312903010 .
2015-09-01 16:27:01 +02:00
bb25ca8215
Update jsshell expectations for double parsing now that the problematic cases are separated out.
...
R=floitsch@google.com
Review URL: https://codereview.chromium.org//1313333003 .
2015-09-01 12:09:17 +02:00
bb8ca393e1
Split two string to double corner cases into a separate multitest.
...
When using a simpler version of the doubleconversion library that
uses the system strtod to parse strings these cases fail on MacOS.
Splitting them out allows us to mark only these corner cases as
failing on MacOS.
R=floitsch@google.com
Review URL: https://codereview.chromium.org//1312893007 .
2015-09-01 10:20:04 +02:00
0216e21efc
dart2js cps: Use 'this' instead of receiver-arg when possible.
...
This fixes a bug in how intercepted super calls were handled,
and enables the redundant receiver optimization.
BUG=
R=kmillikin@google.com
Review URL: https://codereview.chromium.org//1312393002 .
2015-08-26 16:06:41 +02:00
bc0deb66d7
dart2js: fetch http Resources
...
BUG=
R=sigmund@google.com
Review URL: https://codereview.chromium.org//1308143002 .
2015-08-25 10:46:27 -07:00
6820b95c1c
dart2js cps: update test expectations.
...
TBR=kmillikin@google.com
Review URL: https://codereview.chromium.org//1303333003 .
2015-08-24 10:59:15 +02:00
689ea4f24a
dart2js: Update status files.
...
dart2js/http_test passes when run in isolation, but always times out
on my machine when run in a large batch. I marked it as slow in
unchecked mode (was already marked as slow in checked mode).
Some timeouts that were fixed in dart2js cps but somehow were added to
the status file again.
Some tests in corelib fail in CPS.
BUG=
Review URL: https://codereview.chromium.org//1292223003 .
2015-08-18 10:35:47 +02:00
1b8f3fba14
Make List constructor give better error messages for non-int arguments
...
BUG= http://dartbug.com/15986
R=herhut@google.com , iposva@google.com , sra@google.com
Committed: https://github.com/dart-lang/sdk/commit/33c76638268e3e24fb7a73a8f6f141f38272e8dd
Review URL: https://codereview.chromium.org//1214723009 .
2015-08-17 13:01:13 +02:00
51fa195f16
Revert "Make List constructor give better error messages for non-int arguments"
...
There are VM-only tests that assume exact text of failure.
BUG=
Review URL: https://codereview.chromium.org//1294483003 .
2015-08-14 15:05:17 +02:00
33c7663826
Make List constructor give better error messages for non-int arguments
...
BUG= http://dartbug.com/15986
R=herhut@google.com , iposva@google.com , sra@google.com
Review URL: https://codereview.chromium.org//1214723009 .
2015-08-14 13:44:19 +02:00
8301c6e7b2
Don't expect analyzer to fail resource tests.
...
Also make package have `publish_to:"none"` on pubspec.
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//1286713002 .
2015-08-11 11:35:36 +02:00
c26095b1b3
Add resource tests.
...
R=sgjesse@google.com , whesse@google.com
Review URL: https://codereview.chromium.org//1276263002 .
2015-08-11 10:07:10 +02:00
7eb3bb82b7
dart2js cps: update test expectations for new tests.
...
TBR=kmillikin@google.com
Review URL: https://codereview.chromium.org//1280603003 .
2015-08-07 08:36:47 +02:00
783ed933ff
Fix boolean conversion bug in dart2js + update JSRegExp accordingly.
...
BUG=
R=herhut@google.com
Review URL: https://codereview.chromium.org//1259473005 .
2015-07-27 14:19:26 +02:00
7d8067135c
dart2js cps: Support 'on T' clauses without a 'catch'.
...
BUG=
R=karlklose@google.com
Review URL: https://codereview.chromium.org//1247333003 .
2015-07-23 12:39:10 +02:00
1b7053bcf6
dart2js cps: Use CPS IR for patched functions and typed data.
...
R=asgerf@google.com
Review URL: https://codereview.chromium.org//1241303003 .
2015-07-22 13:07:35 +02:00
848f6c978c
Do "path normalization" when creating a URI.
...
Path normaliztion removes '.' and '..' segments from a URI. Such relative references are only intended for URI References, and Uri References are only intended for resolving against a full URI.
We do path normalization on all URIs that have a scheme, authority or an absolute path, and partial normalization on what are really just relative paths. The partial normalization can leave ".." at the start of the path.
The URI reference resolution algorithm doesn't work as expected for a URI ending in "..". Resolving "./foo" wrt. a base of "/a/.." results in "/a/foo" - this is avoided when the base is path normalized before it's used.
This also fixes the "normalizePath" function which currently removes leading '..' segments, contrary to its documentation. It also makes the function redundant since all URI paths are normalized automatically.
See discussion on http://dartbug.com/23688
Also fix bug in the removeDotSegments function.
R=floitsch@google.com
Review URL: https://codereview.chromium.org//1224263009 .
2015-07-17 17:08:36 +02:00
04dacd24f4
Remove functions white-listed for use of try-finally and switch, add JS_SET_CURRENT_ISOLATE.
...
R=asgerf@google.com
Review URL: https://codereview.chromium.org//1237573002 .
2015-07-14 10:26:38 +02:00
3fe9309c96
dart2js cps: Implement compilation of redirecting factory constructors for reflection.
...
Without reflection, redirecting factory constructor invocations are shortcut at the instantiation site. With reflection, code like
reflectClass(Foo).newInstance(const Symbol(''), [])
can hit a redirecting factory constructor and we need to emit a function that does the redirection and type substitution.
R=asgerf@google.com
Review URL: https://codereview.chromium.org//1227873004 .
2015-07-09 14:54:23 +02:00
71e2bec0a5
dart2js cps: Support JS_CURRENT_ISOLATE.
...
R=asgerf@google.com
Review URL: https://codereview.chromium.org//1222913003 .
2015-07-07 15:55:13 +02:00
469d541f31
Don't expect 0.gcd(0) to throw in bigint test.
...
Review URL: https://codereview.chromium.org//1224643003 .
2015-07-07 11:11:42 +02:00
3c976019cc
Make int.gcd accept zero as an operand, including both operands being zero.
...
R=floitsch@google.com , regis@google.com , sgjesse@google.com
Review URL: https://codereview.chromium.org//1211473002 .
2015-07-07 09:51:13 +02:00
61f47e7384
dart2js cps: Ensure JSArray is emitted when we see a type cast.
...
This is a workaround to resolve an issue that is affecting a lot
of tests.
BUG=
R=floitsch@google.com
Review URL: https://codereview.chromium.org//1214123003 .
2015-07-03 14:32:01 +02:00
ede6cb71a5
Make modInv throw Exception on incompatible operands.
...
Also update errors to be more descriptive accross the integer methods.
I'm still considering whether a more precise "NotCoPrimeException" would be better.
R=regis@google.com , sgjesse@google.com
Review URL: https://codereview.chromium.org//1209523002 .
2015-06-30 14:46:14 +02:00
34302b1320
dart2js cps: Translate synthesized mixin constructors.
...
BUG=
R=kmillikin@google.com
Review URL: https://codereview.chromium.org//1216593002 .
2015-06-29 15:28:40 +02:00
ec55d46148
dart2js cps: Fix translation of local constants.
...
BUG=
R=kmillikin@google.com
Review URL: https://codereview.chromium.org//1211393003 .
2015-06-29 14:32:49 +02:00
3a0edfba72
Add tests for gcd, modInverse and modPow that also run on dart2js.
...
R=regis@google.com , sgjesse@google.com
Review URL: https://codereview.chromium.org//1205363003 .
2015-06-26 11:05:11 +02:00
fceb7f00dc
dart2js cps: Handle checks against mutable and extendable lists.
...
BUG=
R=kmillikin@google.com
Review URL: https://codereview.chromium.org//1206873003 .
2015-06-25 15:03:00 +02:00
089ed2965b
Implement try/finally by inlining the finally code.
...
Try/finally is implemented by inlining. There is a try/catch to catch
exceptions in the try block. The catch body contains the finally code
followed by a rethrow. The code for finally is translated again after the
normal exit of the try block. Break, continue, and return exits in the try
block have the finally code inlined just before the exit is taken.
Try/catch/finally is not yet supported, it requires some changes to the
assigned variables analysis.
R=asgerf@google.com
Review URL: https://codereview.chromium.org//1201983002 .
2015-06-24 10:12:42 +02:00
28594e455d
Disable guessing 'other' cid; this prevents an issue in range analysis. It is not clear if guessing the 'other' cid optimization is the right thing to do as it may bring the flow graph in an unexpected state
...
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//1203773002 .
2015-06-23 13:23:02 -07:00
e91b99b66d
Fix crash in modPow (issue 23693); various bigint knowledge missing.
...
BUG=
R=regis@google.com
Review URL: https://codereview.chromium.org//1197263002 .
2015-06-22 15:11:36 -07:00
d0d5185550
- Status file tuning.
...
BUG=
Review URL: https://codereview.chromium.org//1199593004 .
2015-06-22 12:47:18 -07:00
d9da805f07
- Split big integer tests into pieces.
...
BUG=
R=srdjan@google.com
Review URL: https://codereview.chromium.org//1198993003 .
2015-06-22 12:22:14 -07:00
aa8ea6da27
Enable TryCreateICData optimization, disable crashing test in status file
...
BUG=
R=iposva@google.com
Review URL: https://codereview.chromium.org//1198333004 .
2015-06-22 10:58:51 -07:00
bf595224d5
Implement simple switch statements as nested if/else.
...
Simple switch statements that do not have continue to labeled cases
are compiled into a chain if/else comparisons.
R=asgerf@google.com
Review URL: https://codereview.chromium.org//1191193005 .
2015-06-22 11:29:31 +02:00
a192ef4acb
Implement gcd in sdk.
...
R=srdjan@google.com
Review URL: https://codereview.chromium.org//1199513003 .
2015-06-19 13:40:01 -07:00
3f46181244
cps-ir: Support foreign code.
...
R=kmillikin@google.com
Committed: https://github.com/dart-lang/sdk/commit/a120ee7c9071b60edccff066dcdade078f601377
Reverted: https://github.com/dart-lang/sdk/commit/40ed0daaaf71904d2da271e66ba8381ef857116d
Review URL: https://codereview.chromium.org//1185633003 .
2015-06-19 13:44:58 +02:00
Karl Klose