dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
78,705 Commits 2 Branches 0 Tags
387e9d9ab2cd991663df8781d4fd914c194960da
Commit Graph

44 Commits

Author SHA1 Message Date
Ryan Macnak be7bea72dc [infra] Add new compressed architectures to the test matrix. 
This merely makes the architectures known to test.py; it does not create new bots.

TEST=ci
Change-Id: Icd50eb3b09c7eeadec796d5154226bba5cacf227
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/182665
Reviewed-by: Liam Appelbe <liama@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2021-02-04 17:44:37 +00:00
William Hesse 4a39a9b9fe [infra] Disallow spaces in test configuration names 
Change-Id: Ibd96e414d9a8c76a36b4fc8360ceca3560f1dd91
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181404
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
 2021-01-29 14:55:56 +00:00
Sigmund Cherem 72cdf5beb8 [test_runner] support testing dartdevk with d8 
Change-Id: If38d3013a4ac60b6ef552f004451556898838445
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/177001
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2021-01-06 01:53:30 +00:00
Alexander Markov 4054a9edf4 [Test tool] Remove -c dartkb configuration 
Change-Id: I178f18484b853aa35248fa9f6252509ec0df6832
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/169500
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2020-11-02 14:06:19 +00:00
Karl Klose 1ad255e8b9 [pkg/smith] Check that each configuration is tested on at most one builder 
Change-Id: I9233fa6f75dae727bc3a6951ca35792967610db0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148064
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Karl Klose <karlklose@google.com>
 2020-05-14 10:40:41 +00:00
Ryan Macnak fd9d99d527 [infra] Reduce duplication in configuring the sanitizer bots. 
Reduce the suites run by AOT ASAN/MSAN to "vm" and "standalone"; the full set of suites takes longer than the bot timeout.

Change-Id: I29cb0cfc19d429d63229f2123fe7f6ddfad93cd0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142566
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2020-04-08 20:26:33 +00:00
Karl Klose bb14279237 [infra] pkg/smith: custom test runner steps are test steps 
Change-Id: I6517475d1db1cad707fb0d096e2689ea265f6a9b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133522
Commit-Queue: Karl Klose <karlklose@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-03-26 13:44:08 +00:00
Samir Jindel 1fbc71da0f Re-land "[vm] AOT blobs snapshots are obsolete. Remove dead code." 
Original change is in Patchset 1. I erroneously assumed DART_PRECOMPILER
was only used AOT compilation (it is also used for JIT snapshots).

Change-Id: I77f6c463db7f2b482c9b098f353dc28f0676ea0d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135900
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
 2020-02-17 11:12:15 +00:00
Siva Annamalai edd64e6d5c Revert "[vm] AOT blobs snapshots are obsolete. Remove dead code." 
This reverts commit bcc0900e6a.

Reason for revert: This CL is breaking the Fuchsia Flutter build see https://github.com/flutter/engine/pull/16604/checks?check_run_id=445155807 

Original change's description:
> [vm] AOT blobs snapshots are obsolete. Remove dead code.
> 
> Change-Id: I35cf4befbe66b92197dcd659172f90be3de30f8e
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134840
> Commit-Queue: Samir Jindel <sjindel@google.com>
> Reviewed-by: Ryan Macnak <rmacnak@google.com>

TBR=rmacnak@google.com,sjindel@google.com

Change-Id: I9dd32a71bf43907f59ed766b98bf453bab99ea3c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135881
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
 2020-02-14 06:40:31 +00:00
Samir Jindel bcc0900e6a [vm] AOT blobs snapshots are obsolete. Remove dead code. 
Change-Id: I35cf4befbe66b92197dcd659172f90be3de30f8e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134840
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2020-02-13 14:16:49 +00:00
Karl Klose 3ab2112b06 [infra] Add support for branches to pkg/smith 
Change-Id: Id2562a7dd2a4180aef7d7623ac937d7abae8ff74
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133237
Commit-Queue: Karl Klose <karlklose@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-01-31 06:37:41 +00:00
Daco Harkes a86288a1d8 [test_runner] QEMU named configurations 
Issue: https://github.com/dart-lang/sdk/issues/40337

Change-Id: Ifd6855406686ff87f3a600cf5acef8777e44bed7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133525
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2020-01-28 16:08:27 +00:00
Karl Klose 23fa59f8b6 [infra] Add support for builders to pkg/smith 
Change-Id: I21b970aaa61331b25687891f325621165f7861ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128160
Commit-Queue: Karl Klose <karlklose@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-01-27 08:13:25 +00:00
Ryan Macnak 3678a3bd42 [build] Use separate out directories for each sanitizer. 
Bug: https://github.com/dart-lang/sdk/issues/39611
Change-Id: Ie0aeaff758234220c2f0267b462d14f4c076bdf6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127821
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2019-12-11 18:12:47 +00:00
Samir Jindel c885bdde1d [vm] DBC is obsolete. Remove dead code. 
Change-Id: Ica33af158cca53c8e951e4b2582de83660e8a60d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121851
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2019-10-27 18:18:29 +00:00
Alexander Thomas e62c7ae3bb [infra] Add legacy AST mode builder to the test-matrix.json 
This also removes the now redundant bytecode testing from the dartkb
builders.

Replace the useKernelBytecode boolean option with a more flexible
genKernelOptions string list option.

See also See also https://dart-review.googlesource.com/c/sdk/+/122321/ for the
corresponding Luci config updates.

Change-Id: Iabb207bc02637b758c42c00ae9175bd52f46559f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122320
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2019-10-25 15:11:00 +00:00
Martin Kustermann e82fedc345 [vm] Remove deprecated (and untested) ARMv5 support from the VM 
Since we have no CQ/CI test coverage of ARMv5 and none of our customers
uses it, a breaking change request was made (see issue further down).

The breaking change has been approved and a corresponding email has been
sent out:

https://groups.google.com/a/dartlang.org/forum/?nomobile=true#!topic/announce/vRQja7di3FQ

This CL removes any armv5 related code from our codebase.

Closes https://github.com/dart-lang/sdk/issues/36666

Change-Id: I9abf32f1980ca19a9cf882b43c9966b2127f89e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122540
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2019-10-23 14:44:33 +00:00
Robert Nystrom aab88791b8 Change experiment flag name in test runner and test config. 
Use "enable-experiment" to be consistent with other tools.

Change-Id: If9598f667517443a4f61ef91955ff57a477f0a5c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121681
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
 2019-10-14 23:24:58 +00:00
Samir Jindel db352304ec [vm] Test AOT on Android with the 64->32 bit cross-compiler. 
We introduce a new architecture ARM_X64, which is the same as ARM except that
the host-targeting-host binaries are compiled for X64 instead of X86.

Issue https://github.com/dart-lang/sdk/issues/38709

Change-Id: I00a2b1cc71948adec9f66c7b2ee61e9e5ac53d2a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120121
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2019-10-07 10:35:45 +00:00
Robert Nystrom 3f7805a90e Make the NNBD command-line options less, uh, half-baked. 
- Better name than "optedIn".
- Actually hook up the command-line option to the configuration.
- Add tests, which would have caught the previous mistake.
- Don't allow comma-separated values for "--progress" and "--nnbd".
- Remove unused dead "--strong" option.

Change-Id: I57d7cb0d81af50d662dcf3f7f4c9ca1f2b102f2f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116544
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Mayank Patke <fishythefish@google.com>
 2019-09-10 22:39:19 +00:00
Robert Nystrom 981be87206 Add configuration options and flags for controlling NNBD mode. 
This data is parsed by configurations and allowed as command-line
options to the test runner, but isn't currently plumbed through to any
of the tools. That's the next step.

Change-Id: I7931a11502a1c460e28b2a4a13d8722d8ad6974d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115767
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Mayank Patke <fishythefish@google.com>
 2019-09-06 01:17:07 +00:00
Robert Nystrom 89ad636b58 Remove the old "preview Dart 2" flags from the test runner. 
Dart 2 shipped a year ago, so we're pretty well past a "preview". :)

Change-Id: I6c5d21ae4181e4228cc1fc49b6344cdb8fc43794
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115544
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Mayank Patke <fishythefish@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
 2019-09-05 16:59:43 +00:00
Robert Nystrom 7cfedd9a6f Run dartfmt --fix on pkg/smith. 
Change-Id: I423489b851638f6d50fe365433863fd6bc91bb14
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115501
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
Reviewed-by: Mayank Patke <fishythefish@google.com>
 2019-09-04 22:55:56 +00:00
Nate Bosch efc85cac7c Drop TODO to remove isHostChecked option 
See #37318

This enables asserts in the dart2js compiler and is worth keeping.
Update the comment to better express the behavior and remove the TODO to
drop it.

Change-Id: I2e1eef74eac7949812670dd1c6294641ce80a4a8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106940
Auto-Submit: Nate Bosch <nbosch@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2019-06-24 18:59:27 +00:00
Nate Bosch cf03e96b90 Remove appJit and precompiled compiler options 
Towards #37318

- appJit has been replaced by appJitk and is no longer.
- precompiled has been replaced by dartkp and is no longer used.
- For the precompiled runtime, default to dartkp.
- Remove status file references to these compiler options and normalize
  status files.

Change-Id: I48728db13dc84737092a92314e2f474a9309f4d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106942
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2019-06-24 16:07:27 +00:00
Vijay Menon b3b9aacc5f [dartdevc] enable testing on ff/safari/edge 
Change-Id: Ice9cc8f4955561a7d36b7ab2bc7a0622cc4966b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105482
Auto-Submit: Vijay Menon <vsm@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2019-06-10 16:24:55 +00:00
Alexander Thomas 182d55dfda [dart2js] Add support for BabelJS to test.py 
This adds support for BabelJS to test.py's dart2js compiler
configuration. When --babel is specified directly or through a named
configuration, test.py will run an additional step after dart2js that
post-processes the javascript output by running it through BabelJS with
the specified Babel configuration. BabelJS is added to the DEPS in its
standalone form. d8 is used to run BabelJS standalone to avoid adding
a dependency on NodeJS. d8 can only write to stdout but not to files or
stderr, which makes it necessary to change the test_runner to handle
commands that expect their output to be piped to a file.

Changes:
* Add --babel option to test.py.
* Add babel option to pkg/smith.
* Switch IE11 builder to use babel transformation.
* Fix option list comparison bugs in pkg/smith.
* Change dart2js compiler configuration to generate files using the
  test name rather than just "out.js" (update test that relied on this).
* Remove runtime_configuration dependency on test_suite.
* Remove obsolete blocks adding --preview-dart-2 dart2js arguments.
* Make dart2js' compiler configuration more like DDC's.
* Remove createCommand method that is no longer used.
* Remove support for "OtherResources" which was only used for
  dart:isolate tests on dart2js and DDC.
* Skip co19_2 tests that are slow to transform with babel.
* Simplify the timeout handling in the test runner with Future.timeout.

Change-Id: I32e4917b2a57ecbe684538e40d744f0101c552a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/90402
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-05-29 08:39:44 +00:00
Ryan Macnak af93ebcf4c [vm] Direct generation of ELF shared libraries. 
Change-Id: I41c9911f33490e504f4852f15695ca4c3f32a77f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/81323
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2019-05-28 18:48:57 +00:00
Sigmund Cherem 888596af88 Add support for a production dart2js mode in test.dart 
Change-Id: Ia828cb46106f044313e579f1c4b23ec92c6a2d44
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96862
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2019-03-14 23:59:28 +00:00
Sigmund Cherem 1b5f7c1047 Remove unnecessary flags for dart2js from test.dart 
Change-Id: I751688fba97d605de69164068fe2377d80087127
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96861
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2019-03-14 22:01:13 +00:00
William Hesse a533753bec Remove --fast-startup flag support from testing scripts and status files 
Change-Id: Icfb4aa228c0f13bf9fce25aeb7bacbf1e38497ee
Reviewed-on: https://dart-review.googlesource.com/c/89582
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-01-16 11:32:44 +00:00
Martin Kustermann 2260758ffe [infra] Make --keep-generated-files work with -n option 
Makes the --keep-generated-files flag an option for the test.py command
only, not part of a named configuration passed in with the -n flag
and defined in tools/bots/test_matrix.json.

Change-Id: If67c2848cf6fc15e4cb7167ce23eeb3eb9bd1684
Reviewed-on: https://dart-review.googlesource.com/c/85705
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2018-12-03 15:35:40 +00:00
Martin Kustermann 5d7786948c [infra] Add --keep-files flag to tools/test.py 
This allows one to actually run the commands which are printed in a
failure.

Change-Id: I62c8a387c37d3563ea3c0f803c107e2e9d8262bb
Reviewed-on: https://dart-review.googlesource.com/c/85483
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2018-11-28 16:44:15 +00:00
Paul Berry c925fa6b00 Lay the groundwork for comparing language_2 compilation results between analyzer and CFE. 
This CL just adds the compiler=compareAnalyzerCfe option to the test
framework, and updates the status files so that no language_2 failures
are expected when this "compiler" is used.  A placeholder executable
has been added to sdk/bin, but it is not wired up yet--that will be
done in a future CL.

In a future CL I will wire up the placeholder executable to the code
in pkg/analyzer_fe_comparison, and fill in the methods in
CompareAnalyzerCfeCommandOutput to process the output accordingly.

Change-Id: I27439de4ac609cb8b003f157a0ff88d181bfbcae
Reviewed-on: https://dart-review.googlesource.com/73561
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2018-09-08 15:25:05 +00:00
William Hesse e29176ea0d Add --use-cfe and --analyzer-use-fasta-parser flags to smith:configuration 
Use them in test_matrix.json for the analyzer builders.

Bug: https://github.com/dart-lang/sdk/issues/34151
Change-Id: I4abe0bcc8b62ee372df32c0402fad3cd9042cb27
Reviewed-on: https://dart-review.googlesource.com/70282
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2018-08-17 14:42:43 +00:00
William Hesse 4c2ef4bb33 Add side-by-side printing of configurations to package:smith 
Change-Id: I5e516447c619a189b155a5b55ee3ec45504d6b30
Reviewed-on: https://dart-review.googlesource.com/68682
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2018-08-16 13:28:27 +00:00
Alexander Thomas ba10df6611 [infra] Switch pkg bots to Dart 2 
* Update named configs for unit tests to Dart 2.
* Bump json_rpc_2 in front_end package.
* Use named configurations in unit tests.
* Fix typing issues.

Change-Id: Id3b393a0d2abe92c8eaec10fa8057fb35d18a4c6
Reviewed-on: https://dart-review.googlesource.com/67341
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-08-13 07:04:06 +00:00
William Hesse be7022f6d9 Remove named configuration template expansion code from test.py. 
Named configuration templates are expanded by the recipe before being
passed to test.py.

Change-Id: I164df7acf0a0aff76f050b871101590efae51954
Reviewed-on: https://dart-review.googlesource.com/69300
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
 2018-08-10 13:12:49 +00:00
William Hesse 0bb7a8730a Fix analysis error in pkg/smith 
Change-Id: Idf84bc411d08353d2235b927f6373501f9a327b1
Reviewed-on: https://dart-review.googlesource.com/68370
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-08-06 17:55:12 +00:00
William Hesse e0f6fdfff1 Refactor testing:TestConfiguration to use smith:Configuration by inclusion. 
Change-Id: I5c116ad082a24c25a07b9ceb6aaf8c9cbe3f11e3
Reviewed-on: https://dart-review.googlesource.com/68361
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2018-08-06 16:19:08 +00:00
William Hesse cf77a3b00f [Test.dart] Use Compiler, Runtime, etc. classes from pkg:smith. 
Change-Id: I1251c94e87fe6953f7604b5ef8f6ae5c49ab36d3
Reviewed-on: https://dart-review.googlesource.com/67522
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2018-08-01 09:45:17 +00:00
Zach Anderson 1336802dee [test] Adds a KBC configuration to the test matrix 
This is to run on FYI

Change-Id: Ic62e858853a3ccb67d844ec454fd1819aa35b87d
Reviewed-on: https://dart-review.googlesource.com/65780
Commit-Queue: Zach Anderson <zra@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2018-07-26 22:05:06 +00:00
William Hesse 1400cf66e7 Add named configurations to test matrix. 
Change-Id: I259cd854a6ceb2ab2c2813184bfaae1fbc7b3f4e
Reviewed-on: https://dart-review.googlesource.com/62140
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2018-07-04 13:57:19 +00:00
Bob Nystrom a4c7cf388f First stab at a parsing library for named configurations. 
Change-Id: I1a2660914715d529b0233645b109b13c2fa9171a
Reviewed-on: https://dart-review.googlesource.com/61121
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2018-06-26 22:17:08 +00:00