dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
84,081 Commits 2 Branches 0 Tags
345dfd34ac7613cea4ba9f736eb10529982de66d
Commit Graph

1331 Commits

Author SHA1 Message Date
Konstantin Shcheglov 2cffb8dc68 Test for Flutter outline works in enum methods. 
Change-Id: I789b97b1c11f601ce4fd29b1c661176bf2cbc3a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234447
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-26 00:16:02 +00:00
Sam Rawlins 98361461f0 Add remove_leading_underscore fix for lint 
Change-Id: I2db240604580f270980296c07296a1336d45ff90
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234341
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-02-25 15:57:33 +00:00
Danny Tuppeny 84806572e0 [analysis_server] Allow Flutter "Wrap" assists to work with constructor names selected 
Fixes https://github.com/Dart-Code/Dart-Code/issues/2492.

Change-Id: I5347e3ade842c3a155809e5224ca0ab40dd8651b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234285
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-24 20:04:30 +00:00
Konstantin Shcheglov 69c8eccfc2 Implement outline for enum members. 
Change-Id: I1f117d20b23206e192b3fb3286581aaa2d46b942
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234321
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-24 18:56:43 +00:00
Brian Wilkerson d41b7d73b0 Support converting classes with factory constructors to enums 
Change-Id: If42ca118ade6750ecb88f09ce7e18a338e8255ca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233761
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-20 21:27:44 +00:00
Konstantin Shcheglov 627eb64320 Test for Flutter outline with named arguments anywhere. 
Change-Id: I9e2df45ba04c0e02b2388029c2c3c56213ef9dc5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233644
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-19 02:04:31 +00:00
Brian Wilkerson 0921dceaef Add a quick assist to convert a class to an enum 
Change-Id: Iebd83940c85e778132132bfe483df08193f574ff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233002
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-18 20:00:21 +00:00
Konstantin Shcheglov 60b428e2b1 Deprecate superclass2, mixinTypes2, etc. 
Change-Id: Ieaaeab57930cb93f5b6b1323efe63c3395b79993
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232742
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-17 02:20:42 +00:00
Danny Tuppeny 74248dc6db [analysis_server] Use ConvertToPackageImport fix for always_use_package_imports lint 
Fixes https://github.com/Dart-Code/Dart-Code/issues/3823.

Change-Id: I33d1448b36de1927e3e3cc5628d0d822d4f21786
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232265
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-10 19:45:31 +00:00
Sai Sandeep Mutyala 7605a36ab3 Add fix for sort_constructors_first lint. 
Bug: https://github.com/dart-lang/sdk/issues/47953
Change-Id: I0c927714f55eddd30d0c3770a3315118f64a160b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232141
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-10 06:03:59 +00:00
Sam Rawlins efe0af4cae Add functionality and tests for super-parameters in fixes for Hints and Errors 
Change-Id: I8e2c9754f65368ee5d1a243160e844b742506509
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232229
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-02-10 02:53:19 +00:00
Sai Sandeep Mutyala 3de72ec6b0 Add fix for sort_unnamed_constructors_first lint. 
Change-Id: I08decb3d05612d0899c570597ce0a3b8e1eb1c02
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231900
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-09 06:51:07 +00:00
fredbroz da97de73cb [analyzer] Add fix for avoid_void_async lint 
Closes https://github.com/dart-lang/sdk/issues/47959

Change-Id: I32838d7889cbaf9491d24672f19995cd6f75c2fa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-07 19:57:35 +00:00
Konstantin Shcheglov f69d1f887f Use CompletionSuggestionBuilder, and HasCompletionData to store location independent data. 
Change-Id: I767bfc1c31b5aebc8f4e27267520f705701e7724
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231044
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-04 17:33:19 +00:00
Brian Wilkerson a4b3b8edec Add an assist to convert a normal parameter to a super initializing parameter 
Change-Id: Icf5d44a3a155e67f76165eca711094d368cdca64
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231520
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-04 01:03:36 +00:00
fredbroz d48a637bf5 [Analyzer] Add fix for use_raw_strings lint 
Closes https://github.com/dart-lang/sdk/issues/47955

Bug: https://github.com/dart-lang/sdk/issues/47955
Change-Id: If321097598fcdcd79c246032f64332e91ee7f57c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231302
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-03 15:55:56 +00:00
Sam Rawlins b9b1252752 For existing fixes, add super-parameter and named-args-anywhere tests 
Bug: https://github.com/dart-lang/sdk/issues/48067, https://github.com/dart-lang/sdk/issues/47578
Change-Id: Iaef317459c7e6901296475163959ad92a6c880b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231070
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-02-02 17:47:49 +00:00
Keerti Parthasarathy eb4f5077ab Check for private elements while rename 
Change-Id: I3423cd746e675315a3abd1b728bc6cd978384beb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230954
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2022-02-02 03:08:46 +00:00
Sai Sandeep Mutyala 4e77df92de Add a fix for the leading_newlines_in_multiline_strings lint. 
Bug: https://github.com/dart-lang/sdk/issues/47960
Change-Id: Id775cfc3a2c5a8635ad26c8b4a611c94e770b6b6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229480
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-01-25 17:24:01 +00:00
Brian Wilkerson 1708703d15 Complete the refactoring of ElementMatcher 
There are quite a few TODOs left in the code, and I'll address them in
future CLs, but this appears to be consistent with the behavior of the
previous implementation and finishes the majority of the refactoring
changes.

Change-Id: I68093f6ac115f8b8b9b10bf93239fe4e2b9c6390
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229660
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-01-25 05:36:36 +00:00
Konstantin Shcheglov 8781ab0151 Update CompletionWithSuggestionsTest for better alignment with the new protocol. 
A few tests added, mostly removing CompletionSuggestionKind.INVOCATION
because it is set just for any available declaration by the completion
driver, but this is not what we use for local elements and the new
protocol.

Change-Id: I87da134fd94da75005a98e17e81f43ee56451baf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229261
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-01-20 22:44:08 +00:00
Danny Tuppeny 32b3e18e92 [analysis_server] Insert "required" keyword in created methods/added named parameters 
Fixes https://github.com/Dart-Code/Dart-Code/issues/3770.

Change-Id: I954b9bbcac72ffc7a7b6e168214971bf1786872a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228564
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-01-20 17:00:37 +00:00
Konstantin Shcheglov 6d5543e01b [analyzer] Update generated experiments 
experimental_features.yaml was updated in
https://dart-review.googlesource.com/c/sdk/+/219789
but unfortunately the analyzer code wasn't regenerated.

This CL updates the generated files and adds capability of checking
consistency to the generator. A check of consistency is add next to
the check for consistency used in presubmit for the CFE counterpart.

Was: https://dart-review.googlesource.com/c/sdk/+/224520
Change-Id: I59be4335ee81743aca5dc48eaa0df278d64d3692
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229020
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-01-20 00:07:36 +00:00
Brian Wilkerson df2e8fedbb Start to refactor ElementMatcher 
This is the first of multiple smaller CLs to refactor `ElementMatcher`.

I was starting to fix a bug and realized that the current implementation
allows the number of components to be out of sync with the element kind.
The primary goal is to prevent that by eventually merging the methods
`_componentsForNode` and `_kindsForNode` into a single method
(`buildMatchersForNode`).

In the process I realized that we can sometimes match either a top-level
declaraation or an instance member from a superclass, and that means
that we need multiple matchers (otherwise I think the number of
components will continue to be out-of-sync with the element kinds).

This CL also includes the failing test that started the whole
investigation into refactoring this class.

Change-Id: I0c3a56f29f0f6c6d0cad6ac80145b26201931518
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228722
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-01-18 23:39:27 +00:00
Danny Tuppeny 650b9627b7 [analysis_server] Rebuild analysis contexts if changes occur between creation and watchers being ready 
See https://github.com/Dart-Code/Dart-Code/issues/3438.

Change-Id: I3ca038d8c878b118a465b6f230c62912d63990eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/222763
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-01-15 00:18:41 +00:00
Konstantin Shcheglov 6e30e5a7f6 Add 'Extract local variable' fix for UNCHECKED_PROPERTY_ACCESS_OF_NULLABLE_VALUE. 
Bug: https://github.com/dart-lang/sdk/issues/47588
Change-Id: Ice823f239b3b152d9583cecb143ea78a62361539
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/227900
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-01-13 01:03:22 +00:00
Konstantin Shcheglov 3adbfcf6a5 Suggest SUPER if Feature.super_parameters is enabled. 
Change-Id: I9d6393a412e5f5016359c89cf85fd910b0ac9357
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/226608
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-01-06 19:07:55 +00:00
Brian Wilkerson f795340952 Add required keyword when fields are non-nullable 
Fixes https://github.com/dart-lang/sdk/issues/48021

Change-Id: I75062fba435d56beaea26b93178d24030a98fb32
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/226482
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2022-01-05 18:08:46 +00:00
pq bb10749b1f fix enum-like class tests 
See failure: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8825929622369081137/+/u/test_results/new_test_failures__logs_

Change-Id: I9c5e3caecd82674276ca89f7d7796aae91542835
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/226483
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-01-05 03:02:12 +00:00
Parker Lougheed 57fdc16b7b Enable prefer_final_parameters quick fix for default parameters. 
Fixes #47912

Bug: 47912
Change-Id: Ic2e2802ee89d6f78750efef862dcaa74083a9d33
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/225840
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-01-04 19:23:51 +00:00
Brian Wilkerson eaef692c3f Add quick fixes for invalid return types for generator functions 
Change-Id: I23a3befd37946c02aadc8c0ebdf75e60cf6767c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/225426
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2021-12-23 17:36:42 +00:00
Brian Wilkerson 7b7079f519 Allow authors to specify that a member is static 
This information isn't currently being used, but the intention is to not
apply a transform for a static element if the reference to the element
isn't qualified by the name of the container (because outside the
container all references to a static member must be qualifed).

Change-Id: I9e316c32287e6cf3dcdfd911296bc3948f1749e2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/225460
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-12-23 00:11:32 +00:00
Sam Rawlins b16b0322b9 Reland "analyzer: Report missing return for nullable return types" 
This is a reland of 93bcdf0329

Original change's description:
> analyzer: Report missing return for nullable return types
>
> This is implemented as a new HintCode, but it could be a new Warning, if
> we'd like to stop adding new Hints.
>
> There is also a dartfix available in this change.
>
> Fixes https://github.com/dart-lang/sdk/issues/46656
>
> Change-Id: I8e93e576d2bd09a8ff02d52c12bbb9ec6adff9c2
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220803
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
> Commit-Queue: Samuel Rawlins <srawlins@google.com>

Change-Id: I369b2dc38db0dc278f50b55aab67da53a5a63a8d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/225400
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2021-12-22 18:46:14 +00:00
Alexander Thomas 3b5d06e449 Revert "analyzer: Report missing return for nullable return types" 
This reverts commit 93bcdf0329.

Reason for revert: Broke google3 rolls.

Original change's description:
> analyzer: Report missing return for nullable return types
>
> This is implemented as a new HintCode, but it could be a new Warning, if
> we'd like to stop adding new Hints.
>
> There is also a dartfix available in this change.
>
> Fixes https://github.com/dart-lang/sdk/issues/46656
>
> Change-Id: I8e93e576d2bd09a8ff02d52c12bbb9ec6adff9c2
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220803
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
> Commit-Queue: Samuel Rawlins <srawlins@google.com>

TBR=scheglov@google.com,brianwilkerson@google.com,srawlins@google.com

Change-Id: I122be4cb1d07f7f95334d2d5cbac1de4bd597d15
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/224950
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2021-12-22 08:38:52 +00:00
Sam Rawlins 93bcdf0329 analyzer: Report missing return for nullable return types 
This is implemented as a new HintCode, but it could be a new Warning, if
we'd like to stop adding new Hints.

There is also a dartfix available in this change.

Fixes https://github.com/dart-lang/sdk/issues/46656

Change-Id: I8e93e576d2bd09a8ff02d52c12bbb9ec6adff9c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220803
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2021-12-21 18:22:03 +00:00
Danny Tuppeny 8e407058db [analysis_server] Include required named parameters in generated super constructor calls 
Fixes https://github.com/Dart-Code/Dart-Code/issues/3734.

Change-Id: I5dcae267b4989a5244c0704a4ddedba5409b2ce6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/224940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-12-21 17:01:53 +00:00
Keerti Parthasarathy 498d976e1e Implement signature help for cider. 
Change-Id: I4b10d4a2a61d3c1fc0bcec652694b7a1b7d0393d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/222841
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2021-12-13 18:02:18 +00:00
Konstantin Shcheglov f25b9a0601 Tweaks for IMPORT_LIBRARY_PREFIX. 
Change-Id: I8a91de92a41a9ed33ea74c53c6a77eb4c36901af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/223480
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-12-13 16:38:27 +00:00
Konstantin Shcheglov b2f2aac4b9 Use 'packagesRootPath' in 'Import Library' tests. 
Change-Id: I106a4bbca5ae3dfe1d08211eb91a321827227b68
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/223460
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-12-13 16:30:24 +00:00
Konstantin Shcheglov 30ea5d1167 Return variable to either getter or setter. 
Change-Id: I412b1747f95505c37812a4f72f5f1e0fe6fff81f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/223500
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-12-13 16:29:53 +00:00
Konstantin Shcheglov 979f3ea79e Use LibraryElement(s) to find extensions for 'Import Library' quick fix. 
So, we don't need ExtensionCache anymore.

This fixes the issue with importing a library from lib/src sometimes.

Bug: https://github.com/dart-lang/sdk/issues/47842
Change-Id: I9a28fb2e1e14ab96a58c3ef72daa87562f1bccd6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/223441
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-12-12 17:39:22 +00:00
Konstantin Shcheglov 5cc2d95815 Implement DartFixContext.getTopLevelDeclarations() as a method. 
Change-Id: Iaf58027c46cd6824e76c66139a4b13fb03825ffb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/223340
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-12-11 18:51:20 +00:00
Konstantin Shcheglov e0752585f2 Use available files and element models for 'Import Library' quick fix. 
We still use `ExtensionCache` to fix members.
I will try to change this next.

Change-Id: I047250b0fc9187673fcc88e80b1d40fc421db475
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/222542
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-12-10 20:35:40 +00:00
Danny Tuppeny 08aeef0303 [analysis_server] Switch assert() to expect() in test function 
+ tweak dartdoc on RangeFactory method.

Change-Id: I8026132f808f195cf0ca68673147efaa8cc95364
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/223100
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-12-10 19:51:35 +00:00
Danny Tuppeny e94799ad01 [analysis_server] Keep trailing comments when sorting members 
Change-Id: I7c6a2bf2ac5bcc5ff1079818d1c8a5ab768de946
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/222463
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-12-09 20:23:30 +00:00
Danny Tuppeny 30e4510f20 [analysis_server] Add a server.cancelRequest request for cancelling outstanding requests 
Change-Id: I1b43b0e61e5cc89261170ce13613fad756600d97
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/222201
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-12-09 17:39:43 +00:00
Keerti Parthasarathy c7de515ac9 Add support to rename compilation unit members. 
Change-Id: I81d50c06126b9ad552f978e6ce298f9797c05866
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/222340
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2021-12-08 17:21:30 +00:00
Konstantin Shcheglov 76bfec126d Issue 47842. Add a test for extension from other package. 
Bug: https://github.com/dart-lang/sdk/issues/47842
Change-Id: Ib6c4d6791f823191ef39998a6e350c48915d52fa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/222243
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2021-12-06 21:40:47 +00:00
Sam Rawlins e774227a81 analysis_server: Remove implicit casts from test and tool 
Bug: https://github.com/dart-lang/sdk/issues/41651
Change-Id: I0a165aef2b5d5cd2f97e5728bb6011a8eb70d9a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/222041
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2021-12-06 03:30:26 +00:00
Konstantin Shcheglov 387fc2e8db Use testPackageLibPath in analysis_server/ tests. 
Change-Id: I0500183fe14288447735c85e6d8e070fc913e8a4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/221993
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-12-03 00:05:26 +00:00