Commit Graph

13 Commits

Author SHA1 Message Date
William Hesse cd21da1d98 Disable taskkill failure when killing dart processes on windows.
There is an outstanding issue with pub hanging and being unkillable on
windows.  Make the taskkill step pass on windows, even if there are
dart processes, until we fix this issue.

BUG=https://github.com/dart-lang/sdk/issues/24086
R=kustermann@google.com

Review URL: https://codereview.chromium.org/1582773002 .
2016-01-13 11:17:18 +01:00
Rico Wind 171ca680ba Upstream change to also kill fletch as part of task_kill.py.
This is to keep the patching of our branch as small as possible (and to guarantee consistency if we share bots between sdk and fletch runners)

R=ahe@google.com, whesse@google.com
BUG=

Review URL: https://codereview.chromium.org//1304613002 .
2015-08-20 09:32:59 +02:00
Rico Wind 6d4aea874d Don't fail taskkill on chrome processes alive
It happens quite often that the browser controller fails to kill chrome on the package waterfall.

R=eernst@google.com
BUG=

Review URL: https://codereview.chromium.org//1150543004
2015-06-04 12:43:33 +02:00
ricow@google.com c53f791e62 Remove editor and java kill script from the taskkill script
R=whesse@google.com
BUG=

Review URL: https://codereview.chromium.org//1136233002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45731 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-12 10:41:32 +00:00
whesse@google.com c7d5711688 Build Tools Cleanup
Cleans up Python Code in Build Tools

TEST: build everything and run tests
BUG: https://code.google.com/p/dart/issues/detail?id=19592

R=ricow@google.com

Review URL: https://codereview.chromium.org//350483003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38573 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-25 11:47:59 +00:00
messick@google.com 97fda01ba0 Kill java to terminate editor on linux.
The DartEditor process can be killed without causing the editor
to terminate. I believe that in addition to killing it we also
need to stop the jvm. Plus, it needs to be done in order or else
the DartEditor process will display an error dialog when the
jvm is killed.

R=ricow@google.com

Review URL: https://codereview.chromium.org//317423002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37099 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-06 20:18:05 +00:00
ricow@google.com 28719c7c90 Always kill the editor and eggplant if on linux
R=messick@google.com

Review URL: https://codereview.chromium.org//306383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36889 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-02 18:26:19 +00:00
ricow@google.com 1aba267aa7 Add git and svn to task_kill which we run on the bots.
We are occasionally seeing orphaned git processes when running pub tests on windows.

R=kustermann@google.com

Review URL: https://codereview.chromium.org//259963007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35475 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-28 07:32:45 +00:00
kustermann@google.com 6b219869ec Add content_shell to the list of processes that get killed in the task_kill.py step
R=ricow@google.com

Review URL: https://codereview.chromium.org//131743002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31656 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-09 14:07:20 +00:00
ricow@google.com 0ea1b3ed34 Reenable non-zero exitcode in the task_kill script
BUG:13121

R=kustermann@google.com

Review URL: https://codereview.chromium.org//23714008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27241 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-06 10:26:13 +00:00
ricow@google.com 6383f784a6 Tempoarily return 0 from taskkill process.
We are seeing hanging firefox instances on windows.

Review URL: https://codereview.chromium.org//23809006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27229 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-06 07:21:30 +00:00
ricow@google.com 63eaf527ac Update ps command in taskkill to also work on linux
R=kustermann@google.com

Review URL: https://codereview.chromium.org//23946003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27101 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-04 08:52:20 +00:00
ricow@google.com 18504fde18 Add small util for killing hanging processes.
This will be used on the buildbot to kill any hanging dart or browser
processes. We will print the command line that resulted in the hang to
enable us to track over time what is causing us to hang (at least for
the hanging dart processes).

R=kustermann@google.com

Review URL: https://codereview.chromium.org//23549002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26778 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 11:08:02 +00:00