Commit Graph

190 Commits

Author SHA1 Message Date
Jacob Richman cf7ae2e0cb Support JS$ prefix for dart and fix bug where _operator_getter and the [] operator were used inconsistently. Would only impact future use cases where js APIs returned types not auto-proxied with dart:html.
Support typed JS interop classes that extend the behavior of  dart:html types in Dartium.

This theoretically enables supporting package:dom at the same time as dart:html as well as helping with
JavaScript libraries that monkey patch the dom.

Also support JS$ name prefix to resolve name conflicts with dart reserved words and with
dart:html libraries.
Cleanup addEventListener and friends so they are consistent with typed JS Interop and fix
bugs in the unlikely case where multiple functions have the same identity hash.
Add checks to make it easier to catch when allowInterop is accidentally omitted
when using the new typed JavaScript interop. You will now get an exception
any time you pass a Function to JS via the new typed interop without first
calling allowInterop.

BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1583773003 .
2016-01-15 10:40:32 -08:00
Kevin Moore 156bc53866 Hide implementation members in dart:html, dart:js and related libraries
Closes https://github.com/dart-lang/sdk/issues/24602

R=alanknight@google.com, jacobr@google.com, terry@google.com

Review URL: https://codereview.chromium.org/1416043008 .
2015-11-02 13:23:22 -05:00
Alan Knight 8831fb876e Deprecate new internal Dartium/JsInterop APIs that are public
BUG=

Review URL: https://codereview.chromium.org/1428593002 .
2015-10-27 10:55:12 -07:00
Alan Knight c92a2450b4 Switch dart:html objects not to be NativeFieldWrapper subclasses with JsInterop
BUG=

Review URL: https://codereview.chromium.org/1392723003 .
2015-10-07 17:42:39 -07:00
Terry L. Lucas 7b322c246c Dartium JS Enabled take 2
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1348173002 .
2015-09-16 07:13:53 -07:00
Terry L. Lucas 09c804aa78 Revert "Dartium JS Interop enabled."
This reverts commit 403bd1698d.

TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1345083002 .
2015-09-15 19:44:26 -07:00
Terry L. Lucas 403bd1698d Dartium JS Interop enabled.
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1349493003 .
2015-09-15 17:36:47 -07:00
Terry L. Lucas 9b0d2582fc Revert "Dartium w/ JsInterop enabled"
This reverts commit 346af54711.

TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1330163010 .
2015-09-09 17:33:24 -07:00
Terry L. Lucas 346af54711 Dartium w/ JsInterop enabled
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1321613005 .
2015-09-09 17:01:40 -07:00
Terry L. Lucas 012c998f64 Revert "Patched in Dartium JsInterop"
This reverts commit 4bb2e617db.

TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1327083002 .
2015-09-08 13:35:03 -07:00
Terry L. Lucas 4bb2e617db Patched in Dartium JsInterop
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1310363006 .
2015-09-08 12:46:41 -07:00
Terry L. Lucas 5e52d8dc5d Updates for dart:js fixes after initial --gen-interop
TBR=vsm@google.com,alanknight@google.com

Review URL: https://codereview.chromium.org//1228093007 .
2015-07-16 09:52:44 -07:00
Terry L. Lucas cec5812335 Fixed Dictionary and Event hookup w/o --gen-interop
TBR=vsm@google.com

Review URL: https://codereview.chromium.org//1233083004 .
2015-07-14 14:18:48 -07:00
Terry L. Lucas 82fbd3382a Remove blink_jsObject when --gen-interop is not used.
TBR=vsm@google.com

Review URL: https://codereview.chromium.org//1236933003 .
2015-07-14 05:49:27 -07:00
Terry L. Lucas 4947e570d4 Changed to use JSInterop
Review URL: https://codereview.chromium.org//1173403004 .
2015-07-13 12:38:16 -07:00
alanknight@google.com f0136ff1eb Clean up WheelEvent
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//1126463005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45740 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-12 16:34:01 +00:00
alanknight@google.com 5397482fcc Make dartj2s do type conversions on constructor arguments
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//1023363002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44688 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-25 17:39:49 +00:00
alanknight@google.com b44058a0d2 Make Element.animate work in dart2js Chrome
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//1014843004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44642 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-23 18:26:06 +00:00
alanknight@google.com 46a24513a3 Add MediaSource.supported, annotations for supported browsers, and a minimal test
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//990383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44472 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-13 17:31:42 +00:00
alanknight@google.com 5d2f7f8ae8 Fix notification
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//1002953005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44471 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-13 17:21:31 +00:00
terry@google.com 68c6b252e4 Fixed tests for DOMPoint support for dart2js.
TBR=asiva@google.com,vsm@google.com

Review URL: https://codereview.chromium.org//968613002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44115 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-01 18:01:53 +00:00
terry@google.com e0fff4e457 Changes to support roll 39 IDLs
Reviewers=vsm@google.com,asiva@google.com

Review URL: https://codereview.chromium.org//952133004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44099 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-27 18:10:08 +00:00
sra@google.com 904433bd7c Revert "Annotate dart:html constructor expressions with precise non-nullable types."
Need to fix some html/element_types_test cases.

TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//904663005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43579 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-07 00:35:32 +00:00
sra@google.com f74e57786d Annotate dart:html constructor expressions with precise non-nullable types.
This addresses issue http://dartbug.com/22264

R=alanknight@google.com

Review URL: https://codereview.chromium.org//896723009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43578 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 23:24:19 +00:00
sra@google.com 8bed532218 Tweak toString() for better type inference
These changes ensure dart2js can infer toString() returns a non-null String on some of our samples.

One tactic is to always write toString method for which all returned expressions are a an interpolation (or literal), or a call to StringBuffer.toString.

R=alanknight@google.com, lrn@google.com

Review URL: https://codereview.chromium.org//895813002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43534 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 00:24:51 +00:00
lrn@google.com 42dac4c7b4 Add some ArgumentError and RangeError constructors that capture more information.
Switch some uses of RangeError.range to RangeError.index.
Fix bug in Queue where elementAt allowed `length` as input.

R=sgjesse@google.com

Review URL: https://codereview.chromium.org//711003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41653 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-11 07:55:47 +00:00
leafp@google.com 6de1786199 Arity indexing in dart:blink entry points
This CL replaces type mangling on the blink entry points with arity indexing.  So overloaded methods or methods with optional arguments now dispatch to blink entries specific to their number of arguments (but not their types).  This relies on C++ overload resolution being in place on the blink side (see https://codereview.chromium.org/668733002/).  For the time being, the dart side overload resolution code is left in place.

Resolver strings now have no type or arity info as well.

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//667983002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41236 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-21 20:46:55 +00:00
vsm@google.com 94095d64a2 Merge 38 changes to bleeding edge
TBR=terry@google.com,leafp@google.com
BUG=

Review URL: https://codereview.chromium.org//605083004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40774 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-29 15:56:25 +00:00
vsm@google.com 1c4bb5f363 Revert "Chrome 38 script changes from integration branch"
This reverts commit r40567.

TBR=leafp@google.com

Review URL: https://codereview.chromium.org//589253002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40570 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-22 21:11:34 +00:00
vsm@google.com 9e25106514 Chrome 38 script changes from integration branch
TBR=leafp@google.com

Review URL: https://codereview.chromium.org//593853002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40567 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-22 20:45:57 +00:00
terry@google.com ecceb75d35 Begin hookup of Blink IDL parser for dart:* libraries.
BUG=
R=vsm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39948

Review URL: https://codereview.chromium.org//444743002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40026 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-09 13:18:24 +00:00
terry@google.com ac72bce2f1 "Reverting 39948"
BUG=

Review URL: https://codereview.chromium.org//554853002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39999 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-08 20:58:19 +00:00
terry@google.com cf0c6a3565 Begin hookup of Blink IDL parser for dart:* libraries.
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//444743002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39948 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-08 02:33:50 +00:00
efortuna@google.com b8ab793a1b Reapply 38999. Third time's the charm! The issue was supportsTransitions was a
static method,and with my change I was calling an instance method. I've tested
all of the other html tests (before I was just testing on Dartium).

BUG=
R=leafp@google.com

Review URL: https://codereview.chromium.org//445733003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39003 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-07 18:36:23 +00:00
efortuna@google.com c8d48f89a9 t cl dcommi# Enter a description of the change.
"Reverting 38998"
TBR
BUG=

Review URL: https://codereview.chromium.org//449033004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38999 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-07 17:50:26 +00:00
efortuna@google.com c7dd285314 Reapplication of revision 38996 (dart side edits to make CSS Properties
accessible with and without prefixes), with the addition of CSSPropertyNames.in
which will be deleted once https://codereview.chromium.org/444453006/
is committed.

BUG=

Review URL: https://codereview.chromium.org//452493004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38998 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-07 17:21:06 +00:00
efortuna@google.com ceea5ab278 "Reverting 38996"
TBR because we need CSSPropertyNames.in from DEPS

BUG=

Review URL: https://codereview.chromium.org//451563005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38997 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-07 17:12:12 +00:00
efortuna@google.com 19c379afd9 This is the dart side edits to make this happen.
Fix for https://code.google.com/p/dart/issues/detail?id=19932

BUG=
R=leafp@google.com

Review URL: https://codereview.chromium.org//442523003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38996 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-07 17:09:40 +00:00
sra@google.com 7516e95066 Redo "Use @Native annotation on dart2js DOM native classes"
BUG=

Review URL: https://codereview.chromium.org//410863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38488 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-23 04:27:48 +00:00
sra@google.com 9a4f73207e Revert "Use @Native annotation on dart2js DOM native classes"
TBR=blois@google.com

BUG=

Review URL: https://codereview.chromium.org//410823002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38486 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-23 01:44:13 +00:00
sra@google.com 11a19d95be Use @Native annotation on dart2js DOM native classes
This is one of many steps to removing non-standard syntax from the dart2js libraries.

R=blois@google.com

Review URL: https://codereview.chromium.org//409053002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38484 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-23 00:23:17 +00:00
leafp@google.com 851e41a408 Fix overloading for IDBDatabase transaction
Use the underlying dart implementation class in overloading resolution
checks, rather than the dart interface which is presented to the
user.  This resolves an issue with IDBDatabase in which DOMStringList
and sequence<DOMString> have the same Dart interface type
(List<String>), even though the underlying implementation types differ
(List<String> vs DomStringList).

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//368433004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37883 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-01 17:24:47 +00:00
vsm@google.com 5267857888 Modify blink type map to finalize lazily
Ivan suggested altering our type maps to add a level of indirection - to avoid eagerly finalizing all classes.

Siva: not sure how you're instrumenting startup - can you test this out?

R=asiva@google.com

Review URL: https://codereview.chromium.org//300923003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37222 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-11 05:48:33 +00:00
efortuna@google.com 0e1022a6f7 Make fill parameter in context2d default to 'nonzero' as per the spec.
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org//279453003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36134 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-13 21:04:17 +00:00
vsm@google.com 7f7635fa5c Add type maps from blink name to html name
TBR=leafp@google.com

Review URL: https://codereview.chromium.org//284863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36107 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-13 15:48:29 +00:00
efortuna@google.com c0235e93ab "Reverting 36054"
TBR

BUG=

Review URL: https://codereview.chromium.org//282713002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36071 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-12 21:17:14 +00:00
efortuna@google.com 4599791901 Make fill parameter default to empty String.
BUG=
R=leafp@google.com

Review URL: https://codereview.chromium.org//277403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36054 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-12 19:30:48 +00:00
leafp@google.com d1f0594840 Initial overloading implementation in _blink
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//260893007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35662 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-01 22:03:06 +00:00
leafp@google.com 5e0688e1ec This CL contains all of the changes for splitting off all of the native
calls from dart:html into dart:blink.  As currently configured, the
dart:blink library will be empty and unused.  The only changes in the
idl generated dart and C++ code in the default configuration should
be cosmetic.  The global variable "dart_use_blink" in systemnative.py
currently controls whether or not the real blink library is
generated.  Enabling this requires as yet unchecked in changes to
blink.  These changes are expected to land as part of the chrome
35 roll.

Support for building with/without blink
DOM changes for checked receivers
Dartium native call generation refactor

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//254463006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35430 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 16:22:08 +00:00
jacobr@google.com 1ea29a21d7 Fixes for Chrome 34 merge
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//204033002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34069 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-18 22:08:44 +00:00