dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
36,106 Commits 2 Branches 0 Tags
33aaf940e522cc1ad7bdceaabcc32a48da86b2cf
Commit Graph

1746 Commits

Author SHA1 Message Date
Stephen Adams ffa96cdeac Avoid using wrong 'adaptor' for native methods. 
The Dart arity adaptor was adding default arguments to the call instead of calling with the given number of arguments.
The best way to fix this is to implement Issue 25548.

R=sigmund@google.com

Review URL: https://codereview.chromium.org/1612773002 .
 2016-01-21 08:44:22 -08:00
Harry Terkelsen 71077326d6 dart2js: fix bots for html tests 
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/1592803004 .
 2016-01-15 15:18:19 -08:00
Jacob Richman 1be2db9a05 Add back one test that still fails and remove a bunch of tests that now pass with the refactor. 
BUG=

Review URL: https://codereview.chromium.org/1591843003 .
 2016-01-15 14:42:07 -08:00
Harry Terkelsen f01e8b3e73 dart2js cps: Update status file for html tests 
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org/1585943004 .
 2016-01-15 12:16:36 -08:00
Ivan Posva b2a186c2dd - Readjust Dartium status files. 
BUG=

Review URL: https://codereview.chromium.org/1591063002 .
 2016-01-15 11:22:24 -08:00
Jacob Richman cf7ae2e0cb Support JS$ prefix for dart and fix bug where _operator_getter and the [] operator were used inconsistently. Would only impact future use cases where js APIs returned types not auto-proxied with dart:html. 
Support typed JS interop classes that extend the behavior of  dart:html types in Dartium.

This theoretically enables supporting package:dom at the same time as dart:html as well as helping with
JavaScript libraries that monkey patch the dom.

Also support JS$ name prefix to resolve name conflicts with dart reserved words and with
dart:html libraries.
Cleanup addEventListener and friends so they are consistent with typed JS Interop and fix
bugs in the unlikely case where multiple functions have the same identity hash.
Add checks to make it easier to catch when allowInterop is accidentally omitted
when using the new typed JavaScript interop. You will now get an exception
any time you pass a Function to JS via the new typed interop without first
calling allowInterop.

BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1583773003 .
 2016-01-15 10:40:32 -08:00
Ivan Posva 8741a8dcda - Update status files. 
BUG=

Review URL: https://codereview.chromium.org/1579213003 .
 2016-01-13 01:39:40 -08:00
Alan Knight 7f80dbbbe1 Revert "Mark supportsPointConversions deprecated and always true rather than testing DOMPoint" 
This reverts commit 2dfdfe554e.

BUG=

Review URL: https://codereview.chromium.org/1583673002 .
 2016-01-12 16:24:12 -08:00
Alan Knight 2dd20966d8 Unsuppress test now that Firefox on bots is updated. Bug 23479 
BUG=

Review URL: https://codereview.chromium.org/1581833002 .
 2016-01-12 13:58:42 -08:00
Alan Knight 2dfdfe554e Mark supportsPointConversions deprecated and always true rather than testing DOMPoint 
BUG=

Review URL: https://codereview.chromium.org/1580203002 .
 2016-01-12 13:52:38 -08:00
Alan Knight 914bf02cde Switch to using HashChangeEvent constructor instead of initHashChangeEvent 
BUG=

Review URL: https://codereview.chromium.org/1582443003 .
 2016-01-12 09:42:06 -08:00
Natalie Weizenbaum b33dcfdaad Remove the Dromaeo and TodoMVC samples. 
No one was maintaining or using these, and they were stale to the point
that they were breaking pkgbuild tests because their dependencies
weren't compatible with the latest SDK.

This also removes tools/testing/perf_testing, which only tested these
two samples.

R=kevmoo@google.com

Review URL: https://codereview.chromium.org/1576153002 .
 2016-01-11 13:09:26 -08:00
Ryan Macnak 6b964b83ac Add ./tools/test.py -c precompiler -r dart_precompiled. 
- Make --gen/run-precompiled-snapshot take a directory to use for the snapshot pieces.
 - Throw on Platform.executeable to prevent tests from becoming fork-bombs.
 - Update status files so 'dart_precompiled' is generally expected to behave the same as 'vm'.

Currently multitests will fail unless run with --jobs=1 because the test harness assigns them the same temporary directory.

Running this also requires a great deal of space. My out directory is 380G.

BUG=http://dartbug.com/24975
R=fschneider@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org/1507943002 .
 2015-12-18 12:08:10 -08:00
William Hesse 6485590527 Remove old java-based analyzer from test scripts and status files 
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org/1537653002 .
 2015-12-17 14:44:57 +01:00
Sigmund Cherem e6f6ce9743 fix safari test 
Apparently my approach to use wss didn't work to exercise the error codepath. This change makes us excersize errors. After testing this in Safari though, I coudln't reproduce the issue, so I remove the note about this being a regression test for the original issue.

Review URL: https://codereview.chromium.org/1513363003 .
 2015-12-10 16:02:27 -08:00
Sigmund Cherem db4195c752 Fix #19137: handle when regexp doesn't match in constructorNameFallback 
R=sra@google.com

Review URL: https://codereview.chromium.org/1510763006 .
 2015-12-10 12:28:12 -08:00
Alan Knight 44d82ebc43 Fix Chrome 47 test suppressions and invalid @DontInline directive 
BUG=

Review URL: https://codereview.chromium.org/1509323003 .
 2015-12-09 10:32:26 -08:00
Alan Knight 7f9dcb66a5 One more suppression and fix incorrect test names in previous CL 
BUG=

Review URL: https://codereview.chromium.org/1508963002 .
 2015-12-07 15:14:52 -08:00
Alan Knight e4f1784690 Update more Chrome 47 test statuses 
BUG=

Review URL: https://codereview.chromium.org/1509703003 .
 2015-12-07 14:05:35 -08:00
Alan Knight 39e69b1898 Suppress tests around issue 25155 (object tags in Chrome 47) 
BUG=

Review URL: https://codereview.chromium.org/1507013002 .
 2015-12-07 12:39:37 -08:00
Sigmund Cherem b837d63d47 Require jsInteropObject type to be resolved before we use it in native behaviors 
This fixes a failing interop test in the bots.

R=sra@google.com

Review URL: https://codereview.chromium.org/1484273002 .
 2015-11-30 17:37:02 -08:00
Sigmund Cherem 3fa0cae192 Alternative fix for the js-interop crash. 
R=sra@google.com

Review URL: https://codereview.chromium.org/1457383003 .
 2015-11-30 16:46:14 -08:00
Todd Turnidge bd2b840be0 Revert my recent changes to the Dartium test status files. 
We have restored blocking isolate spawning under a flag.

--------

Revert "Update test status files.  Issue #24990."

This reverts commit 05bf1d6bb6.

Revert "Skip isolate spawning tests on Dartium."

This reverts commit c6c6f121ed.

BUG=

Review URL: https://codereview.chromium.org/1472783004 .
 2015-11-23 15:15:55 -08:00
Todd Turnidge 05bf1d6bb6 Update test status files. Issue #24990. 
BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org/1454143005 .
 2015-11-19 12:42:58 -08:00
Alan Knight 42b9d7b702 Serialize the data argument to History's state-related APIs. 
BUG=

Review URL: https://codereview.chromium.org/1414903007 .
 2015-11-05 16:23:44 -08:00
William Hesse abcb3a4d4d Update status for Firefox 42. 
BUG=https://github.com/dart-lang/sdk/issues/24838
R=sgjesse@google.com

Review URL: https://codereview.chromium.org/1415473006 .
 2015-11-05 16:14:46 +01:00
Jacob Richman 6bfbb93d72 Make Dartium JS interop implementation more robust in the presence of JS paths that touch dart:html types. Note that the dart2js implementation was already robust in the presence of dart:html types. 
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1415463019 .
 2015-11-04 15:47:46 -08:00
Jacob Richman 1e3fb098d5 TBR. Only the method test group fails. Updated the test expectations file to reflect that. 
BUG=

Review URL: https://codereview.chromium.org/1405953006 .
 2015-11-04 10:56:30 -08:00
Jacob Richman 1ea74a407b TBR: fix status file for html.status. Only expect test to fail when it is actually run (which requires a browser). 
BUG=

Review URL: https://codereview.chromium.org/1423623007 .
 2015-11-04 09:40:40 -08:00
Jacob Richman e0f8e96dae Fix status file given new js_typed_interop test that cannot pass in dart2js checked mode without risky changes. 
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org/1410923006 .
 2015-11-03 20:08:19 -08:00
Jacob Richman 12e94fc1d9 Make function type checks for types returned by typed JS interop pass for functions with <=10 arguments. 
BUG=
R=leafp@google.com

Review URL: https://codereview.chromium.org/1428093005 .
 2015-11-03 17:58:22 -08:00
Stephen Adams 7f546e9e0c js_function_getter_trust_types_test should not run in --checked mode 
TBR=jacobr@google.com

Review URL: https://codereview.chromium.org/1417713004 .
 2015-11-02 16:27:12 -08:00
Jacob Richman 6566e91f04 Fix dartium bug handling object literal constructors with zero arguments. 
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1431513004 .
 2015-11-02 14:13:51 -08:00
Jacob Richman d0f456a910 Fix behavior when typed JS interop getters are called as functions. 
BUG=
R=sigmund@google.com, sra@google.com

Review URL: https://codereview.chromium.org/1431523002 .
 2015-10-30 16:07:04 -07:00
Jacob Richman e0d2263bb3 Add @anonymous annotation and restrict object literal constructors to only anonymous classes. This frees up defining factory constructors that do not correspond to object literals on JS interop classes. 
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org/1409033005 .
 2015-10-29 19:18:19 -07:00
Jacob Richman ff200c11fa Fix bug in allowInteropCaptureThis that caused JavaScript objects to accidentally be wrapped. 
Remove spurious call to _convertToJS

BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org/1412193009 .
 2015-10-21 11:12:08 -07:00
Jacob Richman f9551da8e3 Make is and as checks handle JavaScriptFunction correctly. 
BUG=
R=sigmund@google.com, sra@google.com

Review URL: https://codereview.chromium.org/1416803002 .
 2015-10-19 17:58:11 -07:00
Jacob Richman be1fcb9441 Switch Js to JS 
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/1410403003 .
 2015-10-19 17:32:10 -07:00
Alan Knight a9362610ee Hide internal methods like wrap_jso from the dart:html public interface 
Issue https://github.com/dart-lang/sdk/issues/24602

R=terry@google.com

Review URL: https://codereview.chromium.org/1409743003 .
 2015-10-19 11:28:53 -07:00
William Hesse 6a816f2dc1 Update status for failing tests 
BUG=https://github.com/dart-lang/sdk/issues/24608
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org/1410803002 .
 2015-10-16 14:00:48 +02:00
William Hesse b459efe087 Update status files for Chrome 46 
BUG=
TBR=sgjesse@google.com

Review URL: https://codereview.chromium.org/1407923002 .
 2015-10-15 22:42:58 +02:00
Terry L. Lucas e562934def More tests now pass and fixed custom elements to only work in default html and svg namespace 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org/1392063003 .
 2015-10-14 11:44:01 -07:00
Terry L. Lucas 4653701a76 Fixed native element extension, custom events, _VMUpgrader, and data binding. 
Enabled tests that exercise this areas.

TBR=alanknight@google.com

Review URL: https://codereview.chromium.org/1391143006 .
 2015-10-14 10:03:56 -07:00
William Hesse d04dbcd688 Update status for failing Dartium tests. 
TBR=terry@google.com
BUG=https://github.com/dart-lang/sdk/issues/24585
BUG=https://github.com/dart-lang/sdk/issues/24584

Review URL: https://codereview.chromium.org/1407713002 .
 2015-10-14 14:02:23 +02:00
Alan Knight def9b86310 StorageQuota should not be exposed. Remove tests 
BUG=

Review URL: https://codereview.chromium.org/1393103003 .
 2015-10-13 16:45:06 -07:00
Jacob Richman 58547f5508 Fix JavaScript property ordering issue that was breaking js_array_test on FireFox 
BUG=

Review URL: https://codereview.chromium.org/1408453003 .
 2015-10-13 16:23:23 -07:00
Alan Knight 8ab9253879 Unsuppress/fix most indexeddb tests on Dartium 
BUG=

Review URL: https://codereview.chromium.org/1405443003 .
 2015-10-13 15:32:02 -07:00
Jacob Richman fe431b9730 Fix analyzer warning in mirrors_js_typed_interop_test. 
BUG=

Review URL: https://codereview.chromium.org/1402873004 .
 2015-10-13 14:00:37 -07:00
Jacob Richman cd2752431e Support user generated custom native JS classes. 
BUG=
R=jmesserly@google.com, sra@google.com

Review URL: https://codereview.chromium.org//1318043005 .
 2015-10-13 13:15:28 -07:00
Alan Knight 8005f2000a Unsuppress Windows tests from Issue 24546 
BUG=

Review URL: https://codereview.chromium.org/1391193005 .
 2015-10-13 08:59:18 -07:00