dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
36,106 Commits 2 Branches 0 Tags
33aaf940e522cc1ad7bdceaabcc32a48da86b2cf
Commit Graph

19 Commits

Author SHA1 Message Date
pq 9b1fa223a8 Embedded libs key rename to defuse server landmine. 
1.13 stable builds of the SDK contain a version of server that fails catastrophically when analyzing source that imports packages that define embedded libraries. Since we can't pragmatically require more recent SDKs for flutter development we have been prevented from landing embedded libs in the flutter engine.  By renaming the key we use to identify contributed libraries, this change avoids the issue.  Old versions of server will simply ignore the new key and new ones will process it properly.  Win-win!

BUG=
R=danrubel@google.com

Review URL: https://codereview.chromium.org/1643023002 .
 2016-01-29 09:52:04 -08:00
pq 3d3c9c5af4 CLI support for embedders (#25380). 
Background here: https://github.com/dart-lang/sdk/issues/25380

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1631763007 .
 2016-01-26 11:33:14 -08:00
pq 1dcec8c35f Bootloader cleanup. 
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1570603004 .
 2016-01-11 14:13:44 -08:00
Brian Slesinsky ba1b82b240 Add --x-perf-report flag to the dartanalyzer command 
Also added a couple of performance tags to catch time spent in the driver.

BUG=
R=brianwilkerson@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org/1524413002 .
 2015-12-17 11:40:15 -08:00
pq 8887cd69f0 Fix analyzer_cli error overrides (#24452). 
Brings `analyzer_cli` inline with server wrt processing errors configured in `.analysis_options`.

Note some added complexity due to interactions with flags that globally escalate warnings/hints to errors.

https://github.com/dart-lang/sdk/issues/24452

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1529243002 .
 2015-12-16 12:44:38 -08:00
pq e4e61ee462 Disable temp-dir hosted tests pending fixes. 
Background here: https://github.com/dart-lang/sdk/issues/25258

BUG=

Review URL: https://codereview.chromium.org/1526533003 .
 2015-12-14 15:04:43 -08:00
pq fd0f649327 Driver failure mode fixes (and test cleanup). 
* `printAndFail(msg)` doesn't exit in testing (so we need to return null).

R=keertip@google.com

Review URL: https://codereview.chromium.org/1530453002 .
 2015-12-14 13:58:05 -08:00
pq 5a57d6e8dc CLI driver test re-enablement (#25001). 
Another stab.  The rub, I *think*, to our failures are unexpected calls to `exit()` on the bots (that are not reproducing locally).  These fixes should address that (and fix error stream handling along the way).

* fixes test setup and teardown to ensure exit handling is properly managed.
* fixes driver source to use the `exitHandler` and `errorSink` consistently

BUG=
R=keertip@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1525623003 .
 2015-12-14 13:08:47 -08:00
pq 1c3df7f4ec Revert "Make analyzer_cli tests bot-friendly (#25001)." 
This reverts commit e67affe6b6.

R=keertip@google.com

Review URL: https://codereview.chromium.org/1524493002 .
 2015-12-11 14:57:01 -08:00
pq e67affe6b6 Make analyzer_cli tests bot-friendly (#25001). 
* re-enables a host of tests that were breaking on the bots due to path issues

Bug: https://github.com/dart-lang/sdk/issues/25001

R=keertip@google.com

Review URL: https://codereview.chromium.org/1516353003 .
 2015-12-11 14:13:30 -08:00
pq 56650e6bfe More mock cleanup. 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1520673002 .
 2015-12-10 14:37:22 -08:00
pq ad7c566e04 Driver test fixes. 
* Updates to use new CONFIGURED_ERROR_PROCESSORS (rather than defunct CONFIGURED_ERROR_FILTERS).

BUG=
R=keertip@google.com

Review URL: https://codereview.chromium.org/1520663002 .
 2015-12-10 14:22:16 -08:00
Brian Wilkerson ea3ba0e31f Remove deprecated code 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1502213002 .
 2015-12-07 10:24:36 -08:00
pq 8d613feaf9 Migrate mockito mocks to typed_mock (#24994). 
BUG=24994
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1462393002 .
 2015-11-20 13:57:56 -08:00
pq 7c15fa857c More bot-unfriendly test fixing [TBR]. 
Remove tests pending update.

Background: https://github.com/dart-lang/sdk/issues/25001

BUG=25001

Review URL: https://codereview.chromium.org/1463133002 .
 2015-11-19 16:52:14 -08:00
pq c58e064b67 Remove bot-unfriendly tests (#25001). 
Remove tests pending update.

Background: https://github.com/dart-lang/sdk/issues/25001

BUG=25001

Review URL: https://codereview.chromium.org/1459083005 .
 2015-11-19 16:15:18 -08:00
pq 9ae1265ff5 analyzer_cli move to SDK. 
Tracking bug: https://github.com/dart-lang/sdk/issues/24731

Note, dartium build changes are in a separate CL: https://codereview.chromium.org/1453413006/

Some tests had to be disabled for want of mockito in the SDK; tracking their reimplementation is here: https://github.com/dart-lang/sdk/issues/24994

BUG=24731
R=whesse@google.com

Review URL: https://codereview.chromium.org/1459683003 .
 2015-11-19 14:52:54 -08:00
pq 5cc9a288bb Revert "Move analyzer_cli into the SDK." 
This reverts commit a573ed31f1.

BUG=
R=whesse@google.com

Review URL: https://codereview.chromium.org/1462143002 .
 2015-11-19 11:28:52 -08:00
pq a573ed31f1 Move analyzer_cli into the SDK. 
Build changes to follow.

Tracking bug: https://github.com/dart-lang/sdk/issues/24731

BUG=24731
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1464553003 .
 2015-11-19 11:11:17 -08:00