dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
36,106 Commits 2 Branches 0 Tags
33aaf940e522cc1ad7bdceaabcc32a48da86b2cf
Commit Graph

122 Commits

Author SHA1 Message Date
Konstantin Shcheglov e7e52ae2c0 Issue 25542. If an element does not have its own documentation, use the documentation from the overridden superclass member or an implemented interface. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25542

Review URL: https://codereview.chromium.org/1632033002 .
 2016-01-25 17:09:48 -08:00
Konstantin Shcheglov cba8d0d7c3 Issue 25538. Fix for 'analysis.implemented' notification and private members. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25538

Review URL: https://codereview.chromium.org/1615023002 .
 2016-01-21 09:49:18 -08:00
Konstantin Shcheglov 5dc34340a1 Issue 25538. Fix for notification and private methods. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25538

Review URL: https://codereview.chromium.org/1610773003 .
 2016-01-21 08:01:51 -08:00
Konstantin Shcheglov 6824bd9b32 Fix for enum signatures. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1529593002 .
 2015-12-14 10:53:08 -08:00
Konstantin Shcheglov 38a4193b5f Issue 25244. Disable invalid overrides. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25244

Review URL: https://codereview.chromium.org/1519413002 .
 2015-12-13 15:50:12 -08:00
Konstantin Shcheglov 2f0f398c73 Fix lints: unnecessary_brace_in_string_interp 
Also fixes two cases of empty_constructor_bodies.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1521883002 .
 2015-12-13 13:05:00 -08:00
Konstantin Shcheglov 168556a3e4 Tweaks for hover. 
1. Include full signature of classes - extends, with and implements clauses.

2. Provide statis type only for variables - for all other elements the static type is always the same as in the signature.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1513943005 .
 2015-12-11 14:25:46 -08:00
pq 62656833d4 Wraps up the server-side of the 'Allow a user to configure which hints are "fatal"' ask (#24452). 
* migrates error filtering from a predicate to a process that can customize severities.
* moves filtering/processing from the `dart` task into the `getErrors` request and the errors notification.

See: https://github.com/dart-lang/sdk/issues/24452

(Pending a thumbs-up, support for CLI to follow.)

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1517723002 .
 2015-12-10 13:35:11 -08:00
Konstantin Shcheglov 72cf3cbe91 Remove unnecessary 'noSuchMethod' declarations. 
Also format these file.
I don't like how the new formatter changed the code :-(

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1507813004 .
 2015-12-08 11:39:37 -08:00
Paul Berry 4f654473ff Merge remote-tracking branch 'origin/master' into analyzer-breaking-0.27 2015-12-06 08:41:24 -08:00
Konstantin Shcheglov 2be2c5e55c Fix for navigation reginos for instance creations with import prefixes. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1498163003 .
 2015-12-04 14:24:09 -08:00
Brian Wilkerson b9644af695 Remove the old task model 
Review URL: https://codereview.chromium.org/1490233007 .
 2015-12-03 10:14:06 -08:00
Konstantin Shcheglov 1933891bad Issue 25057. A static member cannot be implemented. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25057

Review URL: https://codereview.chromium.org/1488443002 .
 2015-11-29 19:20:25 -08:00
Konstantin Shcheglov c302b65584 Use async/await in all analysis domain tests. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1478513002 .
 2015-11-24 14:18:37 -08:00
Konstantin Shcheglov cfb7d61a9c Issue 25034. Record only the target source's errors. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25034

Review URL: https://codereview.chromium.org/1477553002 .
 2015-11-24 14:00:00 -08:00
Konstantin Shcheglov 670db50707 Generate separate navigation regions for 'super' and optional 'name'. 
Also support for navigation regions for RedirectingConstructorInvocation.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1465303003 .
 2015-11-23 14:27:03 -08:00
Konstantin Shcheglov a689bf4180 Report error for ignored priority file. Ignore subscription for ignored files. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1462693002 .
 2015-11-18 17:31:58 -08:00
Konstantin Shcheglov abe8d87e0e Implement AnalysisServer.getContainingContext() using ContextManager. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1455163005 .
 2015-11-18 14:10:35 -08:00
Konstantin Shcheglov 03eed1c3c9 Fix for duplicate priority sources. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1408163008 .
 2015-10-29 17:46:00 -07:00
Konstantin Shcheglov 7b75a53fef Fix for regions reported with multiple targets. 
We should merge them into single NavigationRegion(s) with multiple targets.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1403373018 .
 2015-10-28 16:38:12 -07:00
pq 2f9c4af993 Error Suppression FTW. 
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1420363005 .
 2015-10-28 09:59:05 -07:00
pq 52fb3b3bab Introducing a lint server plugin. 
Avoids introducing an unwanted dependency on the options plugin to server (efects discovered: https://codereview.chromium.org/1411313005/). Also soon to be future home for fixes and completions.

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1410553005 .
 2015-10-26 12:11:38 -07:00
Konstantin Shcheglov 289bd0a056 [Atom] Issue 424. Fix for 'getNavigation' and index expressions. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-atom/dartlang/issues/424

Review URL: https://codereview.chromium.org/1402353009 .
 2015-10-25 11:29:54 -07:00
pq afa746230f Lint option change propagation test. 
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1417963004 .
 2015-10-21 15:22:13 -07:00
pq 6c85fe785a Analysis Options error notifications. 
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1411013003 .
 2015-10-21 09:59:19 -07:00
Konstantin Shcheglov 18a29ba8a8 Tweak for make test passing with useTaskModel = true. 
A real fix after final actual switching.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1410493005 .
 2015-10-16 08:29:35 -07:00
pq 91e5facc0f Registry memory leak fixes. 
Fixes #24549.

A few notes:
  * does away with registry in favor of context-associated configurations
  * pulls in linter rev that does the context association
  * bumps analyzer version before publishing (needed to update analyzer_cli)

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1406043002 .
 2015-10-15 14:24:20 -07:00
Konstantin Shcheglov a30bcd7b97 Issue 24599. Fix for requesting navigation for directives. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24599

Review URL: https://codereview.chromium.org/1405033002 .
 2015-10-15 10:54:06 -07:00
pq cae05d6bd4 Context invalidation on option changes (Implements #24574). 
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1399893004 .
 2015-10-14 20:42:50 -07:00
Brian Wilkerson 9ad256cf18 Move the wire protocol support into the public API 
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1398293002 .
 2015-10-11 07:34:28 -07:00
pq 695256d586 Linter hookup into AS. 
Note the TODO to fix the extension manager interaction hijinx.  Really we should ensure that we are only using the one in engine.  At the moment, it's easy to get this wrong (as the initialization heroics herein testify).

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1392683003 .
 2015-10-09 13:40:07 -07:00
pq 90e975b656 Suppress scanner errors for non-existent URIs. 
Fixes #23754.

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1378503003 .
 2015-10-06 10:25:50 -07:00
Konstantin Shcheglov 0e7f4b5717 Fix hover documentation for parameters. 
R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/1384583007 .
 2015-10-05 07:04:20 -07:00
Brian Wilkerson 66a122a9db Stop defensively copying AST structures before resolution 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1383043002 .
 2015-10-02 12:38:18 -07:00
Konstantin Shcheglov 62fd9ac787 Issue 24487. Annotations with constructor resolution should produce navigation reginos to constructors. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24487

Review URL: https://codereview.chromium.org/1378713004 .
 2015-10-02 10:44:58 -07:00
Konstantin Shcheglov 03e379de7a Compute Outline.kind/libraryName actually. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24279

Review URL: https://codereview.chromium.org/1380103005 .
 2015-10-01 13:09:38 -07:00
Florian Schneider c4d0ff8a4c pkg: Eliminate flaky analysis test failure. 
Running in debug mode (or any slower configuration) makes this test fail since
it waits for a max of 100 event loop iterations for the analysis results.

Instead wait without limit until results are ready, with checking every few milliseconds.

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1379153002 .
 2015-10-01 19:34:50 +02:00
Konstantin Shcheglov 1d28f99524 Fix for 'implemented' notification after an incremental change. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//1374943005 .
 2015-09-30 11:08:41 -07:00
Konstantin Shcheglov 83f94a2114 Add navigation region for 'library' directives. 
Dart Editor uses presence of a navigation region as a sign that there is something that can be renamed, and enables the Rename action.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1373593002 .
 2015-09-25 12:35:51 -07:00
Konstantin Shcheglov df827a06ae The 'analysis.implemented' notification implementation. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1368793003 .
 2015-09-25 12:33:02 -07:00
Konstantin Shcheglov 5fd8b38737 Tweak navigation for 'part of' directives. 
This makes it consistent with import/export/part directives, where only URIs are navigation sources.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1365663002 .
 2015-09-23 10:14:49 -07:00
Konstantin Shcheglov 4aa6466ccb Use IndexContributor(s) in LocalIndex. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1359113002 .
 2015-09-23 08:17:33 -07:00
Konstantin Shcheglov 75600fc162 Report UNRESOLVED_INSTANCE_MEMBER_REFERENCE for dynamicVar.member references. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1345943006 .
 2015-09-17 10:37:04 -07:00
Konstantin Shcheglov a01281370b Fix for dynamic instance field reference highlighting. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1349223002 .
 2015-09-17 09:25:22 -07:00
Konstantin Shcheglov d71bda7c05 Highlight library identifiers as LIBRARY_NAME. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1352843002 .
 2015-09-17 09:24:14 -07:00
Konstantin Shcheglov e090ff872e Issue 24277. Use node's offset as the source range start for the first unit node in Outline. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24277

Review URL: https://codereview.chromium.org//1325143003 .
 2015-09-02 17:55:15 -07:00
Konstantin Shcheglov 7e99b8696e Support for analysis.setPriorityFiles for files in SDK. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-atom/dartlang/issues/215

Review URL: https://codereview.chromium.org//1289643003 .
 2015-08-17 10:48:38 -07:00
Konstantin Shcheglov 7ab954efb5 Remove debug output in getNavigation(). 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1288163003 .
 2015-08-12 14:02:07 -07:00
Konstantin Shcheglov e9d2f739ad More tweaks in attempt to debug the reason of failing getNavigation() tests. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1284933002 .
 2015-08-11 11:13:48 -07:00
Konstantin Shcheglov 089f84f6cd Keep only unique overridden elements. 
If the implemented interfaces don't declare an element, keep only a single copy of the element - from the superclass.

In Dart Editor we use any element, but in in IDEA we show all of them, and we don't want to have duplicates.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1273003005 .
 2015-08-10 16:13:43 -07:00