86106d7a6d
Issue 25623. When adding the 'async' modifier, change the return type.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25623
Review URL: https://codereview.chromium.org/1652963003 .
2016-02-01 10:35:47 -08:00
3f7a21bc0e
Issue 25622. Quick fix for 'async-for'.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25622
Review URL: https://codereview.chromium.org/1650853002 .
2016-02-01 08:03:55 -08:00
9b1fa223a8
Embedded libs key rename to defuse server landmine.
...
1.13 stable builds of the SDK contain a version of server that fails catastrophically when analyzing source that imports packages that define embedded libraries. Since we can't pragmatically require more recent SDKs for flutter development we have been prevented from landing embedded libs in the flutter engine. By renaming the key we use to identify contributed libraries, this change avoids the issue. Old versions of server will simply ignore the new key and new ones will process it properly. Win-win!
BUG=
R=danrubel@google.com
Review URL: https://codereview.chromium.org/1643023002 .
2016-01-29 09:52:04 -08:00
e7e52ae2c0
Issue 25542. If an element does not have its own documentation, use the documentation from the overridden superclass member or an implemented interface.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25542
Review URL: https://codereview.chromium.org/1632033002 .
2016-01-25 17:09:48 -08:00
205a2a9c28
Don't add sources to DartSdk contexts.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1625273003 .
2016-01-24 15:49:18 -08:00
fe7a48d6c7
Isse 25404. When remove a method during inlining, remove also leading empty lines.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25404
Review URL: https://codereview.chromium.org/1628623002 .
2016-01-22 19:40:38 -08:00
5237561075
Issue 25404. 'Inline Method' should update implicit 'this' and class references.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25404
Review URL: https://codereview.chromium.org/1629533003 .
2016-01-22 17:21:57 -08:00
9f451cb0dc
Issue 25538. Fix for type hierarchy and private class members.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25538
Review URL: https://codereview.chromium.org/1615093002 .
2016-01-21 10:56:05 -08:00
cba8d0d7c3
Issue 25538. Fix for 'analysis.implemented' notification and private members.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25538
Review URL: https://codereview.chromium.org/1615023002 .
2016-01-21 09:49:18 -08:00
5dc34340a1
Issue 25538. Fix for notification and private methods.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25538
Review URL: https://codereview.chromium.org/1610773003 .
2016-01-21 08:01:51 -08:00
b37e3b7ec1
(TBR) fix embedder tests on Windows
...
Review URL: https://codereview.chromium.org/1609003003 .
2016-01-19 16:24:01 -05:00
53b2815ad8
Ignore 'expr is' outside of a statement.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1609883002 .
2016-01-19 13:20:38 -08:00
2ae3026c43
add enableAsync to analysis option file flags
...
integrate enableAsync into analysis server
include enableAsync on context status page
update api spec to indicate that enableAsync is no longer deprecated
relys on landing https://codereview.chromium.org/1570183002/
fixes #25373
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1574523002 .
2016-01-08 20:48:07 -05:00
e1c6faceb5
Issue 25316. Quick Fix for removing 'final' keyword.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25316
Review URL: https://codereview.chromium.org/1545323002 .
2015-12-27 13:19:41 -08:00
78ae012d2d
Issue 25313. Skip constructor names and named expressions.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25313
Review URL: https://codereview.chromium.org/1547113002 .
2015-12-27 12:05:05 -08:00
e13a49fdfa
(TBR) "fix" test_no_duplicate_notifications
...
Review URL: https://codereview.chromium.org/1542433002 .
2015-12-19 11:41:32 -05:00
e5bbeddf4d
completion performance measurement for local status page
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1536083002 .
2015-12-19 11:12:45 -05:00
43ee7b5bc9
move OpType into dart folder
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1523243006 .
2015-12-19 11:11:04 -05:00
99c3be6331
remove old completion API
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1536073002 .
2015-12-19 11:09:48 -05:00
39d5abb662
remove internal streaming of results, remove obsolete test, cleanup unused code
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1538883003 .
2015-12-18 10:52:21 -05:00
1adabf4abc
remove extraneous classes and cleanup code
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1535643004 .
2015-12-18 08:53:39 -05:00
1f8eddcc21
Cache element docs (and add to completions) [ #23694 ].
...
This does away with the expensive call to `computeDocumentationComment` in favor of cached comments. Notably this makes adding doc content to code completion proposals performant (and so is done here). It should also make `dartdoc` *much* faster for doc generation since there are no more trips to disk to fetch comments for elements (still needed for source though).
For more on the desire for docs in completions see here: https://github.com/dart-lang/sdk/issues/23694
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1534043002 .
2015-12-17 21:07:42 -08:00
fbaba56375
move DartCompletionSorter to dart specific contributor
...
consolidate common test code
remove duplicate test
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1539693002 .
2015-12-17 17:54:29 -05:00
4ee5173f42
move ReplacementRange into dart specific contributor
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1531383002 .
2015-12-17 16:24:49 -05:00
baf03ebdfe
merge completion suggestions based upon relevance
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1536823002 .
2015-12-17 16:22:40 -05:00
a3f816e75b
- Fix usage of Platform.packageRoot.
...
BUG=
Review URL: https://codereview.chromium.org/1533693003 .
2015-12-17 13:08:19 -08:00
b3fa2629bf
remove CompletionCache and obsolete tests, and cleanup imports
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1533973002 .
2015-12-17 16:00:34 -05:00
661cd4e9b9
report invalid param if offset is out of bounds
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1531353002 .
2015-12-17 14:58:14 -05:00
5e128e2544
suggest IDENTIFIER not INVOCATION for dartdoc refs
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1530393004 .
2015-12-17 11:00:15 -05:00
6d5efd3175
remove unused DartCompletionCache
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1536683003 .
2015-12-17 10:58:49 -05:00
0c6fb170dc
Do not suggest loop variable when completing expression in ForEachStatement
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1534793002 .
2015-12-17 10:57:51 -05:00
0de484bb8b
convert ImportedReferenceContributor to new API
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1526303003 .
2015-12-16 21:17:27 -05:00
3bf298760f
extract InheritedReferenceContributor from imported reference contributor
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1533613004 .
2015-12-16 16:20:53 -05:00
f13460e235
rename InheritedContributor to OverrideContributor
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1523163004 .
2015-12-16 12:15:34 -05:00
70cd905c4d
Issue 25253. Improve collecting names that may conflict with the extracted local variable.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25253
Review URL: https://codereview.chromium.org/1528013004 .
2015-12-15 12:26:11 -08:00
62f8832770
cleanup LocalLibraryContributor
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1527613008 .
2015-12-15 13:03:41 -05:00
f71ae984a9
Issue 25252. Stop collecting covering expressions at void invocations.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25252
Review URL: https://codereview.chromium.org/1528023002 .
2015-12-15 09:55:48 -08:00
56fe38f0ab
Clean up imports in analysis_server and analyzer_cli (and one missed in analyzer)
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1527793003 .
2015-12-14 19:31:46 -08:00
6464160147
move LocalDeclarationVisitor
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1529653003 .
2015-12-14 20:36:57 -05:00
5ff1ebe935
extract LocalLibraryContributor from imported reference contributor
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1525753003 .
2015-12-14 20:31:50 -05:00
8a99902b94
suppress all dart contributor suggestions in comments
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1522003003 .
2015-12-14 18:50:18 -05:00
b44ed3e91e
Issue 25251. Fix for extracting string literal part with zero length.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25251
Review URL: https://codereview.chromium.org/1522193002 .
2015-12-14 12:56:59 -08:00
5c3fcf81c0
fix CombinatorContributor to only suggest public members
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1525713002 .
2015-12-14 14:21:01 -05:00
d8494d2f50
move LocalReferenceContributor to new API
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1528633002 .
2015-12-14 13:57:51 -05:00
6824bd9b32
Fix for enum signatures.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1529593002 .
2015-12-14 10:53:08 -08:00
38a4193b5f
Issue 25244. Disable invalid overrides.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25244
Review URL: https://codereview.chromium.org/1519413002 .
2015-12-13 15:50:12 -08:00
2f0f398c73
Fix lints: unnecessary_brace_in_string_interp
...
Also fixes two cases of empty_constructor_bodies.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1521883002 .
2015-12-13 13:05:00 -08:00
86472f32ce
Move public API for elements into a public location
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1519283003 .
2015-12-13 10:48:56 -08:00
aca32e681a
Updates to the stress test
...
R=skybrian@google.com
Review URL: https://codereview.chromium.org/1514693013 .
2015-12-12 07:28:45 -08:00
7db8d0267d
extract LocalConstructorContributor from local reference contributor
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1521753002 .
2015-12-12 10:01:22 -05:00
Konstantin Shcheglov