8db9995c65
Fix an exception when a package is not defined
...
Change-Id: Id2469b4e0c4aaa8acb63c0186e7b53ec4acea95d
Reviewed-on: https://dart-review.googlesource.com/5885
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2017-09-14 19:42:50 +00:00
2b3b0272c4
Switch to using specific throws calls instead of general throwsA() calls.
...
Bug:
Change-Id: Id604dca1b8c3060c1d12c9ed0b1493771d2eb0d6
Reviewed-on: https://dart-review.googlesource.com/5883
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Kevin Moore <kevmoo@google.com >
2017-09-14 18:04:44 +00:00
b12d010064
Remove the use of deprecated package:test API.
...
Bug:
Change-Id: I671678117f72efac5efd60d7b4e459dffcce47c6
Reviewed-on: https://dart-review.googlesource.com/5542
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2017-09-13 21:55:00 +00:00
f7eba2359b
Create new style GenericFunctionTypeElementImpl for function typed parameters.
...
ParameterElement.parameters/typeParameters always return empty lists.
This was initially landed as https://dart-review.googlesource.com/c/sdk/+/3401 ,
but was rolled back because of dartdoc breakage.
R=brianwilkerson@google.com
Bug:
Change-Id: I328355fa4520536dfd0029966ad9f9af2e63a7d2
Reviewed-on: https://dart-review.googlesource.com/5000
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-09-11 19:15:11 +00:00
1b4239d2e4
Export ByteStore and its implementations from front_end.
...
R=ahe@google.com , paulberry@google.com , sigmund@google.com
Bug:
Change-Id: Ie2e3413a7f143e270cec2bd3ae4564ad7cc315b1
Reviewed-on: https://dart-review.googlesource.com/3840
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2017-09-07 19:23:21 +00:00
cb9e334572
Type return Future for AnalysisServer integration tests send().
...
R=brianwilkerson@google.com
Bug:
Change-Id: Idced4d4a43723abe10a848856b9a83fa27b58531
Reviewed-on: https://dart-review.googlesource.com/3347
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-09-06 16:07:49 +00:00
76a3b431bb
Revert "Create new style GenericFunctionTypeElementImpl for function typed parameters."
...
This CL broke the SDK API-doc generation.
See https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fclient.dart%2Fdart-sdk-linux-be%2F15242%2F%2B%2Frecipes%2Fsteps%2Fgenerate_API_docs%2F0%2Fstdout
Change-Id: I2b4acd766fb65e82a29b73412833e04112ba9dc4
Reviewed-on: https://dart-review.googlesource.com/3460
Reviewed-by: Jonas Termansen <sortie@google.com >
2017-09-06 10:43:11 +00:00
a3f8740bbd
Create new style GenericFunctionTypeElementImpl for function typed parameters.
...
ParameterElement.parameters/typeParameters always return empty lists.
R=brianwilkerson@google.com
Bug:
Change-Id: I5200df9e891031437d6e597f30fa54399b7d00e1
Reviewed-on: https://dart-review.googlesource.com/3401
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-09-06 02:31:11 +00:00
455984bbf9
Fix fuzzy arrow warnings in analyzer and analysis_server.
...
There is one warning which I'd like to fix in a separate CL.
The rest is because of package:test predicate().
I think Leaf fixed it in https://github.com/dart-lang/matcher/commit/3625f13698346576da0f5baf44e95abc9c56fb49
R=brianwilkerson@google.com
Bug:
Change-Id: I060f7ced55dbcc460185916251c47ebbd5c838d3
Reviewed-on: https://dart-review.googlesource.com/3404
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-09-06 00:26:18 +00:00
28381b8f06
Add completion of keywords in partial field declarations
...
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/3006033002 .
2017-09-03 13:04:06 -07:00
0db33f7053
Add fixes for more lints
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3009063002 .
2017-09-02 15:11:29 -07:00
aab7af12e9
Add fixes for two more lint rules
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3004293002 .
2017-09-02 15:10:56 -07:00
8f1b6d0aab
Dart Kythe indexer refactoring to gather all variable declaration logic into one method
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/3004273002 .
2017-09-01 12:12:37 -07:00
59516d9794
Added an analysis server argument to set the location of the session cache. ( #30583 )
2017-08-31 10:25:50 -07:00
170c562ffe
Add fixes for two additional lints
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3007783002 .
2017-08-29 10:18:17 -07:00
96ee1d846d
Add variable declaration support to the DeclaredIdentifier AST node in the Kythe Dart indexer.
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/3004763002 .
2017-08-28 10:25:26 -07:00
37042bb59b
Add an integration test for kythe support with bug fixes
...
R=jwren@google.com
Review-Url: https://codereview.chromium.org/3006693002 .
2017-08-28 10:07:04 -07:00
f78d43c3d3
Convert GeneratedContent to async and use AnalysisDriver for tasks graph.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/3002293003 .
2017-08-26 07:51:34 -07:00
bf259dce6b
Remove unused imports missed in earlier CL
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3010443002 .
2017-08-25 09:22:13 -07:00
c38c97def3
Reduce duplicated code
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3002303002 .
2017-08-25 08:18:39 -07:00
23bcc17a61
Use the NavigationCollector from analyzer_plugin to avoid duplication
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3002253002 .
2017-08-25 07:25:16 -07:00
13346cab3d
Put the analytics UI behind a flag.
...
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/3003783002 .
2017-08-24 11:17:37 -07:00
e8b617217f
Remove most of the remaining references to AnalysisContext
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3007493002 .
2017-08-23 12:57:09 -07:00
84a36f1b77
flag to limit file and package URI completion suggestions
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/3003233002 .
2017-08-23 13:39:32 -04:00
e4d44b2dcd
Remove more references to the old plugin system
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3004523003 .
2017-08-23 09:25:07 -07:00
b999edf5ee
Remove more references to AnalysisContext
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3003173002 .
2017-08-23 07:53:14 -07:00
b941f148a7
Remove uses of the old plugin model from the analysis server
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3001413002 .
2017-08-23 07:42:13 -07:00
4aeedec64e
Remove the auto-discovery of plugins
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3003663002 .
2017-08-22 09:04:23 -07:00
ebe2ce681e
Fix ClassElement.allSupertypes to include interfaces of mixins (issue 29767)
...
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/3000183002 .
2017-08-18 07:30:05 -07:00
4076ef910f
Guard the fix code against file system exceptions
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/2997153002 .
2017-08-17 10:41:22 -07:00
8b96449718
Handle watch events that arrive before plugin start-up
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/3001133002 .
2017-08-17 09:57:22 -07:00
6f96d88e1e
Avoid closing an already closed channel
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/2999153002 .
2017-08-17 09:47:33 -07:00
bd8f5ad79f
Guard against getting a watch event before the driver is created
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/3001023002 .
2017-08-16 14:08:44 -07:00
d87fcfd233
Correctly update positions when adding edits before them (issue 30444)
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/2997073002 .
2017-08-16 10:29:26 -07:00
35f6d5da1b
Correctly handle adding imports when pasting into part files
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/3001733002 .
2017-08-16 07:43:36 -07:00
44b5341de8
Update edit.importElements response data to support part files
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/3001723002 .
2017-08-15 08:51:51 -07:00
eaf779ba1e
Fix insertion of imports when there are no existing directives (issue 30430)
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3002643002 .
2017-08-14 13:32:57 -07:00
70cea428f4
Support experimental annotations for the analysis server spec.
...
BUG=
R=brianwilkerson@google.com , brustkelli77@gmail.com
Review-Url: https://codereview.chromium.org/3002543002 .
2017-08-13 12:37:46 -07:00
31887d6e42
Add a test that requires adding an import
...
Review-Url: https://codereview.chromium.org/2998903002 .
2017-08-13 08:33:50 -07:00
e42abf621e
Update the version of the server API spec for analysis.closingLabels
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/3002513002 .
2017-08-12 14:44:41 -07:00
8c8969db4c
Forward Kythe requests to plugins and merge in the results
...
R=jwren@google.com
Review-Url: https://codereview.chromium.org/3000823002 .
2017-08-12 08:16:34 -07:00
0647d9a228
Improvements to analysis server closing labels ( #30411 )
...
* Tweak comment that was based on integration test verison.
See #30285
* Include additional 1/2-line spans that end on same lines as >2 line spans.
See #30285
* Add tests to ensure no unwanted closing labels from multiline expressions.
See #30285
* Don't show closing labels for code inside interpolated strings.
See #30285
* Remove unwanted @soloTest.
See #30285
* Make casing of test names consistent.
See #30285
* Add a constructor and make fields final.
See #30285
* Use putIfAbsent for adding to map.
See #30285
* Shorten closing labels constructor.
See #30285
* Run "Sort members" on closing labels files.
See #30285
* Remove unnecessary type annotations.
See #30285
2017-08-11 11:04:34 -07:00
a714187898
Tweaks to the analysis server benchmarks.
...
BUG=
R=brianwilkerson@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2998813002 .
2017-08-10 12:35:06 -07:00
ecc72d6be5
Initial implementation of the kythe domain
...
R=jwren@google.com
Review-Url: https://codereview.chromium.org/2999783002 .
2017-08-10 11:49:22 -07:00
c8f8f8e7cc
Ignore two unused element warnings in pkg/analysis_server.
...
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2994113002 .
2017-08-10 11:36:12 -07:00
579a032564
Add kythe support to plugins and format the spec files
...
R=jwren@google.com
Review-Url: https://codereview.chromium.org/2994103002 .
2017-08-10 11:24:40 -07:00
619f2995ab
Implement analysis server closing labels (work-in-progress) ( #30372 )
...
* Add empty closing labels computer/visitor and tests.
See #30285
* Add initial implementation and test for closing labels.
See #30285
* Add various tests for analyzer closing labels.
See #30285
* Fail tests if errors occur.
Without this the notifications will never come through and the test will time out. This causes them to fail right away on errors.
See #30285
* Add test and fix for crash that occurred during testing.
See #30285
* Remove unnecessary abs().
See #30285
* Remove question that has been answered (yes).
See #30285
* Remove unnecessary .argumentList on spansManyLines check.
See #30285
* Add test for prefixed import and constructor names.
The behaviour seems like what we want, though need to confirm if this is the best way to do it.
See #30285
* Add additional prefixed tests and another TODO.
See #30285
* Fix method invocations to show full target/name.
See #30285
* Fix constructor invocations to not use toString().
See #30285
* Convert most closing label tests to unit tests.
See #30285
2017-08-09 14:13:47 -07:00
305e84f70a
Fix the buildbots by adding a line for kythe.getKytheEntries to the coverage.md file
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2993353002 .
2017-08-09 13:40:09 -07:00
8a426f3d67
Initial experimental Kythe Dart Analysis Server protocol
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2995683002 .
2017-08-09 12:44:59 -07:00
973d0e1bd1
Add analysis server notifications to the api coverage doc.
...
BUG=
R=brianwilkerson@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/3000563002 .
2017-08-09 10:28:35 -07:00
Brian Wilkerson