Commit Graph

436 Commits

Author SHA1 Message Date
Sigmund Cherem 8d41ec30c0 Remove obsolete comment in status files.
I added these when we were maintaining the .status files with a script at the
time strong-mode was being implemented in the CFE. The comments are no longer
relevant.

TBR=paulberry@google.com

Change-Id: I3d37da32cd611731e3e0d91a5aa751fa550cc179
Reviewed-on: https://dart-review.googlesource.com/c/85408
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-11-27 01:25:51 +00:00
Ben Konyi 39297646bf [ Corelib / Tests ] Removed tests for Maps helper class, which no longer exists
Change-Id: I2adff8cc7f49bcb9710dca2b692fb40761fae175
Reviewed-on: https://dart-review.googlesource.com/c/84082
Commit-Queue: Ben Konyi <bkonyi@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
Auto-Submit: Ben Konyi <bkonyi@google.com>
2018-11-09 23:33:58 +00:00
Samir Jindel e190719e04 [vm] Fix typo in status file update.
Change-Id: I59acedc511194a2f7c8b49ccb25024aa9795cf6e
Reviewed-on: https://dart-review.googlesource.com/c/83000
Reviewed-by: Samir Jindel <sjindel@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
2018-11-06 15:03:29 +00:00
Samir Jindel c05ed92e4d [vm] Update status file for corelib_2/nsm_invocation_test under obfuscation.
Change-Id: I5ff47425f3113a11f3e6d6476c0c3fec21a96027
Reviewed-on: https://dart-review.googlesource.com/c/82991
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Kinan Alsarmini <sarkin@google.com>
2018-11-06 12:12:35 +00:00
Martin Kustermann 6d9dc93d0e [VM] Follow-up status file update after landing changes to kernel2kernel constant evaluator
Change-Id: Ia99a27ce81eed0a6f74b669217c5d998f157ace4
Reviewed-on: https://dart-review.googlesource.com/c/82584
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
2018-11-02 11:14:15 +00:00
Martin Kustermann 8953788993 [VM] Convert const Symbol("..") to SymbolConstants in kernel2kernel transformation
Issue https://github.com/dart-lang/sdk/issues/34911

Change-Id: Ib504d57b5a529a04f511f737af4cec0ff0590250
Reviewed-on: https://dart-review.googlesource.com/c/82069
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2018-11-02 09:28:15 +00:00
Samir Jindel e23acaaf90 [vm/aot] Fix obfuscation.
Test Plan:

Make vm-kernel-precomp-obfuscate-linux-release-x64-try green, ensuring status file changes
reflect design gaps and not bugs.

Tested locally that obfuscated Flutter Gallery runs.

Change-Id: Ifcdc334de58f43c310e15b58dbcf6fe1597206f2
Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-obfuscate-linux-release-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/81009
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2018-10-26 13:00:33 +00:00
Daco Harkes a867487dc1 [gardening] bigint__test make multi test and skip slow subtests on dartkb
Change-Id: I0684d4ab5e6c477a0f956c6dc5c290509d53a430
Reviewed-on: https://dart-review.googlesource.com/c/81366
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
2018-10-25 10:12:12 +00:00
Daco Harkes c2276738e6 [gardening] bigint_parse_radix_test may time out when interpreted
Change-Id: Icd7f46b5c2c4f3a40c2727dc530da9c02c5a5a59
Reviewed-on: https://dart-review.googlesource.com/c/81365
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
2018-10-25 08:58:38 +00:00
Régis Crelier cdf6dde807 [gardening] bigint_test may still time out when interpreted (2nd try).
Change-Id: Ie3a7204811503d82be89d9f9555d867ef087c22f
Reviewed-on: https://dart-review.googlesource.com/c/81383
Reviewed-by: Régis Crelier <regis@google.com>
2018-10-25 04:49:04 +00:00
Régis Crelier 9e9746a83c [gardening] bigint_test may still time out when interpreted.
Change-Id: I9e8f45fb20b5148c658e98877446ca5d36de9f56
Reviewed-on: https://dart-review.googlesource.com/c/81380
Reviewed-by: Régis Crelier <regis@google.com>
2018-10-25 01:46:28 +00:00
Régis Crelier 7de2510339 [VM interpreter] Do not interpret some Bigint intrinsics (fixes #34901).
Update status file.

Change-Id: I43b222562488c90c9438fd792dc2505b14d5d373
Reviewed-on: https://dart-review.googlesource.com/c/81334
Commit-Queue: Régis Crelier <regis@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
2018-10-25 00:44:25 +00:00
Nate Bosch 03eafc0b2e Add fromEntries on HashMap and LinkedHashMap
Closes #34818

Change-Id: I77b117c16169a5c5bd5655e851256930a2ea5a28
Reviewed-on: https://dart-review.googlesource.com/c/81188
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2018-10-23 20:53:34 +00:00
Alexander Markov 4e49d19bd6 [gardening] Update status for #34901
Issue: https://github.com/dart-lang/sdk/issues/34901
Change-Id: Iaa0d082a0d4e0ddd034f51f49fc9b722a0ca3fd4
Reviewed-on: https://dart-review.googlesource.com/c/81281
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
2018-10-23 18:09:02 +00:00
Martin Kustermann 349adc5b1f Reland "[VM] Use c++/kernel2kernel constant evaluator for const StaticInvocation in the kernel IR"
Fixes https://github.com/dart-lang/sdk/issues/34770

Change-Id: I55b02e6ce327f4a08d96612fea44f7b03bddcbb5
Reviewed-on: https://dart-review.googlesource.com/c/79680
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2018-10-16 11:22:56 +00:00
Siva Annamalai aabc26bafe Revert "[VM] Use c++/kernel2kernel constant evaluator for const StaticInvocation in the kernel IR"
This reverts commit 29ff9e4a6a.

Reason for revert: We seem to be seeing a number of dartkp failures after this commit.

Original change's description:
> [VM] Use c++/kernel2kernel constant evaluator for const StaticInvocation in the kernel IR
> 
> Fixes https://github.com/dart-lang/sdk/issues/34770
> 
> Change-Id: Ie0a3ea82992d70bfce04dcd8986b62f3e1dd5962
> Reviewed-on: https://dart-review.googlesource.com/c/79581
> Commit-Queue: Martin Kustermann <kustermann@google.com>
> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>

TBR=vegorov@google.com,kustermann@google.com

Change-Id: Ib3f67e869e6bfa87161f7c580b0142d676e5a631
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/79467
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
2018-10-12 19:34:27 +00:00
Martin Kustermann 29ff9e4a6a [VM] Use c++/kernel2kernel constant evaluator for const StaticInvocation in the kernel IR
Fixes https://github.com/dart-lang/sdk/issues/34770

Change-Id: Ie0a3ea82992d70bfce04dcd8986b62f3e1dd5962
Reviewed-on: https://dart-review.googlesource.com/c/79581
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2018-10-12 16:08:46 +00:00
Alexander Markov 4486bf5f6b [vm/bytecode] Fix return value for several BigInt intrinsics
If these intrinsics are called from interpreter and return garbage,
the interpreter might crash in Interpreter::InvokeCompiled while
inspecting the result.

Also, this CL contains a fix for the slow path of Int64 box
allocation in the interpreter.

Change-Id: I27143d38ed39fdc234520c57e85bff066cc8cde3
Reviewed-on: https://dart-review.googlesource.com/c/78187
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
2018-10-08 21:38:48 +00:00
Alexander Thomas 0e7ca953a9 [gardening] Skip timing out bigint tests on slow configurations (#31659)
Change-Id: Icae0660dead53848f46ed19bdf1a4f465bec944e
Reviewed-on: https://dart-review.googlesource.com/c/78520
Reviewed-by: William Hesse <whesse@google.com>
2018-10-08 13:19:32 +00:00
Lasse R.H. Nielsen 429bca8e65 Make Uri.parse accept [ and ] in path, query and fragment.
Also accept `#` in fragment.
Fix bug in parsing URI where first character of path needs escaping.
The characters are escaped, but parsing doesn't fail, like it previously
did on misplaced general delimiters in those places

Fixes #34451.

Bug: https://dartbug.com/34451
Change-Id: I99aa39bd2909661802ad9d1bb5dada94d579141b
Reviewed-on: https://dart-review.googlesource.com/74780
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-09-26 14:09:37 +00:00
asiva 355c73d4ee [VM] Remove support for option --no-preview-dart-2
- option --no-preview-dart-2 will now result in an error
- change aot-assembly build rule to generate AOT snapshot using Dart 2
- generate coresnapshot using Dart 2 (this snapshot is not used yet, next CL which switch the isolate create code to use this snapshot)
- by pass all Dart1 test runs in the status file
- change the default compiler setting in test.py to use dartk
- have test.py not pick up any configuration for --no-preview-dart-2

Change-Id: Ia136943ebfd0fed0c52683b330745b3e2c7a7ce6
Reviewed-on: https://dart-review.googlesource.com/75820
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
2018-09-24 20:38:08 +00:00
Alexander Markov 62d154f6a3 [vm/bytecode] Record null-initialized fields in bytecode
If a field is initialized with null (either explicitly or implicitly),
field store can be omitted in bytecode. In such case, bytecode should
still convey the information about this initialization to VM for
field guards to work correctly.

Change-Id: I1fd45b858c3c521b97fa5dbffe0e15b1ea75d92f
Reviewed-on: https://dart-review.googlesource.com/76060
Reviewed-by: Zach Anderson <zra@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
2018-09-24 17:56:35 +00:00
Alexander Markov 654c4babc8 [vm/bytecode] Fix a couple of assertions when running with bytecode
Also, add more tests to dartkb bots.

Change-Id: I6fbcbe73d6b9065ec03e64bf150b4ebd742e4d28
Reviewed-on: https://dart-review.googlesource.com/75981
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
2018-09-21 22:54:39 +00:00
Régis Crelier 0c60a52bb2 [VM bytecode] Triage failures in interpreted mode.
Change-Id: I7c896386ef38b5ea5aceab5b6090363a34e960e6
Reviewed-on: https://dart-review.googlesource.com/75794
Commit-Queue: Régis Crelier <regis@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
2018-09-21 02:37:44 +00:00
Lasse R.H. Nielsen cc08d0e1da Add operators &, | and ^ to bool.
Change-Id: Idd6472f239445914c1ff1ab68fc7b38fa6b320ae
Reviewed-on: https://dart-review.googlesource.com/25240
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
2018-09-17 12:33:12 +00:00
William Hesse b9de95da29 Mark bigint_parse_radix_test as flaky crash on reload
Bug: https://github.com/dart-lang/sdk/issues/34361
Change-Id: Id77c3f4ca4a70317ee74ed937f6a12c731206415
Reviewed-on: https://dart-review.googlesource.com/72801
Reviewed-by: Jonas Termansen <sortie@google.com>
2018-09-04 11:22:46 +00:00
Aske Simon Christensen ac77419209 Status file cleanup for dart2js.
Removed all sections labeled $compiler == dart2js and !$fasta.

Removed $fasta from all sections with $compiler == dart2js and merged
with existing sections as appropriate.

Some additional cleanup and normalization.

Change-Id: I8b93283a2cce22ce60e29d364c8d0e70dccbb6e3
Reviewed-on: https://dart-review.googlesource.com/71840
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2018-08-30 10:28:41 +00:00
Devon Carew 87bbceb3f1 More cleanup of analyzer status file predicates.
Change-Id: I047be4db04227d406ade3f206478d382e810cdd4
Reviewed-on: https://dart-review.googlesource.com/72063
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-08-29 22:48:29 +00:00
Alexander Markov cc62869910 [Status files] Update status for passing corelib_2 tests in bytecode mode
Change-Id: Id4929c771ab07054d05288de95eade1a15931454
Reviewed-on: https://dart-review.googlesource.com/71888
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
2018-08-29 00:18:15 +00:00
Janice Collins f40ff153a9 Enable --use-fasta-parser with the analyzer by default.
Based on Devon's change at:

https://dart-review.googlesource.com/c/sdk/+/67090

Change-Id: I80b7943826e248bf37d9bbbb769330d24b0dd6ae
Reviewed-on: https://dart-review.googlesource.com/70160
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
2018-08-28 19:29:17 +00:00
Lasse Reichstein Holst Nielsen edd6b75a05 Add missing method to UnmodifiableMapMixin.
Fixes 34256
BUG= http://dartbug.com/34256

Change-Id: I780368176b0111130bee1b5aae1f5228eabfa16f
Reviewed-on: https://dart-review.googlesource.com/71460
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
2018-08-28 05:11:12 +00:00
William Hesse 14f6fbb457 Fix test_matrix.json for dartkp product mode builder.
Mark a test slow that otherwise times out on dartdevc kernel mode.

Change-Id: Id27683c54982f9a6afd1e41f566dd12aa67040de
Reviewed-on: https://dart-review.googlesource.com/69962
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
2018-08-14 17:18:02 +00:00
William Hesse 46743f3868 Remove $runtime == drt sections and uses of drt from status files.
Change-Id: Iffd934a67668901176a84c9b01512711a011652d
Reviewed-on: https://dart-review.googlesource.com/67803
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
2018-08-03 12:40:46 +00:00
William Hesse 21db860271 Remove non-strong dart2js builders from test_matrix.json
Change-Id: I76c4a1f0df8f6e8f6ddd03fd35c9a069845687ef
Reviewed-on: https://dart-review.googlesource.com/67346
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-07-30 17:47:44 +00:00
Lasse R.H. Nielsen f2402b3c08 Remove deprecated SDK constant declarations.
Change-Id: I0e4208b6fa957765403608103128c28562280657
Reviewed-on: https://dart-review.googlesource.com/51841
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2018-07-18 13:05:00 +00:00
Zach Anderson d0510501d2 [build] Add -a kbc for interpreter
This CL adds support to build.py and test.py for building/testing
a VM with the interpreter on x64, e.g.:

$ ./tools/gn.py -m release -a x64 --bytecode
$ ./tools/build.py -m release -a x64 --bytecode runtime
$ ./tools/test.py -m release -a x64 -r vm -c dartkb language_2

Change-Id: I956d23790636609d4a2e71129481fcbd7afef9a0
Reviewed-on: https://dart-review.googlesource.com/65206
Commit-Queue: Zach Anderson <zra@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
2018-07-17 21:51:41 +00:00
Jenny Messerly f601b9cd45 fix #33287, error in dartdevc if an int cannot be represented in JS
Also fixes #32585, Analyzer's int64 validation was rejecting integers
that are accepted by CFE/VM/int.parse.

Refactors DDC to allow us to emit errors from the CodeGenerator
(previously unsupported).

Change-Id: Ifd24ab90848cc42b226961e375167c557299c0b7
Reviewed-on: https://dart-review.googlesource.com/63023
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
2018-07-12 00:47:01 +00:00
Lasse Reichstein Holst Nielsen e26d3d5f9f Reenable the Iterable.whereType method.
Fixes #32463.

Bug: http://dartbug.com/32463
Change-Id: Ie58ff1acbc0a834956741c7ec0ab8d890793baf9
Reviewed-on: https://dart-review.googlesource.com/63940
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-07-10 18:05:15 +00:00
Sigmund Cherem 4ff4620f68 Adjust status lines for safari (take 2)
Change-Id: I231d449097dc01824e2f05443ce2a63d86b946b4
Reviewed-on: https://dart-review.googlesource.com/64100
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-07-09 21:11:55 +00:00
Devon Carew 6dfc4ef663 Remove old dart2analyzer not strong status file entries.
Change-Id: I8e7775ce9a3d6fd14ee9d1b9d79be2f6df23cd01
Reviewed-on: https://dart-review.googlesource.com/63801
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2018-07-07 04:14:20 +00:00
Sigmund Cherem 32d208d8b0 Revert "Adjust status lines for safari"
This reverts commit 5da24bbec2.

Reason for revert: inadvertly updated .status of non-strong configuration (incorrectly assumed that lib_2 suite was not run with the legacy compiler)

Original change's description:
> Adjust status lines for safari
> 
> TBR=athom@google.com,johnniwinther@google.com
> 
> Change-Id: I020de6d0f543fe96d8f93fa3a810b649ce587046
> Reviewed-on: https://dart-review.googlesource.com/63705
> Commit-Queue: Sigmund Cherem <sigmund@google.com>
> Reviewed-by: Sigmund Cherem <sigmund@google.com>

TBR=athom@google.com,johnniwinther@google.com,sigmund@google.com

Change-Id: I4a106337fc8490bd0d60cc535475e360726afdd4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/64000
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-07-07 02:07:28 +00:00
Sigmund Cherem 5da24bbec2 Adjust status lines for safari
TBR=athom@google.com,johnniwinther@google.com

Change-Id: I020de6d0f543fe96d8f93fa3a810b649ce587046
Reviewed-on: https://dart-review.googlesource.com/63705
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-07-07 00:57:29 +00:00
Sigmund Cherem 11123b774a Adjust status lines for firefox
TBR=johnniwinther@google.com,athom@google.com

Change-Id: Idf7d90da1e649e0d73df92f952e2384b4b0ebb58
Reviewed-on: https://dart-review.googlesource.com/63694
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-07-04 00:34:26 +00:00
Sigmund Cherem b7b24e9bbe Update dart2js-strong status across several suites
Change-Id: I7550e3221bcfdb4f9281b2be96af8579848c5a69
Reviewed-on: https://dart-review.googlesource.com/63504
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-07-03 00:27:31 +00:00
Alexander Aprelev e5f3d682b4 [gardening] Add multiplier for arm64 buildbot.
Revert "[gardening] Update arm64 status files."

This reverts commit ff0a1d6b67 as
updating multiplier is better solution than updating status files.

Bug: http://dartbug.com/33659
Change-Id: I064964e1fafe9c77fb24d5e9c324927b75cbacb0
Reviewed-on: https://dart-review.googlesource.com/63340
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
2018-07-02 18:39:33 +00:00
Alexander Aprelev ff0a1d6b67 [gardening] Update arm64 status files.
Bug: http://dartbug.com/33659
Change-Id: Ib3bb01fa127c5a95a27709dbfcf24bec43930619
Reviewed-on: https://dart-review.googlesource.com/63304
Reviewed-by: Aart Bik <ajcbik@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
2018-06-29 22:44:49 +00:00
Jens Johansen 6888bc2824 Compile time error for web int literals that cannot be represented exactly
Bug: #33351
Change-Id: I2b99858dfc276dc70c3a36c289030e801145af86
Reviewed-on: https://dart-review.googlesource.com/61180
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
2018-06-22 10:47:54 +00:00
Johnni Winther 075c713a93 Register type arguments on inlining
Closes #33529

Change-Id: I992552a400199490959d10de8c838e56015159e5
Reviewed-on: https://dart-review.googlesource.com/61522
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
2018-06-22 08:24:13 +00:00
Jens Johansen 276598199e Make DDK interpret IntLiteral.value as uint64
As per bug #33351, and based upon what dart2js does.

Change-Id: I18fec2685b22b094d191f4c70a58553a9132b86c
Reviewed-on: https://dart-review.googlesource.com/60841
Reviewed-by: Kevin Millikin <kmillikin@google.com>
2018-06-20 08:18:19 +00:00
Stephen Adams 75f485d6d9 [dart2js] Fix for issue 33500
Fix check for whether to lower JSArray.add to Array.push.

Change-Id: I22149bf7d31442b8a4bba6b6431239f5f031e55b
Reviewed-on: https://dart-review.googlesource.com/61104
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-06-20 05:07:32 +00:00