dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
60,241 Commits 2 Branches 0 Tags
2dbf91ff13110d0022391f86f5aae58aa63243e2
Commit Graph

18630 Commits

Author SHA1 Message Date
Paul Berry 43cd8ba822 Merge commit '4eeebc46cff4e47e6265e86f4774da103d060aa1' into analyzer 
Conflicts:
	pkg/analyzer/CHANGELOG.md
	pkg/analyzer/pubspec.yaml
 2018-12-03 12:20:40 -08:00
Lasse R.H. Nielsen 7be1d77423 Remove invalid tests from set literal tests. 
See #35300

Bug: http://dartbug.com/35300
Change-Id: I00610ce9eadc51499fc5f35d43095dbf29d07543
Reviewed-on: https://dart-review.googlesource.com/c/85740
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2018-12-03 14:07:12 +00:00
Paul Berry 63770042aa Merge commit '80c23f87a3e3123d7e337c1fc8bc3b5ec49b34a0' into analyzer 2018-11-30 08:12:45 -08:00
Daco Harkes 20e819cbbe [gardening] Mark LibTest/io/FileSystemCreateEvent/isDirectory_A01_t06 flaky 
The test makes assumptions about file system events firing synchronously with file system operations

Issue https://github.com/dart-lang/co19/issues/186

Change-Id: Ic54782662e453c240d92113d25f7a6897b268130
Reviewed-on: https://dart-review.googlesource.com/c/85684
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Auto-Submit: Daco Harkes <dacoharkes@google.com>
 2018-11-30 13:08:17 +00:00
Jens Johansen 17d322b62a Handle AmbiguousBuilder in computeRedirecteeType 
We get an AmbiguousBuilder if there are more than one redirecting
factory with the same name. We shouldn't crash though.

Fixes #35266.

Bug: 35266
Change-Id: I1ac0babdde49c4ca3966e6af5c580191baac0873
Reviewed-on: https://dart-review.googlesource.com/c/85390
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-11-30 12:58:07 +00:00
Jens Johansen 5410bc4098 Fix rare crash in type inference engine 
Before this CL, running fasta compile on these 3 tests would make it
crash in type inference because the enclosingClass on a constrcutor
is null:

tests/language_2/const_error_multiply_initialized_test.dart
tests/language_2/constructor_duplicate_final_test.dart
tests/language_2/field3_test.dart

Note that these tests are all multi-tests and they are here run
unprocessed. The compiler crashes only after issuing errors.
The crash likely happens because of multiple definitions of
constructors with the same name.

This is a cut-down version that crashed prior to this CL:

```
class C {
  final d;

  C() {}
  C(this.d) {}
}
```

Fixes #35258.

Change-Id: I350c55428932ef0ae76f78875177b08acf95cdfc
Reviewed-on: https://dart-review.googlesource.com/c/85363
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2018-11-30 12:57:17 +00:00
Daco Harkes 40dd503b3a [gardening] Mark LibTest/io/RawDatagramSocket/singleWhere_A03_t01 failing 
The test make assumptions about delivery order which UDP does not
provide

Issue https://github.com/dart-lang/co19/issues/195

Change-Id: I1c1ed618a68ea9e7a96e2733ed78095451aa5d89
Reviewed-on: https://dart-review.googlesource.com/c/85700
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Auto-Submit: Daco Harkes <dacoharkes@google.com>
 2018-11-30 10:49:03 +00:00
Jens Johansen ad62f21e5b Fix crash with multiple same-named redirecting constructors 
Without this CL we end up putting a null-reference in the tree because
the parent is never set on the redirecting constructor we try pointing
to.

Fixes #35259, #35260.

Change-Id: I8ad520453742ff1de8dd9ca5e619f9edbff9971c
Reviewed-on: https://dart-review.googlesource.com/c/85384
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-11-30 08:53:10 +00:00
Martin Kustermann 85a6da1213 [Gardening] Attempt to make socket_bind test more robust by ignoring unrelated clients 
Change-Id: Ie9ea8806e27ff3186716daf21b09ae7009bb50cc
Reviewed-on: https://dart-review.googlesource.com/c/85563
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2018-11-30 08:52:13 +00:00
Johnni Winther 0a2ed86935 Infer general flow through && and || 
Closes #34993

Change-Id: Ifb849e4525ba9e5518932b8fba2ae556fb49acb3
Reviewed-on: https://dart-review.googlesource.com/c/85502
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2018-11-30 08:32:11 +00:00
Paul Berry b72ca19f33 Merge commit 'c9aaa7a654b1cac1307c854ba38f4dc995c86f09' into analyzer 2018-11-29 09:43:36 -08:00
Kevin Moore be5d0cca5c Remove sha1 impl from dart2js 
pkg:crypto has a fine implementation
Change-Id: Ibefd6c294259c58cd4eb3ac8f5718a078894a39b
Reviewed-on: https://dart-review.googlesource.com/c/85415
Auto-Submit: Kevin Moore <kevmoo@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2018-11-29 04:28:02 +00:00
Aart Bik ef419f68f9 Revert "[vm/compiler] Express control dependence as data dependence." 
This reverts commit 41f3d4326e.

Reason for revert: I hit +2 by accident when I wanted to submit do a dry run

Original change's description:
> [vm/compiler] Express control dependence as data dependence.
> 
> Rationale:
> This provides a more robust way of expressing control
> dependences between bounds checks and their uses, while
> still allowing for CSE and LICM where possible.
> This also fixes the original bug that started this
> whole redesign: invalid LICM of checkbound.
> 
> Note:
> Deals with bounds check, null check still TBD.
> 
> Mini design doc:
> runtime/docs/compiler/data_dep_for_control_dep.md
> 
> https://github.com/dart-lang/sdk/issues/35139
> https://github.com/dart-lang/sdk/issues/34684
> https://github.com/dart-lang/sdk/issues/30633
> 
> Change-Id: Icfbd3ca60662e37046e48b95be7f81d05d94af88
> Reviewed-on: https://dart-review.googlesource.com/c/85470
> Commit-Queue: Aart Bik <ajcbik@google.com>
> Reviewed-by: Alexander Markov <alexmarkov@google.com>
> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>

TBR=vegorov@google.com,kustermann@google.com,rmacnak@google.com,alexmarkov@google.com,asiva@google.com,ajcbik@google.com

Change-Id: Id20699f957681c248851b37d545b330fd4972d7a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/85522
Reviewed-by: Aart Bik <ajcbik@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
 2018-11-29 03:02:17 +00:00
Aart Bik 41f3d4326e [vm/compiler] Express control dependence as data dependence. 
Rationale:
This provides a more robust way of expressing control
dependences between bounds checks and their uses, while
still allowing for CSE and LICM where possible.
This also fixes the original bug that started this
whole redesign: invalid LICM of checkbound.

Note:
Deals with bounds check, null check still TBD.

Mini design doc:
runtime/docs/compiler/data_dep_for_control_dep.md

https://github.com/dart-lang/sdk/issues/35139
https://github.com/dart-lang/sdk/issues/34684
https://github.com/dart-lang/sdk/issues/30633

Change-Id: Icfbd3ca60662e37046e48b95be7f81d05d94af88
Reviewed-on: https://dart-review.googlesource.com/c/85470
Commit-Queue: Aart Bik <ajcbik@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-11-29 01:47:18 +00:00
Paul Berry 82add824fd Merge commit 'db89c2d1ac3e8b6c6130cbb714c4e242e6fefc27' into analyzer 2018-11-27 15:11:22 -08:00
Paul Berry 5949a3f984 Merge commit '5a54f0eb577f0f4a1708ddbd4f69bf70458ff647' into analyzer 2018-11-27 08:34:40 -08:00
Johnni Winther 406d0b3e9c Remove unused code from LocalsHandler 
+ add test for issue 34993

Change-Id: Icd73c865e80ac9dca0e126c6b7e2c6c5320aef94
Reviewed-on: https://dart-review.googlesource.com/c/85240
Auto-Submit: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-11-27 14:07:01 +00:00
Johnni Winther 82f9884289 Support exact class and this expression relations in StrongModeConstraint 
Change-Id: I32e6e5b6f55d4ef4240b6ba87eb26dfc2a699130
Reviewed-on: https://dart-review.googlesource.com/c/85166
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2018-11-27 13:50:04 +00:00
Vyacheslav Egorov e6e88c719c [gardening] Make standalone_2/io/http_loopback_test more robust. 
This test checks that we should not be able to connect to server
listening on IPv4 via IPv6 and vice versa.

However by chance some other test might start listening on the same
port as this test is using, just using different protocol. In this
case the test will fail.

To make this test more robust we add a check which verifies that
server did not actually see the connection from the client with a
matching port (we compare client's port to remotePort that server saw).

After these changes we only should fail this test if we indeed managed
to connect to the loopback server using a mismatching protocol.

Fixes https://github.com/dart-lang/sdk/issues/30700

Change-Id: Ib4f3d0346030dcffaac44ff5dd4050939984b1fc
Reviewed-on: https://dart-review.googlesource.com/c/85389
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2018-11-27 11:10:49 +00:00
Johnni Winther 9cfab12d36 Reorganize imports to decouple dart2js_target.dart from dart2js 
Change-Id: Ie958dbbf75f5cac20074b2a64a4eefb9de636116
Reviewed-on: https://dart-review.googlesource.com/c/85290
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-11-27 09:15:34 +00:00
Sigmund Cherem 8d41ec30c0 Remove obsolete comment in status files. 
I added these when we were maintaining the .status files with a script at the
time strong-mode was being implemented in the CFE. The comments are no longer
relevant.

TBR=paulberry@google.com

Change-Id: I3d37da32cd611731e3e0d91a5aa751fa550cc179
Reviewed-on: https://dart-review.googlesource.com/c/85408
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-11-27 01:25:51 +00:00
Paul Berry 0e275f123c Fix analyzer co19 status after d7ee7b9516 
Change-Id: Id9277f2d98c289eeb187e9a3222cbc1c1d7a7a27
Reviewed-on: https://dart-review.googlesource.com/c/85400
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-26 18:47:27 +00:00
Paul Berry d7ee7b9516 Merge commit '880dfa0bca19b024bea57a20434da6f3f0fe9c87' into analyzer 2018-11-26 08:35:57 -08:00
Stevie Strickland 10dac37103 [gardening] Marking slow tests as possible timeouts. 
Followup to https://dart-review.googlesource.com/c/sdk/+/85200, since
these tests are timing out sporadically on the Mac debug build.

Change-Id: I43d58ce9c2ed56396c94974525594d62ec652101
Reviewed-on: https://dart-review.googlesource.com/c/85382
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Stevie Strickland <sstrickl@google.com>
 2018-11-26 15:56:50 +00:00
Vyacheslav Egorov 682b9e3479 [gardening] Mark LibTest/io/RawDatagramSocket/close_A01_t01 failing 
The test make assumptions about delivery order which UDP does not
provide

Issue https://github.com/dart-lang/co19/issues/195

Change-Id: I5278f8c38c0a23142285167590f3eb30f95fa8fd
Reviewed-on: https://dart-review.googlesource.com/c/85345
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-11-26 10:55:30 +00:00
Vyacheslav Egorov 78332742ac [gardening] Skip lib_2/async/timer_regress22626_test in reload-rollback + debug configuration 
The test is timing dependent so slow reload might cause a failure.

Change-Id: I1970d429a4c2346a1f6af514e226ffc553060e61
Reviewed-on: https://dart-review.googlesource.com/c/85343
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-11-26 10:14:40 +00:00
Vyacheslav Egorov 14d8f7c2da [gardening] Marking standalone_2/fragmentation_test Slow 
Locally it passes in 10s but on Mac bots they take 40s or more and sometimes
timeout.

Change-Id: I0a531aebe46d6526a1f3c2ee598c72f22fc5e25f
Reviewed-on: https://dart-review.googlesource.com/c/85342
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-11-26 09:57:06 +00:00
Johnni Winther bb4e2388b8 Use BasicInfo.resetIds 
Change-Id: I69770f2d4f2e24b25cbeff644747ef605e14d4b9
Reviewed-on: https://dart-review.googlesource.com/c/85167
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2018-11-23 08:51:52 +00:00
Martin Kustermann a29f55e296 [VM] Mark tests slow after removing unsafe optimization for integer operation folding 
Follow-up to https://dart-review.googlesource.com/c/sdk/+/84720

Change-Id: I25b5f8d51c225c8f088937580259d4fd9b8b40ed
Reviewed-on: https://dart-review.googlesource.com/c/85200
Reviewed-by: Martin Kustermann <kustermann@google.com>
Auto-Submit: Martin Kustermann <kustermann@google.com>
 2018-11-22 16:23:14 +00:00
Samir Jindel 48fee5f591 Update status file for receive_A01_t01 and where_A01_t01. 
Change-Id: I7f4b67c9682ae57523c228262220570031257da6
Reviewed-on: https://dart-review.googlesource.com/c/85172
Reviewed-by: Samir Jindel <sjindel@google.com>
Auto-Submit: Samir Jindel <sjindel@google.com>
 2018-11-22 15:07:40 +00:00
Martin Kustermann ad7fbb6dd7 [VM] Fix flow graph builder to not generate different code in unoptimized/optimized mode 
Change-Id: I752be6bd97dcd892ea6ba5d7fdd30575d4cee489
Reviewed-on: https://dart-review.googlesource.com/c/84720
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-11-22 14:05:47 +00:00
Sergey G. Grekhov 8b2458c97b [co19] DEPS and .status file update 
Change-Id: I718a5d70874e7090cb42f1d452cd8dcf020d337e
Reviewed-on: https://dart-review.googlesource.com/c/84631
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2018-11-22 11:28:15 +00:00
Ryan Macnak edba6fbfaa [vm, gc] Add --force-evacuation flag to aid finding untracked pointers. 
Bug: https://github.com/dart-lang/sdk/issues/34934
Change-Id: Ibba2ae5837985a32bd84da4b33bd091dcec3427d
Reviewed-on: https://dart-review.googlesource.com/c/85141
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-11-21 22:58:57 +00:00
Sigmund Cherem 02f6395606 Cleanup library-loader: rename as kernel producer, remove some dependencies 
Once we remove the frontend strategy object, we might want to remove some additional dependencies on KernelResult

Change-Id: I27ef1fbb12e671748b59a87d2dd249100501e02a
Reviewed-on: https://dart-review.googlesource.com/c/85060
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2018-11-21 17:59:18 +00:00
Paul Berry e649ed1aa3 Merge commit 'c1daa3276566e48dac6f52742264578092c56a35' into analyzer 2018-11-21 08:47:55 -08:00
Brian Wilkerson c1daa32765 Fix some issues with the set literal tests 
Change-Id: I3c7b9195bfaea7eeb8d179e23c9c40f263d6053a
Reviewed-on: https://dart-review.googlesource.com/c/85042
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2018-11-21 15:44:30 +00:00
Johnni Winther 0fded45406 Handle serialization with --dump-info 
Change-Id: I626eb8c7dca0b4e92f2aca79429f6e7336215840
Reviewed-on: https://dart-review.googlesource.com/c/84846
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2018-11-21 09:40:02 +00:00
Johnni Winther e62951fd3d Use assigned variables data to infer static types for effectively final locals. 
Change-Id: I3687d28628b0476c6a848f135bbda97e594449c2
Reviewed-on: https://dart-review.googlesource.com/c/84629
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-11-21 09:16:21 +00:00
Jenny Messerly 751d7ad2e2 [dartdevc] fix js_ast comma expression not generating parentheses 
This happened because for-of printed using EXPRESSION precedence
for the iteration expression, but it should be ASSIGNMENT per the spec
(https://tc39.github.io/ecma262/#sec-for-in-and-for-of-statements).

Change-Id: I869ad3f1181cfb33c57fe79aebfa3699f66a0712
Reviewed-on: https://dart-review.googlesource.com/c/84833
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
Auto-Submit: Jenny Messerly <jmesserly@google.com>
 2018-11-20 22:56:35 +00:00
Jenny Messerly 099f48b1da [dartdevc] fix #33621, name collision due to inheriting JS statics 
Change-Id: I6e3f0bb741e919d8303422ac2df853142649e7ff
Reviewed-on: https://dart-review.googlesource.com/c/83563
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Auto-Submit: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
 2018-11-20 21:13:29 +00:00
asiva 0ca1c57593 Reland "[VM] Remove unused flags" 
This is a reland of 1a4cff1bd4

Original change's description:
> [VM] Remove unused flags
> 
> Remove the following flags which are always ON
> --strong
> --reify_generic_functions
> 
> and these flags which are not applicable anymore
> --error-on-bad-override
> --error-on-bad-type
> --enable-type-checks
> 
> Change-Id: I6e1aeb68e663953f4ae49ca94ea0daa87b661900
> Reviewed-on: https://dart-review.googlesource.com/c/79431
> Commit-Queue: Siva Annamalai <asiva@google.com>
> Reviewed-by: Alexander Markov <alexmarkov@google.com>
> Reviewed-by: Régis Crelier <regis@google.com>

Change-Id: Ib4452c22fb05eed38820708abb648939e03b1df0
Reviewed-on: https://dart-review.googlesource.com/c/84923
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-11-20 17:25:42 +00:00
Paul Berry e8e072f87e Merge commit 'bf6ba5db9e2cfef7dad2b5283be93d589f4c7a5a' into analyzer 2018-11-20 08:46:59 -08:00
Paul Berry 47b70aabee Merge commit '784ad29470c96a275fb788c26d3dae08e2766285' into analyzer 2018-11-20 08:27:04 -08:00
Johnni Winther 3bf6a550ea Add static type tests 
Change-Id: I4282a1261ad4f4f4641750bd5ca492e5a943b6f0
Reviewed-on: https://dart-review.googlesource.com/c/84628
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-11-20 14:02:39 +00:00
Johnni Winther b943fa897c Move closure scope classes to ir/ 
Change-Id: Ib14696e9ab8572e30343e0880c1d028cfc26b377
Reviewed-on: https://dart-review.googlesource.com/c/84621
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-11-20 14:02:39 +00:00
Daco Harkes 3f2b605b57 [gardening] Mark LibTest/io/Stdin/first_A04_t01 as flaky 
Issue: https://github.com/dart-lang/co19/issues/193
Change-Id: I42cb92ce8bb624a9869d9c86594b807bbf606ffc
Reviewed-on: https://dart-review.googlesource.com/c/84639
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
 2018-11-20 09:47:15 +00:00
Siva Annamalai f6c41ac3bc Revert "[VM] Remove unused flags" 
This reverts commit 1a4cff1bd4.

Reason for revert: The precompiled arm bot failed a test.

Original change's description:
> [VM] Remove unused flags
> 
> Remove the following flags which are always ON
> --strong
> --reify_generic_functions
> 
> and these flags which are not applicable anymore
> --error-on-bad-override
> --error-on-bad-type
> --enable-type-checks
> 
> Change-Id: I6e1aeb68e663953f4ae49ca94ea0daa87b661900
> Reviewed-on: https://dart-review.googlesource.com/c/79431
> Commit-Queue: Siva Annamalai <asiva@google.com>
> Reviewed-by: Alexander Markov <alexmarkov@google.com>
> Reviewed-by: Régis Crelier <regis@google.com>

TBR=rmacnak@google.com,alexmarkov@google.com,asiva@google.com,regis@google.com

Change-Id: Ib0fe4f33c044047ef1cb31bca9d38591176b7d40
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/84883
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
 2018-11-20 07:32:11 +00:00
asiva 1a4cff1bd4 [VM] Remove unused flags 
Remove the following flags which are always ON
--strong
--reify_generic_functions

and these flags which are not applicable anymore
--error-on-bad-override
--error-on-bad-type
--enable-type-checks

Change-Id: I6e1aeb68e663953f4ae49ca94ea0daa87b661900
Reviewed-on: https://dart-review.googlesource.com/c/79431
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
 2018-11-20 06:41:06 +00:00
Daco Harkes 4e8ffc06cf [gardening] re-enable tests disabled for https://github.com/dart-lang/sdk/issues/25649 
Change-Id: Ie7e0eef727db940ded3f6ebe22a1ea5c52b859f9
Reviewed-on: https://dart-review.googlesource.com/c/84721
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
 2018-11-19 18:12:59 +00:00
Paul Berry 6d8e14c9db Merge commit 'f56fea3e6389727df2cae5c6feebcdd49437b12a' into analyzer 2018-11-19 08:24:02 -08:00