Commit Graph

37 Commits

Author SHA1 Message Date
Johnni Winther 7c6211b1d8 Make unittests work with Dart 2
Change-Id: Ic2c105747dfba067464fc15e158f58417c8636a8
Reviewed-on: https://dart-review.googlesource.com/61922
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
2018-06-22 20:25:05 +00:00
Lasse R.H. Nielsen 0b91676362 Remove the retype method.
See #33075.

Bug: http://dartbug.com/33075
Change-Id: I1ee2f587afbc672dd08ac61ac003bbdc85bb95e2
Reviewed-on: https://dart-review.googlesource.com/59091
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-06-12 14:36:09 +00:00
Lasse Reichstein Holst Nielsen 862a894de6 Make cast do the same things as retype.
Deprecate `retype` and forward it to `cast`.

Change-Id: Ie17ffdd1eef0d3f19582bf638c5349927c7b5ebd
Reviewed-on: https://dart-review.googlesource.com/53802
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-05-09 08:00:08 +00:00
Lasse R.H. Nielsen 6f78471687 New methods on Iterable, List, Set, Queue, Map.
Changes signature of Iterable.singleWhere.
Makes LinkedHashMap no longer be a HashMap.

Change-Id: I7a12fea533d42b0fc8357086649df38ad01f3cdd
Reviewed-on: https://dart-review.googlesource.com/39140
Commit-Queue: Leaf Petersen <leafp@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2018-02-07 06:12:53 +00:00
William Hesse 9c35cff5cd Revert "New methods on Iterable, List, Set, Queue, Map."
This reverts commit 0b59f24f97.

Reason for revert: Creates crashes in dart2js with kernel, see
https://luci-milo.appspot.com/buildbot/client.dart/dart2js-linux-d8-minified-1-5-be/9751

Original change's description:
> New methods on Iterable, List, Set, Queue, Map.
> Changes signature of Iterable.singleWhere.
> Makes LinkedHashMap no longer be a HashMap.
> 
> Change-Id: Ibd7e56e1ac03cb9fb10d19d1328d452fcd06d89f
> Reviewed-on: https://dart-review.googlesource.com/32541
> Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
> Reviewed-by: Leaf Petersen <leafp@google.com>

TBR=lrn@google.com,leafp@google.com

Change-Id: Iab904f5885a5213ae2e16ef496eed0b6843185f3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/39060
Reviewed-by: William Hesse <whesse@google.com>
2018-02-06 13:32:19 +00:00
Lasse R.H. Nielsen 0b59f24f97 New methods on Iterable, List, Set, Queue, Map.
Changes signature of Iterable.singleWhere.
Makes LinkedHashMap no longer be a HashMap.

Change-Id: Ibd7e56e1ac03cb9fb10d19d1328d452fcd06d89f
Reviewed-on: https://dart-review.googlesource.com/32541
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-02-06 11:17:46 +00:00
Johnni Winther f3c9d26cfb Compute side effects through SideEffectsBuilder
Change-Id: Iec89f193a1bd4c897b94698457237e6b4fde9c1f
Reviewed-on: https://dart-review.googlesource.com/21721
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2017-11-20 09:28:08 +00:00
Leaf Petersen 4270b99d75 Fix dynamic as bottom uses in front end and dart2js.
Re-enable the dynamic as bottom hint in analysis_options.yaml and fix
the code to be hint clean again.

Fixes #30589
Fixes #30590

Bug:
Change-Id: Idb7910b3ab1c6d931a3ead3eed885d8bd172e621
Reviewed-on: https://dart-review.googlesource.com/17062
Commit-Queue: Leaf Petersen <leafp@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2017-10-30 19:54:26 +00:00
Erik Corry 029b1cb948 Spelling fixes e to i.
R=kevmoo@google.com
BUG=

Review-Url: https://codereview.chromium.org/2957593002 .
2017-06-24 13:41:39 +02:00
Peter von der Ahé 69d6e8e55a All strong mode cleaning of dart2js.
Fixes https://github.com/dart-lang/sdk/issues/29886

Supersedes CLs 2939193003, 2950433002, and 2947583002.

R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2944843002 .
2017-06-19 14:06:38 +02:00
Johnni Winther dff23682a1 Create closed world for hello world using .dill file
Currently results in compile time error because of a bug in the kernel reuse of mixin applications.

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2865693002 .
2017-05-16 10:30:05 +02:00
Peter von der Ahé d0d27c1c38 Use parser and scanner from package:front_end.
Originally reviewed as:

    Review-Url: https://codereview.chromium.org/2650413002 .
    Review-Url: https://codereview.chromium.org/2652203002 .
    Review-Url: https://codereview.chromium.org/2655843002 .
    Review-Url: https://codereview.chromium.org/2654433009 .
    Review-Url: https://codereview.chromium.org/2647343003 .
    Review-Url: https://codereview.chromium.org/2652663005 .
    Review-Url: https://codereview.chromium.org/2650813002 .
    Review-Url: https://codereview.chromium.org/2650803002 .
    Review-Url: https://codereview.chromium.org/2651843004 .
    Review-Url: https://codereview.chromium.org/2649923002 .
    Review-Url: https://codereview.chromium.org/2651563003 .
    Review-Url: https://codereview.chromium.org/2649123002 .
    Review-Url: https://codereview.chromium.org/2644843006 .
    Review-Url: https://codereview.chromium.org/2647043002 .
    Review-Url: https://codereview.chromium.org/2642903003 .
    Review-Url: https://codereview.chromium.org/2645513002 .
    Review-Url: https://codereview.chromium.org/2642663003 .
    Review-Url: https://codereview.chromium.org/2642713002 .
    Review-Url: https://codereview.chromium.org/2635473002 .
    Review-Url: https://codereview.chromium.org/2624373003 .
    Review-Url: https://codereview.chromium.org/2627723006 .
    Review-Url: https://codereview.chromium.org/2627093007 .
    Review-Url: https://codereview.chromium.org/2629543008 .
    Review-Url: https://codereview.chromium.org/2629543007 .
    Review-Url: https://codereview.chromium.org/2631503002 .
    Review-Url: https://codereview.chromium.org/2621153006 .
2017-02-01 10:29:25 +01:00
Johnni Winther f30bb5ce43 Use generic methods in DebugIterable
- to shut up the analyzer

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2624743002 .
2017-01-12 12:14:30 +01:00
Florian Loitsch 6beb1fdd11 Change Set.difference API to accept Set<Object>.
Fixes #27573
BUG= http://dartbug.com/27573
R=lrn@google.com

Review URL: https://codereview.chromium.org/2413233002 .
2016-10-20 14:37:15 +02:00
Kevin Moore 406d5e0c48 pkg/compiler: fix imports
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2221893003 .
2016-08-08 14:41:50 -07:00
Johnni Winther 3305201211 Serialize this-types in NativeBehavior separately.
BUG=
R=het@google.com

Review URL: https://codereview.chromium.org/2150333002 .
2016-07-18 10:42:23 +02:00
Harry Terkelsen 29cf477139 dartfmt pkg/compiler
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/1859343004 .
2016-04-07 10:00:53 -07:00
Sigmund Cherem 0f979d529d Cleanup 1: split parts into their own libraries for: tree, helpers, ssa, native.
In the case of ssa, I also removed references to AST nodes in ssa nodes that were unused, so now only the builder imports the AST.

I also got rid of unused imports from everywhere else in the code.

R=sra@google.com

Review URL: https://codereview.chromium.org/1762723002 .
2016-03-14 14:03:35 -07:00
Johnni Winther 26d6a8363e Use WorldImpact for element dependencies in deferred_load
BUG=
R=sigurdm@google.com

Review URL: https://codereview.chromium.org/1394923003.
2015-10-14 11:12:19 +02:00
Johnni Winther 1414d9b27e Use common.dart to re-export commonly used entities.
BUG=
R=sigurdm@google.com

Review URL: https://codereview.chromium.org/1394063004.
2015-10-12 09:34:02 +02:00
Johnni Winther 76b7203c19 Extract DiagnosticReporter implementation from Compiler.
BUG=
R=sigurdm@google.com

Review URL: https://codereview.chromium.org/1383483006.
2015-10-06 10:24:44 +02:00
Johnni Winther 8bcbccc067 Use memory compiler in compiler_helper.dart.
BUG=
R=sigurdm@google.com

Review URL: https://codereview.chromium.org//1322973007.
2015-09-11 12:49:34 +02:00
Johnni Winther d655374736 Add warnings and hints to for-in.
BUG=
R=sigurdm@google.com

Review URL: https://codereview.chromium.org//1334673002.
2015-09-11 12:38:34 +02:00
Johnni Winther 930bc75c0d Move diagnostic_listener.dart and messages.dart to the diagnostics folder
BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//1286143003.
2015-08-12 12:05:36 +02:00
Johnni Winther a7c720f61b Remove dart2jslib.dart
dart2jslib.dart is deleted
compiler.dart is a library containing mainly Compiler
other parts of compiler.dart move according to the listing in https://codereview.chromium.org/1280343002/

R=sigmund@google.com

Review URL: https://codereview.chromium.org//1284593003.
2015-08-12 08:42:46 +02:00
Johnni Winther dab1aaae45 Move dart2jslib parts into separate libraries.
BUG=
R=karlklose@google.com, sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/4474acf36bb3b7d10a6fcce0c03de499055401e2

Reverted: https://github.com/dart-lang/sdk/commit/5af48434320f973bd8ae0fd402d9e33f5765420a

Review URL: https://codereview.chromium.org//1284673003.
2015-08-11 09:56:49 +02:00
William Hesse 5af4843432 Revert "Move dart2jslib parts into separate libraries."
This reverts commit 4474acf36b.

BUG=

Review URL: https://codereview.chromium.org//1278503004 .
2015-08-10 16:57:07 +02:00
Johnni Winther 4474acf36b Move dart2jslib parts into separate libraries.
BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//1284673003.
2015-08-10 16:19:02 +02:00
Johnni Winther 73572dc3f1 Generated source mapping through CPS.
BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//1229673006.
2015-07-10 15:32:36 +02:00
Stephan Herhut dfcadddb11 dart2js: Fix hints in code base.
BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//1173403002.
2015-06-11 13:11:17 +02:00
Johnni Winther 6fc3592842 Refactoring resolution of local access and unqualified access of statics
BUG=
R=karlklose@google.com

Committed: https://github.com/dart-lang/sdk/commit/58896b74ce50615114a006282e5b353885eca385

Reverted: https://github.com/dart-lang/sdk/commit/1807369aa14f16bdcf0f23fc7d0091d04dbdd1f9

Review URL: https://codereview.chromium.org//1149403009
2015-06-08 14:51:52 +02:00
Johnni Winther 1807369aa1 Revert "Refactoring resolution of local access and unqualified access of statics"
This reverts commit 58896b74ce.

BUG=

Review URL: https://codereview.chromium.org//1160313006
2015-06-08 12:55:24 +02:00
Johnni Winther 58896b74ce Refactoring resolution of local access and unqualified access of statics
BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//1149403009
2015-06-08 11:53:59 +02:00
johnniwinther@google.com 798f0417e5 Emit warning on import of dart:mirrors.
BUG=
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41688

Review URL: https://codereview.chromium.org//588183002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41822 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-19 09:20:14 +00:00
johnniwinther@google.com 09fbe78e71 Move dart2js from sdk/lib/_internal/compiler to pkg/compiler
BUG=

Review URL: https://codereview.chromium.org//694353007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41514 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-05 08:51:01 +00:00
johnniwinther@google.com 8637cfd322 Revert "Move dart2js from sdk/lib/_internal/compiler to pkg/compiler"
This reverts commit r41512.

BUG=

Review URL: https://codereview.chromium.org//693183006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41513 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-05 08:15:26 +00:00
johnniwinther@google.com 2b336e17f0 Move dart2js from sdk/lib/_internal/compiler to pkg/compiler
BUG=

Review URL: https://codereview.chromium.org//690103004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41512 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-05 07:09:04 +00:00