dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
60,241 Commits 2 Branches 0 Tags
2dbf91ff13110d0022391f86f5aae58aa63243e2
Commit Graph

6553 Commits

Author SHA1 Message Date
Paul Berry 43cd8ba822 Merge commit '4eeebc46cff4e47e6265e86f4774da103d060aa1' into analyzer 
Conflicts:
	pkg/analyzer/CHANGELOG.md
	pkg/analyzer/pubspec.yaml
 2018-12-03 12:20:40 -08:00
Paul Berry be529425d2 Prepare for a future breaking change to the UriResolver class. 
See https://dart-review.googlesource.com/c/sdk/+/85726 for the
breaking change that is anticipated.

Change-Id: I4ba84a0e70bf5b3c62191c053ba9de7aee71ac93
Reviewed-on: https://dart-review.googlesource.com/c/85728
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-12-03 14:29:30 +00:00
Paul Berry 6f5d6db9c2 Cherry-pick analyzer CHANGELOG and pubspec from analyzer-0.33 branch. 
Also includes changes to the kernel and front_end pubspecs, since
those packages are tightly coupled to the analyzer.

These changes were made on the analyzer-0.33 branch in preparation for
previous releases of the analyzer.  Merging them to the master branch
makes it easier to keep the pubspec and CHANGELOG files up to date on
that branch.

Change-Id: I08a7bdcd49b6b2396166953131927656eca2c563
Reviewed-on: https://dart-review.googlesource.com/c/85727
Auto-Submit: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-12-01 17:23:47 +00:00
Paul Berry 5b00611568 Revert "Add AnalysisDriver.resetUriResolution() and use it for analysis.reanalyze request." 
This reverts commit 3428cc6dae.

Reason for revert: Unintentional breaking API change

Original change's description:
> Add AnalysisDriver.resetUriResolution() and use it for analysis.reanalyze request.
> 
> This CL changes "analysis.reanalyze" API. We decided to repurpose it. It was not
> used for some time now in IntelliJ, and AFAIK has never been used in VS Code.
> 
> R=​brianwilkerson@google.com, paulberry@google.com
> 
> Change-Id: I7510b0189197c9f3f848b0fc59a7b2bd22889ac7
> Reviewed-on: https://dart-review.googlesource.com/c/85523
> Reviewed-by: Paul Berry <paulberry@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

TBR=paulberry@google.com,scheglov@google.com,brianwilkerson@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I6a3e874278f4cf976363a0c7f80f7a65a0a03acf
Reviewed-on: https://dart-review.googlesource.com/c/85723
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-11-30 21:03:30 +00:00
Paul Berry 63770042aa Merge commit '80c23f87a3e3123d7e337c1fc8bc3b5ec49b34a0' into analyzer 2018-11-30 08:12:45 -08:00
danrubel 80c23f87a3 Update more analyzer error codes to be generated 
This updates more analyzer error codes to be generated
from the corresponding CFE error code.

Several of these analyzer error codes had multiple CFE error
codes mapped to them. In these situations, new analyzer error
codes were added to match the existing CFE error codes:

* EXTERNAL_FACTORY_WITH_BODY
* EXTERNAL_FACTORY_REDIRECTION
* CATCH_SYNTAX_EXTRA_PARAMETERS

Change-Id: Ib1cbb9e04d2092e4859e2cfadbcc85e03093f808
Reviewed-on: https://dart-review.googlesource.com/c/85431
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-11-30 15:00:36 +00:00
pq 45bf7e9906 validate deprecated lints 
Change-Id: I83d3dcd2d22d1b5fd4ef8b1af6f06288eb9cd917
Reviewed-on: https://dart-review.googlesource.com/c/85648
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2018-11-30 00:07:20 +00:00
Paul Berry 1d14b8a94e Prepare to publish analyzer 0.34.0. 
Change-Id: I66fe8810655b6ae2089e70d50af327909fecd5e1
Reviewed-on: https://dart-review.googlesource.com/c/85418
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2018-11-29 22:13:08 +00:00
Paul Berry 73621c71b7 Cherry-pick CHANGELOG from analyzer-0.33 branch. 
This CHANGELOG entry was made on the analyzer-0.33 branch.
Cherry-picking it over to the analyzer branch ensures that future
analyzer releases based on this branch won't be missing any changelog
entries.

Change-Id: Idb49c6aa2d8ad48e1b7c4bca54cefac2ea62ca46
Reviewed-on: https://dart-review.googlesource.com/c/85621
Commit-Queue: Paul Berry <paulberry@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-29 19:25:31 +00:00
Brian Wilkerson ec5b4bad99 Fix false positive for sdk constraints (issue 35290) 
Change-Id: I64164cb97b88dcc0431237cf3a45831fb668c2c5
Reviewed-on: https://dart-review.googlesource.com/c/85620
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-11-29 19:12:50 +00:00
Konstantin Shcheglov 3428cc6dae Add AnalysisDriver.resetUriResolution() and use it for analysis.reanalyze request. 
This CL changes "analysis.reanalyze" API. We decided to repurpose it. It was not
used for some time now in IntelliJ, and AFAIK has never been used in VS Code.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I7510b0189197c9f3f848b0fc59a7b2bd22889ac7
Reviewed-on: https://dart-review.googlesource.com/c/85523
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-11-29 19:08:30 +00:00
Paul Berry c7dea39faa Fix analyzer CHANGELOG. 
The changelog entry for analyzer version 0.33.5 actually won't be
released until analyzer 0.33.6.

Change-Id: Iab4f2924ef9c8f43b5e81f9cf3ab316f7fc96918
Reviewed-on: https://dart-review.googlesource.com/c/85549
Auto-Submit: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-29 17:26:57 +00:00
Paul Berry 589a823888 Cherry-pick f02e7bb374 to the analyzer branch 
Original commit message:

    Rework parseLiteralSetOrMapSuffix to remove expression lookahead

    This reworks the set literal support to remove unnecessary lookahead
    by removing the listener.beginLiteralMapEntry event
    and renaming the listener.endLiteralMapEntry to handleLiteralMapEntry.

Change-Id: I608e94aadc2afb86c772fdc6ef24b0da32c5ddde
Reviewed-on: https://dart-review.googlesource.com/c/85410
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-11-28 23:53:01 +00:00
Paul Berry 1d0c0559f6 Cherry-pick CHANGELOG from analyzer-0.33 branch. 
This CHANGELOG entry was made on the analyzer-0.33 branch.
Cherry-picking it over to the analyzer branch ensures that future
analyzer releases based on this branch won't be missing any changelog
entries.

Change-Id: I27a4cb235471244855c8c18679c6a61c2ca9587f
Reviewed-on: https://dart-review.googlesource.com/c/85542
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-11-28 23:37:34 +00:00
Brian Wilkerson 235da6f45d Rename AstNode.getAncestor by deprecating it and adding the new method (analyzer) 
Change-Id: Ia00d8cb7153bd9db798352aab00b2431ba709671
Reviewed-on: https://dart-review.googlesource.com/c/85540
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-28 21:04:57 +00:00
Brian Wilkerson 5bff334f84 Introduce replacement for AstNode.getAncestor (master) 
Change-Id: Ib93cf9b9c19b3db2b971f83ae871442db244ec38
Reviewed-on: https://dart-review.googlesource.com/c/85541
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-28 20:59:03 +00:00
Brian Wilkerson 65787a250e Use the experiment flag to enable scanning the >>> operator 
Change-Id: I93678479911b629c3b88edd76d1ffa0c1daebaf3
Reviewed-on: https://dart-review.googlesource.com/c/85520
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2018-11-28 20:22:28 +00:00
danrubel de764dbec1 more set literal tests 
Change-Id: I9d6a24e240be7379674b898fb4d094e86058611b
Reviewed-on: https://dart-review.googlesource.com/c/85429
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-11-28 19:02:00 +00:00
Konstantin Shcheglov 9b65c81c03 Clear direct users of LibraryCycle on invalidate. 
We invalidate recursively, so all the direct and indirect users are
invalidated, and we want to clear direct users to cut each branch
and avoid visiting them uselessly multiple times through multiple
direct users.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I7a5937c91330149e2a703ffc424c24fffbf24734
Reviewed-on: https://dart-review.googlesource.com/c/85428
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-11-28 16:55:47 +00:00
Paul Berry 81a056c8a3 Cherry-pick CHANGELOG from analyzer-0.33 branch. 
These CHANGELOG changes were made on the analyzer-0.33 branch.
Cherry-picking them over to the analyzer branch ensures that future
analyzer releases based on this branch won't be missing any changelog
entries.

Change-Id: I4d995452f9f735a1e7a46969b6a505f1ef697dbe
Reviewed-on: https://dart-review.googlesource.com/c/85417
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-28 15:09:20 +00:00
Paul Berry 82add824fd Merge commit 'db89c2d1ac3e8b6c6130cbb714c4e242e6fefc27' into analyzer 2018-11-27 15:11:22 -08:00
Konstantin Shcheglov 232aa553fb Backport AnalysisSession.getResolvedLibrary()/ByElement(). 
Change-Id: I83c1dbe9d758be12212fcd892bb57ae69407d8be
Reviewed-on: https://dart-review.googlesource.com/c/85147
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2018-11-27 22:53:24 +00:00
Konstantin Shcheglov 2beed40848 Move Workspace and its implementations into src/workspace. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I172d95e55ced9925e8f428b9b07f432251ef5248
Reviewed-on: https://dart-review.googlesource.com/c/85462
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-11-27 21:50:00 +00:00
Konstantin Shcheglov 561d892d29 Only consider known files in AnalysisDriver.changeFile(). 
So, when we internally listen for the whole repo changes, each instance
of AnalysisDriver can react only on what matters for it.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I0b70cfa662ff23adce7644d313ff9841c8170e0c
Reviewed-on: https://dart-review.googlesource.com/c/85461
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-11-27 21:48:10 +00:00
Paul Berry 3fdccc27ae Update analyzer SDK requirement 
This CL causes the anaylzer to require an SDK version of at least
2.1.0-dev.5.0, which was the first version of the SDK in which
dart:core exported Future.

This change was already applied to the analyzer and analyzer-0.33
branches; this CL merely applies it to the master branch as well.  See
https://github.com/dart-lang/sdk/issues/35158.

Change-Id: I74ba071c5a2244a7ffa3d7ecadcfc9b2d7fbcf3f
Reviewed-on: https://dart-review.googlesource.com/c/85413
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-11-27 20:04:20 +00:00
Brian Wilkerson 92a8d5c193 Make it easier for lint rules to define their own lint codes 
Change-Id: Ia1672e13544a0c73acfc22173cca14e75ed026b3
Reviewed-on: https://dart-review.googlesource.com/c/85407
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-27 15:34:30 +00:00
Konstantin Shcheglov 61a1793574 Issue 35162. Include SDK version constraint into AnalysisOptions. 
So, analysis result signatures depend on it and recomputed when it
is changed.

Also, change analysis server to update analysis options not only
when analysis_options.yaml is changed, but also when pubspec.yaml
is changed.

R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/35162
Change-Id: If4b937c26212d3da74ac7125eb2c6f70dbcb1793
Reviewed-on: https://dart-review.googlesource.com/c/85405
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2018-11-27 00:57:27 +00:00
danrubel 52892f7c47 Add scanner and parser support for new >>> operator 
This adds support for the new >>> operator as detailed in
https://github.com/dart-lang/language/blob/master/accepted/future-releases/constant-update-2018/feature-specification.md#new-operators

Tracking issue: https://github.com/dart-lang/language/issues/60

Enable support by setting AbstractScanner.enableGtGtGt = true

Change-Id: I8e7d2fb341971452d8e05d734a1de612880fef5e
Reviewed-on: https://dart-review.googlesource.com/c/85421
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-11-26 22:12:25 +00:00
danrubel f02e7bb374 Rework parseLiteralSetOrMapSuffix to remove expression lookahead 
This reworks the set literal support to remove unnecessary lookahead
by removing the listener.beginLiteralMapEntry event
and renaming the listener.endLiteralMapEntry to handleLiteralMapEntry.

Change-Id: Ia71fe69359b0447a60d729db34ec35ad25a54750
Reviewed-on: https://dart-review.googlesource.com/c/84661
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-11-26 20:03:19 +00:00
Paul Berry d7ee7b9516 Merge commit '880dfa0bca19b024bea57a20434da6f3f0fe9c87' into analyzer 2018-11-26 08:35:57 -08:00
Brian Wilkerson d5ae2d573b Remove some unnecessary instance creations in ElementResolver 
Change-Id: I1a8e825e0b90ccbd74bbce2d5a7e58df3ba71a51
Reviewed-on: https://dart-review.googlesource.com/c/85300
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-25 19:16:11 +00:00
Brian Wilkerson 67472e59fb Remove an unused error code and the fix associated with it 
Change-Id: I5118cea64a9c687e7ebd102a09cbfbaf467d1e96
Reviewed-on: https://dart-review.googlesource.com/c/85320
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-25 19:11:46 +00:00
Konstantin Shcheglov 95d67393a8 Sort libraries to produce stable library cycle signatures. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I0a418d9fa95facfd9f335610276a479271ac1127
Reviewed-on: https://dart-review.googlesource.com/c/85145
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-11-21 23:24:55 +00:00
Brian Wilkerson 198d4d135f Infer an empty set literal when appropriate 
Change-Id: Ib46c35adbd3dd9e28073aeb5996d785b5e62e608
Reviewed-on: https://dart-review.googlesource.com/c/85142
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-11-21 22:27:53 +00:00
Paul Berry 94d1d74076 Improve the exception message when a library can't be found in a summary. 
This would have made it easier to debug internal bug #119875658.

Change-Id: I71a5e61602187b44923ca6f9b0ec254efe376f87
Reviewed-on: https://dart-review.googlesource.com/c/85143
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-11-21 21:18:42 +00:00
Konstantin Shcheglov c5601d7d47 Switch Parsed/ResolvedLibraryResultImpl to AnalysisSession.getParsed/ResolvedLibraryByElement(). 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I4ad2fdea2abbbdafd38d5167ffa60ee79c28360f
Reviewed-on: https://dart-review.googlesource.com/c/85140
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-11-21 18:07:23 +00:00
Paul Berry e649ed1aa3 Merge commit 'c1daa3276566e48dac6f52742264578092c56a35' into analyzer 2018-11-21 08:47:55 -08:00
Dan Rubel f3344f3c13 Update parser to report error for missing comma 
Fix https://github.com/dart-lang/sdk/issues/35213

Change-Id: Ia9a1628f15bebf0c915f5d16712f98ac614896e8
Reviewed-on: https://dart-review.googlesource.com/c/85021
Auto-Submit: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-11-21 16:17:48 +00:00
Brian Wilkerson ae6f534188 Add fixes for SDK violation hint 
Change-Id: Icbb41c2e305b45c6abb9ade343d677c2e28895ce
Reviewed-on: https://dart-review.googlesource.com/c/84691
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-11-21 02:19:21 +00:00
Paul Berry 4255a012f8 Update analyzer pubspec to note dependency on pub_semver. 
The dependency was added in cb88347087.

Change-Id: I33bd532211ed0f60e665ce6c4017ac22805a039a
Reviewed-on: https://dart-review.googlesource.com/c/84967
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-21 00:09:22 +00:00
Brian Wilkerson 758e690b8d Enable the use of set literals in the analyzer unit tests 
Change-Id: Idbf0b807d59fd68436906f699fd4ab55db23ac62
Reviewed-on: https://dart-review.googlesource.com/c/84962
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-11-20 23:56:40 +00:00
Paul Berry c165ef8a37 Ensure that lists and maps built by ExprBuilder have their staticType set. 
We can't rely on resolution to do this, because resolution only
operates in the compilation unit currently being analyzed, and
constant values may be needed from other compilation units.

Fixes #35230.

Change-Id: I11fa5597110bc13164ca5dc9846836848120cd08
Reviewed-on: https://dart-review.googlesource.com/c/84964
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-11-20 22:22:15 +00:00
Konstantin Shcheglov 5498e58e3c Remove unused GnWorkspace.findFile(). 
R=brianwilkerson@google.com

Change-Id: I1b2e4a413362d28c2d54f3e2f5955f3324d44c8d
Reviewed-on: https://dart-review.googlesource.com/c/84963
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-11-20 21:51:20 +00:00
pq eceafa2df8 new “deprecated” lint maturity 
Change-Id: Idd5257b5d4707b7a141efec644370c2fff9b7b3d
Reviewed-on: https://dart-review.googlesource.com/c/84701
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2018-11-20 19:05:43 +00:00
Paul Berry 42d4269e06 Remove unused import 
Change-Id: Ibc3a323dc19e2c7677370a20e009c9659544ec22
Reviewed-on: https://dart-review.googlesource.com/c/84924
Auto-Submit: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-20 18:34:19 +00:00
Brian Wilkerson d29633f080 Add support for accessing the errors produced during constant evaluation 
Change-Id: Iabd13ff201b79a1ca45cf609a9f48ed7e7155b61
Reviewed-on: https://dart-review.googlesource.com/c/84922
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-20 17:47:57 +00:00
Brian Wilkerson fafb93ecbd Perform type analysis and inference for set literals 
Change-Id: Iadf4b3cbfa90f593d7be29036104a9dfc8f2868f
Reviewed-on: https://dart-review.googlesource.com/c/84921
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-20 17:20:00 +00:00
Paul Berry 051643c0ed Hook up analyzer set literal logic to Fasta parser. 
A few analyzer summary tests had minor bugs that weren't noticed until
we hooked up the parser; those are fixed now.

Note that more analyzer set literal logic still needs to be written.

Change-Id: I6ba22602887cda20984770f927743595cc7cf451
Reviewed-on: https://dart-review.googlesource.com/c/84828
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-11-19 23:25:27 +00:00
Konstantin Shcheglov 5c7f36e2f1 Add getParsed/ResolvedLibraryByUri() to AnalysisDriver and use in AnalysisSession. 
This is how clients actually ask ParsedLibraryResult - by its element,
and correspondingly AnalysisDriver.getParsedLibraryByUri().

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Id295122a667ec57f11d05c2bef8fcb905c463d3a
Reviewed-on: https://dart-review.googlesource.com/c/84826
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-11-19 23:11:07 +00:00
Paul Berry a8b833750a Convert parser.dart to triple-slash comment style 
Change-Id: I5eb340875736b536c253967242d14a7fde9037b7
Reviewed-on: https://dart-review.googlesource.com/c/84825
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2018-11-19 22:23:48 +00:00